138737 2014-11-14 03:57:39 -0800 Painting in selection-only black-text-only mode incorrectly includes RenderReplaced background color 2015-04-23 16:14:31 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue esprehn+autocc glenn hyatt kondapallykalyan mitz sam simon.fraser oldest_to_newest 1048724 0 241575 thorton 2014-11-14 03:57:39 -0800 Created attachment 241575 repro case Steps to Reproduce: 1. Open the attached repro case in Safari. 2. Cmd-F, "something" 3. Cmd-G. Repeat. Expected: The text indicator for the "something" over the <img> and the "something" over the <div> should both have a flat yellow background. Actual: The text indicator for the "something" over the <img> includes the red background from the <img>! The text indicator for the "something" over the <div> correctly does not paint the <div>'s blue background. Notes: Somehow we're getting into background painting when we ought not. Here's a fragment of the stack near where things go wrong, I'm just not sure exactly where/how to cut it off: WebCore::GraphicsContext::fillRect(WebCore::FloatRect const&, WebCore::Color const&, WebCore::ColorSpace) WebCore::RenderBoxModelObject::paintFillLayerExtended(WebCore::PaintInfo const&, WebCore::Color const&, WebCore::FillLayer const*, WebCore::LayoutRect const&, WebCore::BackgroundBleedAvoidance, WebCore::InlineFlowBox*, WebCore::LayoutSize const&, WebCore::CompositeOperator, WebCore::RenderElement*, WebCore::BaseBackgroundColorUsage) WebCore::RenderBox::paintFillLayer(WebCore::PaintInfo const&, WebCore::Color const&, WebCore::FillLayer const*, WebCore::LayoutRect const&, WebCore::BackgroundBleedAvoidance, WebCore::CompositeOperator, WebCore::RenderElement*, WebCore::BaseBackgroundColorUsage) WebCore::RenderBox::paintFillLayers(WebCore::PaintInfo const&, WebCore::Color const&, WebCore::FillLayer const*, WebCore::LayoutRect const&, WebCore::BackgroundBleedAvoidance, WebCore::CompositeOperator, WebCore::RenderElement*) WebCore::RenderBox::paintBackground(WebCore::PaintInfo const&, WebCore::LayoutRect const&, WebCore::BackgroundBleedAvoidance) WebCore::RenderBox::paintBoxDecorations(WebCore::PaintInfo&, WebCore::LayoutPoint const&) WebCore::RenderReplaced::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow> const&, WebCore::GraphicsContext*, WebCore::RenderLayer::LayerPaintingInfo const&, unsigned int, WebCore::RenderObject*) 1048748 1 mitz 2014-11-14 07:18:52 -0800 You can also see the problem by selecting the text and dragging the selection out. 1088082 2 251510 thorton 2015-04-23 16:10:03 -0700 Created attachment 251510 Patch 1088084 3 thorton 2015-04-23 16:14:31 -0700 http://trac.webkit.org/changeset/183227 241575 2014-11-14 03:57:39 -0800 2014-11-14 03:57:39 -0800 repro case repro-selectionpaint.html text/html 293 thorton PGltZyBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogcmVkOyB3aWR0aDogMjAwcHg7IGhlaWdodDog MTAwcHg7Ij48L2NhbnZhcz48YnIvPgo8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiBncmVl bjsgd2lkdGg6IDIwMHB4OyBoZWlnaHQ6IDEwMHB4OyIvPgo8ZGl2IHN0eWxlPSJwb3NpdGlvbjog YWJzb2x1dGU7IHRvcDogNTBweDsgbGVmdDogMjBweDsiPnNvbWV0aGluZzwvZGl2Pgo8ZGl2IHN0 eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMTUwcHg7IGxlZnQ6IDIwcHg7Ij5zb21ldGhp bmc8L2Rpdj4= 251510 2015-04-23 16:10:03 -0700 2015-04-23 16:11:18 -0700 Patch bug-138737-20150423160859.patch text/plain 1939 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzc4M2EyNzY5N2RjNjYz ZGU5MWQ2ZGFkNDY3Y2U2NTEzZmExNTg4My4uNWQ3NjdkNzkzNWQ2ZDhkZjI1NGJiNDY1OTE5ZjI3 YjFjMjg1MWFjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA0LTIzICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFllbGxvdyBoaWdo bGlnaHQgaGFzIGdyYXkgYmFja2dyb3VuZCBjb2xvciB3aGVuIGludm9raW5nIExvb2t1cCBvbiBh biBhZGRyZXNzIGluIGEgR29vZ2xlIE1hcHMgZHJvcCBkb3duCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg3MzcKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzE4OTA0NDI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclJlcGxhY2VkOjpwYWludCk6CisgICAgICAgIE90aGVyIFJlbmRlck9iamVjdHMgZG9u J3QgcGFpbnQgYm94IGRlY29yYXRpb25zIGluIHRoZSBzZWxlY3Rpb24gcGFpbnRpbmcgcGhhc2Us CisgICAgICAgIHNvIFJlbmRlclJlcGxhY2VkIHByb2JhYmx5IHNob3VsZG4ndCBlaXRoZXIuIFRo aXMgZml4ZXMgdGhlIGNhc2Ugd2hlcmUsIHdoZW4gZG9pbmcKKyAgICAgICAgc2VsZWN0aW9uLW9u bHkgcGFpbnRpbmcgb2YgYSBiaXQgb2YgdGV4dCBvdmVyIHRvcCBvZiBhIFJlbmRlclJlcGxhY2Vk LCB0aGUgUmVuZGVyUmVwbGFjZWQKKyAgICAgICAgd291bGQgcGFpbnQgaXRzIGJhY2tncm91bmQs IGZpbGxpbmcgdGhlIHByZXZpb3VzbHkgdHJhbnNwYXJlbnQgYml0bWFwIHdpdGggYW4gdW53YW50 ZWQgY29sb3IuCisKIDIwMTUtMDQtMjMgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBVc2UgbGVzcyBtZW1vcnkgd2hlbiBjb21waWxpbmcgY29u dGVudCBleHRlbnNpb25zLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclJlcGxhY2VkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZXBsYWNl ZC5jcHAKaW5kZXggYmQ4ODA4NDI3NDIyZmM1YWEwYjIwNGM2MjIwZjE3MmEwODk2YzY2MS4uZmVk NWI2MzVjMTEyOGY5NjczOTVjY2ZiMzlkZDcwZDZjMGNjZmQ4YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlcGxhY2VkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyUmVwbGFjZWQuY3BwCkBAIC0xNDIsNyArMTQyLDcgQEAgdm9pZCBS ZW5kZXJSZXBsYWNlZDo6cGFpbnQoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFBv aW50JiBwYWludE9mZnNldCkKICAgICAKICAgICBMYXlvdXRQb2ludCBhZGp1c3RlZFBhaW50T2Zm c2V0ID0gcGFpbnRPZmZzZXQgKyBsb2NhdGlvbigpOwogICAgIAotICAgIGlmIChoYXNCb3hEZWNv cmF0aW9ucygpICYmIChwYWludEluZm8ucGhhc2UgPT0gUGFpbnRQaGFzZUZvcmVncm91bmQgfHwg cGFpbnRJbmZvLnBoYXNlID09IFBhaW50UGhhc2VTZWxlY3Rpb24pKSAKKyAgICBpZiAoaGFzQm94 RGVjb3JhdGlvbnMoKSAmJiBwYWludEluZm8ucGhhc2UgPT0gUGFpbnRQaGFzZUZvcmVncm91bmQp CiAgICAgICAgIHBhaW50Qm94RGVjb3JhdGlvbnMocGFpbnRJbmZvLCBhZGp1c3RlZFBhaW50T2Zm c2V0KTsKICAgICAKICAgICBpZiAocGFpbnRJbmZvLnBoYXNlID09IFBhaW50UGhhc2VNYXNrKSB7 Cg==