138735 2014-11-14 02:27:58 -0800 Remove pre-[DDActionContext contextForView:...] fallback path 2014-11-14 17:59:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca bdakin commit-queue webkit-bug-importer oldest_to_newest 1048701 0 thorton 2014-11-14 02:27:58 -0800 Remove pre-[DDActionContext contextForView:...] fallback path 1048703 1 241570 thorton 2014-11-14 02:28:34 -0800 Created attachment 241570 Patch 1048705 2 webkit-bug-importer 2014-11-14 02:29:24 -0800 <rdar://problem/18982046> 1048706 3 commit-queue 2014-11-14 02:31:20 -0800 Attachment 241570 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:571: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:573: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:576: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1048956 4 thorton 2014-11-14 17:59:05 -0800 http://trac.webkit.org/changeset/176150 241570 2014-11-14 02:28:34 -0800 2014-11-14 17:56:23 -0800 Patch bug-138735-20141114022840.patch text/plain 5121 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2MTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTU1MDMzODVlZmVmYjI4 MGNiNGNiZDYzMDA2NzRhNzVhNWMyNjIxNy4uMmFkY2ExNmM2MDVmMTgzZTc1ZGNiN2FmMTExMWM1 NWUxMjBhOGUyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTExLTE0ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCisgICAgICAgIFJlbW92ZSBwcmUt W0REQWN0aW9uQ29udGV4dCBjb250ZXh0Rm9yVmlldzouLi5dIGZhbGxiYWNrIHBhdGgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODczNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21h Yy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250 cm9sbGVyIHdpbGxPcGVuTWVudTp3aXRoRXZlbnQ6XSk6CisgICAgICAgICgtW1dLQWN0aW9uTWVu dUNvbnRyb2xsZXIgZGlkQ2xvc2VNZW51OndpdGhFdmVudDpdKToKKyAgICAgICAgKC1bV0tBY3Rp b25NZW51Q29udHJvbGxlciBfZGVmYXVsdE1lbnVJdGVtc0ZvckRhdGFEZXRlY3RlZFRleHRdKToK KyAgICAgICAgKGhhc0RhdGFEZXRlY3RvcnNDb21wbGV0aW9uQVBJKTogRGVsZXRlZC4KKyAgICAg ICAgUmVtb3ZlIHRoZSBub3ctdW5uZWNlc3NhcnkgZmFsbGJhY2sgcGF0aC4KKworMjAxNC0xMS0x NCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwogICAgICAgICBNb3Zl IERhdGFEZXRlY3RvcnMgc2Nhbm5pbmcgY29kZSB0byBXZWJDb3JlCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg3MzEKICAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzE4ODc3NTM1PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21h Yy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21h Yy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCmluZGV4IDZlNmIzNGU1YjFkM2E0MDhlZjI5ODM2 ZGE5ZmQ1ODY1ODRlMjg2OTMuLjE3NjY4Y2JkZGUyMzJiMzQwODZhN2QwODBhYzMwZDkxNDM1M2Iy MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51 Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9u TWVudUNvbnRyb2xsZXIubW0KQEAgLTU0LDE1ICs1NCw2IEBACiBTT0ZUX0xJTktfRlJBTUVXT1JL X0lOX1VNQlJFTExBKFF1YXJ0eiwgSW1hZ2VLaXQpCiBTT0ZUX0xJTktfQ0xBU1MoSW1hZ2VLaXQs IElLU2xpZGVzaG93KQogCi1zdGF0aWMgYm9vbCBoYXNEYXRhRGV0ZWN0b3JzQ29tcGxldGlvbkFQ SSgpIHsKLSAgICBzdGF0aWMgYm9vbCBoYXNDb21wbGV0aW9uQVBJOwotICAgIHN0YXRpYyBkaXNw YXRjaF9vbmNlX3Qgb25jZVRva2VuOwotICAgIGRpc3BhdGNoX29uY2UoJm9uY2VUb2tlbiwgXnsK LSAgICAgICAgaGFzQ29tcGxldGlvbkFQSSA9IFtnZXREREFjdGlvbnNNYW5hZ2VyQ2xhc3MoKSBy ZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHNob3VsZFVzZUFjdGlvbnNXaXRoQ29udGV4dDop XSAmJiBbZ2V0RERBY3Rpb25zTWFuYWdlckNsYXNzKCkgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxl Y3RvcihkaWRVc2VBY3Rpb25zKV07Ci0gICAgfSk7Ci0gICAgcmV0dXJuIGhhc0NvbXBsZXRpb25B UEk7Ci19Ci0KIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogdXNpbmcgbmFtZXNwYWNlIFdlYktp dDsKIApAQCAtMjAxLDE3ICsxOTIsMTMgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICAg ICAgcmV0dXJuOwogCiAgICAgaWYgKF90eXBlID09IGtXS0FjdGlvbk1lbnVEYXRhRGV0ZWN0ZWRJ dGVtKSB7Ci0gICAgICAgIGlmIChfY3VycmVudEFjdGlvbkNvbnRleHQgJiYgaGFzRGF0YURldGVj dG9yc0NvbXBsZXRpb25BUEkoKSkgewotICAgICAgICAgICAgaWYgKCFbZ2V0RERBY3Rpb25zTWFu YWdlckNsYXNzKCkgc2hvdWxkVXNlQWN0aW9uc1dpdGhDb250ZXh0Ol9jdXJyZW50QWN0aW9uQ29u dGV4dC5nZXQoKV0pIHsKLSAgICAgICAgICAgICAgICBbbWVudSBjYW5jZWxUcmFja2luZ107Ci0g ICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfQorICAgICAgICBpZiAoX2N1cnJl bnRBY3Rpb25Db250ZXh0ICYmICFbZ2V0RERBY3Rpb25zTWFuYWdlckNsYXNzKCkgc2hvdWxkVXNl QWN0aW9uc1dpdGhDb250ZXh0Ol9jdXJyZW50QWN0aW9uQ29udGV4dC5nZXQoKV0pIHsKKyAgICAg ICAgICAgIFttZW51IGNhbmNlbFRyYWNraW5nXTsKKyAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQotICAgICAgICBpZiAobWVudS5udW1iZXJPZkl0ZW1zID09IDEpIHsKKyAgICAgICAgaWYg KG1lbnUubnVtYmVyT2ZJdGVtcyA9PSAxKQogICAgICAgICAgICAgX3BhZ2UtPmNsZWFyU2VsZWN0 aW9uKCk7Ci0gICAgICAgICAgICBpZiAoIWhhc0RhdGFEZXRlY3RvcnNDb21wbGV0aW9uQVBJKCkp Ci0gICAgICAgICAgICAgICAgW3NlbGYgX3Nob3dUZXh0SW5kaWNhdG9yXTsKLSAgICAgICAgfSBl bHNlCisgICAgICAgIGVsc2UKICAgICAgICAgICAgIF9wYWdlLT5zZWxlY3RMYXN0QWN0aW9uTWVu dVJhbmdlKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0yMzQsMTMgKzIyMSw4IEBAIHVz aW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAgICAgICAgIHJldHVybjsKIAogICAgIGlmIChfdHlwZSA9 PSBrV0tBY3Rpb25NZW51RGF0YURldGVjdGVkSXRlbSkgewotICAgICAgICBpZiAoaGFzRGF0YURl dGVjdG9yc0NvbXBsZXRpb25BUEkoKSkgewotICAgICAgICAgICAgaWYgKF9jdXJyZW50QWN0aW9u Q29udGV4dCkKLSAgICAgICAgICAgICAgICBbZ2V0RERBY3Rpb25zTWFuYWdlckNsYXNzKCkgZGlk VXNlQWN0aW9uc107Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBpZiAobWVudS5udW1i ZXJPZkl0ZW1zID4gMSkKLSAgICAgICAgICAgICAgICBbc2VsZiBfaGlkZVRleHRJbmRpY2F0b3Jd OwotICAgICAgICB9CisgICAgICAgIGlmIChfY3VycmVudEFjdGlvbkNvbnRleHQpCisgICAgICAg ICAgICBbZ2V0RERBY3Rpb25zTWFuYWdlckNsYXNzKCkgZGlkVXNlQWN0aW9uc107CiAgICAgfQog CiAgICAgaWYgKCFfc2hvdWxkS2VlcFByZXZpZXdQb3BvdmVyT3BlbikKQEAgLTU4NCwyNyArNTY2 LDE3IEBAIHN0YXRpYyBOU1N0cmluZyAqcGF0aFRvUGhvdG9PbkRpc2soTlNTdHJpbmcgKnN1Z2dl c3RlZEZpbGVuYW1lKQogICAgIGlmICghYWN0aW9uQ29udGV4dCkKICAgICAgICAgcmV0dXJuIEBb IF07CiAKLSAgICBpZiAoaGFzRGF0YURldGVjdG9yc0NvbXBsZXRpb25BUEkoKSkgewotICAgICAg ICAvLyBSZWYgb3VyIFdlYlBhZ2VQcm94eSBmb3IgdXNlIGluIHRoZSBibG9ja3MgYmVsb3cuCi0g ICAgICAgIFJlZlB0cjxXZWJQYWdlUHJveHk+IHBhZ2UgPSBfcGFnZTsKLSAgICAgICAgX2N1cnJl bnRBY3Rpb25Db250ZXh0ID0gW2FjdGlvbkNvbnRleHQgY29udGV4dEZvclZpZXc6X3drVmlldyBh bHRNb2RlOllFUyBpbnRlcmFjdGlvblN0YXJ0ZWRIYW5kbGVyOl4oKSB7Ci0gICAgICAgICAgICBw YWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpEYXRhRGV0ZWN0b3JzRGlkUHJlc2VudFVJKCkp OwotICAgICAgICB9IGludGVyYWN0aW9uQ2hhbmdlZEhhbmRsZXI6XigpIHsKLSAgICAgICAgICAg IFtzZWxmIF9zaG93VGV4dEluZGljYXRvcl07Ci0gICAgICAgICAgICBwYWdlLT5zZW5kKE1lc3Nh Z2VzOjpXZWJQYWdlOjpEYXRhRGV0ZWN0b3JzRGlkQ2hhbmdlVUkoKSk7Ci0gICAgICAgIH0gaW50 ZXJhY3Rpb25TdG9wcGVkSGFuZGxlcjpeKCkgewotICAgICAgICAgICAgW3NlbGYgX2hpZGVUZXh0 SW5kaWNhdG9yXTsKLSAgICAgICAgICAgIHBhZ2UtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OkRh dGFEZXRlY3RvcnNEaWRIaWRlVUkoKSk7Ci0gICAgICAgIH1dOwotICAgIH0gZWxzZSB7Ci0gICAg ICAgIF9jdXJyZW50QWN0aW9uQ29udGV4dCA9IGFjdGlvbkNvbnRleHQ7Ci0KLSAgICAgICAgW19j dXJyZW50QWN0aW9uQ29udGV4dCBzZXRDb21wbGV0aW9uSGFuZGxlcjpeKCkgewotICAgICAgICAg ICAgW3NlbGYgX2hpZGVUZXh0SW5kaWNhdG9yXTsKLSAgICAgICAgfV07Ci0KLSAgICAgICAgW19j dXJyZW50QWN0aW9uQ29udGV4dCBzZXRGb3JBY3Rpb25NZW51Q29udGVudDpZRVNdOwotICAgIH0K KyAgICAvLyBSZWYgb3VyIFdlYlBhZ2VQcm94eSBmb3IgdXNlIGluIHRoZSBibG9ja3MgYmVsb3cu CisgICAgUmVmUHRyPFdlYlBhZ2VQcm94eT4gcGFnZSA9IF9wYWdlOworICAgIF9jdXJyZW50QWN0 aW9uQ29udGV4dCA9IFthY3Rpb25Db250ZXh0IGNvbnRleHRGb3JWaWV3Ol93a1ZpZXcgYWx0TW9k ZTpZRVMgaW50ZXJhY3Rpb25TdGFydGVkSGFuZGxlcjpeKCkgeworICAgICAgICBwYWdlLT5zZW5k KE1lc3NhZ2VzOjpXZWJQYWdlOjpEYXRhRGV0ZWN0b3JzRGlkUHJlc2VudFVJKCkpOworICAgIH0g aW50ZXJhY3Rpb25DaGFuZ2VkSGFuZGxlcjpeKCkgeworICAgICAgICBbc2VsZiBfc2hvd1RleHRJ bmRpY2F0b3JdOworICAgICAgICBwYWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpEYXRhRGV0 ZWN0b3JzRGlkQ2hhbmdlVUkoKSk7CisgICAgfSBpbnRlcmFjdGlvblN0b3BwZWRIYW5kbGVyOl4o KSB7CisgICAgICAgIFtzZWxmIF9oaWRlVGV4dEluZGljYXRvcl07CisgICAgICAgIHBhZ2UtPnNl bmQoTWVzc2FnZXM6OldlYlBhZ2U6OkRhdGFEZXRlY3RvcnNEaWRIaWRlVUkoKSk7CisgICAgfV07 CiAKICAgICBbX2N1cnJlbnRBY3Rpb25Db250ZXh0IHNldEhpZ2hsaWdodEZyYW1lOltfd2tWaWV3 LndpbmRvdyBjb252ZXJ0UmVjdFRvU2NyZWVuOltfd2tWaWV3IGNvbnZlcnRSZWN0Ol9oaXRUZXN0 UmVzdWx0LmRldGVjdGVkRGF0YUJvdW5kaW5nQm94IHRvVmlldzpuaWxdXV07CiAK