138713 2014-11-13 15:18:57 -0800 WK1: Support default actions for video 2014-11-13 15:31:30 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1048516 0 bdakin 2014-11-13 15:18:57 -0800 WK1: Support default actions for video rdar://problem/18877520 1048518 1 241510 bdakin 2014-11-13 15:21:52 -0800 Created attachment 241510 Patch 1048531 2 bdakin 2014-11-13 15:31:30 -0800 Thanks Tim! http://trac.webkit.org/changeset/176099 241510 2014-11-13 15:21:52 -0800 2014-11-13 15:28:17 -0800 Patch for-review.txt text/plain 6519 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjA5NSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTExLTEz ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBXSzE6IFN1cHBvcnQg ZGVmYXVsdCBhY3Rpb25zIGZvciB2aWRlbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NzEzCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAg ICAgICAgcmRhcjovL3Byb2JsZW0vMTg4Nzc1MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDYWxsIHNldFRvTm9uU2hhZG93QW5jZXN0b3IoKSBmb3Ig bWVkaWEgSGl0VGVzdFJlc3VsdHMuCisgICAgICAgICogV2ViVmlldy9XZWJBY3Rpb25NZW51Q29u dHJvbGxlci5tbToKKyAgICAgICAgKC1bV2ViQWN0aW9uTWVudUNvbnRyb2xsZXIgcGVyZm9ybUhp dFRlc3RBdFBvaW50Ol0pOgorCisgICAgICAgIERlZmF1bHQgaXRlbXMgYW5kIGFjdGlvbnMuCisg ICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIF9kZWZhdWx0TWVudUl0ZW1zRm9yVmlk ZW86XSk6CisgICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIF9jb3B5VmlkZW9VUkw6 XSk6CisgICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIF9zYXZlVmlkZW9Ub0Rvd25s b2FkczpdKToKKyAgICAgICAgKC1bV2ViQWN0aW9uTWVudUNvbnRyb2xsZXIgX2NyZWF0ZUFjdGlv bk1lbnVJdGVtRm9yVGFnOndpdGhIaXRUZXN0UmVzdWx0Ol0pOgorICAgICAgICAoLVtXZWJBY3Rp b25NZW51Q29udHJvbGxlciBfZGVmYXVsdE1lbnVJdGVtc0ZvckhpdFRlc3RSZXN1bHQ6XSk6Cisg ICAgICAgICogV2ViVmlldy9XZWJVSURlbGVnYXRlUHJpdmF0ZS5oOgorCiAyMDE0LTExLTEzICBU aW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFdLMTogVXBk YXRlIGljb24gZm9yIEFkZCB0byBSZWFkaW5nIExpc3QKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViQWN0aW9uTWVudUNvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJBY3Rpb25NZW51Q29udHJvbGxlci5tbQkocmV2aXNpb24g MTc2MDQxKQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJBY3Rpb25NZW51Q29udHJv bGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMTEwLDYgKzExMCwxNSBAQCAtIChXZWJFbGVtZW50 RGljdGlvbmFyeSAqKXBlcmZvcm1IaXRUZXN0CiAgICAgSGl0VGVzdFJlcXVlc3Q6OkhpdFRlc3RS ZXF1ZXN0VHlwZSBoaXRUeXBlID0gSGl0VGVzdFJlcXVlc3Q6OlJlYWRPbmx5IHwgSGl0VGVzdFJl cXVlc3Q6OkFjdGl2ZTsKICAgICBfaGl0VGVzdFJlc3VsdCA9IGNvcmVGcmFtZS0+ZXZlbnRIYW5k bGVyKCkuaGl0VGVzdFJlc3VsdEF0UG9pbnQoSW50UG9pbnQocG9pbnQpLCBoaXRUeXBlKTsKIAor ICAgIC8vIFdlIGhpdCB0ZXN0IGluY2x1ZGluZyBzaGFkb3cgY29udGVudCB0byBnZXQgdGhlIGRl c2lyZWQgcmVzdWx0IGZvciBlZGl0YWJsZSB0ZXh0IHJlZ2lvbnMuCisgICAgLy8gQnV0IGZvciBt ZWRpYSwgd2Ugd2FudCB0byByZS1zZXQgdG8gdGhlIHNoYWRvdyByb290LgorICAgIGlmIChOb2Rl KiBub2RlID0gX2hpdFRlc3RSZXN1bHQuaW5uZXJOb2RlKCkpIHsKKyAgICAgICAgaWYgKEVsZW1l bnQqIHNoYWRvd0hvc3QgPSBub2RlLT5zaGFkb3dIb3N0KCkpIHsKKyAgICAgICAgICAgIGlmIChz aGFkb3dIb3N0LT5pc01lZGlhRWxlbWVudCgpKQorICAgICAgICAgICAgICAgIF9oaXRUZXN0UmVz dWx0LnNldFRvTm9uU2hhZG93QW5jZXN0b3IoKTsKKyAgICAgICAgfQorICAgIH0KKwogICAgIHJl dHVybiBbW1tXZWJFbGVtZW50RGljdGlvbmFyeSBhbGxvY10gaW5pdFdpdGhIaXRUZXN0UmVzdWx0 Ol9oaXRUZXN0UmVzdWx0XSBhdXRvcmVsZWFzZV07CiB9CiAKQEAgLTM4NSw2ICszOTQsNDQgQEAg LSAodm9pZClfc2F2ZUltYWdlVG9Eb3dubG9hZHM6KGlkKXNlbmRlcgogICAgIFtfd2ViVmlldyBf ZG93bmxvYWRVUkw6X2hpdFRlc3RSZXN1bHQuYWJzb2x1dGVJbWFnZVVSTCgpXTsKIH0KIAorI3By YWdtYSBtYXJrIFZpZGVvIGFjdGlvbnMKKworLSAoTlNBcnJheSopX2RlZmF1bHRNZW51SXRlbXNG b3JWaWRlbzooV2ViRWxlbWVudERpY3Rpb25hcnkgKiloaXRUZXN0UmVzdWx0Cit7CisgICAgUmV0 YWluUHRyPE5TTWVudUl0ZW0+IGNvcHlWaWRlb1VSTEl0ZW0gPSBbc2VsZiBfY3JlYXRlQWN0aW9u TWVudUl0ZW1Gb3JUYWc6V2ViQWN0aW9uTWVudUl0ZW1UYWdDb3B5VmlkZW9VUkwgd2l0aEhpdFRl c3RSZXN1bHQ6aGl0VGVzdFJlc3VsdF07CisKKyAgICBSZXRhaW5QdHI8TlNNZW51SXRlbT4gc2F2 ZVRvRG93bmxvYWRzSXRlbSA9IFtzZWxmIF9jcmVhdGVBY3Rpb25NZW51SXRlbUZvclRhZzpXZWJB Y3Rpb25NZW51SXRlbVRhZ1NhdmVWaWRlb1RvRG93bmxvYWRzIHdpdGhIaXRUZXN0UmVzdWx0Omhp dFRlc3RSZXN1bHRdOworICAgIGlmICghX2hpdFRlc3RSZXN1bHQuaXNEb3dubG9hZGFibGVNZWRp YSgpIHx8ICFfd2ViVmlldy5kb3dubG9hZERlbGVnYXRlKQorICAgICAgICBbc2F2ZVRvRG93bmxv YWRzSXRlbSBzZXRFbmFibGVkOk5PXTsKKworICAgIFJldGFpblB0cjxOU01lbnVJdGVtPiBzaGFy ZUl0ZW0gPSBbc2VsZiBfY3JlYXRlQWN0aW9uTWVudUl0ZW1Gb3JUYWc6V2ViQWN0aW9uTWVudUl0 ZW1UYWdTaGFyZVZpZGVvIHdpdGhIaXRUZXN0UmVzdWx0OmhpdFRlc3RSZXN1bHRdOworICAgIE5T U3RyaW5nICp1cmxUb1NoYXJlID0gX2hpdFRlc3RSZXN1bHQuYWJzb2x1dGVNZWRpYVVSTCgpOwor ICAgIGlmICghX2hpdFRlc3RSZXN1bHQuaXNEb3dubG9hZGFibGVNZWRpYSgpKSB7CisgICAgICAg IFtzYXZlVG9Eb3dubG9hZHNJdGVtIHNldEVuYWJsZWQ6Tk9dOworICAgICAgICB1cmxUb1NoYXJl ID0gW193ZWJWaWV3IG1haW5GcmFtZVVSTF07CisgICAgfQorICAgIF9zaGFyaW5nU2VydmljZVBp Y2tlciA9IGFkb3B0TlMoW1tOU1NoYXJpbmdTZXJ2aWNlUGlja2VyIGFsbG9jXSBpbml0V2l0aEl0 ZW1zOkBbIHVybFRvU2hhcmUgXV0pOworICAgIFtfc2hhcmluZ1NlcnZpY2VQaWNrZXIgc2V0RGVs ZWdhdGU6c2VsZl07CisgICAgW3NoYXJlSXRlbSBzZXRTdWJtZW51Oltfc2hhcmluZ1NlcnZpY2VQ aWNrZXIgbWVudV1dOworCisgICAgcmV0dXJuIEBbIGNvcHlWaWRlb1VSTEl0ZW0uZ2V0KCksIFtO U01lbnVJdGVtIHNlcGFyYXRvckl0ZW1dLCBzYXZlVG9Eb3dubG9hZHNJdGVtLmdldCgpLCBzaGFy ZUl0ZW0uZ2V0KCkgXTsKK30KKworLSAodm9pZClfY29weVZpZGVvVVJMOihpZClzZW5kZXIKK3sK KyAgICBOU1N0cmluZyAqdXJsVG9Db3B5ID0gX2hpdFRlc3RSZXN1bHQuYWJzb2x1dGVNZWRpYVVS TCgpOworICAgIGlmICghX2hpdFRlc3RSZXN1bHQuaXNEb3dubG9hZGFibGVNZWRpYSgpKQorICAg ICAgICB1cmxUb0NvcHkgPSBbX3dlYlZpZXcgbWFpbkZyYW1lVVJMXTsKKworICAgIFtbTlNQYXN0 ZWJvYXJkIGdlbmVyYWxQYXN0ZWJvYXJkXSBjbGVhckNvbnRlbnRzXTsKKyAgICBbW05TUGFzdGVi b2FyZCBnZW5lcmFsUGFzdGVib2FyZF0gd3JpdGVPYmplY3RzOkBbIHVybFRvQ29weSBdXTsKK30K KworLSAodm9pZClfc2F2ZVZpZGVvVG9Eb3dubG9hZHM6KGlkKXNlbmRlcgoreworICAgIFtfd2Vi VmlldyBfZG93bmxvYWRVUkw6X2hpdFRlc3RSZXN1bHQuYWJzb2x1dGVNZWRpYVVSTCgpXTsKK30K KwogI3ByYWdtYSBtYXJrIFRleHQgYWN0aW9ucwogCiAtIChOU0FycmF5ICopX2RlZmF1bHRNZW51 SXRlbXNGb3JUZXh0OihXZWJFbGVtZW50RGljdGlvbmFyeSAqKWhpdFRlc3RSZXN1bHQKQEAgLTY2 NCw2ICs3MTEsMjMgQEAgLSAoUmV0YWluUHRyPE5TTWVudUl0ZW0+KV9jcmVhdGVBY3Rpb25NZQog ICAgICAgICBpbWFnZSA9IFtOU0ltYWdlIGltYWdlTmFtZWQ6QCJOU0FjdGlvbk1lbnVTaGFyZSJd OwogICAgICAgICBicmVhazsKIAorICAgIGNhc2UgV2ViQWN0aW9uTWVudUl0ZW1UYWdDb3B5Vmlk ZW9VUkw6CisgICAgICAgIHNlbGVjdG9yID0gQHNlbGVjdG9yKF9jb3B5VmlkZW9VUkw6KTsKKyAg ICAgICAgdGl0bGUgPSBXRUJfVUlfU1RSSU5HX0tFWSgiQ29weSIsICJDb3B5ICh2aWRlbyBhY3Rp b24gbWVudSBpdGVtKSIsICJ2aWRlbyBhY3Rpb24gbWVudSBpdGVtIik7CisgICAgICAgIGltYWdl ID0gW05TSW1hZ2UgaW1hZ2VOYW1lZDpAIk5TQWN0aW9uTWVudUNvcHkiXTsKKyAgICAgICAgYnJl YWs7CisKKyAgICBjYXNlIFdlYkFjdGlvbk1lbnVJdGVtVGFnU2F2ZVZpZGVvVG9Eb3dubG9hZHM6 CisgICAgICAgIHNlbGVjdG9yID0gQHNlbGVjdG9yKF9zYXZlVmlkZW9Ub0Rvd25sb2FkczopOwor ICAgICAgICB0aXRsZSA9IFdFQl9VSV9TVFJJTkdfS0VZKCJTYXZlIHRvIERvd25sb2FkcyIsICJT YXZlIHRvIERvd25sb2FkcyAodmlkZW8gYWN0aW9uIG1lbnUgaXRlbSkiLCAidmlkZW8gYWN0aW9u IG1lbnUgaXRlbSIpOworICAgICAgICBpbWFnZSA9IFtOU0ltYWdlIGltYWdlTmFtZWQ6QCJOU0Fj dGlvbk1lbnVTYXZlVG9Eb3dubG9hZHMiXTsKKyAgICAgICAgYnJlYWs7CisKKyAgICBjYXNlIFdl YkFjdGlvbk1lbnVJdGVtVGFnU2hhcmVWaWRlbzoKKyAgICAgICAgdGl0bGUgPSBXRUJfVUlfU1RS SU5HX0tFWSgiU2hhcmUiLCAiU2hhcmUgKHZpZGVvIGFjdGlvbiBtZW51IGl0ZW0pIiwgInZpZGVv IGFjdGlvbiBtZW51IGl0ZW0iKTsKKyAgICAgICAgaW1hZ2UgPSBbTlNJbWFnZSBpbWFnZU5hbWVk OkAiTlNBY3Rpb25NZW51U2hhcmUiXTsKKyAgICAgICAgYnJlYWs7CisKICAgICBkZWZhdWx0Ogog ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuIG5pbDsKQEAgLTY5 MCw2ICs3NTQsMTEgQEAgLSAoTlNBcnJheSAqKV9kZWZhdWx0TWVudUl0ZW1zRm9ySGl0VGVzdAog ICAgICAgICByZXR1cm4gW3NlbGYgX2RlZmF1bHRNZW51SXRlbXNGb3JMaW5rOmhpdFRlc3RSZXN1 bHRdOwogICAgIH0KIAorICAgIGlmICghX2hpdFRlc3RSZXN1bHQuYWJzb2x1dGVNZWRpYVVSTCgp LmlzRW1wdHkoKSkgeworICAgICAgICBfdHlwZSA9IFdlYkFjdGlvbk1lbnVWaWRlbzsKKyAgICAg ICAgcmV0dXJuIFtzZWxmIF9kZWZhdWx0TWVudUl0ZW1zRm9yVmlkZW86aGl0VGVzdFJlc3VsdF07 CisgICAgfQorCiAgICAgaWYgKF9oaXRUZXN0UmVzdWx0LmltYWdlKCkgJiYgIV9oaXRUZXN0UmVz dWx0LmFic29sdXRlSW1hZ2VVUkwoKS5pc0VtcHR5KCkpIHsKICAgICAgICAgX3R5cGUgPSBXZWJB Y3Rpb25NZW51SW1hZ2U7CiAgICAgICAgIHJldHVybiBbc2VsZiBfZGVmYXVsdE1lbnVJdGVtc0Zv ckltYWdlOmhpdFRlc3RSZXN1bHRdOwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJVSURlbGVnYXRlUHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViVUlEZWxlZ2F0ZVByaXZhdGUuaAkocmV2aXNpb24gMTc2MDQxKQorKysgU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJVSURlbGVnYXRlUHJpdmF0ZS5oCSh3b3JraW5nIGNvcHkp CkBAIC0xMjQsNyArMTI0LDEwIEBAIGVudW0gewogICAgIFdlYkFjdGlvbk1lbnVJdGVtVGFnQ29w eUltYWdlLAogICAgIFdlYkFjdGlvbk1lbnVJdGVtVGFnQWRkSW1hZ2VUb1Bob3RvcywKICAgICBX ZWJBY3Rpb25NZW51SXRlbVRhZ1NhdmVJbWFnZVRvRG93bmxvYWRzLAotICAgIFdlYkFjdGlvbk1l bnVJdGVtVGFnU2hhcmVJbWFnZQorICAgIFdlYkFjdGlvbk1lbnVJdGVtVGFnU2hhcmVJbWFnZSwK KyAgICBXZWJBY3Rpb25NZW51SXRlbVRhZ0NvcHlWaWRlb1VSTCwKKyAgICBXZWJBY3Rpb25NZW51 SXRlbVRhZ1NhdmVWaWRlb1RvRG93bmxvYWRzLAorICAgIFdlYkFjdGlvbk1lbnVJdGVtVGFnU2hh cmVWaWRlbwogfTsKIAogdHlwZWRlZiBlbnVtIHsKQEAgLTEzNCw3ICsxMzcsOCBAQCB0eXBlZGVm IGVudW0gewogICAgIFdlYkFjdGlvbk1lbnVFZGl0YWJsZVRleHQsCiAgICAgV2ViQWN0aW9uTWVu dVdoaXRlc3BhY2VJbkVkaXRhYmxlQXJlYSwKICAgICBXZWJBY3Rpb25NZW51RWRpdGFibGVUZXh0 V2l0aFN1Z2dlc3Rpb25zLAotICAgIFdlYkFjdGlvbk1lbnVJbWFnZQorICAgIFdlYkFjdGlvbk1l bnVJbWFnZSwKKyAgICBXZWJBY3Rpb25NZW51VmlkZW8KIH0gV2ViQWN0aW9uTWVudVR5cGU7CiAK IC8vIE1lc3NhZ2UgU291cmNlcy4K