138703 2014-11-13 11:22:56 -0800 Policy client not called for navigations through the page cache 2014-11-13 15:22:58 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=20842 P2 Normal --- 1 mitz webkit-unassigned buildbot commit-queue japhet rniwa oldest_to_newest 1048450 0 mitz 2014-11-13 11:22:56 -0800 When a back/forward navigation uses a page from the page cache, the policy client isn’t called to decide how to handle the navigation. 1048477 1 241500 mitz 2014-11-13 13:52:17 -0800 Created attachment 241500 Update a cached page’s DocumentLoader before reusing it for a back/forward navigation 1048486 2 mitz 2014-11-13 14:13:46 -0800 *** Bug 133422 has been marked as a duplicate of this bug. *** 1048519 3 241500 commit-queue 2014-11-13 15:22:53 -0800 Comment on attachment 241500 Update a cached page’s DocumentLoader before reusing it for a back/forward navigation Clearing flags on attachment: 241500 Committed r176096: <http://trac.webkit.org/changeset/176096> 1048520 4 commit-queue 2014-11-13 15:22:58 -0800 All reviewed patches have been landed. Closing bug. 241500 2014-11-13 13:52:17 -0800 2014-11-13 15:22:53 -0800 Update a cached page’s DocumentLoader before reusing it for a back/forward navigation 138703.diff text/plain 5024 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjA4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTExLTEzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUG9saWN5IGNsaWVudCBub3QgY2Fs bGVkIGZvciBuYXZpZ2F0aW9ucyB0aHJvdWdoIHRoZSBwYWdlIGNhY2hlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg3MDMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IGFkZGVkIHRvIFRlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL05hdmlnYXRpb24ubW0uCisKKyAgICAgICAgKiBsb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmxvYWRE aWZmZXJlbnREb2N1bWVudEl0ZW0pOiBXaGVuIHVzaW5nIGEgY2FjaGVkIHBhZ2UsIHdoaWNoIGFs cmVhZHkKKyAgICAgICAgaGFzIGEgZG9jdW1lbnQgbG9hZGVyLCBzZXQgdGhlIGRvY3VtZW50IGxv YWRlcuKAmXMgdHJpZ2dlcmluZyBhY3Rpb24gKHNvIHRoYXQgdGhlIHBvbGljeQorICAgICAgICBj bGllbnQgc2VlcyB0aGF0IHRoaXMgaXMgYSBiYWNrL2ZvcndhcmQgbmF2aWdhdGlvbikgYW5kIGNs ZWFyIGl0cyBsYXN0IGNoZWNrZWQgcmVxdWVzdCAoc28KKyAgICAgICAgdGhhdCB0aGUgcG9saWN5 IGNsaWVudCBnZXRzIGNhbGxlZCkuCisKIDIwMTQtMTEtMTMgIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IHRoZSBtYXRjaGluZyBmb3Ig Om50aC1sYXN0LWNoaWxkKEFuK0Igb2Ygc2VsZWN0b3ItbGlzdCkKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv bG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gMTc2MDc2KQorKysgU291cmNlL1dlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE1Myw3ICszMTUz LDEwIEBAIHZvaWQgRnJhbWVMb2FkZXI6OmxvYWREaWZmZXJlbnREb2N1bWVudEkKICAgICBoaXN0 b3J5KCkuc2V0UHJvdmlzaW9uYWxJdGVtKGl0ZW0pOwogCiAgICAgaWYgKENhY2hlZFBhZ2UqIGNh Y2hlZFBhZ2UgPSBwYWdlQ2FjaGUoKS0+Z2V0KGl0ZW0pKSB7Ci0gICAgICAgIGxvYWRXaXRoRG9j dW1lbnRMb2FkZXIoY2FjaGVkUGFnZS0+ZG9jdW1lbnRMb2FkZXIoKSwgbG9hZFR5cGUsIDAsIEFs bG93TmF2aWdhdGlvblRvSW52YWxpZFVSTDo6WWVzKTsKKyAgICAgICAgYXV0byBkb2N1bWVudExv YWRlciA9IGNhY2hlZFBhZ2UtPmRvY3VtZW50TG9hZGVyKCk7CisgICAgICAgIGRvY3VtZW50TG9h ZGVyLT5zZXRUcmlnZ2VyaW5nQWN0aW9uKE5hdmlnYXRpb25BY3Rpb24oZG9jdW1lbnRMb2FkZXIt PnJlcXVlc3QoKSwgbG9hZFR5cGUsIGZhbHNlKSk7CisgICAgICAgIGRvY3VtZW50TG9hZGVyLT5z ZXRMYXN0Q2hlY2tlZFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0KCkpOworICAgICAgICBsb2FkV2l0 aERvY3VtZW50TG9hZGVyKGRvY3VtZW50TG9hZGVyLCBsb2FkVHlwZSwgMCwgQWxsb3dOYXZpZ2F0 aW9uVG9JbnZhbGlkVVJMOjpZZXMpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCkluZGV4OiBU b29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAx NzYwODYpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBA QAorMjAxNC0xMS0xMyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAg IFBvbGljeSBjbGllbnQgbm90IGNhbGxlZCBmb3IgbmF2aWdhdGlvbnMgdGhyb3VnaCB0aGUgcGFn ZSBjYWNoZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM4NzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9OYXZpZ2F0aW9uLm1tOgorICAgICAg ICAoLVtEZWNpZGVQb2xpY3lGb3JQYWdlQ2FjaGVOYXZpZ2F0aW9uRGVsZWdhdGUgd2ViVmlldzpk aWRGaW5pc2hOYXZpZ2F0aW9uOl0pOgorICAgICAgICAoLVtEZWNpZGVQb2xpY3lGb3JQYWdlQ2Fj aGVOYXZpZ2F0aW9uRGVsZWdhdGUgd2ViVmlldzpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0 aW9uOmRlY2lzaW9uSGFuZGxlcjpdKToKKwogMjAxNC0xMS0xMyAgTXlsZXMgQy4gTWF4ZmllbGQg IDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IGNvbnN0cnVjdGluZyBhIGJh c2UgUGFzc1JlZiB3aXRoIGEgZGVyaXZlZCBSZWYKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0MkNvY29hL05hdmlnYXRpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvTmF2aWdhdGlvbi5tbQkocmV2aXNpb24gMTc2 MDc2KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvTmF2aWdhdGlv bi5tbQkod29ya2luZyBjb3B5KQpAQCAtOTAsNiArOTAsNyBAQCBURVNUKFdLTmF2aWdhdGlvbiwg TG9hZFJlcXVlc3QpCiAgICAgQVNTRVJUX05PVF9OVUxMKGN1cnJlbnROYXZpZ2F0aW9uKTsKICAg ICBBU1NFUlRfVFJVRShbW2N1cnJlbnROYXZpZ2F0aW9uIF9yZXF1ZXN0XSBpc0VxdWFsOnJlcXVl c3RdKTsKIAorICAgIGlzRG9uZSA9IGZhbHNlOwogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1 bigmaXNEb25lKTsKIH0KIApAQCAtMTM1LDcgKzEzNiw1NSBAQCBURVNUKFdLTmF2aWdhdGlvbiwg RGlkRmFpbFByb3Zpc2lvbmFsTmF2CiAgICAgQVNTRVJUX05PVF9OVUxMKGN1cnJlbnROYXZpZ2F0 aW9uKTsKICAgICBBU1NFUlRfVFJVRShbW2N1cnJlbnROYXZpZ2F0aW9uIF9yZXF1ZXN0XSBpc0Vx dWFsOnJlcXVlc3RdKTsKIAorICAgIGlzRG9uZSA9IGZhbHNlOwogICAgIFRlc3RXZWJLaXRBUEk6 OlV0aWw6OnJ1bigmaXNEb25lKTsKIH0KIAorQGludGVyZmFjZSBEZWNpZGVQb2xpY3lGb3JQYWdl Q2FjaGVOYXZpZ2F0aW9uRGVsZWdhdGUgOiBOU09iamVjdCA8V0tOYXZpZ2F0aW9uRGVsZWdhdGU+ CitAcHJvcGVydHkgKG5vbmF0b21pYykgQk9PTCBkZWNpZGVkUG9saWN5Rm9yQmFja0ZvcndhcmRO YXZpZ2F0aW9uOworQGVuZAorCitAaW1wbGVtZW50YXRpb24gRGVjaWRlUG9saWN5Rm9yUGFnZUNh Y2hlTmF2aWdhdGlvbkRlbGVnYXRlCisKKy0gKHZvaWQpd2ViVmlldzooV0tXZWJWaWV3ICopd2Vi VmlldyBkaWRGaW5pc2hOYXZpZ2F0aW9uOihXS05hdmlnYXRpb24gKiluYXZpZ2F0aW9uCit7Cisg ICAgaXNEb25lID0gdHJ1ZTsKK30KKworLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJW aWV3IGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb246KFdLTmF2aWdhdGlvbkFjdGlvbiAq KW5hdmlnYXRpb25BY3Rpb24gZGVjaXNpb25IYW5kbGVyOih2b2lkICheKShXS05hdmlnYXRpb25B Y3Rpb25Qb2xpY3kpKWRlY2lzaW9uSGFuZGxlcgoreworICAgIGlmIChuYXZpZ2F0aW9uQWN0aW9u Lm5hdmlnYXRpb25UeXBlID09IFdLTmF2aWdhdGlvblR5cGVCYWNrRm9yd2FyZCkKKyAgICAgICAg X2RlY2lkZWRQb2xpY3lGb3JCYWNrRm9yd2FyZE5hdmlnYXRpb24gPSBZRVM7CisKKyAgICBkZWNp c2lvbkhhbmRsZXIoV0tOYXZpZ2F0aW9uQWN0aW9uUG9saWN5QWxsb3cpOworfQorCitAZW5kCisK K1RFU1QoV0tOYXZpZ2F0aW9uLCBEZWNpZGVQb2xpY3lGb3JQYWdlQ2FjaGVOYXZpZ2F0aW9uKQor eworICAgIFJldGFpblB0cjxXS1dlYlZpZXc+IHdlYlZpZXcgPSBhZG9wdE5TKFtbV0tXZWJWaWV3 IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApXSk7CisKKyAg ICBSZXRhaW5QdHI8RGVjaWRlUG9saWN5Rm9yUGFnZUNhY2hlTmF2aWdhdGlvbkRlbGVnYXRlPiBk ZWxlZ2F0ZSA9IGFkb3B0TlMoW1tEZWNpZGVQb2xpY3lGb3JQYWdlQ2FjaGVOYXZpZ2F0aW9uRGVs ZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAgICBbd2ViVmlldyBzZXROYXZpZ2F0aW9uRGVsZWdhdGU6 ZGVsZWdhdGUuZ2V0KCldOworCisgICAgTlNVUkxSZXF1ZXN0ICpyZXF1ZXN0ID0gW05TVVJMUmVx dWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAImRhdGE6dGV4dC9odG1s LDEiXV07CisKKyAgICBpc0RvbmUgPSBmYWxzZTsKKyAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpy ZXF1ZXN0XTsKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmlzRG9uZSk7CisKKyAgICBy ZXF1ZXN0ID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmlu ZzpAImRhdGE6dGV4dC9odG1sLDIiXV07CisKKyAgICBpc0RvbmUgPSBmYWxzZTsKKyAgICBbd2Vi VmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4o JmlzRG9uZSk7CisKKyAgICBpc0RvbmUgPSBmYWxzZTsKKyAgICBbd2ViVmlldyBnb0JhY2tdOwor ICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmaXNEb25lKTsKKworICAgIEFTU0VSVF9UUlVF KFtkZWxlZ2F0ZSBkZWNpZGVkUG9saWN5Rm9yQmFja0ZvcndhcmROYXZpZ2F0aW9uXSk7Cit9CisK ICNlbmRpZgo=