138682 2014-11-12 19:34:02 -0800 REGRESSION (r172826) Password field placeholder text is missing 2014-11-13 12:15:30 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED data:text/html,<input placeholder="Password" type="password"> InRadar P2 Normal --- 1 jhoneycutt jhoneycutt benjamin cdumez oldest_to_newest 1048328 0 jhoneycutt 2014-11-12 19:34:02 -0800 Pasword field placeholder text is missing if the placeholder attribute precedes the type attribute. To repro, navigate to data:text/html,<input placeholder="Password" type="password"> <rdar://problem/18574213> 1048329 1 241463 jhoneycutt 2014-11-12 20:23:14 -0800 Created attachment 241463 Patch 1048332 2 241463 benjamin 2014-11-12 20:37:19 -0800 Comment on attachment 241463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241463&action=review Thanks a lot for fixing this! > LayoutTests/ChangeLog:12 > + * fast/forms/placeholder-attribute-ordering-expected.html: Added. > + * fast/forms/placeholder-attribute-ordering.html: Added. Can you please add a test were attributes are added dynamically from JS? Dynamic style updates tend to have their own set of bugs. > LayoutTests/fast/forms/placeholder-attribute-ordering.html:5 > + ::-webkit-input-placeholder { color: green; } Do you really need to color the placeholder for testing? Using the pseudo element ::-webkit-input-placeholder is a bit annoying because its scope is not yet well defined. 1048380 3 jhoneycutt 2014-11-13 02:12:54 -0800 (In reply to comment #2) > Comment on attachment 241463 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241463&action=review > > Thanks a lot for fixing this! > > > LayoutTests/ChangeLog:12 > > + * fast/forms/placeholder-attribute-ordering-expected.html: Added. > > + * fast/forms/placeholder-attribute-ordering.html: Added. > > Can you please add a test were attributes are added dynamically from JS? Yes, I'll add some tests for this. > > Dynamic style updates tend to have their own set of bugs. > > > LayoutTests/fast/forms/placeholder-attribute-ordering.html:5 > > + ::-webkit-input-placeholder { color: green; } > > Do you really need to color the placeholder for testing? > > Using the pseudo element ::-webkit-input-placeholder is a bit annoying > because its scope is not yet well defined. I wanted to use the 'placeholder' attribute for the test and the 'value' attribute to display the same text for the reference file, so I styled them to look the same. I'll change them to both use the 'placeholder' attribute, though. Thanks for the review! 1048456 4 jhoneycutt 2014-11-13 12:15:30 -0800 Committed r176082: <http://trac.webkit.org/changeset/176082> 241463 2014-11-12 20:23:14 -0800 2014-11-12 20:37:19 -0800 Patch bug-138682-20141112202319.patch text/plain 5425 jhoneycutt U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGVlOGQ4NDU1YjM5OWYw NGYzMjhkMjQ4NmQ3ZDUxZGIwYjBkMmVkNC4uODExZmY3YjQyNGYzMzJhNmM0MDU5Yzg2N2JjZGRm NjM2YThkMDYzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE0LTExLTEyICBKb24g SG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjE3MjgyNik6IFBhc3N3b3JkIGZpZWxkIHBsYWNlaG9sZGVyIHRleHQgaXMgbWlzc2luZyBpZgor ICAgICAgICBwbGFjZWhvbGRlciBhdHRyaWJ1dGUgcHJlY2VkZXMgdHlwZSBhdHRyaWJ1dGUKKwor ICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODY4Mj4K KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4NTc0MjEzPiAKKworICAgICAgICBXaGVuIHRoZSBw bGFjZWhvbGRlciBhdHRyaWJ1dGUgaXMgZW5jb3VudGVyZWQsIGEgc2hhZG93IHRyZWUgaXMgY3Jl YXRlZAorICAgICAgICB0byBpbmNsdWRlIHRoZSBwbGFjZWhvbGRlciBlbGVtZW50LiBXaGVuIHRo ZSB0eXBlIGF0dHJpYnV0ZSBpcworICAgICAgICBlbmNvdW50ZXJlZCwgdGhlIHByZXZpb3VzIHNo YWRvdyB0cmVlIGlzIGRlc3Ryb3llZCwgYW5kIGEgbmV3IHNoYWRvdworICAgICAgICB0cmVlIGlz IGNyZWF0ZWQuIFRleHRGaWVsZElucHV0VHlwZTo6Y3JlYXRlU2hhZG93U3VidHJlZSgpIGRpZCBu b3QKKyAgICAgICAgaGFuZGxlIGNyZWF0aW5nIHRoZSBwbGFjZWhvbGRlciBlbGVtZW50LiAKKwor ICAgICAgICBUaGlzIHJlZ3Jlc3NlZCBpbiByMTcyODI2IGJlY2F1c2UgcHJpb3IgdG8gcjE3Mjgy NiwgdGhlIHBsYWNlaG9sZGVyCisgICAgICAgIGVsZW1lbnQgd291bGQgYmUgcmVjcmVhdGVkIHdo ZW4KKyAgICAgICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnVwZGF0ZVBsYWNlaG9sZGVy VmlzaWJpbGl0eSgpIHdhcyBjYWxsZWQuCisgICAgICAgIEluIHIxNzI4MjYsIHVwZGF0ZVBsYWNl aG9sZGVyVmlzaWJpbGl0eSgpIHdhcyBjaGFuZ2VkIHRvIG9ubHkgc2hvdyBvcgorICAgICAgICBo aWRlIHRoZSBwbGFjZWhvbGRlciBlbGVtZW50IGlmIGl0IGV4aXN0cy4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRU eXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRGaWVsZElucHV0VHlwZTo6Y3JlYXRlU2hh ZG93U3VidHJlZSk6CisgICAgICAgIENhbGwgdXBkYXRlUGxhY2Vob2xkZXJWaXNpYmlsaXR5KCkg dG8gaW5zZXJ0IHRoZSBwbGFjZWhvbGRlciBlbGVtZW50CisgICAgICAgIChhZnRlciB0aGUgaW5u ZXIgdGV4dCBlbGVtZW50IGhhcyBiZWVuIGluc2VydGVkLCBhcyBpdCBhcHBlYXJzIGJlZm9yZQor ICAgICAgICBpdCBpbiB0aGUgc2hhZG93IERPTSkuCisKIDIwMTQtMTEtMDUgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlICdzaXplJyBDU1MgcHJvcGVydHkg dG8gdGhlIG5ldyBTdHlsZUJ1aWxkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv VGV4dEZpZWxkSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5w dXRUeXBlLmNwcAppbmRleCA4YTkyNThlOGE5ZjkwM2M4OTIwMjAyMTA5ZGE1NmZkMTJiNTJlY2Ji Li42MmQ3MDhjNmI1OGM1MGEyNWYwOGYxY2RmMDI2ZTNmZDJlZTIyZDk3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCkBAIC0yNDIsNiArMjQyLDcgQEAgdm9p ZCBUZXh0RmllbGRJbnB1dFR5cGU6OmNyZWF0ZVNoYWRvd1N1YnRyZWUoKQogICAgIG1faW5uZXJU ZXh0ID0gVGV4dENvbnRyb2xJbm5lclRleHRFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQpOwogICAg IGlmICghY3JlYXRlc0NvbnRhaW5lcikgewogICAgICAgICBlbGVtZW50KCkudXNlckFnZW50U2hh ZG93Um9vdCgpLT5hcHBlbmRDaGlsZChtX2lubmVyVGV4dCwgSUdOT1JFX0VYQ0VQVElPTik7Cisg ICAgICAgIHVwZGF0ZVBsYWNlaG9sZGVyVGV4dCgpOwogICAgICAgICByZXR1cm47CiAgICAgfQog CkBAIC0yNTQsNiArMjU1LDggQEAgdm9pZCBUZXh0RmllbGRJbnB1dFR5cGU6OmNyZWF0ZVNoYWRv d1N1YnRyZWUoKQogICAgIG1faW5uZXJCbG9jay0+YXBwZW5kQ2hpbGQobV9pbm5lclRleHQsIElH Tk9SRV9FWENFUFRJT04pOwogICAgIG1fY29udGFpbmVyLT5hcHBlbmRDaGlsZChtX2lubmVyQmxv Y2ssIElHTk9SRV9FWENFUFRJT04pOwogCisgICAgdXBkYXRlUGxhY2Vob2xkZXJUZXh0KCk7CisK ICAgICBpZiAoc2hvdWxkSGF2ZVNwaW5CdXR0b24pIHsKICAgICAgICAgbV9pbm5lclNwaW5CdXR0 b24gPSBTcGluQnV0dG9uRWxlbWVudDo6Y3JlYXRlKGRvY3VtZW50LCAqdGhpcyk7CiAgICAgICAg IG1fY29udGFpbmVyLT5hcHBlbmRDaGlsZChtX2lubmVyU3BpbkJ1dHRvbiwgSUdOT1JFX0VYQ0VQ VElPTik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggOWNlYWY2NjVkZWQ5NDk1ZWY0Njc5NDgyNzI1YTg0MzdhMGRhZDA5NS4u MDQwNDg0NDJkY2Y0MTc5MDVmYzZhMzMxNDQ0NTNkZWJmYjM4NTljMCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE0LTExLTEyICBKb24gSG9uZXljdXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE3MjgyNik6IFBhc3N3b3JkIGZpZWxkIHBsYWNlaG9s ZGVyIHRleHQgaXMgbWlzc2luZyBpZgorICAgICAgICBwbGFjZWhvbGRlciBhdHRyaWJ1dGUgcHJl Y2VkZXMgdHlwZSBhdHRyaWJ1dGUKKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzODY4Mj4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4NTc0MjEz PiAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZh c3QvZm9ybXMvcGxhY2Vob2xkZXItYXR0cmlidXRlLW9yZGVyaW5nLWV4cGVjdGVkLmh0bWw6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvcGxhY2Vob2xkZXItYXR0cmlidXRlLW9yZGVyaW5n Lmh0bWw6IEFkZGVkLgorCiAyMDE0LTExLTA1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJA YXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIGJhY2tpbmcgc3RvcmUgZm9yIG9wYWNpdHk6MCBk ZXNjZW5kYW50IGxheWVycwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9wbGFj ZWhvbGRlci1hdHRyaWJ1dGUtb3JkZXJpbmctZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvcGxhY2Vob2xkZXItYXR0cmlidXRlLW9yZGVyaW5nLWV4cGVjdGVkLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uMTE5YmE0NTkzNTc2YzU4ZDg4ZjgxODg0NzkzNjFjYmYwMzBlYjI0YgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcGxhY2Vob2xkZXItYXR0cmlidXRl LW9yZGVyaW5nLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwyMyBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzdHlsZT4KKyAgICAgICAgaW5wdXQgeyBjb2xvcjogZ3Jl ZW47IH0KKyAgICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisgICAgPHA+VGhpcyB0ZXN0IGVu c3VyZXMgdGhhdCBwbGFjZWhvbGRlciB0ZXh0IGlzIHNob3duIHJlZ2FyZGxlc3Mgb2YgdGhlICd0 eXBlJyBhbmQgJ3BsYWNlaG9sZGVyJyBhdHRyaWJ1dGUgb3JkZXIuPC9wPgorICAgIDxkaXY+Cisg ICAgICAgIDxpbnB1dCB0eXBlPSJ0ZXh0IiB2YWx1ZT0iV2ViS2l0Ij4KKyAgICAgICAgPGlucHV0 IHR5cGU9InRleHQiIHZhbHVlPSJXZWJLaXQiPgorICAgIDwvZGl2PgorICAgIDxkaXY+CisgICAg ICAgIDxpbnB1dCB0eXBlPSJ0ZXh0IiB2YWx1ZT0iV2ViS2l0Ij4KKyAgICAgICAgPGlucHV0IHR5 cGU9InRleHQiIHZhbHVlPSJXZWJLaXQiPgorICAgIDwvZGl2PgorICAgIDxkaXY+CisgICAgICAg IDxpbnB1dCB0eXBlPSJudW1iZXIiIHZhbHVlPSIxMjMiPgorICAgICAgICA8aW5wdXQgdHlwZT0i bnVtYmVyIiB2YWx1ZT0iMTIzIj4KKyAgICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcGxhY2Vob2xkZXItYXR0cmlidXRlLW9yZGVy aW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLWF0dHJpYnV0ZS1v cmRlcmluZy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYzMTMxMWYzMjc5ZmZlYWEyMmVhYzQ4ZGI4Mzg5MjJl N2Y0ODFjZTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3BsYWNl aG9sZGVyLWF0dHJpYnV0ZS1vcmRlcmluZy5odG1sCkBAIC0wLDAgKzEsMjMgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAgIDo6LXdlYmtpdC1p bnB1dC1wbGFjZWhvbGRlciB7IGNvbG9yOiBncmVlbjsgfQorICAgIDwvc3R5bGU+Cis8L2hlYWQ+ Cis8Ym9keT4KKyAgICA8cD5UaGlzIHRlc3QgZW5zdXJlcyB0aGF0IHBsYWNlaG9sZGVyIHRleHQg aXMgc2hvd24gcmVnYXJkbGVzcyBvZiB0aGUgJ3R5cGUnIGFuZCAncGxhY2Vob2xkZXInIGF0dHJp YnV0ZSBvcmRlci48L3A+CisgICAgPGRpdj4KKyAgICAgICAgPGlucHV0IHR5cGU9InRleHQiIHBs YWNlaG9sZGVyPSJXZWJLaXQiPgorICAgICAgICA8aW5wdXQgcGxhY2Vob2xkZXI9IldlYktpdCIg dHlwZT0idGV4dCI+CisgICAgPC9kaXY+CisgICAgPGRpdj4KKyAgICAgICAgPGlucHV0IHR5cGU9 InBhc3N3b3JkIiBwbGFjZWhvbGRlcj0iV2ViS2l0Ij4KKyAgICAgICAgPGlucHV0IHBsYWNlaG9s ZGVyPSJXZWJLaXQiIHR5cGU9InBhc3N3b3JkIj4KKyAgICA8L2Rpdj4KKyAgICA8ZGl2PgorICAg ICAgICA8aW5wdXQgdHlwZT0ibnVtYmVyIiBwbGFjZWhvbGRlcj0iMTIzIj4KKyAgICAgICAgPGlu cHV0IHBsYWNlaG9sZGVyPSIxMjMiIHR5cGU9Im51bWJlciI+CisgICAgPC9kaXY+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==