13868 2007-05-24 21:50:38 -0700 REGRESSION: crash on accessing a new iframe's contentWindow property 2007-05-30 14:19:10 -0700 1 1 1 Unclassified WebKit Frames 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 sam webkit-unassigned oldest_to_newest 9177 0 sam 2007-05-24 21:50:38 -0700 I have narrowed down the revisions to somewhere between r21639 - 21665. 9178 1 14711 sam 2007-05-24 21:54:48 -0700 Created attachment 14711 testcase {CRASHES BROWSER} 9165 2 sam 2007-05-24 22:39:06 -0700 From preliminary testing it looks like http://trac.webkit.org/projects/webkit/changeset/21646 is the culprit. 8718 3 14791 sam 2007-05-30 13:54:26 -0700 Created attachment 14791 patch 8719 4 sam 2007-05-30 13:56:02 -0700 <rdar://problem/5234019> 8708 5 14791 sam 2007-05-30 14:18:54 -0700 Comment on attachment 14791 patch This was reviewed by David Harrison. 8709 6 sam 2007-05-30 14:19:10 -0700 Landed in r21902. 14711 2007-05-24 21:54:48 -0700 2007-05-24 21:54:48 -0700 testcase {CRASHES BROWSER} iframe-crash.html text/html 327 sam VGhpcyBpcyBhIHRlc3QgZm9yIDxhIGhyZWY9Imh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzODY4Ij5odHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mzg2ODwvYT4gClJFR1JFU1NJT046IGNyYXNoIG9uIGFjY2Vzc2luZyBhIG5ldyBpZnJhbWUncyBj b250ZW50V2luZG93IHByb3BlcnR5LiAgSWYgdGhlcmUgaXMgbm8gY3Jhc2ggdGhpcyB0ZXN0IHBh c3Nlcy4KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgogICAgZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgnaWZyYW1lJykuY29udGVudFdpbmRvdzsKPC9zY3JpcHQ+ 14791 2007-05-30 13:54:26 -0700 2007-05-30 14:18:54 -0700 patch iframeCrashPatch.diff text/plain 6719 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTkwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDctMDUtMzAgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXRjaCBm b3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NjgKKyAgICAgICAg UkVHUkVTU0lPTjogY3Jhc2ggb24gYWNjZXNzaW5nIGEgbmV3IGlmcmFtZSdzIGNvbnRlbnRXaW5k b3cgcHJvcGVydHkKKworICAgICAgICBBZGRzIGEgbnVsbCBjaGVjayBpbiBmb3IgdGhlIGNvbnRl bnRXaW5kb3cgcHJvcGVydHkgZm9yIEhUTUxJRnJhbWVFbGVtZW50CisgICAgICAgIGFuZCBIVE1M RnJhbWVFbGVtZW50LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y SlMucG06CisgICAgICAgICogaHRtbC9IVE1MRnJhbWVFbGVtZW50LmlkbDoKKyAgICAgICAgKiBo dG1sL0hUTUxJRnJhbWVFbGVtZW50LmlkbDoKKwogMjAwNy0wNS0zMCAgTWl0eiBQZXR0ZWwgIDxt aXR6QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBXZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0JKHJldmlzaW9uIDIxOTAw KQorKysgV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkod29ya2lu ZyBjb3B5KQpAQCAtOTA3LDYgKzkwNyw4IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAg ICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgfVxuXG4i KTsKICAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICAgICBy ZXR1cm4gdG9KUyhleGVjLCBvYmouZ2V0KCkpO1xuIik7CiAgICAgICAgICAgICAgICAgICAgICAg ICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICB9XG4iKTsKKyAgICAgICAgICAgICAgICAgICAgfSBl bHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiTnVsbENo ZWNrIn0pIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAg ICAgICByZXR1cm4gaW1wLT4kbmFtZSgpID8gJGpzVHlwZSA6IGpzVW5kZWZpbmVkKCk7XG4iKTsK ICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICAgICAgICAgIHB1 c2goQGltcGxDb250ZW50LCAiICAgICAgICByZXR1cm4gJGpzVHlwZTtcbiIpOwogICAgICAgICAg ICAgICAgICAgICB9CkBAIC05MTcsNiArOTE5LDggQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRp b24KICAgICAgICAgCiAgICAgICAgICAgICAgICAgaWYgKCRwb2RUeXBlKSB7CiAgICAgICAgICAg ICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICAgICBLSlM6OkpTVmFsdWUqIHJlc3Vs dCA9ICIgLiBOYXRpdmVUb0pTVmFsdWUoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLCAiIiwgImltcC4k bmFtZShlYykiKSAuICI7XG4iKTsKKyAgICAgICAgICAgICAgICB9IGVsc2lmICgkYXR0cmlidXRl LT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJOdWxsQ2hlY2sifSkgeworICAgICAg ICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgcmV0dXJuIGltcC0+JG5h bWUoZWMpID8gIiAuIE5hdGl2ZVRvSlNWYWx1ZSgkYXR0cmlidXRlLT5zaWduYXR1cmUsICRpbXBs Q2xhc3NOYW1lRm9yVmFsdWVDb252ZXJzaW9uLCAiaW1wLT4kbmFtZShlYykiKSAuICIgOiBqc1Vu ZGVmaW5lZCgpO1xuIik7CiAgICAgICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgICAgIEtKUzo6SlNWYWx1ZSogcmVzdWx0ID0g IiAuIE5hdGl2ZVRvSlNWYWx1ZSgkYXR0cmlidXRlLT5zaWduYXR1cmUsICRpbXBsQ2xhc3NOYW1l Rm9yVmFsdWVDb252ZXJzaW9uLCAiaW1wLT4kbmFtZShlYykiKSAuICI7XG4iKTsKICAgICAgICAg ICAgICAgICB9CkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudC5pZGwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnQuaWRsCShyZXZpc2lvbiAyMTkw MCkKKysrIFdlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50LmlkbAkod29ya2luZyBjb3B5KQpA QCAtMzcsNyArMzcsNyBAQCBtb2R1bGUgaHRtbCB7CiAgICAgICAgIC8vIEV4dGVuc2lvbnMKICNp ZiBkZWZpbmVkKExBTkdVQUdFX0pBVkFTQ1JJUFQpCiAgICAgICAgIC8vIEZJWE1FOiB0aGlzIG5l ZWQgbm90IGJlIEpTIG9ubHkuIFNlZSBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzc5OAotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgV2luZG93IGNvbnRlbnRXaW5k b3c7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbTnVsbENoZWNrXSBXaW5kb3cgY29udGVu dFdpbmRvdzsKICNlbmRpZgogCiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBbQ29udmVydE51 bGxUb051bGxTdHJpbmddIERPTVN0cmluZyAgICAgICBsb2NhdGlvbjsKSW5kZXg6IFdlYkNvcmUv aHRtbC9IVE1MSUZyYW1lRWxlbWVudC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hU TUxJRnJhbWVFbGVtZW50LmlkbAkocmV2aXNpb24gMjE5MDApCisrKyBXZWJDb3JlL2h0bWwvSFRN TElGcmFtZUVsZW1lbnQuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw3IEBAIG1vZHVs ZSBodG1sIHsKICAgICAgICAgLy8gRXh0ZW5zaW9ucwogI2lmIGRlZmluZWQoTEFOR1VBR0VfSkFW QVNDUklQVCkKICAgICAgICAgLy8gRklYTUU6IHRoaXMgbmVlZCBub3QgYmUgSlMgb25seS4gU2Vl IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzk4Ci0gICAgICAgIHJl YWRvbmx5IGF0dHJpYnV0ZSBXaW5kb3cgY29udGVudFdpbmRvdzsKKyAgICAgICAgcmVhZG9ubHkg YXR0cmlidXRlIFtOdWxsQ2hlY2tdIFdpbmRvdyBjb250ZW50V2luZG93OwogI2VuZGlmCiAKICAg ICB9OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjE5MDApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwNy0wNS0zMCAgU2FtIFdlaW5pZyAg PHNhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFBhdGNoIGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzg2OAorICAgICAgICBSRUdSRVNTSU9OOiBjcmFzaCBvbiBhY2Nlc3NpbmcgYSBuZXcgaWZy YW1lJ3MgY29udGVudFdpbmRvdyBwcm9wZXJ0eQorCisgICAgICAgICogZmFzdC9kb20vZnJhbWUt Y29udGVudFdpbmRvdy1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv ZG9tL2ZyYW1lLWNvbnRlbnRXaW5kb3ctY3Jhc2guaHRtbDogQWRkZWQuCisgICAgICAgICogZmFz dC9kb20vaWZyYW1lLWNvbnRlbnRXaW5kb3ctY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2RvbS9pZnJhbWUtY29udGVudFdpbmRvdy1jcmFzaC5odG1sOiBBZGRlZC4K KwogMjAwNy0wNS0zMCAgTWl0eiBQZXR0ZWwgIDxtaXR6QHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9mcmFtZS1jb250 ZW50V2luZG93LWNyYXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2RvbS9mcmFtZS1jb250ZW50V2luZG93LWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2ZyYW1lLWNvbnRlbnRXaW5kb3ctY3Jhc2gtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitUaGlzIGlzIGEgdGVzdCBmb3Ig aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NjggUkVHUkVTU0lPTjog Y3Jhc2ggb24gYWNjZXNzaW5nIGEgbmV3IGlmcmFtZSdzIGNvbnRlbnRXaW5kb3cgcHJvcGVydHku IFRoaXMgdGVzdHMgSFRNTEZyYW1lRWxlbWVudC5jb250ZW50V2luZG93LiBJZiB0aGVyZSBpcyBu byBjcmFzaCB0aGlzIHRlc3QgcGFzc2VzLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vZnJh bWUtY29udGVudFdpbmRvdy1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvZG9tL2ZyYW1lLWNvbnRlbnRXaW5kb3ctY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2Zhc3QvZG9tL2ZyYW1lLWNvbnRlbnRXaW5kb3ctY3Jhc2guaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwxMiBAQAorVGhpcyBpcyBhIHRlc3QgZm9yIDxhIGhyZWY9Imh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODY4Ij5odHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg2ODwvYT4gCitSRUdSRVNTSU9OOiBjcmFzaCBvbiBh Y2Nlc3NpbmcgYSBuZXcgaWZyYW1lJ3MgY29udGVudFdpbmRvdyBwcm9wZXJ0eS4KKworVGhpcyB0 ZXN0cyBIVE1MRnJhbWVFbGVtZW50LmNvbnRlbnRXaW5kb3cuCisKK0lmIHRoZXJlIGlzIG5vIGNy YXNoIHRoaXMgdGVzdCBwYXNzZXMuCis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+Cisg ICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZnJh bWUnKS5jb250ZW50V2luZG93OworPC9zY3JpcHQ+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9pZnJhbWUtY29udGVudFdpbmRvdy1jcmFzaC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9kb20vaWZyYW1lLWNvbnRlbnRXaW5kb3ctY3Jhc2gtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vaWZyYW1lLWNvbnRlbnRX aW5kb3ctY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitUaGlz IGlzIGEgdGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4 NjggUkVHUkVTU0lPTjogY3Jhc2ggb24gYWNjZXNzaW5nIGEgbmV3IGlmcmFtZSdzIGNvbnRlbnRX aW5kb3cgcHJvcGVydHkuIFRoaXMgdGVzdHMgSFRNTElGcmFtZUVsZW1lbnQuY29udGVudFdpbmRv dy4gSWYgdGhlcmUgaXMgbm8gY3Jhc2ggdGhpcyB0ZXN0IHBhc3Nlcy4KSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvZG9tL2lmcmFtZS1jb250ZW50V2luZG93LWNyYXNoLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vaWZyYW1lLWNvbnRlbnRXaW5kb3ctY3Jhc2guaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2lmcmFtZS1jb250ZW50V2luZG93 LWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKK1RoaXMgaXMgYSB0ZXN0 IGZvciA8YSBocmVmPSJodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg2 OCI+aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4Njg8L2E+IAorUkVH UkVTU0lPTjogY3Jhc2ggb24gYWNjZXNzaW5nIGEgbmV3IGlmcmFtZSdzIGNvbnRlbnRXaW5kb3cg cHJvcGVydHkuCisKK1RoaXMgdGVzdHMgSFRNTElGcmFtZUVsZW1lbnQuY29udGVudFdpbmRvdy4K KworSWYgdGhlcmUgaXMgbm8gY3Jhc2ggdGhpcyB0ZXN0IHBhc3Nlcy4KKzxzY3JpcHQgdHlwZT0i dGV4dC9qYXZhc2NyaXB0Ij4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgnaWZyYW1lJykuY29udGVudFdpbmRvdzsKKzwvc2NyaXB0Pgo=