138677 2014-11-12 15:37:17 -0800 Web Inspector: Reduce work when activating multiple agents sequentially 2014-11-12 16:27:21 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1048284 0 joepeck 2014-11-12 15:37:17 -0800 * SUMMARY When activating agents lazily, only do the work in handlers if the current agent is being activated. Otherwise the duplicate work could produce exceptions. E.g. Multiple PageAgent.getResourceTree calls. 1048285 1 webkit-bug-importer 2014-11-12 15:37:54 -0800 <rdar://problem/18962467> 1048286 2 241446 joepeck 2014-11-12 15:38:13 -0800 Created attachment 241446 [PATCH] Proposed Fix 1048297 3 241446 commit-queue 2014-11-12 16:27:17 -0800 Comment on attachment 241446 [PATCH] Proposed Fix Clearing flags on attachment: 241446 Committed r176049: <http://trac.webkit.org/changeset/176049> 1048298 4 commit-queue 2014-11-12 16:27:21 -0800 All reviewed patches have been landed. Closing bug. 241446 2014-11-12 15:38:13 -0800 2014-11-12 16:27:17 -0800 [PATCH] Proposed Fix domains.patch text/plain 3302 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFjMjU5ZTIuLmY0NDM3ZjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTExLTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNl IHdvcmsgd2hlbiBhY3RpdmF0aW5nIG11bHRpcGxlIGFnZW50cyBzZXF1ZW50aWFsbHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODY3NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuYWN0aXZhdGVFeHRyYURvbWFp bnMpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1h bmFnZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRnJhbWVSZXNvdXJjZU1hbmFnZXIucHJv dG90eXBlLl9leHRyYURvbWFpbnNBY3RpdmF0ZWQpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Q29udHJvbGxlcnMvU3RvcmFnZU1hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3Rv cmFnZU1hbmFnZXIucHJvdG90eXBlLl9leHRyYURvbWFpbnNBY3RpdmF0ZWQpOgorCiAyMDE0LTEx LTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogSGFuZGxlIGFjdGl2YXRpbmcgZXh0cmEgYWdlbnRzIHByb3Blcmx5IGFmdGVy IGluc3BlY3RvciBoYXMgY29ubmVjdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggOGMyNzUwOC4uY2UzZjQxNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMzY1 LDcgKzM2NSw3IEBAIFdlYkluc3BlY3Rvci5hY3RpdmF0ZUV4dHJhRG9tYWlucyA9IGZ1bmN0aW9u KGRvbWFpbnMpCiAgICAgICAgICAgICBhZ2VudC5lbmFibGUoKTsKICAgICB9CiAKLSAgICB0aGlz Lm5vdGlmaWNhdGlvbnMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5Ob3Rp ZmljYXRpb24uRXh0cmFEb21haW5zQWN0aXZhdGVkKTsKKyAgICB0aGlzLm5vdGlmaWNhdGlvbnMu ZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5Ob3RpZmljYXRpb24uRXh0cmFE b21haW5zQWN0aXZhdGVkLCB7ImRvbWFpbnMiOiBkb21haW5zfSk7CiAKICAgICBXZWJJbnNwZWN0 b3IuQ1NTQ29tcGxldGlvbnMucmVxdWVzdENTU05hbWVDb21wbGV0aW9ucygpOwogfTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0Zy YW1lUmVzb3VyY2VNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIuanMKaW5kZXggZWNiNzk3YS4uNDE1 MDJlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIuanMKQEAg LTU4Nyw5ICs1ODcsOSBAQCBXZWJJbnNwZWN0b3IuRnJhbWVSZXNvdXJjZU1hbmFnZXIucHJvdG90 eXBlID0gewogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0 b3IuRnJhbWVSZXNvdXJjZU1hbmFnZXIuRXZlbnQuTWFpbkZyYW1lRGlkQ2hhbmdlLCB7b2xkTWFp bkZyYW1lOiBvbGRNYWluRnJhbWV9KTsKICAgICB9LAogCi0gICAgX2V4dHJhRG9tYWluc0FjdGl2 YXRlZDogZnVuY3Rpb24oKQorICAgIF9leHRyYURvbWFpbnNBY3RpdmF0ZWQ6IGZ1bmN0aW9uKGV2 ZW50KQogICAgIHsKLSAgICAgICAgaWYgKHdpbmRvdy5QYWdlQWdlbnQpCisgICAgICAgIGlmIChl dmVudC5kYXRhLmRvbWFpbnMuY29udGFpbnMoIlBhZ2UiKSAmJiB3aW5kb3cuUGFnZUFnZW50KQog ICAgICAgICAgICAgUGFnZUFnZW50LmdldFJlc291cmNlVHJlZSh0aGlzLl9wcm9jZXNzTWFpbkZy YW1lUmVzb3VyY2VUcmVlUGF5bG9hZC5iaW5kKHRoaXMpKTsKICAgICB9CiB9OwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvU3RvcmFn ZU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9TdG9yYWdlTWFuYWdlci5qcwppbmRleCA1MDQ2MzRjLi5hMjM5NDJlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9TdG9yYWdl TWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9TdG9yYWdlTWFuYWdlci5qcwpAQCAtMzA4LDkgKzMwOCwxMCBAQCBXZWJJbnNwZWN0 b3IuU3RvcmFnZU1hbmFnZXIucHJvdG90eXBlID0gewogICAgICAgICByZXR1cm4gbnVsbDsKICAg ICB9LAogCi0gICAgX2V4dHJhRG9tYWluc0FjdGl2YXRlZDogZnVuY3Rpb24oKQorICAgIF9leHRy YURvbWFpbnNBY3RpdmF0ZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKHdp bmRvdy5ET01TdG9yYWdlQWdlbnQgJiYgRE9NU3RvcmFnZUFnZW50LmdldERPTVN0b3JhZ2VJdGVt cykKKyAgICAgICAgCisgICAgICAgIGlmIChldmVudC5kYXRhLmRvbWFpbnMuY29udGFpbnMoIkRP TVN0b3JhZ2UiKSAmJiB3aW5kb3cuRE9NU3RvcmFnZUFnZW50ICYmIERPTVN0b3JhZ2VBZ2VudC5n ZXRET01TdG9yYWdlSXRlbXMpCiAgICAgICAgICAgICBXZWJJbnNwZWN0b3IuRnJhbWUuYWRkRXZl bnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRnJhbWUuRXZlbnQuU2VjdXJpdHlPcmlnaW5EaWRDaGFu Z2UsIHRoaXMuX3NlY3VyaXR5T3JpZ2luRGlkQ2hhbmdlLCB0aGlzKTsKICAgICB9CiB9Owo=