138663 2014-11-12 12:09:06 -0800 Generate get_by_id for bracket access with constant string subscript. 2014-11-12 13:13:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling buildbot ggaren kling rniwa oldest_to_newest 1048215 0 kling 2014-11-12 12:09:06 -0800 Turn o["f"] into o.f at bytecode generation time. 1048217 1 241436 kling 2014-11-12 12:09:45 -0800 Created attachment 241436 Patch 1048219 2 241436 msaboff 2014-11-12 12:11:45 -0800 Comment on attachment 241436 Patch r=me 1048232 3 kling 2014-11-12 13:13:13 -0800 Committed r176035: <http://trac.webkit.org/changeset/176035> 241436 2014-11-12 12:09:45 -0800 2014-11-12 12:11:45 -0800 Patch bug-138663.diff text/plain 2687 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk4NzRlZTMuLmMyNmIzNzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTExLTEyICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBHZW5lcmF0ZSBnZXRfYnlfaWQgZm9yIGJy YWNrZXQgYWNjZXNzIHdpdGggY29uc3RhbnQgc3RyaW5nIHN1YnNjcmlwdC4KKyAgICAgICAgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzEzODY2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUcmFuc2Zvcm0gb1siZiJdIGludG8gby5mIHdoZW4gZ2VuZXJh dGluZyBieXRlY29kZS4gVGhpcyBhbGxvd3Mgb3VyIEpJVAorICAgICAgICB0byBpbmxpbmUtY2Fj aGUgdGhvc2UgYWNjZXNzZXMgaW5zdGVhZCBvZiBhbHdheXMgZHJvcHBpbmcgb3V0IHRvIEMrKy4K KworICAgICAgICBUaGlzIGlzIHN1cnByaXNpbmdseSBjb21tb24gaW4gcmVhbC13ZWIgY29udGVu dCwgbGVzcyBzbyBpbiBiZW5jaG1hcmtzLgorICAgICAgICBJbnRlcmVzdGluZ2x5LCBTcGVlZG9t ZXRlciBkb2VzIGhpdCB0aGUgb3B0aW1pemF0aW9uIHF1aXRlIGEgYml0LgorCisgICAgICAgICog Ynl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAgIChKU0M6OkJyYWNrZXRBY2Nl c3Nvck5vZGU6OmVtaXRCeXRlY29kZSk6CisKIDIwMTQtMTEtMTIgIHBlYXZvQG91dGxvb2suY29t ICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBJbmNvcnJlY3QgbmFt ZXMgZm9yIHRlc3QgZXhlY3V0YWJsZXMgaW4gZGVidWcgbW9kZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAppbmRleCBmNWEwMzkz Li5jODYzZjEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVy L05vZGVzQ29kZWdlbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxl ci9Ob2Rlc0NvZGVnZW4uY3BwCkBAIC0zODksMTEgKzM4OSwyMCBAQCBSZWdpc3RlcklEKiBCcmFj a2V0QWNjZXNzb3JOb2RlOjplbWl0Qnl0ZWNvZGUoQnl0ZWNvZGVHZW5lcmF0b3ImIGdlbmVyYXRv ciwgUmVnaQogICAgICAgICByZXR1cm4gZ2VuZXJhdG9yLmVtaXRHZXRBcmd1bWVudEJ5VmFsKGdl bmVyYXRvci5maW5hbERlc3RpbmF0aW9uKGRzdCksIGdlbmVyYXRvci51bmNoZWNrZWRMb2NhbEFy Z3VtZW50c1JlZ2lzdGVyKCksIHByb3BlcnR5KTsKICAgICB9CiAKLSAgICBSZWZQdHI8UmVnaXN0 ZXJJRD4gYmFzZSA9IGdlbmVyYXRvci5lbWl0Tm9kZUZvckxlZnRIYW5kU2lkZShtX2Jhc2UsIG1f c3Vic2NyaXB0SGFzQXNzaWdubWVudHMsIG1fc3Vic2NyaXB0LT5pc1B1cmUoZ2VuZXJhdG9yKSk7 Ci0gICAgUmVnaXN0ZXJJRCogcHJvcGVydHkgPSBnZW5lcmF0b3IuZW1pdE5vZGUobV9zdWJzY3Jp cHQpOwotICAgIGdlbmVyYXRvci5lbWl0RXhwcmVzc2lvbkluZm8oZGl2b3QoKSwgZGl2b3RTdGFy dCgpLCBkaXZvdEVuZCgpKTsKKyAgICBSZWdpc3RlcklEKiByZXQ7CiAgICAgUmVnaXN0ZXJJRCog ZmluYWxEZXN0ID0gZ2VuZXJhdG9yLmZpbmFsRGVzdGluYXRpb24oZHN0KTsKLSAgICBSZWdpc3Rl cklEKiByZXQgPSBnZW5lcmF0b3IuZW1pdEdldEJ5VmFsKGZpbmFsRGVzdCwgYmFzZS5nZXQoKSwg cHJvcGVydHkpOworCisgICAgaWYgKG1fc3Vic2NyaXB0LT5pc1N0cmluZygpKSB7CisgICAgICAg IFJlZlB0cjxSZWdpc3RlcklEPiBiYXNlID0gZ2VuZXJhdG9yLmVtaXROb2RlKG1fYmFzZSk7Cisg ICAgICAgIHJldCA9IGdlbmVyYXRvci5lbWl0R2V0QnlJZChmaW5hbERlc3QsIGJhc2UuZ2V0KCks IHN0YXRpY19jYXN0PFN0cmluZ05vZGUqPihtX3N1YnNjcmlwdCktPnZhbHVlKCkpOworICAgIH0g ZWxzZSB7CisgICAgICAgIFJlZlB0cjxSZWdpc3RlcklEPiBiYXNlID0gZ2VuZXJhdG9yLmVtaXRO b2RlRm9yTGVmdEhhbmRTaWRlKG1fYmFzZSwgbV9zdWJzY3JpcHRIYXNBc3NpZ25tZW50cywgbV9z dWJzY3JpcHQtPmlzUHVyZShnZW5lcmF0b3IpKTsKKyAgICAgICAgUmVnaXN0ZXJJRCogcHJvcGVy dHkgPSBnZW5lcmF0b3IuZW1pdE5vZGUobV9zdWJzY3JpcHQpOworICAgICAgICByZXQgPSBnZW5l cmF0b3IuZW1pdEdldEJ5VmFsKGZpbmFsRGVzdCwgYmFzZS5nZXQoKSwgcHJvcGVydHkpOworICAg IH0KKworICAgIGdlbmVyYXRvci5lbWl0RXhwcmVzc2lvbkluZm8oZGl2b3QoKSwgZGl2b3RTdGFy dCgpLCBkaXZvdEVuZCgpKTsKKwogICAgIGlmIChnZW5lcmF0b3Iudm0oKS0+dHlwZVByb2ZpbGVy KCkpIHsKICAgICAgICAgZ2VuZXJhdG9yLmVtaXRQcm9maWxlVHlwZShmaW5hbERlc3QsIFByb2Zp bGVUeXBlQnl0ZWNvZGVEb2VzTm90SGF2ZUdsb2JhbElELCBudWxscHRyKTsKICAgICAgICAgZ2Vu ZXJhdG9yLmVtaXRUeXBlUHJvZmlsZXJFeHByZXNzaW9uSW5mbyhkaXZvdFN0YXJ0KCksIGRpdm90 RW5kKCkpOwo=