138659 2014-11-12 07:06:02 -0800 [WinCairo] Incorrect names for test executables in debug mode. 2014-11-12 10:31:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue oldest_to_newest 1048152 0 peavo 2014-11-12 07:06:02 -0800 In debug mode, jsc.exe, and testapi.exe are not created, causing JSC test failures. 1048153 1 241425 peavo 2014-11-12 07:15:46 -0800 Created attachment 241425 Patch 1048155 2 241425 alex.christensen 2014-11-12 08:37:19 -0800 Comment on attachment 241425 Patch Thanks! I saw this problem, but I didn't have time to look into its source. Turns out to be a pretty simple problem. 1048162 3 241425 commit-queue 2014-11-12 09:16:19 -0800 Comment on attachment 241425 Patch Clearing flags on attachment: 241425 Committed r176021: <http://trac.webkit.org/changeset/176021> 1048163 4 commit-queue 2014-11-12 09:16:22 -0800 All reviewed patches have been landed. Closing bug. 1048188 5 peavo 2014-11-12 10:31:41 -0800 (In reply to comment #2) > Comment on attachment 241425 [details] > Patch > > Thanks! I saw this problem, but I didn't have time to look into its source. > Turns out to be a pretty simple problem. Thanks for the review :) 241425 2014-11-12 07:15:46 -0800 2014-11-12 09:16:19 -0800 Patch bug-138659-20141112161539.patch text/plain 4154 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2MDE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTExLTEyICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIFtXaW5DYWlyb10gSW5jb3JyZWN0IG5hbWVzIGZvciB0ZXN0IGV4ZWN1dGFibGVzIGlu IGRlYnVnIG1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzg2NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbiBkZWJ1ZyBtb2RlLCBqc2MuZXhlLCBhbmQgdGVzdGFwaS5leGUgYXJlIG5vdCBjcmVh dGVkLCBjYXVzaW5nIEpTQyB0ZXN0IGZhaWx1cmVzLgorCisgICAgICAgICogSmF2YVNjcmlwdENv cmUudmN4cHJvai9qc2MvanNjTGF1bmNoZXIudmN4cHJvajoKKyAgICAgICAgKiBKYXZhU2NyaXB0 Q29yZS52Y3hwcm9qL3Rlc3RhcGkvdGVzdGFwaUxhdW5jaGVyLnZjeHByb2o6CisKIDIwMTQtMTEt MTEgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdl IERGRyB0byB1c2Ugc2NvcGUgb3BlcmFuZCBmb3Igb3BfcmVzb2x2ZV9zY29wZQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovanNjL2pzY0xhdW5jaGVy LnZjeHByb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRD b3JlLnZjeHByb2ovanNjL2pzY0xhdW5jaGVyLnZjeHByb2oJKHJldmlzaW9uIDE3NjAxNCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qL2pzYy9qc2NMYXVu Y2hlci52Y3hwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC0xNzgsMTEgKzE3OCwxMyBAQAogICA8UHJv cGVydHlHcm91cD4NCiAgICAgPF9Qcm9qZWN0RmlsZVZlcnNpb24+MTAuMC40MDIxOS4xPC9fUHJv amVjdEZpbGVWZXJzaW9uPg0KICAgICA8VGFyZ2V0TmFtZSBDb25kaXRpb249IickKENvbmZpZ3Vy YXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVnfFdpbjMyJyI+anNjJChEZWJ1Z1N1ZmZpeCk8L1Rh cmdldE5hbWU+DQorICAgIDxUYXJnZXROYW1lIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8 JChQbGF0Zm9ybSknPT0nRGVidWdfV2luQ2Fpcm98V2luMzInIj5qc2MkKERlYnVnU3VmZml4KTwv VGFyZ2V0TmFtZT4NCiAgICAgPFRhcmdldE5hbWUgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9u KXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z1N1ZmZpeHxXaW4zMiciPmpzYyQoRGVidWdTdWZmaXgpPC9U YXJnZXROYW1lPg0KICAgICA8VGFyZ2V0TmFtZSBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24p fCQoUGxhdGZvcm0pJz09J1Byb2R1Y3Rpb258V2luMzInIj5qc2MkKERlYnVnU3VmZml4KTwvVGFy Z2V0TmFtZT4NCiAgICAgPFRhcmdldE5hbWUgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwk KFBsYXRmb3JtKSc9PSdSZWxlYXNlfFdpbjMyJyI+anNjJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5h bWU+DQogICAgIDxUYXJnZXROYW1lIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0 Zm9ybSknPT0nUmVsZWFzZV9XaW5DYWlyb3xXaW4zMiciPmpzYyQoRGVidWdTdWZmaXgpPC9UYXJn ZXROYW1lPg0KICAgICA8VGFyZ2V0TmFtZSBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQo UGxhdGZvcm0pJz09J0RlYnVnfHg2NCciPmpzYyQoRGVidWdTdWZmaXgpPC9UYXJnZXROYW1lPg0K KyAgICA8VGFyZ2V0TmFtZSBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0p Jz09J0RlYnVnX1dpbkNhaXJvfHg2NCciPmpzYyQoRGVidWdTdWZmaXgpPC9UYXJnZXROYW1lPg0K ICAgICA8VGFyZ2V0TmFtZSBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0p Jz09J0RlYnVnU3VmZml4fHg2NCciPmpzYyQoRGVidWdTdWZmaXgpPC9UYXJnZXROYW1lPg0KICAg ICA8VGFyZ2V0TmFtZSBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09 J1Byb2R1Y3Rpb258eDY0JyI+anNjJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5hbWU+DQogICAgIDxU YXJnZXROYW1lIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nUmVs ZWFzZXx4NjQnIj5qc2MkKERlYnVnU3VmZml4KTwvVGFyZ2V0TmFtZT4NCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai90ZXN0YXBpL3Rlc3RhcGlMYXVu Y2hlci52Y3hwcm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2Ny aXB0Q29yZS52Y3hwcm9qL3Rlc3RhcGkvdGVzdGFwaUxhdW5jaGVyLnZjeHByb2oJKHJldmlzaW9u IDE3NjAxNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3hwcm9q L3Rlc3RhcGkvdGVzdGFwaUxhdW5jaGVyLnZjeHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTE3OCwx MSArMTc4LDEzIEBACiAgIDxQcm9wZXJ0eUdyb3VwPg0KICAgICA8X1Byb2plY3RGaWxlVmVyc2lv bj4xMC4wLjQwMjE5LjE8L19Qcm9qZWN0RmlsZVZlcnNpb24+DQogICAgIDxUYXJnZXROYW1lIENv bmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nRGVidWd8V2luMzInIj50 ZXN0YXBpJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5hbWU+DQorICAgIDxUYXJnZXROYW1lIENvbmRp dGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nRGVidWdfV2luQ2Fpcm98V2lu MzInIj50ZXN0YXBpJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5hbWU+DQogICAgIDxUYXJnZXROYW1l IENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nRGVidWdTdWZmaXh8 V2luMzInIj50ZXN0YXBpJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5hbWU+DQogICAgIDxUYXJnZXRO YW1lIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nUHJvZHVjdGlv bnxXaW4zMiciPnRlc3RhcGkkKERlYnVnU3VmZml4KTwvVGFyZ2V0TmFtZT4NCiAgICAgPFRhcmdl dE5hbWUgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNl fFdpbjMyJyI+dGVzdGFwaSQoRGVidWdTdWZmaXgpPC9UYXJnZXROYW1lPg0KICAgICA8VGFyZ2V0 TmFtZSBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J1JlbGVhc2Vf V2luQ2Fpcm98V2luMzInIj50ZXN0YXBpJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5hbWU+DQogICAg IDxUYXJnZXROYW1lIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0n RGVidWd8eDY0JyI+dGVzdGFwaSQoRGVidWdTdWZmaXgpPC9UYXJnZXROYW1lPg0KKyAgICA8VGFy Z2V0TmFtZSBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVn X1dpbkNhaXJvfHg2NCciPnRlc3RhcGkkKERlYnVnU3VmZml4KTwvVGFyZ2V0TmFtZT4NCiAgICAg PFRhcmdldE5hbWUgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdE ZWJ1Z1N1ZmZpeHx4NjQnIj50ZXN0YXBpJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5hbWU+DQogICAg IDxUYXJnZXROYW1lIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0n UHJvZHVjdGlvbnx4NjQnIj50ZXN0YXBpJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5hbWU+DQogICAg IDxUYXJnZXROYW1lIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0n UmVsZWFzZXx4NjQnIj50ZXN0YXBpJChEZWJ1Z1N1ZmZpeCk8L1RhcmdldE5hbWU+DQo=