138651 2014-11-11 20:30:07 -0800 Change DFG to use scope operand for op_resolve_scope 2014-11-11 22:00:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 312.x All All RESOLVED FIXED P2 Normal --- 136724 1 msaboff msaboff oldest_to_newest 1048091 0 msaboff 2014-11-11 20:30:07 -0800 The DFG should use the scope operand provided by op_resolve_scope. 1048094 1 241412 msaboff 2014-11-11 20:37:46 -0800 Created attachment 241412 Patch 1048100 2 241412 ggaren 2014-11-11 21:25:43 -0800 Comment on attachment 241412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241412&action=review r=me > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2304 > +Node* ByteCodeParser::getScope(VirtualRegister scope, unsigned skipCount) Strange to call a function named "get scope" and pass it a thing named "scope". A better name for this argument would be scopeChain, since it's the list of possible scopes, but the head is not necessarily the one you want to get. 1048104 3 msaboff 2014-11-11 21:59:52 -0800 (In reply to comment #2) > Comment on attachment 241412 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241412&action=review > > r=me > > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2304 > > +Node* ByteCodeParser::getScope(VirtualRegister scope, unsigned skipCount) > > Strange to call a function named "get scope" and pass it a thing named > "scope". > > A better name for this argument would be scopeChain, since it's the list of > possible scopes, but the head is not necessarily the one you want to get. I changed the argument's name to scopeChain. 1048105 4 msaboff 2014-11-11 22:00:41 -0800 Committed r176005: <http://trac.webkit.org/changeset/176005> 241412 2014-11-11 20:37:46 -0800 2014-11-11 21:25:43 -0800 Patch 138651.patch text/plain 2240 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2MDAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTExLTExICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENoYW5nZSBERkcgdG8gdXNlIHNjb3BlIG9wZXJhbmQgZm9yIG9wX3Jlc29sdmVfc2NvcGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODY1MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZWQg dG8gdXNlIHRoZSBwcm92aWRlZCBzY29wZSBWaXJ0dWFsUmVnaXN0ZXIuCisKKyAgICAgICAgKiBk ZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFy c2VyOjpnZXRTY29wZSk6IENoYW5nZWQgdG8gdXNlIGFuIGFyZ3VtZW50IHNjb3BlIHJlZ2lzdGVy LgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFyc2VyOjpwYXJzZUJsb2NrKTogQ3JlYXRl ZCBWaXJ0dWFsUmVnaXN0ZXIgZnJvbSBzY29wZSBvcGVyYW5kLgorCiAyMDE0LTExLTExICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmVtb3ZlIElu Y3JlbWVudGFsU3dlZXBlcjo6Y3JlYXRlKCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCShyZXZpc2lvbiAxNzU5OTcpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjA2LDcgKzIwNiw3IEBAIHByaXZhdGU6CiAgICAgICAgIGJvb2wgaXNEaXJlY3QpOwog ICAgIHZvaWQgZW1pdENoZWNrcyhjb25zdCBDb25zdGFudFN0cnVjdHVyZUNoZWNrVmVjdG9yJik7 CiAKLSAgICBOb2RlKiBnZXRTY29wZSh1bnNpZ25lZCBza2lwQ291bnQpOworICAgIE5vZGUqIGdl dFNjb3BlKFZpcnR1YWxSZWdpc3RlciBzY29wZSwgdW5zaWduZWQgc2tpcENvdW50KTsKICAgICAK ICAgICB2b2lkIHByZXBhcmVUb1BhcnNlQmxvY2soKTsKICAgICB2b2lkIGNsZWFyQ2FjaGVzKCk7 CkBAIC0yMzAxLDkgKzIzMDEsOSBAQCB2b2lkIEJ5dGVDb2RlUGFyc2VyOjpjbGVhckNhY2hlcygp CiAgICAgbV9jb25zdGFudHMucmVzaXplKDApOwogfQogCi1Ob2RlKiBCeXRlQ29kZVBhcnNlcjo6 Z2V0U2NvcGUodW5zaWduZWQgc2tpcENvdW50KQorTm9kZSogQnl0ZUNvZGVQYXJzZXI6OmdldFNj b3BlKFZpcnR1YWxSZWdpc3RlciBzY29wZSwgdW5zaWduZWQgc2tpcENvdW50KQogewotICAgIE5v ZGUqIGxvY2FsQmFzZSA9IGdldChWaXJ0dWFsUmVnaXN0ZXIoSlNTdGFjazo6U2NvcGVDaGFpbikp OworICAgIE5vZGUqIGxvY2FsQmFzZSA9IGdldChzY29wZSk7CiAgICAgZm9yICh1bnNpZ25lZCBu ID0gc2tpcENvdW50OyBuLS07KQogICAgICAgICBsb2NhbEJhc2UgPSBhZGRUb0dyYXBoKFNraXBT Y29wZSwgbG9jYWxCYXNlKTsKICAgICByZXR1cm4gbG9jYWxCYXNlOwpAQCAtMzE5OCw3ICszMTk4 LDcgQEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayh1bnNpZ25lZAogICAgICAgICAg ICAgICAgICAgICBzZXQoVmlydHVhbFJlZ2lzdGVyKGRzdCksIHdlYWtKU0NvbnN0YW50KGxleGlj YWxFbnZpcm9ubWVudCkpOwogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAg ICAgICB9Ci0gICAgICAgICAgICAgICAgc2V0KFZpcnR1YWxSZWdpc3Rlcihkc3QpLCBnZXRTY29w ZShkZXB0aCkpOworICAgICAgICAgICAgICAgIHNldChWaXJ0dWFsUmVnaXN0ZXIoZHN0KSwgZ2V0 U2NvcGUoVmlydHVhbFJlZ2lzdGVyKGN1cnJlbnRJbnN0cnVjdGlvblsyXS51Lm9wZXJhbmQpLCBk ZXB0aCkpOwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICAg ICAgY2FzZSBEeW5hbWljOgo=