138640 2014-11-11 16:39:45 -0800 Modernize $buildingForIPhone in CodeGeneratorObjC.pm 2014-11-12 09:35:50 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue dbates joepeck mrowe oldest_to_newest 1048025 0 ddkilzer 2014-11-11 16:39:45 -0800 Mac OS X is the only platform that supports NSColor, so rename $buildingForIPhone to $shouldUseCGColor (which is actually what the variable represents) and define it in terms of the "macosx" platform name. 1048027 1 241394 ddkilzer 2014-11-11 16:43:26 -0800 Created attachment 241394 Patch v1 1048029 2 ddkilzer 2014-11-11 16:48:03 -0800 <rdar://problem/18919000> 1048037 3 241394 dbates 2014-11-11 17:06:56 -0800 Comment on attachment 241394 Patch v1 OK. 1048038 4 241394 mrowe 2014-11-11 17:07:04 -0800 Comment on attachment 241394 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=241394&action=review > Source/WebCore/ChangeLog:3 > + Modernize $buildingForIPhone in CodeGeneratorObjC.pm "Modernize" is a strange way of saying "rename". 1048043 5 241394 commit-queue 2014-11-11 17:20:35 -0800 Comment on attachment 241394 Patch v1 Clearing flags on attachment: 241394 Committed r175995: <http://trac.webkit.org/changeset/175995> 1048044 6 commit-queue 2014-11-11 17:20:39 -0800 All reviewed patches have been landed. Closing bug. 1048176 7 ddkilzer 2014-11-12 09:35:50 -0800 (In reply to comment #4) > Comment on attachment 241394 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241394&action=review > > > Source/WebCore/ChangeLog:3 > > + Modernize $buildingForIPhone in CodeGeneratorObjC.pm > > "Modernize" is a strange way of saying "rename". That's because it wasn't just a variable rename; I changed the logic of how the variable was defined and removed some cruft. 241394 2014-11-11 16:43:26 -0800 2014-11-11 17:20:35 -0800 Patch v1 bug-138640-20141111164330.patch text/plain 4115 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1OTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFiNTA2MDQ5NmY3MWEz Mzc3MjM3NWE0NzdjZmU3M2M0NTJjM2I0NC4uMmM0YjhjNDE3OGExMDUwMzNiYTlkMDc2NGFhMDI5 NTZmNzg5MDRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE0LTExLTExICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTW9kZXJuaXplICRidWls ZGluZ0ZvcklQaG9uZSBpbiBDb2RlR2VuZXJhdG9yT2JqQy5wbQorICAgICAgICA8aHR0cDovL3dl YmtpdC5vcmcvYi8xMzg2NDA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFjIE9TIFggaXMgdGhlIG9ubHkgcGxhdGZvcm0gdGhhdCBzdXBwb3J0cyBO U0NvbG9yLCBzbyByZW5hbWUKKyAgICAgICAgJGJ1aWxkaW5nRm9ySVBob25lIHRvICRzaG91bGRV c2VDR0NvbG9yICh3aGljaCBpcyBhY3R1YWxseSB3aGF0CisgICAgICAgIHRoZSB2YXJpYWJsZSBy ZXByZXNlbnRzKSBhbmQgZGVmaW5lIGl0IGluIHRlcm1zIG9mIHRoZSAibWFjb3N4IgorICAgICAg ICBwbGF0Zm9ybSBuYW1lLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yT2JqQy5wbToKKyAgICAgICAgKCRidWlsZGluZ0ZvcklQaG9uZSk6IFJlbmFtZSB0byAkc2hv dWxkVXNlQ0dDb2xvci4KKyAgICAgICAgKCRzaG91bGRVc2VDR0NvbG9yKTogRmFsc2UgaWYgUExB VEZPUk1fTkFNRSBpcyBub3QgZGVmaW5lZCwKKyAgICAgICAgd2hpY2ggaXMgdGhlIGNhc2Ugb24g b2xkZXIgWGNvZGVzIHdoZW4gYnVpbGRpbmcgZm9yIE1hYyBPUyBYLCBvcgorICAgICAgICBpZiBQ TEFURk9STV9OQU1FIGlzIGVxdWFsIHRvICJtYWNvc3giLiAgVHJ1ZSBvdGhlcndpc2UuCisgICAg ICAgIChHZXRDbGFzc05hbWUpOiBTd2l0Y2ggdG8gdXNlIG5ldyB2YXJpYWJsZSBuYW1lLgorICAg ICAgICAoQWRkSW5jbHVkZXNGb3JUeXBlKTogRGl0dG8uCisgICAgICAgIChHZW5lcmF0ZUhlYWRl cik6IFJlbW92ZSBkZWFkIGNvZGUuICBUaGUKKyAgICAgICAgJGJ1aWxkaW5nRm9yVGlnZXJPckVh cmxpZXIgdmFyaWFibGUgd2FzIGFjY2lkZW50YWxseQorICAgICAgICByZS1pbnRyb2R1Y2VkIGlu IHIxNjE2MzgsIGJ1dCB3YXMgb3JpZ2luYWxseSByZW1vdmVkIGluIHIxMjcwMzIhCisgICAgICAg IChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKTogU3dpdGNoIHRvIHVzZSBuZXcgdmFyaWFibGUgbmFt ZS4KKwogMjAxNC0xMS0xMSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBjbGVhbnVwIHdpcmVsZXNzIHJvdXRlIG1vbml0b3JpbmcKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMu cG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBt CmluZGV4IDNkNTM0NzM3YzRlNTUyNGY3MjkxY2NlYzZjZDY5ZjU1MWY0NWE2MWUuLmFhZmUwYmEz ZTJjYTk5YjI1MWIxM2QwN2Y0MzVmZTNlYzUwZjUxZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0KKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQpAQCAtMTA0LDcgKzEw NCw3IEBAIG15ICViYXNlVHlwZUhhc2ggPSAoIk9iamVjdCIgPT4gMSwgIk5vZGUiID0+IDEsICJO b2RlTGlzdCIgPT4gMSwgIk5hbWVkTm9kZU1hcCIKICAgICAgICAgICAgICAgICAgICAgIk5vZGVJ dGVyYXRvciIgPT4gMSwgIlRyZWVXYWxrZXIiID0+IDEsICJBYnN0cmFjdFZpZXciID0+IDEsICJC bG9iIiA9PiAxKTsKIAogIyBDb25zdGFudHMKLW15ICRidWlsZGluZ0ZvcklQaG9uZSA9IGRlZmlu ZWQgJEVOVntQTEFURk9STV9OQU1FfSAmJiAoJEVOVntQTEFURk9STV9OQU1FfSBlcSAiaXBob25l b3MiIG9yICRFTlZ7UExBVEZPUk1fTkFNRX0gZXEgImlwaG9uZXNpbXVsYXRvciIpOworbXkgJHNo b3VsZFVzZUNHQ29sb3IgPSBkZWZpbmVkICRFTlZ7UExBVEZPUk1fTkFNRX0gJiYgJEVOVntQTEFU Rk9STV9OQU1FfSBuZSAibWFjb3N4IjsKIG15ICRudWxsYWJsZUluaXQgPSAiYm9vbCBpc051bGwg PSBmYWxzZTsiOwogbXkgJGV4Y2VwdGlvbkluaXQgPSAiV2ViQ29yZTo6RXhjZXB0aW9uQ29kZSBl YyA9IDA7IjsKIG15ICRqc0NvbnRleHRTZXR0ZXIgPSAiV2ViQ29yZTo6SlNNYWluVGhyZWFkTnVs bFN0YXRlIHN0YXRlOyI7CkBAIC0zOTIsNyArMzkyLDcgQEAgc3ViIEdldENsYXNzTmFtZQogCiAg ICAgIyBzcGVjaWFsIGNhc2VzCiAgICAgcmV0dXJuICJOU1N0cmluZyIgaWYgJGNvZGVHZW5lcmF0 b3ItPklzU3RyaW5nVHlwZSgkbmFtZSkgb3IgJG5hbWUgZXEgIlNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZSI7Ci0gICAgcmV0dXJuICJDR0NvbG9yUmVmIiBpZiAkbmFtZSBlcSAiQ29sb3IiIGFuZCAkYnVp bGRpbmdGb3JJUGhvbmU7CisgICAgcmV0dXJuICJDR0NvbG9yUmVmIiBpZiAkbmFtZSBlcSAiQ29s b3IiIGFuZCAkc2hvdWxkVXNlQ0dDb2xvcjsKICAgICByZXR1cm4gIk5TJG5hbWUiIGlmIElzTmF0 aXZlT2JqQ1R5cGUoJG5hbWUpOwogICAgIHJldHVybiAiQk9PTCIgaWYgJG5hbWUgZXEgImJvb2xl YW4iOwogICAgIHJldHVybiAidW5zaWduZWQgY2hhciIgaWYgJG5hbWUgZXEgIm9jdGV0IjsKQEAg LTY1OSw3ICs2NTksNyBAQCBzdWIgQWRkSW5jbHVkZXNGb3JUeXBlCiAKICAgICBpZiAoSXNOYXRp dmVPYmpDVHlwZSgkdHlwZSkpIHsKICAgICAgICAgaWYgKCR0eXBlIGVxICJDb2xvciIpIHsKLSAg ICAgICAgICAgIGlmICgkYnVpbGRpbmdGb3JJUGhvbmUpIHsKKyAgICAgICAgICAgIGlmICgkc2hv dWxkVXNlQ0dDb2xvcikgewogICAgICAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7IkNvbG9yU3Bh Y2UuaCJ9ID0gMTsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgJGltcGxJ bmNsdWRlc3siQ29sb3JNYWMuaCJ9ID0gMTsKQEAgLTg2Myw3ICs4NjMsNyBAQCBzdWIgR2VuZXJh dGVIZWFkZXIKICAgICAgICAgICAgIG15ICRwdWJsaWNJbnRlcmZhY2VLZXkgPSAkcHJvcGVydHkg LiAiOyI7CiAKICAgICAgICAgICAgICMgRklYTUU6IFRoaXMgb25seSB3b3JrcyBmb3IgdGhlIGdl dHRlciwgYnV0IG5vdCB0aGUgc2V0dGVyLiAgTmVlZCB0byByZWZhY3RvciB0aGlzIGNvZGUuCi0g ICAgICAgICAgICBpZiAoJGJ1aWxkaW5nRm9yVGlnZXJPckVhcmxpZXIgJiYgISRidWlsZGluZ0Zv cklQaG9uZSB8fCBJc0NvcmVGb3VuZGF0aW9uVHlwZSgkYXR0cmlidXRlVHlwZSkpIHsKKyAgICAg ICAgICAgIGlmIChJc0NvcmVGb3VuZGF0aW9uVHlwZSgkYXR0cmlidXRlVHlwZSkpIHsKICAgICAg ICAgICAgICAgICAkcHVibGljSW50ZXJmYWNlS2V5ID0gIi0gKCIgLiAkYXR0cmlidXRlVHlwZSAu ICIpIiAuICRhdHRyaWJ1dGVOYW1lIC4gIjsiOwogICAgICAgICAgICAgfQogCkBAIC0xMzI5LDcg KzEzMjksNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgICAgICAgICAgICAgICRn ZXR0ZXJDb250ZW50SGVhZCA9ICJraXQoJGdldHRlckNvbnRlbnRIZWFkIjsKICAgICAgICAgICAg ICAgICAkZ2V0dGVyQ29udGVudFRhaWwgLj0gIikiOwogICAgICAgICAgICAgfSBlbHNpZiAoJGlk bFR5cGUgZXEgIkNvbG9yIikgewotICAgICAgICAgICAgICAgIGlmICgkYnVpbGRpbmdGb3JJUGhv bmUpIHsKKyAgICAgICAgICAgICAgICBpZiAoJHNob3VsZFVzZUNHQ29sb3IpIHsKICAgICAgICAg ICAgICAgICAgICAgJGdldHRlckNvbnRlbnRIZWFkID0gIldlYkNvcmU6OmNhY2hlZENHQ29sb3Io JGdldHRlckNvbnRlbnRIZWFkIjsKICAgICAgICAgICAgICAgICAgICAgJGdldHRlckNvbnRlbnRU YWlsIC49ICIsIFdlYkNvcmU6OkNvbG9yU3BhY2VEZXZpY2VSR0IpIjsKICAgICAgICAgICAgICAg ICB9IGVsc2Ugewo=