13864 2007-05-24 13:44:28 -0700 REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths() 2008-08-24 02:19:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 efidler webkit-unassigned ariya.hidayat bdakin dacarson hyatt kbalazs mitz staikos oldest_to_newest 9204 0 efidler 2007-05-24 13:44:28 -0700 For text blocks that are just whitespace and stripFrontSpaces=true, when checking if the block should be considered for breaking, beginWS and endWS are used, but are uninitialized (RenderBlock.cpp:3741). They don't get initialized in RenderText::trimmedPrefWidths() since it returns early. I'm not sure if such blocks should be considered for breaking, so I don't know what values to initialize beginWS and endWS to. 9197 1 hyatt 2007-05-24 16:02:27 -0700 Confirming. This is a regression from newly-added code. 2092 2 16009 mitz 2007-08-17 08:25:19 -0700 Created attachment 16009 All-whitespace text test case I think the code in RenderBlock::calcInlinePrefWidths is wrong anyway as demonstrated by this test case. 1161 3 adele 2007-08-30 14:38:39 -0700 <rdar://problem/5451470> 1147 4 adele 2007-08-30 14:40:09 -0700 What kind of effects could we see on real-world sites from this bug? 64077 5 mitz 2007-12-12 23:50:59 -0800 *** Bug 16414 has been marked as a duplicate of this bug. *** 80529 6 ariya.hidayat 2008-05-15 12:14:53 -0700 *** Bug 19083 has been marked as a duplicate of this bug. *** 87160 7 mrowe 2008-07-28 08:22:43 -0700 *** Bug 20194 has been marked as a duplicate of this bug. *** 89188 8 22959 mitz 2008-08-24 01:35:50 -0700 Created attachment 22959 Patch 89189 9 mitz 2008-08-24 02:19:03 -0700 Fixed in <http://trac.webkit.org/changeset/35902>. 16009 2007-08-17 08:25:19 -0700 2007-08-17 08:25:19 -0700 All-whitespace text test case 13864 test case.html text/html 577 mitz PHRhYmxlPgoJPHRyPgoJCTx0ZCBzdHlsZT0iYmFja2dyb3VuZDogZ3JlZW47Ij48c3BhbiBzdHls ZT0ibWFyZ2luLWxlZnQ6IDUwcHg7Ij4gPC9zcGFuPlg8L3RkPgoJCTx0ZCB3aWR0aD0iMTAwJSI+ PC90ZD4KCTwvdHI+CjwvdGFibGU+Cgo8dGFibGU+Cgk8dHI+CgkJPHRkIHN0eWxlPSJiYWNrZ3Jv dW5kOiBncmVlbjsiPjxzcGFuIHN0eWxlPSJtYXJnaW4tcmlnaHQ6IDUwcHg7Ij4gPC9zcGFuPlg8 L3RkPgoJCTx0ZCB3aWR0aD0iMTAwJSI+PC90ZD4KCTwvdHI+CjwvdGFibGU+Cgo8dGFibGU+Cgk8 dHI+CgkJPHRkIHN0eWxlPSJiYWNrZ3JvdW5kOiBncmVlbjsiPjxzcGFuIHN0eWxlPSJtYXJnaW4t bGVmdDogNTBweDsiPiA8c3Bhbj5XPC9zcGFuPjwvc3Bhbj5YPC90ZD4KCQk8dGQgd2lkdGg9IjEw MCUiPjwvdGQ+Cgk8L3RyPgo8L3RhYmxlPgoKPHRhYmxlPgoJPHRyPgoJCTx0ZCBzdHlsZT0iYmFj a2dyb3VuZDogZ3JlZW47Ij48c3BhbiBzdHlsZT0ibWFyZ2luLXJpZ2h0OiA1MHB4OyI+IDxzcGFu Plc8L3NwYW4+PC9zcGFuPlg8L3RkPgoJCTx0ZCB3aWR0aD0iMTAwJSI+PC90ZD4KCTwvdHI+Cjwv dGFibGU+Cg== 22959 2008-08-24 01:35:50 -0700 2008-08-24 02:05:17 -0700 Patch 13864_r1.diff text/plain 1596 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTkwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDgtMjQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZp eCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NjQKKyAgICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTQ1MTQ3MD4gUkVHUkVTU0lPTjogVW5pbml0aWFsaXplZCB2YWx1 ZSBpbiBSZW5kZXJCbG9jazo6Y2FsY0lubGluZVByZWZXaWR0aHMoKQorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlclRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4dDo6dHJp bW1lZFByZWZXaWR0aHMpOiBNb3ZlZCB0aGUgYXNzaWdubWVudCB0bworICAgICAgICBiZWdpbldT IGFuZCBlbmRXUyBiZWZvcmUgdGhlIGVhcmx5IHJldHVybiB0byBlbnN1cmUgdGhhdCB0aGV5IGFy ZQorICAgICAgICBpbml0aWFsaXplZCBpbiB0aGF0IGNhc2UuCisKIDIwMDgtMDgtMjMgIENhbWVy b24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CiAKICAgICAgICAgUnViYmVyLXN0 YW1wZWQgYnkgTWFyayBSb3dlLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHJldmlz aW9uIDM1ODk4KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQxMCw3ICs0MTAsMTEgQEAgdm9pZCBSZW5kZXJUZXh0Ojp0cmltbWVkUHJlZldp ZHRocyhpbnQgbAogICAgIGlmIChtX2hhc1RhYiB8fCBwcmVmV2lkdGhzRGlydHkoKSkKICAgICAg ICAgY2FsY1ByZWZXaWR0aHMobGVhZFdpZHRoKTsKIAorICAgIGJlZ2luV1MgPSAhc3RyaXBGcm9u dFNwYWNlcyAmJiBtX2hhc0JlZ2luV1M7CisgICAgZW5kV1MgPSBtX2hhc0VuZFdTOworCiAgICAg aW50IGxlbiA9IHRleHRMZW5ndGgoKTsKKwogICAgIGlmICghbGVuIHx8IChzdHJpcEZyb250U3Bh Y2VzICYmIG1fdGV4dC0+Y29udGFpbnNPbmx5V2hpdGVzcGFjZSgpKSkgewogICAgICAgICBiZWdp bk1pblcgPSAwOwogICAgICAgICBlbmRNaW5XID0gMDsKQEAgLTQyNCw4ICs0MjgsNiBAQCB2b2lk IFJlbmRlclRleHQ6OnRyaW1tZWRQcmVmV2lkdGhzKGludCBsCiAKICAgICBtaW5XID0gbV9taW5X aWR0aDsKICAgICBtYXhXID0gbV9tYXhXaWR0aDsKLSAgICBiZWdpbldTID0gIXN0cmlwRnJvbnRT cGFjZXMgJiYgbV9oYXNCZWdpbldTOwotICAgIGVuZFdTID0gbV9oYXNFbmRXUzsKIAogICAgIGJl Z2luTWluVyA9IG1fYmVnaW5NaW5XaWR0aDsKICAgICBlbmRNaW5XID0gbV9lbmRNaW5XaWR0aDsK