138630 2014-11-11 14:27:53 -0800 build.webkit.org/dashboard shows obsolete results when builds are substantially out of order 2015-04-13 17:09:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue thorton oldest_to_newest 1047979 0 ap 2014-11-11 14:27:53 -0800 For this sequence of builds (newest at top), the dashboard decides that r175872 is the most recent revision, and r175866 is the last successful build. But it's actually r175886 that is the most recent. Nov 11 06:40 175858 success #158 Build successful Nov 11 05:48 175859 success #157 Build successful Nov 11 05:47 175860 success #156 Build successful Nov 11 05:17 175866 success #155 Build successful Nov 11 05:17 175865 success #154 Build successful Nov 11 05:14 175870 failure #153 Failed build archive Nov 11 04:51 175869 failure #152 Failed build archive Nov 11 04:44 175872 failure #151 Failed build archive Nov 11 03:57 175871 failure #150 Failed build archive Nov 11 03:54 175879 success #149 Build successful Nov 11 03:52 175878 success #148 Build successful Nov 11 03:52 175877 success #147 Build successful Nov 11 03:00 175886 success #146 Build successful Nov 11 02:36 175876 success #145 Build successful Nov 11 02:31 175875 success #144 Build successful Nov 11 02:28 175874 success #143 Build successful Nov 11 02:26 175873 failure #142 Failed build archive Nov 11 01:34 175881 success #141 Build successful Nov 11 01:16 175864 success #140 Build successful I am not sure if there is a way to fix this other than by fetching a lot more revisions upfront. 1084907 1 ap 2015-04-13 12:34:32 -0700 I don't think that the above example accurately represents what happens for out of order builds. We would not have something like this: > Nov 11 05:47 175860 success #156 Build successful > Nov 11 05:17 175866 success #155 Build successful > Nov 11 05:17 175865 success #154 Build successful How it works is that out of order builds appear to always happen in descending order. This gives us a way to identify out of order builds, and to ignore them when deciding whether we have the results for recent commits. 1084917 2 250667 ap 2015-04-13 12:46:59 -0700 Created attachment 250667 proposed fix 1084997 3 ap 2015-04-13 16:22:15 -0700 Of course, the dashboard would still be confused if there are many builds scheduled manually. 1085009 4 250667 commit-queue 2015-04-13 17:09:29 -0700 Comment on attachment 250667 proposed fix Clearing flags on attachment: 250667 Committed r182770: <http://trac.webkit.org/changeset/182770> 1085010 5 commit-queue 2015-04-13 17:09:32 -0700 All reviewed patches have been landed. Closing bug. 250667 2015-04-13 12:46:59 -0700 2015-04-13 17:09:29 -0700 proposed fix OutOfOrderBuilds.txt text/plain 5776 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4Mjc0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI1IEBACisyMDE1LTA0LTEzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkIHNob3dzIG9ic29sZXRlIHJl c3VsdHMgd2hlbiBidWlsZHMgYXJlIHN1YnN0YW50aWFsbHkgb3V0IG9mIG9yZGVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg2MzAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB3 ZSBhbHdheXMgbG9hZCBhdCBsZWFzdCBvbmUgaW4gb3JkZXIgcHJvZHVjdGl2ZSBpdGVyYXRpb24u CisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlLmpzOgorICAgICAgICAo QnVpbGRib3RRdWV1ZSk6IEFkZGVkIF9oYXNMb2FkZWRJdGVyYXRpb25Gb3JJbk9yZGVyUmVzdWx0 IHRvIHRyYWNrIHdoZXRoZXIgdGhlIHF1ZXVlCisgICAgICAgIGlzIGRvbmUgbG9hZGluZyBhdCBs ZWFzdCBvbmUgaXRlcmF0aW9uIHRoYXQgd2Fzbid0IGFuIG91dCBvZiBvcmRlciBidWlsZC4KKyAg ICAgICAgKEJ1aWxkYm90UXVldWUucHJvdG90eXBlLmxvYWRNb3JlSGlzdG9yaWNhbEl0ZXJhdGlv bnMpOiBMaXN0ZW4gZm9yIGl0ZXJhdGlvbiBsb2FkCisgICAgICAgIHdoZW4gdGhhdCdzIG5lZWRl ZCB0byBjaGVjayBmb3Igb3V0IG9mIG9yZGVyIGJ1aWxkcy4KKyAgICAgICAgKEJ1aWxkYm90UXVl dWUucHJvdG90eXBlLnVwZGF0ZSk6IERpdHRvLgorICAgICAgICAoQnVpbGRib3RRdWV1ZS5wcm90 b3R5cGUuX2NoZWNrRm9ySW5PcmRlclJlc3VsdCk6IENoZWNrIGlmIHRoZSBxdWV1ZSBoYXMgYW4g aW4gb3JkZXIKKyAgICAgICAgcmVzdWx0LCBhbmQgaWYgaXQgZG9lcyBub3QsIGxvYWQgbW9yZSBp dGVyYXRpb25zLgorICAgICAgICAoQnVpbGRib3RRdWV1ZS5wcm90b3R5cGUubG9hZEFsbCk6IFdl IGhhdmUgZXZlcnl0aGluZyBsb2FkZWQsIHNvIHdlIGNlcnRhaW5seSBoYXZlCisgICAgICAgIGFu IGluIG9yZGVyIGl0ZXJhdGlvbiBsb2FkZWQgdG9vLgorICAgICAgICAoQnVpbGRib3RRdWV1ZS5w cm90b3R5cGUuY29tcGFyZUl0ZXJhdGlvbnMpOiBFeHRyYWN0ZWQgZnJvbSBzb3J0SXRlcmF0aW9u cygpLCBhbmQKKyAgICAgICAgY29ycmVjdGVkIHRvIGFsd2F5cyBzb3J0IGxvYWRlZCBpdGVyYXRp b25zIGJlZm9yZSB1bmxvYWRlZCBvbmVzLgorCiAyMDE1LTA0LTEzICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJk OiBDcmFzaC1vbmx5IHF1ZXVlcyBzaG91bGQgc2hvdyBmYWlsdXJlIHdoZW4gdGVzdGluZyBmYWls cyB0byBzdGFydApJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RRdWV1ZS5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlLmpzCShyZXZp c2lvbiAxODI2MzApCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlLmpzCSh3 b3JraW5nIGNvcHkpCkBAIC00Nyw2ICs0NywxMSBAQCBCdWlsZGJvdFF1ZXVlID0gZnVuY3Rpb24o YnVpbGRib3QsIGlkLCBpCiAKICAgICB0aGlzLml0ZXJhdGlvbnMgPSBbXTsKICAgICB0aGlzLl9r bm93bkl0ZXJhdGlvbnMgPSB7fTsKKworICAgIC8vIFNvbWUgcXVldWVzIHByb2Nlc3MgY2hhbmdl cyBvdXQgb2Ygb3JkZXIsIGJ1dCB3ZSBuZWVkIHRvIGRpc3BsYXkgcmVzdWx0cyBmb3IgdGhlIGxh dGVzdCBjb21taXQsCisgICAgLy8gbm90IHRoZSBsYXRlc3QgYnVpbGQuIEJ1aWxkYm90UXVldWUg ZW5zdXJlcyB0aGF0IGF0IGxlYXN0IG9uZSBwcm9kdWN0aXZlIGl0ZXJhdGlvbgorICAgIC8vIHRo YXQgd2FzIHJ1biBpbiBvcmRlciBnZXRzIGxvYWRlZCAoaWYgdGhlIHF1ZXVlIGhhZCBhbnkgcHJv ZHVjdGl2ZSBpdGVyYXRpb25zLCBvZiBjb3Vyc2UpLgorICAgIHRoaXMuX2hhc0xvYWRlZEl0ZXJh dGlvbkZvckluT3JkZXJSZXN1bHQgPSBmYWxzZTsKIH07CiAKIEJhc2VPYmplY3QuYWRkQ29uc3Ry dWN0b3JGdW5jdGlvbnMoQnVpbGRib3RRdWV1ZSk7CkBAIC0xNzgsNiArMTgzLDggQEAgQnVpbGRi b3RRdWV1ZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBpZiAoIWl0ZXJhdGlvbi5sb2FkZWQp IHsKICAgICAgICAgICAgICAgICBpZiAoaW5kZXhPZkZpcnN0TmV3bHlMb2FkaW5nSXRlcmF0aW9u ID09PSB1bmRlZmluZWQpCiAgICAgICAgICAgICAgICAgICAgIGluZGV4T2ZGaXJzdE5ld2x5TG9h ZGluZ0l0ZXJhdGlvbiA9IGk7CisgICAgICAgICAgICAgICAgaWYgKCF0aGlzLl9oYXNMb2FkZWRJ dGVyYXRpb25Gb3JJbk9yZGVyUmVzdWx0KQorICAgICAgICAgICAgICAgICAgICBpdGVyYXRpb24u YWRkRXZlbnRMaXN0ZW5lcihCdWlsZGJvdEl0ZXJhdGlvbi5FdmVudC5VcGRhdGVkLCB0aGlzLl9j aGVja0ZvckluT3JkZXJSZXN1bHQuYmluZCh0aGlzKSk7CiAgICAgICAgICAgICAgICAgaXRlcmF0 aW9uLnVwZGF0ZSgpOwogICAgICAgICAgICAgfQogICAgICAgICB9CkBAIC0yMDYsOCArMjEzLDEx IEBAIEJ1aWxkYm90UXVldWUucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgICAgICB0aGlz Ll9rbm93bkl0ZXJhdGlvbnNbaXRlcmF0aW9uLmlkXSA9IGl0ZXJhdGlvbjsKICAgICAgICAgICAg ICAgICB9CiAKLSAgICAgICAgICAgICAgICBpZiAoaSA+PSBsb2FkaW5nU3RvcCAmJiAoIWl0ZXJh dGlvbi5maW5pc2hlZCB8fCAhaXRlcmF0aW9uLmxvYWRlZCkpCisgICAgICAgICAgICAgICAgaWYg KGkgPj0gbG9hZGluZ1N0b3AgJiYgKCFpdGVyYXRpb24uZmluaXNoZWQgfHwgIWl0ZXJhdGlvbi5s b2FkZWQpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmICghdGhpcy5faGFzTG9hZGVkSXRlcmF0 aW9uRm9ySW5PcmRlclJlc3VsdCkKKyAgICAgICAgICAgICAgICAgICAgICAgIGl0ZXJhdGlvbi5h ZGRFdmVudExpc3RlbmVyKEJ1aWxkYm90SXRlcmF0aW9uLkV2ZW50LlVwZGF0ZWQsIHRoaXMuX2No ZWNrRm9ySW5PcmRlclJlc3VsdC5iaW5kKHRoaXMpKTsKICAgICAgICAgICAgICAgICAgICAgaXRl cmF0aW9uLnVwZGF0ZSgpOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KIAogICAg ICAgICAgICAgaWYgKCFuZXdJdGVyYXRpb25zLmxlbmd0aCkKQEAgLTIxOSw2ICsyMjksMjIgQEAg QnVpbGRib3RRdWV1ZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0uYmluZCh0aGlzKSk7CiAgICAg fSwKIAorICAgIF9jaGVja0ZvckluT3JkZXJSZXN1bHQ6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsK KyAgICAgICAgaWYgKHRoaXMuX2hhc0xvYWRlZEl0ZXJhdGlvbkZvckluT3JkZXJSZXN1bHQpCisg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIHZhciBpdGVyYXRpb25zSW5PcmlnaW5hbE9yZGVy ID0gdGhpcy5pdGVyYXRpb25zLmNvbmNhdCgpLnNvcnQoZnVuY3Rpb24oYSwgYikgeyByZXR1cm4g Yi5pZCAtIGEuaWQ7IH0pOworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGl0ZXJhdGlvbnNJ bk9yaWdpbmFsT3JkZXIubGVuZ3RoIC0gMTsgKytpKSB7CisgICAgICAgICAgICB2YXIgaTEgPSBp dGVyYXRpb25zSW5PcmlnaW5hbE9yZGVyW2ldOworICAgICAgICAgICAgdmFyIGkyID0gaXRlcmF0 aW9uc0luT3JpZ2luYWxPcmRlcltpICsgMV07CisgICAgICAgICAgICBpZiAoaTEucHJvZHVjdGl2 ZSAmJiBpMi5sb2FkZWQgJiYgdGhpcy5jb21wYXJlSXRlcmF0aW9ucyhpMSwgaTIpIDwgMCkgewor ICAgICAgICAgICAgICAgIHRoaXMuX2hhc0xvYWRlZEl0ZXJhdGlvbkZvckluT3JkZXJSZXN1bHQg PSB0cnVlOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAgICAgICAg fQorICAgICAgICB0aGlzLmxvYWRNb3JlSGlzdG9yaWNhbEl0ZXJhdGlvbnMoKTsKKyAgICB9LAor CiAgICAgbG9hZEFsbDogZnVuY3Rpb24oY2FsbGJhY2spCiAgICAgewogICAgICAgICAvLyBGSVhN RTogRG9uJ3QgbG9hZCBldmVyeXRoaW5nIGF0IG9uY2UsIGRvIGl0IGluY3JlbWVudGFsbHkgYXMg cmVxdWVzdGVkLgpAQCAtMjMyLDI1ICsyNTgsMzIgQEAgQnVpbGRib3RRdWV1ZS5wcm90b3R5cGUg PSB7CiAKICAgICAgICAgICAgIHRoaXMuc29ydEl0ZXJhdGlvbnMoKTsKIAorICAgICAgICAgICAg dGhpcy5faGFzTG9hZGVkSXRlcmF0aW9uRm9ySW5PcmRlclJlc3VsdCA9IHRydWU7CisKICAgICAg ICAgICAgIGNhbGxiYWNrKHRoaXMpOwogICAgICAgICB9LmJpbmQodGhpcykpOwogICAgIH0sCiAK LSAgICBzb3J0SXRlcmF0aW9uczogZnVuY3Rpb24oKQorICAgIGNvbXBhcmVJdGVyYXRpb25zOiBm dW5jdGlvbihhLCBiKQogICAgIHsKLSAgICAgICAgZnVuY3Rpb24gY29tcGFyZUl0ZXJhdGlvbnMo YSwgYikKLSAgICAgICAgewotICAgICAgICAgICAgdmFyIHJlc3VsdCA9IGIub3BlblNvdXJjZVJl dmlzaW9uIC0gYS5vcGVuU291cmNlUmV2aXNpb247Ci0gICAgICAgICAgICBpZiAocmVzdWx0KQot ICAgICAgICAgICAgICAgIHJldHVybiByZXN1bHQ7Ci0KLSAgICAgICAgICAgIHJlc3VsdCA9IGIu aW50ZXJuYWxSZXZpc2lvbiAtIGEuaW50ZXJuYWxSZXZpc2lvbjsKLSAgICAgICAgICAgIGlmIChy ZXN1bHQpCi0gICAgICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsKKyAgICAgICAgdmFyIHJlc3Vs dCA9IGIub3BlblNvdXJjZVJldmlzaW9uIC0gYS5vcGVuU291cmNlUmV2aXNpb247CisgICAgICAg IGlmIChyZXN1bHQpCisgICAgICAgICAgICByZXR1cm4gcmVzdWx0OworCisgICAgICAgIHJlc3Vs dCA9IGIuaW50ZXJuYWxSZXZpc2lvbiAtIGEuaW50ZXJuYWxSZXZpc2lvbjsKKyAgICAgICAgaWYg KHJlc3VsdCkKKyAgICAgICAgICAgIHJldHVybiByZXN1bHQ7CisKKyAgICAgICAgLy8gQSBsb2Fk ZWQgaXRlcmF0aW9uIG1heSBub3QgaGF2ZSByZXZpc2lvbiBudW1iZXJzIGlmIGl0IGZhaWxlZCBl YXJseSwgYmVmb3JlIHN2biBzdGVwcyBmaW5pc2hlZC4KKyAgICAgICAgcmVzdWx0ID0gYi5sb2Fk ZWQgLSBhLmxvYWRlZDsKKyAgICAgICAgaWYgKHJlc3VsdCkKKyAgICAgICAgICAgIHJldHVybiBy ZXN1bHQ7CiAKLSAgICAgICAgICAgIHJldHVybiBiLmlkIC0gYS5pZDsKLSAgICAgICAgfQorICAg ICAgICByZXR1cm4gYi5pZCAtIGEuaWQ7CisgICAgfSwKIAotICAgICAgICB0aGlzLml0ZXJhdGlv bnMuc29ydChjb21wYXJlSXRlcmF0aW9ucyk7CisgICAgc29ydEl0ZXJhdGlvbnM6IGZ1bmN0aW9u KCkKKyAgICB7CisgICAgICAgIHRoaXMuaXRlcmF0aW9ucy5zb3J0KHRoaXMuY29tcGFyZUl0ZXJh dGlvbnMpOwogICAgIH0KIH07Cg==