138620 2014-11-11 12:13:14 -0800 Regression(r175947): Caused assertions in debug builds 2014-11-11 20:06:33 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 138556 1 cdumez cdumez benjamin commit-queue darin esprehn+autocc gyuyoung.kim rniwa thorton oldest_to_newest 1047925 0 cdumez 2014-11-11 12:13:14 -0800 ASSERTION FAILED: traversed == (current != end ? 1 : 0) /Volumes/Data/slave/mavericks-debug/build/Source/WebCore/dom/CollectionIndexCache.h(98) : unsigned int WebCore::CollectionIndexCache<WebCore::HTMLCollection, WebCore::Element *>::computeNodeCountUpdatingListCache(const Collection &) [Collection = WebCore::HTMLCollection, Iterator = WebCore::Element *] 1 0x105970330 WTFCrash 2 0x109c0ff45 WebCore::CollectionIndexCache<WebCore::HTMLCollection, WebCore::Element*>::computeNodeCountUpdatingListCache(WebCore::HTMLCollection const&) 3 0x109c0e400 WebCore::CollectionIndexCache<WebCore::HTMLCollection, WebCore::Element*>::nodeCount(WebCore::HTMLCollection const&) 4 0x109c0c639 WebCore::HTMLCollection::length() const 5 0x10a193155 WebCore::JSHTMLCollection::getOwnPropertySlotByIndex(JSC::JSObject*, JSC::ExecState*, unsigned int, JSC::PropertySlot&) 6 0x10505dfbb JSC::JSObject::getPropertySlot(JSC::ExecState*, unsigned int, JSC::PropertySlot&) 7 0x10535c543 JSC::JSValue::get(JSC::ExecState*, unsigned int, JSC::PropertySlot&) const 8 0x105337d08 JSC::JSValue::get(JSC::ExecState*, unsigned int) const 9 0x10574aea3 JSC::LLInt::getByVal(JSC::ExecState*, JSC::JSValue, JSC::JSValue) 10 0x1057442e3 llint_slow_path_get_by_val 11 0x105751d35 llint_entry 12 0x10574e3c9 vmEntryToJavaScript 13 0x1055ddb4a JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 14 0x1055c20d4 JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) 15 0x1051573f0 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 16 0x10a276125 WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 17 0x10abfda5d WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) 18 0x10abfdba4 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) 19 0x10ac0d127 WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) 20 0x10ac0c0f0 WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) 21 0x109ce30f9 WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition const&) 22 0x109ce2f09 WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition const&) 23 0x109c22eb1 WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() 24 0x109c22ff8 WebCore::HTMLDocumentParser::canTakeNextToken(WebCore::HTMLDocumentParser::SynchronousMode, WebCore::PumpSession&) 25 0x109c2219f WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) 26 0x109c21c29 WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) 27 0x109c23bc1 WebCore::HTMLDocumentParser::append(WTF::PassRefPtr<WTF::StringImpl>) 28 0x1096e251c WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter&, char const*, unsigned long) 29 0x109805fce WebCore::DocumentWriter::addData(char const*, unsigned long) 30 0x1097cd826 WebCore::DocumentLoader::commitData(char const*, unsigned long) 31 0x1103d538d -[WebFrame(WebInternal) _commitData:] 1047926 1 cdumez 2014-11-11 12:15:08 -0800 Patch is coming shortly, just need to validate locally first. 1047930 2 241367 cdumez 2014-11-11 12:21:56 -0800 Created attachment 241367 Patch Still waiting for my build to complete so I can test this locally. 1047937 3 241370 cdumez 2014-11-11 12:40:08 -0800 Created attachment 241370 Patch 1047938 4 241370 cdumez 2014-11-11 12:41:48 -0800 Comment on attachment 241370 Patch Clearing flags on attachment: 241370 Committed r175968: <http://trac.webkit.org/changeset/175968> 1047939 5 cdumez 2014-11-11 12:41:53 -0800 All reviewed patches have been landed. Closing bug. 1048085 6 darin 2014-11-11 20:06:33 -0800 Thanks for fixing this. Sorry! 241367 2014-11-11 12:21:56 -0800 2014-11-11 12:40:04 -0800 Patch 138620_assertions.patch text/plain 1544 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYzEzZGUzLi45OWY0MDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMTEtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAg ICBSZWdyZXNzaW9uKHIxNzU5NDcpOiBDYXVzZWQgYXNzZXJ0aW9ucyBpbiBkZWJ1ZyBidWlsZHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODYyMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEhUTUxD b2xsZWN0aW9uOjp0cmF2ZXJzZUZvcndhcmQoKSwgdHJhdmVyc2VkQ291bnQgd2FzIGluY3JlbWVu dGVkIDEKKyAgICAgICAgdGltZSB0b28gbWFueSB3aGVuIGhpdHRpbmcgdGhlIGVuZCBvZiB0aGUg Y29sbGVjdGlvbiAoaS5lLiBlbGVtZW50CisgICAgICAgIGJlY29tZXMgbnVsbCkuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5IGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAg ICAgICAgKiBodG1sL0hUTUxDb2xsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxD b2xsZWN0aW9uOjp0cmF2ZXJzZUZvcndhcmQpOgorCiAyMDE0LTExLTExICBEYW5pZWwgQmF0ZXMg IDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbRnJhbWUgRmxhdHRlbmluZ10gQVNTRVJU KHRyYW5zYWN0aW9uLT52aWV3ID09ICZ2aWV3KCkpIGZhaWxzIGluIFJlbmRlckJsb2NrOjpyZW1v dmVGcm9tVXBkYXRlU2Nyb2xsSW5mb0FmdGVyTGF5b3V0VHJhbnNhY3Rpb24oKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxDb2xsZWN0aW9uLmNwcAppbmRleCA4ZTk2NTZmLi4yOTJkMGFmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDb2xsZWN0aW9uLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxDb2xsZWN0aW9uLmNwcApAQCAtMzM4LDYgKzMzOCwxMCBAQCBpbmxp bmUgRWxlbWVudCogSFRNTENvbGxlY3Rpb246OnRyYXZlcnNlRm9yd2FyZChFbGVtZW50JiBjdXJy ZW50LCB1bnNpZ25lZCBjb3VudAogICAgICAgICBmb3IgKHRyYXZlcnNlZENvdW50ID0gMDsgZWxl bWVudCAmJiB0cmF2ZXJzZWRDb3VudCA8IGNvdW50OyArK3RyYXZlcnNlZENvdW50KQogICAgICAg ICAgICAgZWxlbWVudCA9IG5leHRNYXRjaGluZ0VsZW1lbnQoKnRoaXMsICplbGVtZW50LCByb290 KTsKICAgICB9CisgICAgaWYgKCFlbGVtZW50KSB7CisgICAgICAgIC8vIFdlIHJlYWNoZWQgdGhl IGVuZCBvZiB0aGUgY29sbGVjdGlvbiBhbmQgc2hvdWxkIHJlYWRqdXN0IHRyYXZlcnNlZENvdW50 LgorICAgICAgICAtLXRyYXZlcnNlZENvdW50OworICAgIH0KICAgICByZXR1cm4gZWxlbWVudDsK IH0KIAo= 241370 2014-11-11 12:40:08 -0800 2014-11-11 12:41:48 -0800 Patch bug-138620-20141111124011.patch text/plain 2477 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1OTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MxM2RlMzZlZWU0M2Nj MTgxNjg1NDg4YTA4NmI3MzAyN2IzODFiNC4uOWRiMmIxNWExOTFmZTAwM2UyZmVjYjc0ODdlNDgz M2YzZjgxOGNkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTExLTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMTc1OTQ3 KTogQ2F1c2VkIGFzc2VydGlvbnMgaW4gZGVidWcgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg2MjAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBIVE1MQ29sbGVjdGlvbjo6dHJhdmVyc2VG b3J3YXJkKCksIHRyYXZlcnNlZENvdW50IHdhcyBpbmNyZW1lbnRlZCAxCisgICAgICAgIHRpbWUg dG9vIG1hbnkgd2hlbiBoaXR0aW5nIHRoZSBlbmQgb2YgdGhlIGNvbGxlY3Rpb24gKGkuZS4gZWxl bWVudAorICAgICAgICBiZWNvbWVzIG51bGwpLiBEb2luZyBhIHBhcnRpYWwgcmV2ZXJ0LgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgor CisgICAgICAgICogaHRtbC9IVE1MQ29sbGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpI VE1MQ29sbGVjdGlvbjo6dHJhdmVyc2VGb3J3YXJkKToKKwogMjAxNC0xMS0xMSAgRGFuaWVsIEJh dGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0ZyYW1lIEZsYXR0ZW5pbmddIEFT U0VSVCh0cmFuc2FjdGlvbi0+dmlldyA9PSAmdmlldygpKSBmYWlscyBpbiBSZW5kZXJCbG9jazo6 cmVtb3ZlRnJvbVVwZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dFRyYW5zYWN0aW9uKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENvbGxlY3Rpb24uY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5jcHAKaW5kZXggOGU5NjU2ZjVjNWQwYjVkMWUxMWUz ZDcwNmViYjcwNzE2NDJmNzg5OS4uNDI3NzIyNWQ1YTNkZGI3YmUxYjhiMWRhNWJmODkxNjJmMzc1 NTA2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29sbGVjdGlvbi5jcHAKQEAgLTMyOSwxNCAr MzI5LDIzIEBAIGlubGluZSBFbGVtZW50KiBIVE1MQ29sbGVjdGlvbjo6dHJhdmVyc2VGb3J3YXJk KEVsZW1lbnQmIGN1cnJlbnQsIHVuc2lnbmVkIGNvdW50CiB7CiAgICAgRWxlbWVudCogZWxlbWVu dCA9ICZjdXJyZW50OwogICAgIGlmICh1c2VzQ3VzdG9tRm9yd2FyZE9ubHlUcmF2ZXJzYWwoKSkg ewotICAgICAgICBmb3IgKHRyYXZlcnNlZENvdW50ID0gMDsgZWxlbWVudCAmJiB0cmF2ZXJzZWRD b3VudCA8IGNvdW50OyArK3RyYXZlcnNlZENvdW50KQorICAgICAgICBmb3IgKHRyYXZlcnNlZENv dW50ID0gMDsgdHJhdmVyc2VkQ291bnQgPCBjb3VudDsgKyt0cmF2ZXJzZWRDb3VudCkgewogICAg ICAgICAgICAgZWxlbWVudCA9IGN1c3RvbUVsZW1lbnRBZnRlcihlbGVtZW50KTsKKyAgICAgICAg ICAgIGlmICghZWxlbWVudCkKKyAgICAgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICAg ICAgfQogICAgIH0gZWxzZSBpZiAobV9zaG91bGRPbmx5SW5jbHVkZURpcmVjdENoaWxkcmVuKSB7 Ci0gICAgICAgIGZvciAodHJhdmVyc2VkQ291bnQgPSAwOyBlbGVtZW50ICYmIHRyYXZlcnNlZENv dW50IDwgY291bnQ7ICsrdHJhdmVyc2VkQ291bnQpCisgICAgICAgIGZvciAodHJhdmVyc2VkQ291 bnQgPSAwOyB0cmF2ZXJzZWRDb3VudCA8IGNvdW50OyArK3RyYXZlcnNlZENvdW50KSB7CiAgICAg ICAgICAgICBlbGVtZW50ID0gbmV4dE1hdGNoaW5nU2libGluZ0VsZW1lbnQoKnRoaXMsICplbGVt ZW50KTsKKyAgICAgICAgICAgIGlmICghZWxlbWVudCkKKyAgICAgICAgICAgICAgICByZXR1cm4g bnVsbHB0cjsKKyAgICAgICAgfQogICAgIH0gZWxzZSB7Ci0gICAgICAgIGZvciAodHJhdmVyc2Vk Q291bnQgPSAwOyBlbGVtZW50ICYmIHRyYXZlcnNlZENvdW50IDwgY291bnQ7ICsrdHJhdmVyc2Vk Q291bnQpCisgICAgICAgIGZvciAodHJhdmVyc2VkQ291bnQgPSAwOyB0cmF2ZXJzZWRDb3VudCA8 IGNvdW50OyArK3RyYXZlcnNlZENvdW50KSB7CiAgICAgICAgICAgICBlbGVtZW50ID0gbmV4dE1h dGNoaW5nRWxlbWVudCgqdGhpcywgKmVsZW1lbnQsIHJvb3QpOworICAgICAgICAgICAgaWYgKCFl bGVtZW50KQorICAgICAgICAgICAgICAgIHJldHVybiBudWxscHRyOworICAgICAgICB9CiAgICAg fQogICAgIHJldHVybiBlbGVtZW50OwogfQo=