138604 2014-11-11 00:12:10 -0800 Occasional assertion failure under recommendedScrollbarStyleDidChange() 2014-11-11 13:52:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified VERIFIED FIXED P2 Normal --- 1 thorton thorton bdakin cdumez sam oldest_to_newest 1047786 0 thorton 2014-11-11 00:12:10 -0800 Occasional assertion failure under recommendedScrollbarStyleDidChange() 1047787 1 241340 thorton 2014-11-11 00:12:28 -0800 Created attachment 241340 Patch 1047788 2 thorton 2014-11-11 00:13:17 -0800 <rdar://problem/18855914> 1047834 3 241340 andersca 2014-11-11 06:10:17 -0800 Comment on attachment 241340 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241340&action=review > Source/WebKit2/UIProcess/API/mac/WKViewInternal.h:137 > +- (NSTrackingArea *)_primaryTrackingArea; > +- (void)_replacePrimaryTrackingArea:(NSTrackingArea *)trackingArea; Couldn't this just be expressed as a property? 1047896 4 thorton 2014-11-11 11:02:35 -0800 (In reply to comment #3) > Comment on attachment 241340 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241340&action=review > > > Source/WebKit2/UIProcess/API/mac/WKViewInternal.h:137 > > +- (NSTrackingArea *)_primaryTrackingArea; > > +- (void)_replacePrimaryTrackingArea:(NSTrackingArea *)trackingArea; > > Couldn't this just be expressed as a property? Sure! 1047965 5 thorton 2014-11-11 13:40:46 -0800 http://trac.webkit.org/changeset/175973 1047969 6 cdumez 2014-11-11 13:52:02 -0800 I confirm the crash is gone for me. 241340 2014-11-11 00:12:28 -0800 2014-11-11 12:44:12 -0800 Patch bug-138604-20141111001231.patch text/plain 6504 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1ODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWYyNzE2Y2E3OTYwYjNj ZjU4ZGJmOTE1OTdkZGY4MWFlZDFjYmIwNi4uNWE0MDY4MzliYjM1M2JkMmRiYWQyNGY4MDk4NWYw M2VjNTZlZTYwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE0LTExLTExICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIE9jY2FzaW9uYWwg YXNzZXJ0aW9uIGZhaWx1cmUgdW5kZXIgcmVjb21tZW5kZWRTY3JvbGxiYXJTdHlsZURpZENoYW5n ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg2 MDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4ODU1OTE0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlzIHBvc3NpYmxlIGZvciBBcHBLaXQg dG8gaW5zdGFsbCB0cmFja2luZyBhcmVhcyBpbnRvIG91ciB2aWV3CisgICAgICAgIGJlaGluZCBv dXIgYmFjaywgYnV0IHdlIGhhdmUgY29kZSB0aGF0IGRlcGVuZHMgb24ga25vd2luZyBleGFjdGx5 CisgICAgICAgIHRoZSBzZXQgb2YgdHJhY2tpbmcgYXJlYXMgaW5zdGFsbGVkIG9uIFdLVmlldy4K KworICAgICAgICBNYWtlIHRoaXMgbW9yZSByb2J1c3QgYnkga2VlcGluZyBhIHJlZmVyZW5jZSB0 byB0aGUgdHJhY2tpbmcgYXJlYSB3ZQorICAgICAgICB1c2UgZm9yIG1hbnkgdGhpbmdzIGFuZCBt YW5pcHVsYXRpbmcgdGhhdCBpbnN0ZWFkIG9mIG1ha2luZyBhc3N1bXB0aW9ucworICAgICAgICBh Ym91dCB0aGUgdG90YWwgc2V0IG9mIHRyYWNraW5nIGFyZWFzIG9uIFdLVmlldy4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IF9wcmlt YXJ5VHJhY2tpbmdBcmVhXSk6CisgICAgICAgICgtW1dLVmlldyBfcmVwbGFjZVByaW1hcnlUcmFj a2luZ0FyZWE6XSk6CisgICAgICAgIFByb3ZpZGUgYSAncHJpbWFyeScgdHJhY2tpbmcgYXJlYSBz ZXR0ZXIvZ2V0dGVyLgorCisgICAgICAgICgtW1dLVmlldyBpbml0V2l0aEZyYW1lOmNvbnRleHQ6 Y29uZmlndXJhdGlvbjp3ZWJWaWV3Ol0pOgorICAgICAgICBLZWVwIGEgcmVmZXJlbmNlIHRvIHRo ZSBvcmlnaW5hbCB0cmFja2luZyBhcmVhIGluc3RhbGxlZCBhdCBpbml0aWFsaXphdGlvbiB0aW1l LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3SW50ZXJuYWwuaDoKKyAgICAg ICAgKiBVSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1tOgorICAgICAgICAoV2ViS2l0OjpQ YWdlQ2xpZW50SW1wbDo6cmVjb21tZW5kZWRTY3JvbGxiYXJTdHlsZURpZENoYW5nZSk6CisgICAg ICAgIEluc3RlYWQgb2Ygd2Fsa2luZyB0aGUgc2V0IG9mIHRyYWNraW5nIGFyZWFzLCBtYWtlIHVz ZSBvZiB0aGUgZmFjdCB0aGF0CisgICAgICAgIHdlIGtub3cgZXhhY3RseSB3aGljaCB0cmFja2lu ZyBhcmVhIHdlIGluc3RhbGxlZCwgYW5kIHVuaW5zdGFsbCBqdXN0IHRoYXQKKyAgICAgICAgb25l LCBhbmQgcmVwbGFjZSBpdCB3aXRoIG91ciBuZXdseS1idWlsdCBvbmUuCisKIDIwMTQtMTEtMTAg IEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdoaXRlc3BhY2UgYWN0 aW9uIG1lbnVzIGFyZW4ndCB3b3JraW5nIHByb3Blcmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL21hYy9XS1ZpZXcubW0KaW5kZXggMmY3NDBmNzUyZTYzNDhiYjMzZjQ2MWJmNTM3OTY1 OGNlNGZlNWU3YS4uMDU3MjQ4ZjQ5YTk2ODY1MDZjMTE2NTBhMDc1MWUzOTk3NWM4MjdhYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQpAQCAtMTcwLDYgKzE3 MCw4IEBAIHN0cnVjdCBXS1ZpZXdJbnRlcnByZXRLZXlFdmVudHNQYXJhbWV0ZXJzIHsKICAgICBS ZXRhaW5QdHI8V0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyPiBfYnJvd3NpbmdDb250ZXh0Q29u dHJvbGxlcjsKICNlbmRpZgogCisgICAgUmV0YWluUHRyPE5TVHJhY2tpbmdBcmVhPiBfcHJpbWFy eVRyYWNraW5nQXJlYTsKKwogICAgIC8vIEZvciBUb29sVGlwcy4KICAgICBOU1Rvb2xUaXBUYWcg X2xhc3RUb29sVGlwVGFnOwogICAgIGlkIF90cmFja2luZ1JlY3RPd25lcjsKQEAgLTM0OTMsNiAr MzQ5NSwxOCBAQCBzdGF0aWMgTlNTdHJpbmcgKnBhdGhXaXRoVW5pcXVlRmlsZW5hbWVGb3JQYXRo KE5TU3RyaW5nICpwYXRoKQogICAgIHJldHVybiBfZGF0YS0+X3BhZ2UtPnN1cHByZXNzVmlzaWJp bGl0eVVwZGF0ZXMoKTsKIH0KIAorLSAoTlNUcmFja2luZ0FyZWEgKilfcHJpbWFyeVRyYWNraW5n QXJlYQoreworICAgIHJldHVybiBfZGF0YS0+X3ByaW1hcnlUcmFja2luZ0FyZWEuZ2V0KCk7Cit9 CisKKy0gKHZvaWQpX3JlcGxhY2VQcmltYXJ5VHJhY2tpbmdBcmVhOihOU1RyYWNraW5nQXJlYSAq KXRyYWNraW5nQXJlYQoreworICAgIFtzZWxmIHJlbW92ZVRyYWNraW5nQXJlYTpfZGF0YS0+X3By aW1hcnlUcmFja2luZ0FyZWEuZ2V0KCldOworICAgIF9kYXRhLT5fcHJpbWFyeVRyYWNraW5nQXJl YSA9IHRyYWNraW5nQXJlYTsKKyAgICBbc2VsZiBhZGRUcmFja2luZ0FyZWE6dHJhY2tpbmdBcmVh XTsKK30KKwogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoRnJhbWU6KE5TUmVjdClmcmFtZSBjb250 ZXh0OihXZWJDb250ZXh0Jiljb250ZXh0IGNvbmZpZ3VyYXRpb246KFdlYlBhZ2VDb25maWd1cmF0 aW9uKXdlYlBhZ2VDb25maWd1cmF0aW9uIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKIHsK ICAgICBzZWxmID0gW3N1cGVyIGluaXRXaXRoRnJhbWU6ZnJhbWVdOwpAQCAtMzUxMCwxNCArMzUy NCwxMCBAQCBzdGF0aWMgTlNTdHJpbmcgKnBhdGhXaXRoVW5pcXVlRmlsZW5hbWVGb3JQYXRoKE5T U3RyaW5nICpwYXRoKQogICAgIGVsc2UKICAgICAgICAgb3B0aW9ucyB8PSBOU1RyYWNraW5nQWN0 aXZlSW5LZXlXaW5kb3c7CiAKLSAgICBOU1RyYWNraW5nQXJlYSAqdHJhY2tpbmdBcmVhID0gW1tO U1RyYWNraW5nQXJlYSBhbGxvY10gaW5pdFdpdGhSZWN0OmZyYW1lCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3B0aW9uczpv cHRpb25zCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBvd25lcjpzZWxmCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1c2VySW5mbzpuaWxdOwotICAgIFtz ZWxmIGFkZFRyYWNraW5nQXJlYTp0cmFja2luZ0FyZWFdOwotICAgIFt0cmFja2luZ0FyZWEgcmVs ZWFzZV07Ci0KICAgICBfZGF0YSA9IFtbV0tWaWV3RGF0YSBhbGxvY10gaW5pdF07CisgICAgX2Rh dGEtPl9wcmltYXJ5VHJhY2tpbmdBcmVhID0gYWRvcHROUyhbW05TVHJhY2tpbmdBcmVhIGFsbG9j XSBpbml0V2l0aFJlY3Q6ZnJhbWUgb3B0aW9uczpvcHRpb25zIG93bmVyOnNlbGYgdXNlckluZm86 bmlsXSk7CisgICAgW3NlbGYgYWRkVHJhY2tpbmdBcmVhOl9kYXRhLT5fcHJpbWFyeVRyYWNraW5n QXJlYS5nZXQoKV07CisKICAgICBfZGF0YS0+X3BhZ2VDbGllbnQgPSBzdGQ6Om1ha2VfdW5pcXVl PFBhZ2VDbGllbnRJbXBsPihzZWxmLCB3ZWJWaWV3KTsKICAgICBfZGF0YS0+X3BhZ2UgPSBjb250 ZXh0LmNyZWF0ZVdlYlBhZ2UoKl9kYXRhLT5fcGFnZUNsaWVudCwgV1RGOjptb3ZlKHdlYlBhZ2VD b25maWd1cmF0aW9uKSk7CiAgICAgX2RhdGEtPl9wYWdlLT5zZXRBZGRzVmlzaXRlZExpbmtzKGNv bnRleHQuaGlzdG9yeUNsaWVudCgpLmFkZHNWaXNpdGVkTGlua3MoKSk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3SW50ZXJuYWwuaAppbmRleCA4ZTI2YjI4 MDg5YzA4MTU3YzQ3NjViNjVkYjU5MGQ5YjA3MjExMTk1Li5kY2Q1ODdjODBhZDZiZThmYTQ2YTMy MDU1Yzk3ODFlNjZhMjhlNzFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1dLVmlld0ludGVybmFsLmgKQEAgLTEzMyw0ICsxMzMsNyBAQCBzdHJ1Y3QgV2ViUGFn ZUNvbmZpZ3VyYXRpb247CiAKIC0gKHZvaWQpX2Rpc21pc3NBY3Rpb25NZW51UG9wb3ZlcnM7CiAK Ky0gKE5TVHJhY2tpbmdBcmVhICopX3ByaW1hcnlUcmFja2luZ0FyZWE7CistICh2b2lkKV9yZXBs YWNlUHJpbWFyeVRyYWNraW5nQXJlYTooTlNUcmFja2luZ0FyZWEgKil0cmFja2luZ0FyZWE7CisK IEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVu dEltcGwubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1t CmluZGV4IDAxYTc0NzllYjU1MDhiYWE0Y2U4MTg5YzhmNjVlNDE0YzhlMjBlNjkuLmYxY2UyNzAx MzE1YWY5YTdjMmJmNjE2NmRkODQ4YmYxYzM1ZmIwY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW0KKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1wbC5tbQpAQCAtNTg1LDEzICs1ODUsNiBAQCB2b2lk IFBhZ2VDbGllbnRJbXBsOjpyZWNvcmRBdXRvY29ycmVjdGlvblJlc3BvbnNlKEF1dG9jb3JyZWN0 aW9uUmVzcG9uc2VUeXBlIHJlcwogCiB2b2lkIFBhZ2VDbGllbnRJbXBsOjpyZWNvbW1lbmRlZFNj cm9sbGJhclN0eWxlRGlkQ2hhbmdlKGludDMyX3QgbmV3U3R5bGUpCiB7Ci0gICAgTlNBcnJheSAq dHJhY2tpbmdBcmVhcyA9IFttX3drVmlldyB0cmFja2luZ0FyZWFzXTsKLSAgICBOU1VJbnRlZ2Vy IGNvdW50ID0gW3RyYWNraW5nQXJlYXMgY291bnRdOwotICAgIEFTU0VSVChjb3VudCA9PSAxKTsK LSAgICAKLSAgICBmb3IgKE5TVUludGVnZXIgaSA9IDA7IGkgPCBjb3VudDsgKytpKQotICAgICAg ICBbbV93a1ZpZXcgcmVtb3ZlVHJhY2tpbmdBcmVhOlt0cmFja2luZ0FyZWFzIG9iamVjdEF0SW5k ZXg6aV1dOwotCiAgICAgLy8gTm93IHJlLWNyZWF0ZSBhIHRyYWNraW5nIGFyZWEgd2l0aCB0aGUg YXBwcm9wcmlhdGUgb3B0aW9ucyBnaXZlbiB0aGUgbmV3IHNjcm9sbGJhciBzdHlsZQogICAgIE5T VHJhY2tpbmdBcmVhT3B0aW9ucyBvcHRpb25zID0gTlNUcmFja2luZ01vdXNlTW92ZWQgfCBOU1Ry YWNraW5nTW91c2VFbnRlcmVkQW5kRXhpdGVkIHwgTlNUcmFja2luZ0luVmlzaWJsZVJlY3Q7CiAg ICAgaWYgKG5ld1N0eWxlID09IE5TU2Nyb2xsZXJTdHlsZUxlZ2FjeSkKQEAgLTU5OSwxMiArNTky LDggQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6cmVjb21tZW5kZWRTY3JvbGxiYXJTdHlsZURpZENo YW5nZShpbnQzMl90IG5ld1N0eWxlKQogICAgIGVsc2UKICAgICAgICAgb3B0aW9ucyB8PSBOU1Ry YWNraW5nQWN0aXZlSW5LZXlXaW5kb3c7CiAKLSAgICBOU1RyYWNraW5nQXJlYSAqdHJhY2tpbmdB cmVhID0gW1tOU1RyYWNraW5nQXJlYSBhbGxvY10gaW5pdFdpdGhSZWN0OlttX3drVmlldyBmcmFt ZV0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBvcHRpb25zOm9wdGlvbnMKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG93bmVyOm1fd2tWaWV3Ci0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB1c2VySW5mbzpuaWxdOwotICAgIFttX3drVmlldyBhZGRUcmFja2luZ0FyZWE6dHJhY2tpbmdB cmVhXTsKLSAgICBbdHJhY2tpbmdBcmVhIHJlbGVhc2VdOworICAgIFJldGFpblB0cjxOU1RyYWNr aW5nQXJlYT4gdHJhY2tpbmdBcmVhID0gYWRvcHROUyhbW05TVHJhY2tpbmdBcmVhIGFsbG9jXSBp bml0V2l0aFJlY3Q6W21fd2tWaWV3IGZyYW1lXSBvcHRpb25zOm9wdGlvbnMgb3duZXI6bV93a1Zp ZXcgdXNlckluZm86bmlsXSk7CisgICAgW21fd2tWaWV3IF9yZXBsYWNlUHJpbWFyeVRyYWNraW5n QXJlYTp0cmFja2luZ0FyZWEuZ2V0KCldOwogfQogCiB2b2lkIFBhZ2VDbGllbnRJbXBsOjppbnRy aW5zaWNDb250ZW50U2l6ZURpZENoYW5nZShjb25zdCBJbnRTaXplJiBpbnRyaW5zaWNDb250ZW50 U2l6ZSkK