138581 2014-11-10 14:54:15 -0800 Test that complex and fast text codepaths measure the same width 2014-11-10 17:37:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield buildbot commit-queue dino jonlee mitz rniwa simon.fraser thorton oldest_to_newest 1047646 0 mmaxfield 2014-11-10 14:54:15 -0800 Test that complext and fast text codepaths measure the same width 1047648 1 241310 mmaxfield 2014-11-10 14:55:01 -0800 Created attachment 241310 Patch 1047657 2 mitz 2014-11-10 15:12:59 -0800 I suspect that this test would have passed even with a change such as the one introduced by <http://trac.webkit.org/r175813>, because tests run in an environment where kerning and ligatures are disabled by default. Another good way to test that the two code paths agree is to use the --complex-text option of run-webkit-tests. 1047667 3 mmaxfield 2014-11-10 15:37:51 -0800 You're right; the test passes. This whole "not testing what we ship" thing is pretty terrible. 1047668 4 simon.fraser 2014-11-10 15:38:29 -0800 Should we add a way that a test can opt into the complex text path? 1047683 5 mmaxfield 2014-11-10 16:12:02 -0800 This isn't actually about the fast vs slow code paths, it's about how kerning and ligatures are turned off. Instead of opting in, I think it's time we enabled K&L for all tests by default. 1047693 6 mitz 2014-11-10 16:46:06 -0800 (In reply to comment #5) > This isn't actually about the fast vs slow code paths, it's about how > kerning and ligatures are turned off. Instead of opting in, I think it's > time we enabled K&L for all tests by default. I agree. (Note that we do have some tests that enable kerning and/or ligatures using the relevant CSS properties, and we even have some tests that force the complex code path to be taken). 1047714 7 241310 commit-queue 2014-11-10 17:37:20 -0800 Comment on attachment 241310 Patch Clearing flags on attachment: 241310 Committed r175843: <http://trac.webkit.org/changeset/175843> 1047715 8 commit-queue 2014-11-10 17:37:24 -0800 All reviewed patches have been landed. Closing bug. 241310 2014-11-10 14:55:01 -0800 2014-11-10 17:37:20 -0800 Patch bug-138581-20141110145503.patch text/plain 2264 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1ODI2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjEwNmZlOWM3NThlMWQ1ODZhMDFj ODRmMGJiM2IxYWM0YTEzNTc3Ny4uYjI3M2VlZDkxNjgxMDAwZmE4YTZmODJlM2FjNjE2MmQ4Yzhh NDcwMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTEwICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgVGVzdCB0aGF0IGNvbXBsZXh0IGFu ZCBmYXN0IHRleHQgY29kZXBhdGhzIG1lYXN1cmUgdGhlIHNhbWUgd2lkdGgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODU4MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC90ZXh0L3NwYWNlLXdp ZHRoLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9zcGFjZS13aWR0 aC5odG1sOiBBZGRlZC4KKwogMjAxNC0xMS0wNCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNzQ4MjMpOiBTZXZlcmFsIHRlc3RzIGZhaWwg ZHVlIHRvIGNhbnBsYXl0aHJvdWdoIGZpcmluZyBiZWZvcmUgdHJhY2tzIGFyZSBhdmFpbGFibGUK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9zcGFjZS13aWR0aC1leHBlY3RlZC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3NwYWNlLXdpZHRoLWV4cGVjdGVkLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNDNlYzY1NTUxNmVmMjZhOGEwZjcwNTVlYmE4NGYzYWM3YTRiOGNkZQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9zcGFjZS13aWR0aC1leHBlY3RlZC5o dG1sCkBAIC0wLDAgKzEsMjIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxz dHlsZT4KKyAgICAudyB7CisgICAgICAgIGZvbnQtc2l6ZTogMzZweDsKKyAgICAgICAgZm9udC1m YW1pbHk6IHRpbWVzOworICAgICAgICBib3JkZXItcmlnaHQ6IHNvbGlkIGJsYWNrOworICAgICAg ICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CisgICAgfSAgIAorPC9zdHlsZT4KKzwvaGVhZD4KKzxi b2R5PgorVGhpcyB0ZXN0IG1ha2VzIHN1cmUgdGhhdCBzcGFjZXMgZHJhd24gd2l0aCB0aGUgY29t cGxleCB0ZXh0IGNvZGVwYXRoCithbmQgdGhlIGZhc3QgdGV4dCBjb2RlcGF0aCBhcmUgdGhlIHNh bWUgd2lkdGguCis8ZGl2PgorICAgIDxkaXYgY2xhc3M9InciPgorICAgICAgICBXbyYjeGU4OyBX b2UgV29lIFdvZSBXb2UgV29lIFdvZSBXb2UgV29lIFdvZSBXb2UgV29lIFdvZSBXb2UKKyAgICA8 L2Rpdj4KKzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L3NwYWNlLXdpZHRoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvc3BhY2Ut d2lkdGguaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42YzI0ODMzNmZkODYxODFmN2NhMDMwZDJhZDg5NGIxNDE2 ZTk4ODQ5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3NwYWNlLXdp ZHRoLmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFk PgorPHN0eWxlPgorICAgIC53IHsKKyAgICAgICAgZm9udC1zaXplOiAzNnB4OworICAgICAgICBm b250LWZhbWlseTogdGltZXM7CisgICAgICAgIGJvcmRlci1yaWdodDogc29saWQgYmxhY2s7Cisg ICAgICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKKyAgICB9ICAgCis8L3N0eWxlPgorPC9oZWFk PgorPGJvZHk+CitUaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0IHNwYWNlcyBkcmF3biB3aXRoIHRo ZSBjb21wbGV4IHRleHQgY29kZXBhdGgKK2FuZCB0aGUgZmFzdCB0ZXh0IGNvZGVwYXRoIGFyZSB0 aGUgc2FtZSB3aWR0aC4KKzxkaXY+CisgICAgPGRpdiBjbGFzcz0idyI+CisgICAgICAgIFdvZSYj eDAzMDA7IFdvZSBXb2UgV29lIFdvZSBXb2UgV29lIFdvZSBXb2UgV29lIFdvZSBXb2UgV29lIFdv ZSAKKyAgICA8L2Rpdj4KKzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=