138580 2014-11-10 14:29:42 -0800 WK1: Support default actions for editable text 2014-11-10 14:36:46 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1047635 0 bdakin 2014-11-10 14:29:42 -0800 WK1: Support default actions for editable text rdar://problem/18877497 1047637 1 241307 bdakin 2014-11-10 14:31:46 -0800 Created attachment 241307 Patch 1047639 2 bdakin 2014-11-10 14:36:46 -0800 Thanks Tim! http://trac.webkit.org/changeset/175832 241307 2014-11-10 14:31:46 -0800 2014-11-10 14:32:57 -0800 Patch for-review.txt text/plain 4671 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTgzMSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTExLTEw ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBXSzE6IFN1cHBvcnQg ZGVmYXVsdCBhY3Rpb25zIGZvciBlZGl0YWJsZSB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg1ODAKKyAgICAgICAgLWFuZCBjb3JyZXNwb25k aW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xODg3NzQ5NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyBtZW51IHR5cGUsIGFuZCBuZXcgYWN0 aW9uIHR5cGUgZm9yIHBhc3RlLiAKKworICAgICAgICAqIFdlYlZpZXcvV2ViQWN0aW9uTWVudUNv bnRyb2xsZXIubW06CisgICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIGlzTWVudUZv clRleHRDb250ZW50XSk6CisgICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIHdpbGxP cGVuTWVudTp3aXRoRXZlbnQ6XSk6CisgICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVy IF9kZWZhdWx0TWVudUl0ZW1zRm9yRWRpdGFibGVUZXh0Ol0pOgorICAgICAgICAoLVtXZWJBY3Rp b25NZW51Q29udHJvbGxlciBfcGFzdGU6XSk6CisgICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250 cm9sbGVyIF9jcmVhdGVBY3Rpb25NZW51SXRlbUZvclRhZzp3aXRoSGl0VGVzdFJlc3VsdDpdKToK KyAgICAgICAgKC1bV2ViQWN0aW9uTWVudUNvbnRyb2xsZXIgX2RlZmF1bHRNZW51SXRlbXNGb3JI aXRUZXN0UmVzdWx0Ol0pOgorICAgICAgICAqIFdlYlZpZXcvV2ViVUlEZWxlZ2F0ZVByaXZhdGUu aDoKKwogMjAxNC0xMS0xMCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgV0sxOiBUZXh0IGlzIGdldHRpbmcgc2VsZWN0ZWQgZXZlbiB3aGVuIGFuIGFjdGlvbiBtZW51 IGZhaWxzIHRvIGludm9rZQpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJBY3Rp b25NZW51Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJW aWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLm1tCShyZXZpc2lvbiAxNzU4MzEpCisrKyBTb3Vy Y2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0xMjYsMTIgKzEyNiwxNyBAQCAtICh2b2lkKXByZXBhcmVGb3JNZW51OihOU01l bnUgKiltZW51IHdpCiAgICAgICAgIFthY3Rpb25NZW51IGFkZEl0ZW06aXRlbV07CiB9CiAKKy0g KEJPT0wpaXNNZW51Rm9yVGV4dENvbnRlbnQKK3sKKyAgICByZXR1cm4gX3R5cGUgPT0gV2ViQWN0 aW9uTWVudVJlYWRPbmx5VGV4dCB8fCBfdHlwZSA9PSBXZWJBY3Rpb25NZW51RWRpdGFibGVUZXh0 OworfQorCiAtICh2b2lkKXdpbGxPcGVuTWVudTooTlNNZW51ICopbWVudSB3aXRoRXZlbnQ6KE5T RXZlbnQgKilldmVudAogewogICAgIGlmIChtZW51ICE9IF93ZWJWaWV3LmFjdGlvbk1lbnUpCiAg ICAgICAgIHJldHVybjsKIAotICAgIGlmIChfdHlwZSAhPSBXZWJBY3Rpb25NZW51UmVhZE9ubHlU ZXh0KSB7CisgICAgaWYgKCFbc2VsZiBpc01lbnVGb3JUZXh0Q29udGVudF0pIHsKICAgICAgICAg W1tfd2ViVmlldyBfc2VsZWN0ZWRPck1haW5GcmFtZV0gX2NsZWFyU2VsZWN0aW9uXTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KQEAgLTI1OSw2ICsyNjQsMTUgQEAgLSAoTlNBcnJheSAqKV9kZWZh dWx0TWVudUl0ZW1zRm9yVGV4dDooVwogICAgIHJldHVybiBAWyBjb3B5VGV4dEl0ZW0uZ2V0KCks IGxvb2t1cFRleHRJdGVtLmdldCgpIF07CiB9CiAKKy0gKE5TQXJyYXkgKilfZGVmYXVsdE1lbnVJ dGVtc0ZvckVkaXRhYmxlVGV4dDooV2ViRWxlbWVudERpY3Rpb25hcnkgKiloaXRUZXN0UmVzdWx0 Cit7CisgICAgUmV0YWluUHRyPE5TTWVudUl0ZW0+IGNvcHlUZXh0SXRlbSA9IFtzZWxmIF9jcmVh dGVBY3Rpb25NZW51SXRlbUZvclRhZzpXZWJBY3Rpb25NZW51SXRlbVRhZ0NvcHlUZXh0IHdpdGhI aXRUZXN0UmVzdWx0OmhpdFRlc3RSZXN1bHRdOworICAgIFJldGFpblB0cjxOU01lbnVJdGVtPiBs b29rdXBUZXh0SXRlbSA9IFtzZWxmIF9jcmVhdGVBY3Rpb25NZW51SXRlbUZvclRhZzpXZWJBY3Rp b25NZW51SXRlbVRhZ0xvb2t1cFRleHQgd2l0aEhpdFRlc3RSZXN1bHQ6aGl0VGVzdFJlc3VsdF07 CisgICAgUmV0YWluUHRyPE5TTWVudUl0ZW0+IHBhc3RlSXRlbSA9IFtzZWxmIF9jcmVhdGVBY3Rp b25NZW51SXRlbUZvclRhZzpXZWJBY3Rpb25NZW51SXRlbVRhZ1Bhc3RlIHdpdGhIaXRUZXN0UmVz dWx0OmhpdFRlc3RSZXN1bHRdOworCisgICAgcmV0dXJuIEBbIGNvcHlUZXh0SXRlbS5nZXQoKSwg bG9va3VwVGV4dEl0ZW0uZ2V0KCksIHBhc3RlSXRlbS5nZXQoKSBdOworfQorCiAtICh2b2lkKV9j b3B5U2VsZWN0aW9uOihpZClzZW5kZXIKIHsKICAgICBbX3dlYlZpZXcgX2V4ZWN1dGVDb3JlQ29t bWFuZEJ5TmFtZTpAImNvcHkiIHZhbHVlOm5pbF07CkBAIC0yODMsNiArMjk3LDExIEBAIC0gKHZv aWQpX2xvb2t1cFRleHQ6KGlkKXNlbmRlcgogICAgIFdLU2hvd1dvcmREZWZpbml0aW9uV2luZG93 KHBvcHVwSW5mby5hdHRyaWJ1dGVkU3RyaW5nLmdldCgpLCB0ZXh0QmFzZWxpbmVPcmlnaW4sIHBv cHVwSW5mby5vcHRpb25zLmdldCgpKTsKIH0KIAorLSAodm9pZClfcGFzdGU6KGlkKXNlbmRlcgor eworICAgIFtfd2ViVmlldyBfZXhlY3V0ZUNvcmVDb21tYW5kQnlOYW1lOkAicGFzdGUiIHZhbHVl Om5pbF07Cit9CisKIC0gKHZvaWQpX3NlbGVjdExvb2t1cFRleHQKIHsKICAgICBOU0RpY3Rpb25h cnkgKm9wdGlvbnMgPSBuaWw7CkBAIC0zOTEsNiArNDEwLDEyIEBAIC0gKFJldGFpblB0cjxOU01l bnVJdGVtPilfY3JlYXRlQWN0aW9uTWUKICAgICAgICAgaW1hZ2UgPSBbTlNJbWFnZSBpbWFnZU5h bWVkOkAiTlNBY3Rpb25NZW51TG9va3VwIl07CiAgICAgICAgIGJyZWFrOwogCisgICAgY2FzZSBX ZWJBY3Rpb25NZW51SXRlbVRhZ1Bhc3RlOgorICAgICAgICBzZWxlY3RvciA9IEBzZWxlY3Rvcihf cGFzdGU6KTsKKyAgICAgICAgdGl0bGUgPSBAIlBhc3RlIjsKKyAgICAgICAgaW1hZ2UgPSBbTlNJ bWFnZSBpbWFnZU5hbWVkOkAiTlNBY3Rpb25NZW51UGFzdGUiXTsKKyAgICAgICAgYnJlYWs7CisK ICAgICBkZWZhdWx0OgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0 dXJuIG5pbDsKQEAgLTQxOSw2ICs0NDQsMTEgQEAgLSAoTlNBcnJheSAqKV9kZWZhdWx0TWVudUl0 ZW1zRm9ySGl0VGVzdAogCiAgICAgTm9kZSogbm9kZSA9IF9oaXRUZXN0UmVzdWx0LmlubmVyTm9k ZSgpOwogICAgIGlmIChub2RlICYmIG5vZGUtPmlzVGV4dE5vZGUoKSkgeworICAgICAgICBpZiAo X2hpdFRlc3RSZXN1bHQuaXNDb250ZW50RWRpdGFibGUoKSkgeworICAgICAgICAgICAgX3R5cGUg PSBXZWJBY3Rpb25NZW51RWRpdGFibGVUZXh0OworICAgICAgICAgICAgcmV0dXJuIFtzZWxmIF9k ZWZhdWx0TWVudUl0ZW1zRm9yRWRpdGFibGVUZXh0OmhpdFRlc3RSZXN1bHRdOworICAgICAgICB9 CisKICAgICAgICAgX3R5cGUgPSBXZWJBY3Rpb25NZW51UmVhZE9ubHlUZXh0OwogICAgICAgICBy ZXR1cm4gW3NlbGYgX2RlZmF1bHRNZW51SXRlbXNGb3JUZXh0OmhpdFRlc3RSZXN1bHRdOwogICAg IH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVUlEZWxlZ2F0ZVByaXZhdGUu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlVJRGVsZWdhdGVQ cml2YXRlLmgJKHJldmlzaW9uIDE3NTgyMSkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViVUlEZWxlZ2F0ZVByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTE4LDEzICsxMTgsMTUg QEAgZW51bSB7CiAgICAgV2ViQWN0aW9uTWVudUl0ZW1UYWdQcmV2aWV3TGluaywKICAgICBXZWJB Y3Rpb25NZW51SXRlbVRhZ0FkZExpbmtUb1NhZmFyaVJlYWRpbmdMaXN0LAogICAgIFdlYkFjdGlv bk1lbnVJdGVtVGFnQ29weVRleHQsCi0gICAgV2ViQWN0aW9uTWVudUl0ZW1UYWdMb29rdXBUZXh0 CisgICAgV2ViQWN0aW9uTWVudUl0ZW1UYWdMb29rdXBUZXh0LAorICAgIFdlYkFjdGlvbk1lbnVJ dGVtVGFnUGFzdGUKIH07CiAKIHR5cGVkZWYgZW51bSB7CiAgICAgV2ViQWN0aW9uTWVudU5vbmUg PSAwLAogICAgIFdlYkFjdGlvbk1lbnVMaW5rLAotICAgIFdlYkFjdGlvbk1lbnVSZWFkT25seVRl eHQKKyAgICBXZWJBY3Rpb25NZW51UmVhZE9ubHlUZXh0LAorICAgIFdlYkFjdGlvbk1lbnVFZGl0 YWJsZVRleHQKIH0gV2ViQWN0aW9uTWVudVR5cGU7CiAKIC8vIE1lc3NhZ2UgU291cmNlcy4K