138576 2014-11-10 13:40:27 -0800 WK1: Text is getting selected even when an action menu fails to invoke 2014-11-10 14:12:24 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1047614 0 bdakin 2014-11-10 13:40:27 -0800 WK1: Text is getting selected even when an action menu fails to invoke 1047621 1 241304 bdakin 2014-11-10 13:58:00 -0800 Created attachment 241304 Patch 1047632 2 bdakin 2014-11-10 14:12:24 -0800 Thanks Tim! http://trac.webkit.org/changeset/175831 241304 2014-11-10 13:58:00 -0800 2014-11-10 14:08:10 -0800 Patch for-review.txt text/plain 5480 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTgyOCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE0LTExLTEw ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBXSzE6IFRleHQgaXMg Z2V0dGluZyBzZWxlY3RlZCBldmVuIHdoZW4gYW4gYWN0aW9uIG1lbnUgZmFpbHMgdG8gaW52b2tl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg1NzYK KyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xODkz MTMzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNl bGVjdGlvbiBjaGFuZ2VzIHNob3VsZCBoYXBwZW4gaW4gd2lsbE9wZW5NZW51OiBpbnN0ZWFkIG9m IHByZXBhcmVGb3JNZW51OgorICAgICAgICAqIFdlYlZpZXcvV2ViQWN0aW9uTWVudUNvbnRyb2xs ZXIuaDoKKyAgICAgICAgKiBXZWJWaWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLm1tOgorICAg ICAgICAoLVtXZWJBY3Rpb25NZW51Q29udHJvbGxlciBwcmVwYXJlRm9yTWVudTp3aXRoRXZlbnQ6 XSk6CisgICAgICAgICgtW1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIHdpbGxPcGVuTWVudTp3aXRo RXZlbnQ6XSk6CisKKyAgICAgICAgX3NlbGVjdExvb2t1cFRleHQgbm8gbG9uZ2VyIG5lZWRzIHRv IHJldHVybiBhIEJPT0wgaW5kaWNhdGluZyBzdWNjZXNzIG9yIGZhaWx1cmUuCisgICAgICAgICgt W1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIF9zZWxlY3RMb29rdXBUZXh0XSk6CisgICAgICAgICgt W1dlYkFjdGlvbk1lbnVDb250cm9sbGVyIF9kZWZhdWx0TWVudUl0ZW1zRm9ySGl0VGVzdFJlc3Vs dDpdKToKKworICAgICAgICBQYXNzIHdpbGxPcGVuTWVudTogb24gdG8gdGhlIGNvbnRyb2xsZXIu CisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IHdpbGxP cGVuTWVudTp3aXRoRXZlbnQ6XSk6CisKIDIwMTQtMTEtMTAgIEJldGggRGFraW4gIDxiZGFraW5A YXBwbGUuY29tPgogCiAgICAgICAgIFNwZWN1bGF0aXZlIGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViQWN0aW9uTWVudUNvbnRyb2xsZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkFjdGlvbk1lbnVDb250cm9sbGVyLmgJ KHJldmlzaW9uIDE3NTgyMSkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViQWN0aW9u TWVudUNvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgsNyBAQCBAaW50ZXJm YWNlIFdlYkFjdGlvbk1lbnVDb250cm9sbGVyIDogTlNPCiAtIChpZClpbml0V2l0aFdlYlZpZXc6 KFdlYlZpZXcgKil3ZWJWaWV3OwogLSAodm9pZCl3ZWJWaWV3Q2xvc2VkOwogLSAodm9pZClwcmVw YXJlRm9yTWVudTooTlNNZW51ICopbWVudSB3aXRoRXZlbnQ6KE5TRXZlbnQgKilldmVudDsKKy0g KHZvaWQpd2lsbE9wZW5NZW51OihOU01lbnUgKiltZW51IHdpdGhFdmVudDooTlNFdmVudCAqKWV2 ZW50OwogLSAodm9pZClkaWRDbG9zZU1lbnU6KE5TTWVudSAqKW1lbnUgd2l0aEV2ZW50OihOU0V2 ZW50ICopZXZlbnQ7CiAKIEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2Vi QWN0aW9uTWVudUNvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMv V2ViVmlldy9XZWJBY3Rpb25NZW51Q29udHJvbGxlci5tbQkocmV2aXNpb24gMTc1ODI1KQorKysg U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJBY3Rpb25NZW51Q29udHJvbGxlci5tbQkod29y a2luZyBjb3B5KQpAQCAtMTE4LDkgKzExOCw2IEBAIC0gKHZvaWQpcHJlcGFyZUZvck1lbnU6KE5T TWVudSAqKW1lbnUgd2kKICAgICBXZWJFbGVtZW50RGljdGlvbmFyeSAqaGl0VGVzdFJlc3VsdCA9 IFtzZWxmIHBlcmZvcm1IaXRUZXN0QXRQb2ludDpbX3dlYlZpZXcgY29udmVydFBvaW50OmV2ZW50 LmxvY2F0aW9uSW5XaW5kb3cgZnJvbVZpZXc6bmlsXV07CiAgICAgTlNBcnJheSAqbWVudUl0ZW1z ID0gW3NlbGYgX2RlZmF1bHRNZW51SXRlbXNGb3JIaXRUZXN0UmVzdWx0OmhpdFRlc3RSZXN1bHRd OwogCi0gICAgaWYgKF90eXBlICE9IFdlYkFjdGlvbk1lbnVSZWFkT25seVRleHQpCi0gICAgICAg IFtbX3dlYlZpZXcgX3NlbGVjdGVkT3JNYWluRnJhbWVdIF9jbGVhclNlbGVjdGlvbl07Ci0KICAg ICAvLyBBbGxvdyBjbGllbnRzIHRvIGN1c3RvbWl6ZSB0aGUgbWVudSBpdGVtcy4KICAgICBpZiAo W1tfd2ViVmlldyBVSURlbGVnYXRlXSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJW aWV3OmFjdGlvbk1lbnVJdGVtc0ZvckhpdFRlc3RSZXN1bHQ6d2l0aFR5cGU6ZGVmYXVsdEFjdGlv bk1lbnVJdGVtczopXSkKICAgICAgICAgbWVudUl0ZW1zID0gW1tfd2ViVmlldyBVSURlbGVnYXRl XSBfd2ViVmlldzpfd2ViVmlldyBhY3Rpb25NZW51SXRlbXNGb3JIaXRUZXN0UmVzdWx0OmhpdFRl c3RSZXN1bHQgd2l0aFR5cGU6X3R5cGUgZGVmYXVsdEFjdGlvbk1lbnVJdGVtczptZW51SXRlbXNd OwpAQCAtMTI5LDYgKzEyNiwyMiBAQCAtICh2b2lkKXByZXBhcmVGb3JNZW51OihOU01lbnUgKilt ZW51IHdpCiAgICAgICAgIFthY3Rpb25NZW51IGFkZEl0ZW06aXRlbV07CiB9CiAKKy0gKHZvaWQp d2lsbE9wZW5NZW51OihOU01lbnUgKiltZW51IHdpdGhFdmVudDooTlNFdmVudCAqKWV2ZW50Cit7 CisgICAgaWYgKG1lbnUgIT0gX3dlYlZpZXcuYWN0aW9uTWVudSkKKyAgICAgICAgcmV0dXJuOwor CisgICAgaWYgKF90eXBlICE9IFdlYkFjdGlvbk1lbnVSZWFkT25seVRleHQpIHsKKyAgICAgICAg W1tfd2ViVmlldyBfc2VsZWN0ZWRPck1haW5GcmFtZV0gX2NsZWFyU2VsZWN0aW9uXTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KKworICAgIC8vIEFjdGlvbiBtZW51cyBmb3IgdGV4dCBzaG91bGQg aGlnaGxpZ2h0IHRoZSB0ZXh0IHNvIHRoYXQgaXQgaXMgY2xlYXIgd2hhdCB0aGUgYWN0aW9uIG1l bnUgYWN0aW9ucworICAgIC8vIHdpbGwgYXBwbHkgdG8uIElmIHRoZSB0ZXh0IGlzIGFscmVhZHkg c2VsZWN0ZWQsIHRoZSBtZW51IHdpbGwgdXNlIHRoZSBleGlzdGluZyBzZWxlY3Rpb24uCisgICAg aWYgKCFfaGl0VGVzdFJlc3VsdC5pc1NlbGVjdGVkKCkpCisgICAgICAgIFtzZWxmIF9zZWxlY3RM b29rdXBUZXh0XTsKK30KKwogLSAodm9pZClkaWRDbG9zZU1lbnU6KE5TTWVudSAqKW1lbnUgd2l0 aEV2ZW50OihOU0V2ZW50ICopZXZlbnQKIHsKICAgICBpZiAobWVudSAhPSBfd2ViVmlldy5hY3Rp b25NZW51KQpAQCAtMjcwLDE5ICsyODMsMTkgQEAgLSAodm9pZClfbG9va3VwVGV4dDooaWQpc2Vu ZGVyCiAgICAgV0tTaG93V29yZERlZmluaXRpb25XaW5kb3cocG9wdXBJbmZvLmF0dHJpYnV0ZWRT dHJpbmcuZ2V0KCksIHRleHRCYXNlbGluZU9yaWdpbiwgcG9wdXBJbmZvLm9wdGlvbnMuZ2V0KCkp OwogfQogCi0tIChCT09MKV9zZWxlY3RMb29rdXBUZXh0CistICh2b2lkKV9zZWxlY3RMb29rdXBU ZXh0CiB7CiAgICAgTlNEaWN0aW9uYXJ5ICpvcHRpb25zID0gbmlsOwogICAgIFJlZlB0cjxSYW5n ZT4gbG9va3VwUmFuZ2UgPSByYW5nZUZvckRpY3Rpb25hcnlMb29rdXBBdEhpdFRlc3RSZXN1bHQo X2hpdFRlc3RSZXN1bHQsICZvcHRpb25zKTsKICAgICBpZiAoIWxvb2t1cFJhbmdlKQotICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgICAgIHJldHVybjsKIAogICAgIEZyYW1lKiBmcmFtZSA9IF9o aXRUZXN0UmVzdWx0LmlubmVyTm9kZSgpLT5kb2N1bWVudCgpLmZyYW1lKCk7CiAgICAgaWYgKCFm cmFtZSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICByZXR1cm47CiAKICAgICBmcmFt ZS0+c2VsZWN0aW9uKCkuc2V0U2VsZWN0ZWRSYW5nZShsb29rdXBSYW5nZS5nZXQoKSwgRE9XTlNU UkVBTSwgdHJ1ZSk7Ci0gICAgcmV0dXJuIHRydWU7CisgICAgcmV0dXJuOwogfQogCiBzdGF0aWMg RGljdGlvbmFyeVBvcHVwSW5mbyBwZXJmb3JtRGljdGlvbmFyeUxvb2t1cEZvclNlbGVjdGlvbihG cmFtZSogZnJhbWUsIGNvbnN0IFZpc2libGVTZWxlY3Rpb24mIHNlbGVjdGlvbikKQEAgLTQwNiwx MCArNDE5LDYgQEAgLSAoTlNBcnJheSAqKV9kZWZhdWx0TWVudUl0ZW1zRm9ySGl0VGVzdAogCiAg ICAgTm9kZSogbm9kZSA9IF9oaXRUZXN0UmVzdWx0LmlubmVyTm9kZSgpOwogICAgIGlmIChub2Rl ICYmIG5vZGUtPmlzVGV4dE5vZGUoKSkgewotICAgICAgICBpZiAoIVtbaGl0VGVzdFJlc3VsdCBv YmplY3RGb3JLZXk6V2ViRWxlbWVudElzU2VsZWN0ZWRLZXldIGJvb2xWYWx1ZV0pIHsKLSAgICAg ICAgICAgIGlmICghW3NlbGYgX3NlbGVjdExvb2t1cFRleHRdKQotICAgICAgICAgICAgICAgIHJl dHVybiBAWyBdOwotICAgICAgICB9CiAgICAgICAgIF90eXBlID0gV2ViQWN0aW9uTWVudVJlYWRP bmx5VGV4dDsKICAgICAgICAgcmV0dXJuIFtzZWxmIF9kZWZhdWx0TWVudUl0ZW1zRm9yVGV4dDpo aXRUZXN0UmVzdWx0XTsKICAgICB9CkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dl YlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3 Lm1tCShyZXZpc2lvbiAxNzU4MjEpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZp ZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTg1NDQsNiArODU0NCwxNCBAQCAtICh2b2lkKXByZXBh cmVGb3JNZW51OihOU01lbnUgKiltZW51IHdpCiAgICAgW19wcml2YXRlLT5hY3Rpb25NZW51Q29u dHJvbGxlciBwcmVwYXJlRm9yTWVudTptZW51IHdpdGhFdmVudDpldmVudF07CiB9CiAKKy0gKHZv aWQpd2lsbE9wZW5NZW51OihOU01lbnUgKiltZW51IHdpdGhFdmVudDooTlNFdmVudCAqKWV2ZW50 Cit7CisgICAgaWYgKG1lbnUgIT0gc2VsZi5hY3Rpb25NZW51KQorICAgICAgICByZXR1cm47CisK KyAgICBbX3ByaXZhdGUtPmFjdGlvbk1lbnVDb250cm9sbGVyIHdpbGxPcGVuTWVudTptZW51IHdp dGhFdmVudDpldmVudF07Cit9CisKIC0gKHZvaWQpZGlkQ2xvc2VNZW51OihOU01lbnUgKiltZW51 IHdpdGhFdmVudDooTlNFdmVudCAqKWV2ZW50CiB7CiAgICAgaWYgKG1lbnUgIT0gc2VsZi5hY3Rp b25NZW51KQo=