138574 2014-11-10 12:50:26 -0800 [iOS WK2] Scroll deceleration rate is wrong 2014-11-10 13:39:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser benjamin buildbot commit-queue rniwa simon.fraser oldest_to_newest 1047601 0 simon.fraser 2014-11-10 12:50:26 -0800 [iOS WK2] Scroll deceleration rate is wrong 1047603 1 simon.fraser 2014-11-10 12:53:02 -0800 rdar://problem/18715303 1047604 2 241300 simon.fraser 2014-11-10 12:53:35 -0800 Created attachment 241300 Patch 1047605 3 commit-queue 2014-11-10 12:55:56 -0800 Attachment 241300 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1316: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1047607 4 241300 benjamin 2014-11-10 12:58:55 -0800 Comment on attachment 241300 Patch Can you add a FIXME explaining how to clean this code? We should really fix UIWebPreferredScrollDecelerationFactor() long term, this looks ridiculous. 1047613 5 simon.fraser 2014-11-10 13:39:37 -0800 https://trac.webkit.org/r175827 241300 2014-11-10 12:53:35 -0800 2014-11-10 12:58:55 -0800 Patch bug-138574-20141110125337.patch text/plain 3920 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1ODIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjcyZDI1MWZhZDJkOWQ2 ZmI1YWYwYzJmNjhiMWZiZGNiOWJmMmE1Yi4uOWQ0ZjgwZjIzOTliZDlhMGE1ZmU5NGI5NDlhZTQ2 ZTNkYTM4Y2FjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTExLTEwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBT Y3JvbGwgZGVjZWxlcmF0aW9uIHJhdGUgaXMgd3JvbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODU3NAorICAgICAgICByZGFyOi8vcHJvYmxlbS8x ODcxNTMwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAK KyAgICAgICAgVGhlIENTUyBTbmFwIFBvaW50cyBjb2RlIGluY29ycmVjdGx5IHNldCB0aGUgV0tT Y3JvbGxWaWV3J3MgZGVjZWxlcmF0aW9uIHJhdGUsCisgICAgICAgIG92ZXJyaWRpbmcgdGhlIGN1 c3RvbSB2YWx1ZSB0aGF0IFVJV2ViU2Nyb2xsVmlldyBzZXRzLgorICAgICAgICAKKyAgICAgICAg Rml4IGJ5IGhhdmluZyBXS1Njcm9sbFZpZXcgc3RvcmUgdGhlIGN1c3RvbSByYXRlIGF0IGluaXQg dGltZSwgYW5kCisgICAgICAgIHVzaW5nIHRoYXQgdmFsdWUgaW4gLXNjcm9sbFZpZXdXaWxsQmVn aW5EcmFnZ2luZzouCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t bToKKyAgICAgICAgKC1bV0tXZWJWaWV3IHNjcm9sbFZpZXdXaWxsQmVnaW5EcmFnZ2luZzpdKToK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLU2Nyb2xsVmlldy5oOgorICAgICAgICAqIFVJUHJv Y2Vzcy9pb3MvV0tTY3JvbGxWaWV3Lm1tOgorICAgICAgICAoLVtXS1Njcm9sbFZpZXcgaW5pdFdp dGhGcmFtZTpdKToKKwogMjAxNC0xMS0xMCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgV0sxOiBTdXBwb3J0IGRlZmF1bHQgYWN0aW9ucyBmb3IgcmVhZC1vbmx5IHRl eHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0K aW5kZXggNDc1ZWFhMjFiYTkzMmQzN2IxNTI4ZTVhMGM5ODU4MDQ2OWFlZGJkMy4uOGJmOTk4MDE3 NWQ1MjBmODQ1YTgyZmQ3MDc5OTIxNzVlNzIxNjVjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTEzMDcsMTEgKzEzMDcsMTMgQEAg LSAodm9pZClzY3JvbGxWaWV3V2lsbEJlZ2luRHJhZ2dpbmc6KFVJU2Nyb2xsVmlldyAqKXNjcm9s bFZpZXcKIAogICAgIGlmIChzY3JvbGxWaWV3LnBhbkdlc3R1cmVSZWNvZ25pemVyLnN0YXRlID09 IFVJR2VzdHVyZVJlY29nbml6ZXJTdGF0ZUJlZ2FuKQogICAgICAgICBbX2NvbnRlbnRWaWV3IHNj cm9sbFZpZXdXaWxsU3RhcnRQYW5PclBpbmNoR2VzdHVyZV07CisKICAgICBbX2NvbnRlbnRWaWV3 IHdpbGxTdGFydFpvb21PclNjcm9sbF07CiAjaWYgRU5BQkxFKENTU19TQ1JPTExfU05BUCkgJiYg RU5BQkxFKEFTWU5DX1NDUk9MTElORykKICAgICAvLyBGSVhNRTogV2Ugd2lsbCB3YW50IHRvIGRl dGVjdCB3aGV0aGVyIHNuYXBwaW5nIHdpbGwgb2NjdXIgYmVmb3JlIGJlZ2lubmluZyB0byBkcmFn LiBTZWUgV2ViUGFnZVByb3h5OjpkaWRDb21taXRMYXllclRyZWUuCiAgICAgV2ViS2l0OjpSZW1v dGVTY3JvbGxpbmdDb29yZGluYXRvclByb3h5KiBjb29yZGluYXRvciA9IF9wYWdlLT5zY3JvbGxp bmdDb29yZGluYXRvclByb3h5KCk7Ci0gICAgc2Nyb2xsVmlldy5kZWNlbGVyYXRpb25SYXRlID0g KGNvb3JkaW5hdG9yICYmIGNvb3JkaW5hdG9yLT5zaG91bGRTZXRTY3JvbGxWaWV3RGVjZWxlcmF0 aW9uUmF0ZUZhc3QoKSkgPyBVSVNjcm9sbFZpZXdEZWNlbGVyYXRpb25SYXRlRmFzdCA6IFVJU2Ny b2xsVmlld0RlY2VsZXJhdGlvblJhdGVOb3JtYWw7CisgICAgQVNTRVJUKHNjcm9sbFZpZXcgPT0g X3Njcm9sbFZpZXcuZ2V0KCkpOworICAgIHNjcm9sbFZpZXcuZGVjZWxlcmF0aW9uUmF0ZSA9IChj b29yZGluYXRvciAmJiBjb29yZGluYXRvci0+c2hvdWxkU2V0U2Nyb2xsVmlld0RlY2VsZXJhdGlv blJhdGVGYXN0KCkpID8gVUlTY3JvbGxWaWV3RGVjZWxlcmF0aW9uUmF0ZUZhc3QgOiBbX3Njcm9s bFZpZXcgcHJlZmVycmVkU2Nyb2xsRGVjZWxlcmF0aW9uRmFjdG9yXTs7CiAjZW5kaWYKIH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1Njcm9sbFZpZXcuaCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3LmgKaW5kZXggY2I0MGJk OGZmNWRiNzhmOTIxN2U5YTY0N2RiZDk5ZDNmMDc2OGFjYy4uZTM5NzEyNTU1N2ZjMWUxNmUxZWJm ODdmZmJlYjZmNTlmODMxZTdjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS1Njcm9sbFZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL U2Nyb2xsVmlldy5oCkBAIC0zMiw2ICszMiw3IEBACiBAaW50ZXJmYWNlIFdLU2Nyb2xsVmlldyA6 IFVJV2ViU2Nyb2xsVmlldwogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgYXNzaWduKSBXS1dlYlZp ZXcgPFVJU2Nyb2xsVmlld0RlbGVnYXRlPiAqaW50ZXJuYWxEZWxlZ2F0ZTsKK0Bwcm9wZXJ0eSAo bm9uYXRvbWljLCByZWFkb25seSkgQ0dGbG9hdCBwcmVmZXJyZWRTY3JvbGxEZWNlbGVyYXRpb25G YWN0b3I7CiAKIC0gKHZvaWQpX3NldENvbnRlbnRTaXplUHJlc2VydmluZ0NvbnRlbnRPZmZzZXRE dXJpbmdSdWJiZXJiYW5kOihDR1NpemUpY29udGVudFNpemU7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS1Njcm9sbFZpZXcubW0KaW5kZXggN2Q1YTJmMjVlNmNjMGQ0YmIyNzZm Njg2MzEzYzcwOGY3YjE0N2UxMC4uOWI5NmQ2ODAyMGM2ZTA1NGU4ZTY2NTAwNTQyNTRjZmFlYTUz NjQ3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1Njcm9sbFZp ZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1Njcm9sbFZpZXcubW0K QEAgLTExMSw2ICsxMTEsMTYgQEAgQGltcGxlbWVudGF0aW9uIFdLU2Nyb2xsVmlldyB7CiAgICAg V0tTY3JvbGxWaWV3RGVsZWdhdGVGb3J3YXJkZXIgKl9kZWxlZ2F0ZUZvcndhcmRlcjsKIH0KIAor LSAoaWQpaW5pdFdpdGhGcmFtZTooQ0dSZWN0KWZyYW1lCit7CisgICAgaWYgKHNlbGYgPSBbc3Vw ZXIgaW5pdFdpdGhGcmFtZTpmcmFtZV0pIHsKKyAgICAgICAgQVNTRVJUKFtzZWxmIHZlcnRpY2Fs U2Nyb2xsRGVjZWxlcmF0aW9uRmFjdG9yXSA9PSBbc2VsZiBob3Jpem9udGFsU2Nyb2xsRGVjZWxl cmF0aW9uRmFjdG9yXSk7CisgICAgICAgIF9wcmVmZXJyZWRTY3JvbGxEZWNlbGVyYXRpb25GYWN0 b3IgPSBbc2VsZiB2ZXJ0aWNhbFNjcm9sbERlY2VsZXJhdGlvbkZhY3Rvcl07CisgICAgfQorICAg IAorICAgIHJldHVybiBzZWxmOworfQorCiAtICh2b2lkKXNldEludGVybmFsRGVsZWdhdGU6KFdL V2ViVmlldyA8VUlTY3JvbGxWaWV3RGVsZWdhdGU+ICopaW50ZXJuYWxEZWxlZ2F0ZQogewogICAg IGlmIChpbnRlcm5hbERlbGVnYXRlID09IF9pbnRlcm5hbERlbGVnYXRlKQo=