138570 2014-11-10 11:47:26 -0800 Object.hasOwnProperty should be more efficient when the property name is not an AtomicString. 2014-11-10 12:27:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 kling kling oldest_to_newest 1047577 0 kling 2014-11-10 11:47:26 -0800 Use JSString::toExistingAtomicString() to avoid churning the AtomicString table in case the property name being looked up isn't already present. Add an early return in case it's not an existing AtomicString, since that also guarantees the string is not an existing own property name. 1047579 1 241294 kling 2014-11-10 11:48:10 -0800 Created attachment 241294 Patch 241294 2014-11-10 11:48:10 -0800 2014-11-10 12:27:48 -0800 Patch bug-138570.diff text/plain 2197 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGEwZWJiOTkuLmVhZmRkMzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTExLTEwICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBPYmplY3QuaGFzT3duUHJvcGVydHkgc2hv dWxkIGJlIG1vcmUgZWZmaWNpZW50IHdoZW4gdGhlIHByb3BlcnR5IG5hbWUgaXMgbm90IGFuIEF0 b21pY1N0cmluZy4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzODU3MD4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgSlNTdHJpbmc6 OnRvRXhpc3RpbmdBdG9taWNTdHJpbmcoKSB0byBhdm9pZCBjaHVybmluZyB0aGUgQXRvbWljU3Ry aW5nIHRhYmxlCisgICAgICAgIGluIGNhc2UgdGhlIHByb3BlcnR5IG5hbWUgYmVpbmcgbG9va2Vk IHVwIGlzbid0IGFscmVhZHkgcHJlc2VudC4KKworICAgICAgICBBZGQgYW4gZWFybHkgcmV0dXJu IGluIGNhc2UgaXQncyBub3QgYW4gZXhpc3RpbmcgQXRvbWljU3RyaW5nLCBzaW5jZSB0aGF0IGFs c28KKyAgICAgICAgZ3VhcmFudGVlcyB0aGUgc3RyaW5nIGlzIG5vdCBhbiBleGlzdGluZyBvd24g cHJvcGVydHkgbmFtZS4KKworICAgICAgICAqIHJ1bnRpbWUvT2JqZWN0UHJvdG90eXBlLmNwcDoK KyAgICAgICAgKEpTQzo6b2JqZWN0UHJvdG9GdW5jSGFzT3duUHJvcGVydHkpOgorCiAyMDE0LTEx LTA5ICBBa29zIEtpc3MgIDxha2lzc0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgRml4ICdu b3JldHVybicgZnVuY3Rpb24gZG9lcyByZXR1cm4gd2FybmluZyBpbiBMTFZNT3ZlcnJpZGVzLmNw cApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0UHJvdG90 eXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdFByb3RvdHlwZS5j cHAKaW5kZXggMGIwN2NjNi4uZDIyNGY3NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvT2JqZWN0UHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9PYmplY3RQcm90b3R5cGUuY3BwCkBAIC04NCw4ICs4NCwxNCBAQCBFbmNvZGVk SlNWYWx1ZSBKU0NfSE9TVF9DQUxMIG9iamVjdFByb3RvRnVuY1ZhbHVlT2YoRXhlY1N0YXRlKiBl eGVjKQogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIG9iamVjdFByb3RvRnVuY0hhc093 blByb3BlcnR5KEV4ZWNTdGF0ZSogZXhlYykKIHsKKyAgICBBdG9taWNTdHJpbmdJbXBsKiBleGlz dGluZ0F0b21pY1N0cmluZyA9IGV4ZWMtPmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMpLT50b0V4 aXN0aW5nQXRvbWljU3RyaW5nKGV4ZWMpOworICAgIGlmICghZXhpc3RpbmdBdG9taWNTdHJpbmcp IHsKKyAgICAgICAgLy8gSWYgdGhlIGFyZ3VtZW50IGRvZXNuJ3QgcmVzb2x2ZSB0byBhbiBleGlz dGluZyBBdG9taWNTdHJpbmcsIHdlIGNhbiBiZSBzdXJlCisgICAgICAgIC8vIHRoZXJlJ3Mgbm8g cHJvcGVydHkgb2YgdGhhdCBuYW1lIHNpbmNlIGFsbCBwcm9wZXJ0eSBuYW1lcyBhcmUgQXRvbWlj U3RyaW5ncy4KKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc0Jvb2xlYW4oZmFsc2Up KTsKKyAgICB9CiAgICAgSlNWYWx1ZSB0aGlzVmFsdWUgPSBleGVjLT50aGlzVmFsdWUoKS50b1Ro aXMoZXhlYywgU3RyaWN0TW9kZSk7Ci0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc0Jvb2xl YW4odGhpc1ZhbHVlLnRvT2JqZWN0KGV4ZWMpLT5oYXNPd25Qcm9wZXJ0eShleGVjLCBleGVjLT5h cmd1bWVudCgwKS50b1N0cmluZyhleGVjKS0+dG9JZGVudGlmaWVyKGV4ZWMpKSkpOworICAgIHJl dHVybiBKU1ZhbHVlOjplbmNvZGUoanNCb29sZWFuKHRoaXNWYWx1ZS50b09iamVjdChleGVjKS0+ aGFzT3duUHJvcGVydHkoZXhlYywgSWRlbnRpZmllcihleGVjLCBleGlzdGluZ0F0b21pY1N0cmlu ZykpKSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgb2JqZWN0UHJvdG9GdW5j SXNQcm90b3R5cGVPZihFeGVjU3RhdGUqIGV4ZWMpCg==