13857 2007-05-24 08:29:36 -0700 REGRESSION: onChange function applied to select element executes twice when focus is set 2007-05-24 21:46:45 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED HasReduction, Regression P1 Major --- 1 sam webkit-unassigned mitz oldest_to_newest 9227 0 sam 2007-05-24 08:29:36 -0700 When a javascript function is called via an onchange event on a select form element, if the function attempts to set the focus to any other DOM element then the function is run again. This is best explained in practice by the reduction that follows. This has been occurring only in the most recent nightly builds (currently running revision 21682) 9228 1 14705 sam 2007-05-24 08:31:07 -0700 Created attachment 14705 Reduced testcase for this bug Test case contains basic instructions for reproducing bug 9203 2 14706 mitz 2007-05-24 13:38:13 -0700 Created attachment 14706 Updated m_lastOnChangeIndex before dispatching the change event to avoid reentrancy 9199 3 sam 2007-05-24 16:30:10 -0700 Landed in r21734. 9176 4 sam 2007-05-24 21:46:45 -0700 Fixed in ten hours!?!?! Are you guys trying to break some kind of speed record? 14705 2007-05-24 08:31:07 -0700 2007-05-24 08:31:07 -0700 Reduced testcase for this bug selectOnChangeReduction.html text/html 843 sam PGh0bWw+Cgk8aGVhZD4KCQk8dGl0bGU+U2VsZWN0IE9uQ2hhbmdlIFJlZHVjdGlvbjwvdGl0bGU+ CgkJPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgoJCQlmdW5jdGlvbiByZWR1Y3Rpb24o KQoJCQl7CgkJCQlhbGVydCgnSSBzaG91bGQgb25seSBhcHBlYXIgb25jZSEnKTsKCQkJCQoJCQkJ ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2ZvY3VzcmVjaXBpZW50JykuZm9jdXMoKTsKCQkJfQoJ CTwvc2NyaXB0PgoJPC9oZWFkPgoJPGJvZHk+CgkJQ2hhbmdlIHRoZSB2YWx1ZSBvZiAiU3dpdGNo ZXIiLiBBbiBhbGVydCBhcHBlYXJzIHR3aWNlLCB0aGF0IHNob3VsZCBvbmx5IGFwcGVhciBvbmNl Ljxici8+CgkJPGJyIC8+CgkJVGhpcyBlcnJvciBvY2N1cnMgb25seSB3aGVuIHRoZSBmb2N1cyBp cyBzZXQgdG8gYW5vdGhlciBpdGVtIG9uIHRoZSBwYWdlIGFzIHBhcnQgb2YgdGhlIG9uQ2hhbmdl IGZ1bmN0aW9uLjxiciAvPgoJCTxiciAvPgoJCTxmb3JtPgoJCQk8ZmllbGRzZXQ+CgkJCQlTd2l0 Y2hlcjogPHNlbGVjdCBuYW1lPSJzd2l0Y2hlciIgaWQ9InN3aXRjaGVyIiBvbmNoYW5nZT0icmVk dWN0aW9uKCk7Ij4KCQkJCQk8b3B0aW9uIHZhbHVlPSJvbmUiPk9uZTwvb3B0aW9uPgoJCQkJCTxv cHRpb24gdmFsdWU9InR3byI+VHdvPC9vcHRpb24+CgkJCQkJPG9wdGlvbiB2YWx1ZT0idGhyZWUi PlRocmVlPC9vcHRpb24+CgkJCQk8L3NlbGVjdD48YnIgLz4KCQkJCUZvY3VzIHJlY2lwaWVudDog PGlucHV0IG5hbWU9ImZvY3VzcmVjaXBpZW50IiBpZD0iZm9jdXNyZWNpcGllbnQiIHZhbHVlPSIi IC8+CgkJCTwvZmllbGRzZXQ+CgkJPC9mb3JtPgoJPC9ib2R5Pgo8L2h0bWw+ 14706 2007-05-24 13:38:13 -0700 2007-05-24 13:43:01 -0700 Updated m_lastOnChangeIndex before dispatching the change event to avoid reentrancy 13857_r1.patch text/plain 4160 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTcyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMDUtMjQgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODU3CisgICAgICAgICAg UkVHUkVTU0lPTjogb25DaGFuZ2UgZnVuY3Rpb24gYXBwbGllZCB0byBzZWxlY3QgZWxlbWVudCBl eGVjdXRlcyB0d2ljZSB3aGVuIGZvY3VzIGlzIHNldAorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9y bXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxTZWxl Y3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxlY3RFbGVtZW50OjptZW51 TGlzdE9uQ2hhbmdlKTogQ2hhbmdlZCB0byB1cGRhdGUgbV9sYXN0T25DaGFuZ2VJbmRleAorICAg ICAgICBiZWZvcmUgZGlzcGF0Y2hpbmcgdGhlIGNoYW5nZSBldmVudCB0byBhdm9pZCByZWVudHJh bmN5LgorCiAyMDA3LTA1LTI0ICBLZXZpbiBNY0N1bGxvdWdoICA8a21jY3VsbG91Z2hAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5LgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxTZWxl Y3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1l bnQuY3BwCShyZXZpc2lvbiAyMTcyMSkKKysrIFdlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg1Myw4ICs4NTMsOCBAQCB2b2lkIEhUTUxTZWxlY3RF bGVtZW50OjptZW51TGlzdE9uQ2hhbmdlCiAgICAgQVNTRVJUKHVzZXNNZW51TGlzdCgpKTsKICAg ICBpbnQgc2VsZWN0ZWQgPSBzZWxlY3RlZEluZGV4KCk7CiAgICAgaWYgKG1fbGFzdE9uQ2hhbmdl SW5kZXggIT0gc2VsZWN0ZWQpIHsKLSAgICAgICAgb25DaGFuZ2UoKTsKICAgICAgICAgbV9sYXN0 T25DaGFuZ2VJbmRleCA9IHNlbGVjdGVkOworICAgICAgICBvbkNoYW5nZSgpOwogICAgIH0KIH0K IApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gMjE3MjQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwNy0wNS0yNCAgTWl0eiBQZXR0ZWwgIDxt aXR6QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSB0ZXN0IGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzg1NworICAgICAgICAgIFJFR1JFU1NJT046IG9uQ2hhbmdlIGZ1bmN0aW9uIGFwcGxpZWQg dG8gc2VsZWN0IGVsZW1lbnQgZXhlY3V0ZXMgdHdpY2Ugd2hlbiBmb2N1cyBpcyBzZXQKKworICAg ICAgICAqIGZhc3QvZm9ybXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS5odG1sOiBB ZGRlZC4KKwogMjAwNy0wNS0yNCAgS2V2aW4gTWNDdWxsb3VnaCAgPGttY2N1bGxvdWdoQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9y bXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxlY3QtZG91YmxlLW9uY2hhbmdlLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VsZWN0LWRvdWJsZS1vbmNo YW5nZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNSBAQAorVGVzdCBmb3Ig aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NTcgUkVHUkVTU0lPTjog b25DaGFuZ2UgZnVuY3Rpb24gYXBwbGllZCB0byBzZWxlY3QgZWxlbWVudCBleGVjdXRlcyB0d2lj ZSB3aGVuIGZvY3VzIGlzIHNldC4KKworU1VDQ0VTUworCisKSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZm9ybXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZm9ybXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxlY3QtZG91YmxlLW9uY2hhbmdlLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDQgQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAg ICA8dGl0bGU+PC90aXRsZT4KKyAgICAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQi PgorICAgICAgICAgICAgdmFyIG9uY2hhbmdlQ291bnQgPSAwOworCisgICAgICAgICAgICBmdW5j dGlvbiB0ZXN0KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBpZiAoIXdpbmRvdy5l dmVudFNlbmRlcikKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAgICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgICAgICAgICAg dmFyIHBvcHVwID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInN3aXRjaGVyIik7CisgICAgICAg ICAgICAgICAgcG9wdXAuZm9jdXMoKTsKKworICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtl eURvd24oInQiLCBudWxsKTsKKyAgICAgICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCJc biIsIG51bGwpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBjaGFuZ2Vk KHNlbGVjdCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBzZWxlY3QuYmx1cigpOwor ICAgICAgICAgICAgICAgIG9uY2hhbmdlQ291bnQrKzsKKworICAgICAgICAgICAgICAgIHZhciBy ZXN1bHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0Iik7CisgICAgICAgICAgICAg ICAgcmVzdWx0LmlubmVyVGV4dCA9IG9uY2hhbmdlQ291bnQgPT0gMSA/ICJTVUNDRVNTIiA6ICJG QUlMVVJFOiBvbmNoYW5nZSBjb3VudCB3YXMgIiArIG9uY2hhbmdlQ291bnQ7CisgICAgICAgICAg ICB9CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keSBvbmxvYWQ9InRl c3QoKSI+CisgICAgICAgIDxwPgorICAgICAgICAgICAgVGVzdCBmb3IgPGk+PGEgaHJlZj0iaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NTciPmh0dHA6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODU3PC9hPgorICAgICAgICAgICAgUkVHUkVTU0lP Tjogb25DaGFuZ2UgZnVuY3Rpb24gYXBwbGllZCB0byBzZWxlY3QgZWxlbWVudCBleGVjdXRlcyB0 d2ljZSB3aGVuIGZvY3VzIGlzIHNldDwvaT4uCisgICAgICAgIDwvcD4KKyAgICAgICAgPHAgaWQ9 InJlc3VsdCI+CisgICAgICAgICAgICBUbyB0ZXN0IGludGVyYWN0aXZlbHksIHNlbGVjdCB0aGUg b3RoZXIgb3B0aW9uIGluIHRoZSBwb3AgdXAuIFRoaXMgdGV4dCBzaG91bGQgY2hhbmdlIHRvIFNV Q0NFU1MuCisgICAgICAgIDwvcD4KKyAgICAgICAgPHNlbGVjdCBuYW1lPSJzd2l0Y2hlciIgaWQ9 InN3aXRjaGVyIiBvbmNoYW5nZT0iY2hhbmdlZCh0aGlzKSI+CisgICAgICAgICAgICA8b3B0aW9u IHZhbHVlPSJvbmUiPk9uZTwvb3B0aW9uPgorICAgICAgICAgICAgPG9wdGlvbiB2YWx1ZT0idHdv Ij5Ud288L29wdGlvbj4KKyAgICAgICAgPC9zZWxlY3Q+CisgICAgPC9ib2R5PgorPC9odG1sPgo=