138564 2014-11-10 05:12:57 -0800 [GTK] fix up the GDB backtrace report tool 2014-11-11 01:05:58 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand buildbot cgarcia clopez commit-queue glenn rniwa oldest_to_newest 1047521 0 pnormand 2014-11-10 05:12:57 -0800 See also Bug 128928 but for now I'll only restore the basic functionality without making too many changes. 1047523 1 241286 pnormand 2014-11-10 05:22:41 -0800 Created attachment 241286 Patch 1047796 2 241286 cgarcia 2014-11-11 00:53:21 -0800 Comment on attachment 241286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241286&action=review LGTM > Tools/Scripts/webkitpy/port/linux_get_crash_log.py:44 > - cmd = ['gdb', '-ex', 'thread apply all bt 1024', '--batch', str(self._path_to_driver()), coredump_path] > + process_name = os.path.join(os.path.dirname(str(self._path_to_driver())), self.name) > + cmd = ['gdb', '-ex', 'thread apply all bt 1024', '--batch', process_name, coredump_path] why do you need str()? the path to driver should be a str already, otherwise it would be None, but in that case gdb will fail anyway. Wouldn't it be easier to pass bin_dir directly to GDBCrashLogGenerator instead of passing the driver only path to get its dirname? 1047797 3 pnormand 2014-11-11 01:02:44 -0800 Committed r175867: <http://trac.webkit.org/changeset/175867> 1047801 4 pnormand 2014-11-11 01:05:58 -0800 (In reply to comment #2) > Comment on attachment 241286 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241286&action=review > > LGTM > > > Tools/Scripts/webkitpy/port/linux_get_crash_log.py:44 > > - cmd = ['gdb', '-ex', 'thread apply all bt 1024', '--batch', str(self._path_to_driver()), coredump_path] > > + process_name = os.path.join(os.path.dirname(str(self._path_to_driver())), self.name) > > + cmd = ['gdb', '-ex', 'thread apply all bt 1024', '--batch', process_name, coredump_path] > > why do you need str()? the path to driver should be a str already, otherwise > it would be None, but in that case gdb will fail anyway. Wouldn't it be > easier to pass bin_dir directly to GDBCrashLogGenerator instead of passing > the driver only path to get its dirname? Might be for unit-tests purposes. Anyway I didn't want to make too many changes in this patch, perhaps this could be fixed along in bug 128928. 241286 2014-11-10 05:22:41 -0800 2014-11-11 00:53:21 -0800 Patch bug-138564-20141110142243.patch text/plain 3251 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1ODA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTIyMTAyN2YxZWY2ZWMxM2E1YWE5OTQ3NjA3MDlmZjEw ZDhiNDI2Zi4uMmM4ODhlZDAzMDFkNzc3ZDA3ZGI3MmVhYjczY2VkZjU1YzNiZWYwMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE0LTExLTEwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBmaXggdXAgdGhlIEdEQiBiYWNrdHJhY2UgcmVwb3J0IHRvb2wKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODU2NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9wb3J0L2d0ay5weToKKyAgICAgICAgKEd0a1BvcnQuX2dldF9jcmFzaF9sb2cpOiBN YXRjaCB0aGUgcHJvY2VzcyBuYW1lIHJlcG9ydGVkIGJ5IHRoZQorICAgICAgICBkcml2ZXIgd2l0 aCB0aGUgR1RLIHBvcnQgV2ViUHJvY2VzcyBleGVjdXRhYmxlIGZpbGVuYW1lLgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvcG9ydC9saW51eF9nZXRfY3Jhc2hfbG9nLnB5OgorICAgICAgICAo R0RCQ3Jhc2hMb2dHZW5lcmF0b3IuX2dldF9nZGJfb3V0cHV0KTogSW52b2tlIGdkYiBmb3IgdGhl IGNyYXNoZWQKKyAgICAgICAgcHJvZ3JhbS4KKyAgICAgICAgKEdEQkNyYXNoTG9nR2VuZXJhdG9y LmdlbmVyYXRlX2NyYXNoX2xvZyk6IFVzZSAlRSBpbiB0aGUgY29yZQorICAgICAgICBwYXR0ZXJu IHRvIHdvcmthcm91bmQgdGhlIDE2IGNoYXJhY3RlcnMgc2l6ZSBsaW1pdCBvZiAlZS4KKwogMjAx NC0xMS0xMCAgQWtvcyBLaXNzICA8YWtpc3NAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIEZp eCB0aGUgZXhjZXB0aW9uIGZ1enogaGVscGVyIHRvIGdlbmVyYXRlIHRhcmdldHMgaW4gdGhlIGNv cnJlY3QgcmFuZ2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CmluZGV4IDhlMTY5M2FlZGNj YTY3MmE1MmE2OWQ3NjM5YzcyODFjNDY5M2RmZWUuLjMzOGUyZDEzNWU2NzEyNzI0YTQ3MGQxNzgw MDk4NDlkMGYzMGFmODYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9n dGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weQpAQCAtMjA3LDYg KzIwNyw3IEBAIGNsYXNzIEd0a1BvcnQoUG9ydCk6CiAgICAgICAgIHJldHVybiBzdXBlcihHdGtQ b3J0LCBzZWxmKS5jaGVja19zeXNfZGVwcyhuZWVkc19odHRwKSBhbmQgc2VsZi5fZHJpdmVyX2Ns YXNzKCkuY2hlY2tfZHJpdmVyKHNlbGYpCiAKICAgICBkZWYgX2dldF9jcmFzaF9sb2coc2VsZiwg bmFtZSwgcGlkLCBzdGRvdXQsIHN0ZGVyciwgbmV3ZXJfdGhhbik6CisgICAgICAgIG5hbWUgPSAi V2ViS2l0V2ViUHJvY2VzcyIgaWYgbmFtZSA9PSAiV2ViUHJvY2VzcyIgZWxzZSBuYW1lCiAgICAg ICAgIHJldHVybiBHREJDcmFzaExvZ0dlbmVyYXRvcihuYW1lLCBwaWQsIG5ld2VyX3RoYW4sIHNl bGYuX2ZpbGVzeXN0ZW0sIHNlbGYuX3BhdGhfdG9fZHJpdmVyKS5nZW5lcmF0ZV9jcmFzaF9sb2co c3Rkb3V0LCBzdGRlcnIpCiAKICAgICBkZWYgdGVzdF9leHBlY3RhdGlvbnNfZmlsZV9wb3NpdGlv bihzZWxmKToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9saW51eF9n ZXRfY3Jhc2hfbG9nLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4X2dldF9j cmFzaF9sb2cucHkKaW5kZXggMzVkMzVkZTlkOWYxODQ4OGYzNjI4NjJkZTA1MjQxYmY4Y2RlMzU3 NC4uNWRiYTAwMmViNzJkYjc5MzdjM2RkMmEyNGJkOWRhYmQ5YjdiODVkMSAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4X2dldF9jcmFzaF9sb2cucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4X2dldF9jcmFzaF9sb2cucHkKQEAgLTQw LDcgKzQwLDggQEAgY2xhc3MgR0RCQ3Jhc2hMb2dHZW5lcmF0b3Iob2JqZWN0KToKICAgICAgICAg c2VsZi5fcGF0aF90b19kcml2ZXIgPSBwYXRoX3RvX2RyaXZlcgogCiAgICAgZGVmIF9nZXRfZ2Ri X291dHB1dChzZWxmLCBjb3JlZHVtcF9wYXRoKToKLSAgICAgICAgY21kID0gWydnZGInLCAnLWV4 JywgJ3RocmVhZCBhcHBseSBhbGwgYnQgMTAyNCcsICctLWJhdGNoJywgc3RyKHNlbGYuX3BhdGhf dG9fZHJpdmVyKCkpLCBjb3JlZHVtcF9wYXRoXQorICAgICAgICBwcm9jZXNzX25hbWUgPSBvcy5w YXRoLmpvaW4ob3MucGF0aC5kaXJuYW1lKHN0cihzZWxmLl9wYXRoX3RvX2RyaXZlcigpKSksIHNl bGYubmFtZSkKKyAgICAgICAgY21kID0gWydnZGInLCAnLWV4JywgJ3RocmVhZCBhcHBseSBhbGwg YnQgMTAyNCcsICctLWJhdGNoJywgcHJvY2Vzc19uYW1lLCBjb3JlZHVtcF9wYXRoXQogICAgICAg ICBwcm9jID0gc3VicHJvY2Vzcy5Qb3BlbihjbWQsIHN0ZGluPU5vbmUsIHN0ZG91dD1zdWJwcm9j ZXNzLlBJUEUsIHN0ZGVycj1zdWJwcm9jZXNzLlBJUEUpCiAgICAgICAgIHN0ZG91dCwgc3RkZXJy ID0gcHJvYy5jb21tdW5pY2F0ZSgpCiAgICAgICAgIGVycm9ycyA9IFtzdGRlcnJfbGluZS5zdHJp cCgpLmRlY29kZSgndXRmOCcsICdpZ25vcmUnKSBmb3Igc3RkZXJyX2xpbmUgaW4gc3RkZXJyLnNw bGl0bGluZXMoKV0KQEAgLTcyLDcgKzczLDcgQEAgY2xhc3MgR0RCQ3Jhc2hMb2dHZW5lcmF0b3Io b2JqZWN0KToKICAgICAgICAgaWYgbm90IGNyYXNoX2xvZzoKICAgICAgICAgICAgIGlmIG5vdCBs b2dfZGlyZWN0b3J5OgogICAgICAgICAgICAgICAgIGxvZ19kaXJlY3RvcnkgPSAiL3BhdGgvdG8v Y29yZWR1bXBzIgotICAgICAgICAgICAgY29yZV9wYXR0ZXJuID0gb3MucGF0aC5qb2luKGxvZ19k aXJlY3RvcnksICJjb3JlLXBpZF8lcC1fLXByb2Nlc3NfJWUiKQorICAgICAgICAgICAgY29yZV9w YXR0ZXJuID0gb3MucGF0aC5qb2luKGxvZ19kaXJlY3RvcnksICJjb3JlLXBpZF8lcC1fLXByb2Nl c3NfJUUiKQogICAgICAgICAgICAgY3Jhc2hfbG9nID0gIiIiXAogQ29yZWR1bXAgJShleHBlY3Rl ZF9jcmFzaF9kdW1wX2ZpbGVuYW1lKXMgbm90IGZvdW5kLiBUbyBlbmFibGUgY3Jhc2ggbG9nczoK IAo=