138563 2014-11-10 05:09:12 -0800 The third parameter of a Map.prototype.forEach callback function is undefined 2015-06-09 13:31:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 southsystems mmirman dpino ggaren mmirman webkit-bug-importer oldest_to_newest 1047520 0 southsystems 2014-11-10 05:09:12 -0800 Codepen here: http://codepen.io/stevesouth/pen/NPKzYz/ According to MDN the callback function of a Map.forEach should get called with three arguments callback is invoked with three arguments: the element value the element key the Map object being traversed https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/forEach However in Webkit the third parameter is undefined. 1047915 1 webkit-bug-importer 2014-11-11 11:52:34 -0800 <rdar://problem/18943661> 1053132 2 242741 dpino 2014-12-07 07:23:15 -0800 Created attachment 242741 Patch 1053133 3 dpino 2014-12-07 07:26:01 -0800 The same change is necessary for Set. According to the ES6 spec [1]: "callbackfn is called with three arguments: the first two arguments are a value contained in the Set. The same value of passed for both arguments. The Set object being traversed is passed as the third argument." [1] http://people.mozilla.org/~jorendorff/es6-draft.html#sec-set.prototype.foreach 1100760 4 242741 mmirman 2015-06-09 12:56:08 -0700 Comment on attachment 242741 Patch The map part was updated in http://trac.webkit.org/changeset/183374 1100763 5 mmirman 2015-06-09 12:57:49 -0700 And the set part in https://bugs.webkit.org/show_bug.cgi?id=144188 1100766 6 242741 ggaren 2015-06-09 13:05:31 -0700 Comment on attachment 242741 Patch r=me 242741 2014-12-07 07:23:15 -0800 2015-06-09 13:31:58 -0700 Patch bug-138563-20141207162352.patch text/plain 6710 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj N2ZiYzA1YWUwYjc1NGZkYjQ2NzcyM2VkM2FmZTM4OTdlM2NlOTUxLi4zMTc4ZjU1YzFmNzhlMTll ODNiYTgzNmEyNTcwNWZhOGJmMjViYzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0xMi0wNyAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFRoZSB0aGlyZCBwYXJhbWV0ZXIgb2YgYSBNYXAucHJvdG90eXBlLmZv ckVhY2ggY2FsbGJhY2sgZnVuY3Rpb24gaXMgdW5kZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg1NjMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvTWFwUHJvdG90eXBlLmNwcDoK KyAgICAgICAgKEpTQzo6bWFwUHJvdG9GdW5jRm9yRWFjaCk6CisgICAgICAgICogcnVudGltZS9T ZXRQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjpzZXRQcm90b0Z1bmNGb3JFYWNoKToKKwog MjAxNC0xMi0wNSAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAg IFtXaW5dIHByb2ogZmlsZXMgY29weWluZyBvdmVyIHRvbyBtYW55IHJlc291cmNlcy4uCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXBQcm90b3R5cGUuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFwUHJvdG90eXBlLmNwcAppbmRleCBkMjIx M2Y0ODRmMzIzNTAwMzQ5ZmY5MzdmMDcxMjE3NmJmMTU4ZDJjLi5lNGE2YTE4MDNlMTBiZjA3YjZh NzU2ZjI5ZTUzODdjZGM4ZjE4YzNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9NYXBQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL01hcFByb3RvdHlwZS5jcHAKQEAgLTEyMSwxMSArMTIxLDEyIEBAIEVuY29kZWRKU1ZhbHVl IEpTQ19IT1NUX0NBTEwgbWFwUHJvdG9GdW5jRm9yRWFjaChDYWxsRnJhbWUqIGNhbGxGcmFtZSkK ICAgICBWTSogdm0gPSAmY2FsbEZyYW1lLT52bSgpOwogICAgIGlmIChjYWxsVHlwZSA9PSBDYWxs VHlwZUpTKSB7CiAgICAgICAgIEpTRnVuY3Rpb24qIGZ1bmN0aW9uID0ganNDYXN0PEpTRnVuY3Rp b24qPihjYWxsQmFjayk7Ci0gICAgICAgIENhY2hlZENhbGwgY2FjaGVkQ2FsbChjYWxsRnJhbWUs IGZ1bmN0aW9uLCAyKTsKKyAgICAgICAgQ2FjaGVkQ2FsbCBjYWNoZWRDYWxsKGNhbGxGcmFtZSwg ZnVuY3Rpb24sIDMpOwogICAgICAgICBmb3IgKGF1dG8gcHRyID0gZGF0YS0+YmVnaW4oKSwgZW5k ID0gZGF0YS0+ZW5kKCk7IHB0ciAhPSBlbmQgJiYgIXZtLT5leGNlcHRpb24oKTsgKytwdHIpIHsK ICAgICAgICAgICAgIGNhY2hlZENhbGwuc2V0VGhpcyh0aGlzVmFsdWUpOwogICAgICAgICAgICAg Y2FjaGVkQ2FsbC5zZXRBcmd1bWVudCgwLCBwdHIudmFsdWUoKSk7CiAgICAgICAgICAgICBjYWNo ZWRDYWxsLnNldEFyZ3VtZW50KDEsIHB0ci5rZXkoKSk7CisgICAgICAgICAgICBjYWNoZWRDYWxs LnNldEFyZ3VtZW50KDIsIGNhbGxGcmFtZS0+dGhpc1ZhbHVlKCkpOwogICAgICAgICAgICAgY2Fj aGVkQ2FsbC5jYWxsKCk7CiAgICAgICAgIH0KICAgICB9IGVsc2UgewpAQCAtMTMzLDYgKzEzNCw3 IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgbWFwUHJvdG9GdW5jRm9yRWFjaChDYWxs RnJhbWUqIGNhbGxGcmFtZSkKICAgICAgICAgICAgIE1hcmtlZEFyZ3VtZW50QnVmZmVyIGFyZ3M7 CiAgICAgICAgICAgICBhcmdzLmFwcGVuZChwdHIudmFsdWUoKSk7CiAgICAgICAgICAgICBhcmdz LmFwcGVuZChwdHIua2V5KCkpOworICAgICAgICAgICAgYXJncy5hcHBlbmQoY2FsbEZyYW1lLT50 aGlzVmFsdWUoKSk7CiAgICAgICAgICAgICBKU0M6OmNhbGwoY2FsbEZyYW1lLCBjYWxsQmFjaywg Y2FsbFR5cGUsIGNhbGxEYXRhLCB0aGlzVmFsdWUsIGFyZ3MpOwogICAgICAgICB9CiAgICAgfQpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2V0UHJvdG90eXBlLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NldFByb3RvdHlwZS5jcHAKaW5kZXgg MDUyMzNhYjYxZjczNjNhNTg1MWIyNjM3YzU0ZWViYWViY2RhMDQ2Ni4uODYwY2FkODA2MDFkNjZh YjI1ZmI3Nzg1YWNiNWQyNDU2NjgwOWNjOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvU2V0UHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9TZXRQcm90b3R5cGUuY3BwCkBAIC0xMjksMTYgKzEyOSwyMCBAQCBFbmNvZGVkSlNW YWx1ZSBKU0NfSE9TVF9DQUxMIHNldFByb3RvRnVuY0ZvckVhY2goQ2FsbEZyYW1lKiBjYWxsRnJh bWUpCiAgICAgVk0qIHZtID0gJmNhbGxGcmFtZS0+dm0oKTsKICAgICBpZiAoY2FsbFR5cGUgPT0g Q2FsbFR5cGVKUykgewogICAgICAgICBKU0Z1bmN0aW9uKiBmdW5jdGlvbiA9IGpzQ2FzdDxKU0Z1 bmN0aW9uKj4oY2FsbEJhY2spOwotICAgICAgICBDYWNoZWRDYWxsIGNhY2hlZENhbGwoY2FsbEZy YW1lLCBmdW5jdGlvbiwgMSk7CisgICAgICAgIENhY2hlZENhbGwgY2FjaGVkQ2FsbChjYWxsRnJh bWUsIGZ1bmN0aW9uLCAzKTsKICAgICAgICAgZm9yIChhdXRvIHB0ciA9IGRhdGEtPmJlZ2luKCks IGVuZCA9IGRhdGEtPmVuZCgpOyBwdHIgIT0gZW5kICYmICF2bS0+ZXhjZXB0aW9uKCk7ICsrcHRy KSB7CiAgICAgICAgICAgICBjYWNoZWRDYWxsLnNldFRoaXModGhpc1ZhbHVlKTsKICAgICAgICAg ICAgIGNhY2hlZENhbGwuc2V0QXJndW1lbnQoMCwgcHRyLmtleSgpKTsKKyAgICAgICAgICAgIGNh Y2hlZENhbGwuc2V0QXJndW1lbnQoMSwgcHRyLmtleSgpKTsKKyAgICAgICAgICAgIGNhY2hlZENh bGwuc2V0QXJndW1lbnQoMiwgY2FsbEZyYW1lLT50aGlzVmFsdWUoKSk7CiAgICAgICAgICAgICBj YWNoZWRDYWxsLmNhbGwoKTsKICAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAgIGZvciAo YXV0byBwdHIgPSBkYXRhLT5iZWdpbigpLCBlbmQgPSBkYXRhLT5lbmQoKTsgcHRyICE9IGVuZCAm JiAhdm0tPmV4Y2VwdGlvbigpOyArK3B0cikgewogICAgICAgICAgICAgTWFya2VkQXJndW1lbnRC dWZmZXIgYXJnczsKICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKHB0ci5rZXkoKSk7CisgICAgICAg ICAgICBhcmdzLmFwcGVuZChwdHIua2V5KCkpOworICAgICAgICAgICAgYXJncy5hcHBlbmQoY2Fs bEZyYW1lLT50aGlzVmFsdWUoKSk7CiAgICAgICAgICAgICBKU0M6OmNhbGwoY2FsbEZyYW1lLCBj YWxsQmFjaywgY2FsbFR5cGUsIGNhbGxEYXRhLCB0aGlzVmFsdWUsIGFyZ3MpOwogICAgICAgICB9 CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDUyZTNiNjM0MTI0YTI5MjUwYjdkZTM0MDc0YmY5MDZlMjI5ZjMwYjIu LmY5NzZmZDg3MmVhNjI0YTJkMTRhNjQ1NmZlNDk1MTMzMGE4YzNmMDQgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOSBAQAorMjAxNC0xMi0wNyAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29t PgorCisgICAgICAgIFRoZSB0aGlyZCBwYXJhbWV0ZXIgb2YgYSBNYXAucHJvdG90eXBlLmZvckVh Y2ggY2FsbGJhY2sgZnVuY3Rpb24gaXMgdW5kZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg1NjMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzL2Jhc2ljLW1hcC1leHBlY3RlZC50eHQ6Cisg ICAgICAgICoganMvYmFzaWMtc2V0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBqcy9zY3JpcHQt dGVzdHMvYmFzaWMtbWFwLmpzOgorICAgICAgICAoc2V0IG1hcCk6IEFkZCB0ZXN0IHRoYXQgY2hl Y2tzIHRoaXJkIHBhcmFtZXRlciBvZiBmb3JFYWNoIGNhbGxiYWNrIGlzCisgICAgICAgIG5vdCBu dWxsLgorICAgICAgICAqIGpzL3NjcmlwdC10ZXN0cy9iYXNpYy1zZXQuanM6IEFkZCB0ZXN0IHRo YXQgY2hlY2tzIHRoaXJkIHBhcmFtZXRlciBvZiBmb3JFYWNoCisgICAgICAgIGNhbGxiYWNrIGlz IG5vdCBudWxsLgorICAgICAgICAoZGVidWcuc2V0IG5ldy5TZXQuc2V0IGZvckVhY2gpOgorCiAy MDE0LTEyLTA2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTc2OTA1LgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvanMvYmFzaWMtbWFwLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2pzL2Jhc2ljLW1h cC1leHBlY3RlZC50eHQKaW5kZXggYzY0MWE2OWM5NGZhNTE5MDFkNTNmMjNjZDdlZmQxZTQ1M2Ey ZmJhZS4uZDNmMDA1Nzk2ZDM4MzkzNThiYzJkNWFhYzFjNzVkZTBhMTBhMWYxNiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvanMvYmFzaWMtbWFwLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9qcy9iYXNpYy1tYXAtZXhwZWN0ZWQudHh0CkBAIC0yMjYsNiArMjI2LDggQEAgQSBkZWFkIGl0 ZXJhdG9yIHNob3VsZCByZW1haW4gZGVhZAogUEFTUyBjb3VudCBpcyAwCiBQQVNTIGNvdW50IGlz IDMKIFBBU1MgY291bnQgaXMgMworZm9yRWFjaCBzaG91bGQgcGFzcyBpdGVyYXRlZCBtYXAgb2Jq ZWN0IGFzIHRoaXJkIHBhcmFtZXRlcgorUEFTUyB0eXBlb2Yob2JqZWN0KSBpcyAib2JqZWN0Igog UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9qcy9iYXNpYy1zZXQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv anMvYmFzaWMtc2V0LWV4cGVjdGVkLnR4dAppbmRleCBiNDg4YjBhNDg4YTQ5MzU5NTFhYTU5MTJm MWJhNjI1NTFjM2NjOGQ0Li41MmUyMjhmN2E2YjdlNWFiNDFhZGZiNmExMDBjZjAyZjE4YTM4NTBi IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9qcy9iYXNpYy1zZXQtZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL2pzL2Jhc2ljLXNldC1leHBlY3RlZC50eHQKQEAgLTE5Nyw2ICsxOTcsOCBA QCBBIGRlYWQgaXRlcmF0b3Igc2hvdWxkIHJlbWFpbiBkZWFkCiBQQVNTIGNvdW50IGlzIDAKIFBB U1MgY291bnQgaXMgMwogUEFTUyBjb3VudCBpcyAzCitmb3JFYWNoIHNob3VsZCBwYXNzIGl0ZXJh dGVkIHNldCBvYmplY3QgYXMgdGhpcmQgcGFyYW1ldGVyCitQQVNTIHR5cGVvZihvYmplY3QpIGlz ICJvYmplY3QiCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExF VEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9iYXNpYy1tYXAuanMg Yi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvYmFzaWMtbWFwLmpzCmluZGV4IGZmZjQyYmE2 ZjRkNjhkZTBlZTA2NzZmM2FkNWYwNWRmMWQ3NTJiYjMuLjgxNDg2ODUxYTdhN2M5MTZkOGViN2Iy MWIxMTZlYThjODQwMzRmMTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0 cy9iYXNpYy1tYXAuanMKKysrIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2Jhc2ljLW1h cC5qcwpAQCAtMjc4LDMgKzI3OCwxMiBAQCBmb3IgKGtleSBvZiBtYXAua2V5cygpKSB7CiAgICAg Y291bnQrKzsKIH0KIHNob3VsZEJlKCJjb3VudCIsICIzIik7CisKK2RlYnVnKCJmb3JFYWNoIHNo b3VsZCBwYXNzIGl0ZXJhdGVkIG1hcCBvYmplY3QgYXMgdGhpcmQgcGFyYW1ldGVyIikKKwordmFy IG1hcCA9IG5ldyBNYXAoKTsKK21hcC5zZXQoImZvbyIsICJiYXIiKTsKK21hcC5mb3JFYWNoKGZ1 bmN0aW9uKHYsIGssIG8pIHsKKyAgICBvYmplY3QgPSBvOworICAgIHNob3VsZEJlKCJ0eXBlb2Yo b2JqZWN0KSIsICJcIm9iamVjdFwiIik7Cit9KTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pz L3NjcmlwdC10ZXN0cy9iYXNpYy1zZXQuanMgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMv YmFzaWMtc2V0LmpzCmluZGV4IDcyZjE5N2FmNTFlNTA4YTZmYWQwMzYwYzk0YWI2ZTBjZjhhMTkw OTUuLjg3NGU3MWIzOWJjY2IwNDA0YTBkMDU1MTJhZTk2Y2FmZGIyMTM1NzkgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9iYXNpYy1zZXQuanMKKysrIGIvTGF5b3V0VGVz dHMvanMvc2NyaXB0LXRlc3RzL2Jhc2ljLXNldC5qcwpAQCAtMjM4LDMgKzIzOCwxMSBAQCBmb3Ig KGtleSBvZiBzZXQua2V5cygpKSB7CiAgICAgY291bnQrKzsKIH0KIHNob3VsZEJlKCJjb3VudCIs ICIzIik7CisKK2RlYnVnKCJmb3JFYWNoIHNob3VsZCBwYXNzIGl0ZXJhdGVkIHNldCBvYmplY3Qg YXMgdGhpcmQgcGFyYW1ldGVyIikKKwordmFyIHNldCA9IG5ldyBTZXQoWyJmb28iXSkKK3NldC5m b3JFYWNoKGZ1bmN0aW9uKHYxLCB2MiwgbykgeworICAgIG9iamVjdCA9IG87CisgICAgc2hvdWxk QmUoInR5cGVvZihvYmplY3QpIiwgIlwib2JqZWN0XCIiKTsKK30pOwo=