138550 2014-11-09 15:02:45 -0800 Move 'resize' CSS property to the new StyleBuilder 2014-11-10 11:56:31 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137910 1 cdumez cdumez commit-queue kling koivisto oldest_to_newest 1047417 0 cdumez 2014-11-09 15:02:45 -0800 Move 'resize' CSS property to the new StyleBuilder 1047421 1 241262 cdumez 2014-11-09 15:30:34 -0800 Created attachment 241262 Patch 1047561 2 241262 kling 2014-11-10 10:55:40 -0800 Comment on attachment 241262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241262&action=review r=me > Source/WebCore/css/StyleBuilderConverter.h:381 > + if (Settings* settings = styleResolver.document().settings()) I wonder when we would be resolving style without there being a Settings object. (Just curious, not important to look into.) 1047581 3 241262 commit-queue 2014-11-10 11:56:27 -0800 Comment on attachment 241262 Patch Clearing flags on attachment: 241262 Committed r175817: <http://trac.webkit.org/changeset/175817> 1047582 4 commit-queue 2014-11-10 11:56:31 -0800 All reviewed patches have been landed. Closing bug. 241262 2014-11-09 15:30:34 -0800 2014-11-10 11:56:27 -0800 Patch bug-138550-20141109153034.patch text/plain 6205 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1Nzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWI5OGYxMGZkYmVlNDUy ZmU0NjE3MjdmYTQ3YTU4YTNhODIxY2VjMy4uZTYwNDQxMTJlOWJlOGYwYTM1YzFlOTRjMDA3ZWU3 NjdjNTVkMDM2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTExLTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSAncmVzaXplJyBDU1Mg cHJvcGVydHkgdG8gdGhlIG5ldyBTdHlsZUJ1aWxkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODU1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdl LgorCisgICAgICAgIE1vdmUgJ3Jlc2l6ZScgQ1NTIHByb3BlcnR5IGZyb20gRGVwcmVjYXRlZFN0 eWxlQnVpbGRlciB0byB0aGUgbmV3CisgICAgICAgIFN0eWxlQnVpbGRlciBieSBhZGRpbmcgYSBu ZXcgJ1Jlc2l6ZScgQ29udmVydGVyIGZ1bmN0aW9uLgorCisgICAgICAgICogY3NzL0NTU1Byb3Bl cnR5TmFtZXMuaW46CisgICAgICAgICogY3NzL0RlcHJlY2F0ZWRTdHlsZUJ1aWxkZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RGVwcmVjYXRlZFN0eWxlQnVpbGRlcjo6RGVwcmVjYXRlZFN0eWxl QnVpbGRlcik6CisgICAgICAgIChXZWJDb3JlOjpBcHBseVByb3BlcnR5UmVzaXplOjphcHBseVZh bHVlKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkFwcGx5UHJvcGVydHlSZXNpemU6OmNy ZWF0ZUhhbmRsZXIpOiBEZWxldGVkLgorICAgICAgICAqIGNzcy9TdHlsZUJ1aWxkZXJDb252ZXJ0 ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlQnVpbGRlckNvbnZlcnRlcjo6Y29udmVydFJl c2l6ZSk6CisKIDIwMTQtMTEtMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgSW1wbGVtZW50IHJvdW5kLXJlY3QgY2xpcHBpbmcgb24gdmlkZW8gZWxl bWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0eU5hbWVzLmlu IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5TmFtZXMuaW4KaW5kZXggMzIwYmNmNTRj Y2M5ZjJmY2U1OTMxY2I3NTIzMzM4ODI3MzQ1NjQ5Ni4uN2ZiNWY0OTBkOTRkOTQwYTljMWZjY2Rh M2JlNzA3OWZmMWQyNjQzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3Bl cnR5TmFtZXMuaW4KKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnR5TmFtZXMuaW4K QEAgLTIwOCw3ICsyMDgsNyBAQCBwYWludC1vcmRlcgogcG9pbnRlci1ldmVudHMgW0luaGVyaXRl ZCwgTmV3U3R5bGVCdWlsZGVyXQogcG9zaXRpb24gW05ld1N0eWxlQnVpbGRlcl0KIHF1b3RlcyBb SW5oZXJpdGVkXQotcmVzaXplIFtJbmhlcml0ZWRdCityZXNpemUgW0luaGVyaXRlZCwgTmV3U3R5 bGVCdWlsZGVyLCBDb252ZXJ0ZXI9UmVzaXplXQogcmlnaHQgW05ld1N0eWxlQnVpbGRlciwgSW5p dGlhbD1pbml0aWFsT2Zmc2V0LCBDb252ZXJ0ZXI9TGVuZ3RoT3JBdXRvXQogc2l6ZSBbTmV3U3R5 bGVCdWlsZGVyLCBDdXN0b209QWxsXQogc3JjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvRGVwcmVjYXRlZFN0eWxlQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvRGVwcmVj YXRlZFN0eWxlQnVpbGRlci5jcHAKaW5kZXggZDlkNTRkYTI0MWUxYjQ1ZDY5NjhlNTUyZTgzYjcx ZjczNDc4MGY0Ni4uMTkyMzI5NDU5ZGM2NWQ4MDhkZTRkZmMyMzU3OGIwYmJhODJjMjc1YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0RlcHJlY2F0ZWRTdHlsZUJ1aWxkZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9EZXByZWNhdGVkU3R5bGVCdWlsZGVyLmNwcApAQCAtMTM4 NiwzNiArMTM4Niw2IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUHJvcGVydHlIYW5kbGVyIGNyZWF0 ZUhhbmRsZXIoKSB7IHJldHVybiBQcm9wZXJ0eUhhbmRsZXIoJmFwcGx5SW5oZXJpdFZhbHVlLCAm YXBwbHlJbml0aWFsVmFsdWUsICZhcHBseVZhbHVlKTsgfQogfTsKIAotY2xhc3MgQXBwbHlQcm9w ZXJ0eVJlc2l6ZSB7Ci1wdWJsaWM6Ci0gICAgc3RhdGljIHZvaWQgYXBwbHlWYWx1ZShDU1NQcm9w ZXJ0eUlELCBTdHlsZVJlc29sdmVyKiBzdHlsZVJlc29sdmVyLCBDU1NWYWx1ZSogdmFsdWUpCi0g ICAgewotICAgICAgICBpZiAoIWlzPENTU1ByaW1pdGl2ZVZhbHVlPigqdmFsdWUpKQotICAgICAg ICAgICAgcmV0dXJuOwotCi0gICAgICAgIENTU1ByaW1pdGl2ZVZhbHVlJiBwcmltaXRpdmVWYWx1 ZSA9IGRvd25jYXN0PENTU1ByaW1pdGl2ZVZhbHVlPigqdmFsdWUpOwotCi0gICAgICAgIEVSZXNp emUgcmVzaXplID0gUkVTSVpFX05PTkU7Ci0gICAgICAgIHN3aXRjaCAocHJpbWl0aXZlVmFsdWUu Z2V0VmFsdWVJRCgpKSB7Ci0gICAgICAgIGNhc2UgMDoKLSAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgY2FzZSBDU1NWYWx1ZUF1dG86Ci0gICAgICAgICAgICBpZiAoU2V0dGluZ3MqIHNldHRp bmdzID0gc3R5bGVSZXNvbHZlci0+ZG9jdW1lbnQoKS5zZXR0aW5ncygpKQotICAgICAgICAgICAg ICAgIHJlc2l6ZSA9IHNldHRpbmdzLT50ZXh0QXJlYXNBcmVSZXNpemFibGUoKSA/IFJFU0laRV9C T1RIIDogUkVTSVpFX05PTkU7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgZGVmYXVsdDoK LSAgICAgICAgICAgIHJlc2l6ZSA9IHByaW1pdGl2ZVZhbHVlOwotICAgICAgICB9Ci0gICAgICAg IHN0eWxlUmVzb2x2ZXItPnN0eWxlKCktPnNldFJlc2l6ZShyZXNpemUpOwotICAgIH0KLQotICAg IHN0YXRpYyBQcm9wZXJ0eUhhbmRsZXIgY3JlYXRlSGFuZGxlcigpCi0gICAgewotICAgICAgICBQ cm9wZXJ0eUhhbmRsZXIgaGFuZGxlciA9IEFwcGx5UHJvcGVydHlEZWZhdWx0QmFzZTxFUmVzaXpl LCAmUmVuZGVyU3R5bGU6OnJlc2l6ZSwgRVJlc2l6ZSwgJlJlbmRlclN0eWxlOjpzZXRSZXNpemUs IEVSZXNpemUsICZSZW5kZXJTdHlsZTo6aW5pdGlhbFJlc2l6ZT46OmNyZWF0ZUhhbmRsZXIoKTsK LSAgICAgICAgcmV0dXJuIFByb3BlcnR5SGFuZGxlcihoYW5kbGVyLmluaGVyaXRGdW5jdGlvbigp LCBoYW5kbGVyLmluaXRpYWxGdW5jdGlvbigpLCAmYXBwbHlWYWx1ZSk7Ci0gICAgfQotfTsKLQog Y2xhc3MgQXBwbHlQcm9wZXJ0eVZlcnRpY2FsQWxpZ24gewogcHVibGljOgogICAgIHN0YXRpYyB2 b2lkIGFwcGx5VmFsdWUoQ1NTUHJvcGVydHlJRCwgU3R5bGVSZXNvbHZlciogc3R5bGVSZXNvbHZl ciwgQ1NTVmFsdWUqIHZhbHVlKQpAQCAtMTY5MSw3ICsxNjYxLDYgQEAgRGVwcmVjYXRlZFN0eWxl QnVpbGRlcjo6RGVwcmVjYXRlZFN0eWxlQnVpbGRlcigpCiAgICAgc2V0UHJvcGVydHlIYW5kbGVy KENTU1Byb3BlcnR5T3JwaGFucywgQXBwbHlQcm9wZXJ0eUF1dG88c2hvcnQsICZSZW5kZXJTdHls ZTo6b3JwaGFucywgJlJlbmRlclN0eWxlOjpzZXRPcnBoYW5zLCAmUmVuZGVyU3R5bGU6Omhhc0F1 dG9PcnBoYW5zLCAmUmVuZGVyU3R5bGU6OnNldEhhc0F1dG9PcnBoYW5zPjo6Y3JlYXRlSGFuZGxl cigpKTsKICAgICBzZXRQcm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlPdXRsaW5lQ29sb3IsIEFw cGx5UHJvcGVydHlDb2xvcjxOb0luaGVyaXRGcm9tUGFyZW50LCAmUmVuZGVyU3R5bGU6Om91dGxp bmVDb2xvciwgJlJlbmRlclN0eWxlOjpzZXRPdXRsaW5lQ29sb3IsICZSZW5kZXJTdHlsZTo6c2V0 VmlzaXRlZExpbmtPdXRsaW5lQ29sb3IsICZSZW5kZXJTdHlsZTo6Y29sb3I+OjpjcmVhdGVIYW5k bGVyKCkpOwogICAgIHNldFByb3BlcnR5SGFuZGxlcihDU1NQcm9wZXJ0eU91dGxpbmVTdHlsZSwg QXBwbHlQcm9wZXJ0eU91dGxpbmVTdHlsZTo6Y3JlYXRlSGFuZGxlcigpKTsKLSAgICBzZXRQcm9w ZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlSZXNpemUsIEFwcGx5UHJvcGVydHlSZXNpemU6OmNyZWF0 ZUhhbmRsZXIoKSk7CiAgICAgc2V0UHJvcGVydHlIYW5kbGVyKENTU1Byb3BlcnR5V2Via2l0VGV4 dERlY29yYXRpb25Db2xvciwgQXBwbHlQcm9wZXJ0eUNvbG9yPE5vSW5oZXJpdEZyb21QYXJlbnQs ICZSZW5kZXJTdHlsZTo6dGV4dERlY29yYXRpb25Db2xvciwgJlJlbmRlclN0eWxlOjpzZXRUZXh0 RGVjb3JhdGlvbkNvbG9yLCAmUmVuZGVyU3R5bGU6OnNldFZpc2l0ZWRMaW5rVGV4dERlY29yYXRp b25Db2xvciwgJlJlbmRlclN0eWxlOjpjb2xvcj46OmNyZWF0ZUhhbmRsZXIoKSk7CiAgICAgc2V0 UHJvcGVydHlIYW5kbGVyKENTU1Byb3BlcnR5V2Via2l0VGV4dERlY29yYXRpb25Ta2lwLCBBcHBs eVByb3BlcnR5VGV4dERlY29yYXRpb25Ta2lwOjpjcmVhdGVIYW5kbGVyKCkpOwogICAgIHNldFBy b3BlcnR5SGFuZGxlcihDU1NQcm9wZXJ0eVdlYmtpdFRleHRVbmRlcmxpbmVQb3NpdGlvbiwgQXBw bHlQcm9wZXJ0eVRleHRVbmRlcmxpbmVQb3NpdGlvbjo6Y3JlYXRlSGFuZGxlcigpKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1aWxkZXJDb252ZXJ0ZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZUJ1aWxkZXJDb252ZXJ0ZXIuaAppbmRleCBhODE1ZmNmZmRiMjI4 NDNiYzQxNTcyNWM2MTMzODZlNjE2ZmE1MzVlLi5lODdiZDI0ODljMmRjZTI2MzYyNWRlYWQ0ZWJh NTM4YmE0YmY5ZjA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVCdWlsZGVy Q29udmVydGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlQnVpbGRlckNvbnZlcnRl ci5oCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSAiQ1NTUHJpbWl0aXZlVmFsdWUuaCIKICNp bmNsdWRlICJMZW5ndGguaCIKICNpbmNsdWRlICJQYWlyLmgiCisjaW5jbHVkZSAiU2V0dGluZ3Mu aCIKICNpbmNsdWRlICJTdHlsZVJlc29sdmVyLmgiCiAjaW5jbHVkZSAiVHJhbnNmb3JtRnVuY3Rp b25zLmgiCiAKQEAgLTYwLDYgKzYxLDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBUZXh0RW1waGFz aXNQb3NpdGlvbiBjb252ZXJ0VGV4dEVtcGhhc2lzUG9zaXRpb24oU3R5bGVSZXNvbHZlciYsIENT U1ZhbHVlJik7CiAgICAgc3RhdGljIEVUZXh0QWxpZ24gY29udmVydFRleHRBbGlnbihTdHlsZVJl c29sdmVyJiwgQ1NTVmFsdWUmKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxDbGlwUGF0aE9wZXJh dGlvbj4gY29udmVydENsaXBQYXRoKFN0eWxlUmVzb2x2ZXImLCBDU1NWYWx1ZSYpOworICAgIHN0 YXRpYyBFUmVzaXplIGNvbnZlcnRSZXNpemUoU3R5bGVSZXNvbHZlciYsIENTU1ZhbHVlJik7CiAK IHByaXZhdGU6CiAgICAgc3RhdGljIExlbmd0aCBjb252ZXJ0VG9SYWRpdXNMZW5ndGgoQ1NTVG9M ZW5ndGhDb252ZXJzaW9uRGF0YSYsIENTU1ByaW1pdGl2ZVZhbHVlJik7CkBAIC0zNzAsNiArMzcy LDIwIEBAIGlubGluZSBQYXNzUmVmUHRyPENsaXBQYXRoT3BlcmF0aW9uPiBTdHlsZUJ1aWxkZXJD b252ZXJ0ZXI6OmNvbnZlcnRDbGlwUGF0aChTdHlsCiAgICAgcmV0dXJuIG9wZXJhdGlvbi5yZWxl YXNlKCk7CiB9CiAKK2lubGluZSBFUmVzaXplIFN0eWxlQnVpbGRlckNvbnZlcnRlcjo6Y29udmVy dFJlc2l6ZShTdHlsZVJlc29sdmVyJiBzdHlsZVJlc29sdmVyLCBDU1NWYWx1ZSYgdmFsdWUpCit7 CisgICAgYXV0byYgcHJpbWl0aXZlVmFsdWUgPSBkb3duY2FzdDxDU1NQcmltaXRpdmVWYWx1ZT4o dmFsdWUpOworCisgICAgRVJlc2l6ZSByZXNpemUgPSBSRVNJWkVfTk9ORTsKKyAgICBpZiAocHJp bWl0aXZlVmFsdWUuZ2V0VmFsdWVJRCgpID09IENTU1ZhbHVlQXV0bykgeworICAgICAgICBpZiAo U2V0dGluZ3MqIHNldHRpbmdzID0gc3R5bGVSZXNvbHZlci5kb2N1bWVudCgpLnNldHRpbmdzKCkp CisgICAgICAgICAgICByZXNpemUgPSBzZXR0aW5ncy0+dGV4dEFyZWFzQXJlUmVzaXphYmxlKCkg PyBSRVNJWkVfQk9USCA6IFJFU0laRV9OT05FOworICAgIH0gZWxzZQorICAgICAgICByZXNpemUg PSBwcmltaXRpdmVWYWx1ZTsKKworICAgIHJldHVybiByZXNpemU7Cit9CisKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIFN0eWxlQnVpbGRlckNvbnZlcnRlcl9oCg==