138544 2014-11-09 09:32:20 -0800 Exception fuzz helper generates incorrect target range 2014-11-09 23:59:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned buildbot commit-queue darin fpizlo rniwa oldest_to_newest 1047394 0 akiss 2014-11-09 09:32:20 -0800 Currently, the jsc-stress-test-helpers/js-exception-fuzz script generates targets in the range of 0..($checkCount-1). However, target 0 is never hit, while target 1 is always outside of the outermost try block of the tests, which therefore prints unexpected output and results in false failures when fired at. Additionally, target $checkCount is never generated. An example failure report for target 1: exceptionFuzz.yaml/exceptionFuzz/3d-cube.js.exception-fuzz: iteration(62) target(1): Exception: Error: Exception Fuzz exceptionFuzz.yaml/exceptionFuzz/3d-cube.js.exception-fuzz: iteration(62) target(1): global code@3d-cube.js:7:18 exceptionFuzz.yaml/exceptionFuzz/3d-cube.js.exception-fuzz: Failure for command ../../../.vm/JavaScriptCore.framework/Resources/jsc 3d-cube.js with seed 1415502219, repeat 100: Unexpected state thrown at end for target 1 at ../../../.helpers/js-exception-fuzz line 67, <$testInput> line 4. exceptionFuzz.yaml/exceptionFuzz/3d-cube.js.exception-fuzz: ERROR: Unexpected exit code: 255 The above output is for 3d-cube.js, but all 3 tests in tests/exceptionFuzz can fail like this. Target 1 can be manually triggered by the command: WebKitBuild/Debug/bin/jsc --enableExceptionFuzz=true --fireExceptionFuzzAt=1 Source/JavaScriptCore/tests/exceptionFuzz/3d-cube.js 1047395 1 241254 akiss 2014-11-09 09:33:58 -0800 Created attachment 241254 Proposed patch. 1047396 2 commit-queue 2014-11-09 09:35:46 -0800 Attachment 241254 did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1047397 3 241254 darin 2014-11-09 09:56:34 -0800 Comment on attachment 241254 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=241254&action=review > Tools/ChangeLog:4 > + Need the bug URL (OOPS!). I don’t think we can land this with the commit queue with this line like this. > Tools/ChangeLog:12 > + Currently, the script generates exception fuzz targets in the range of > + 0..($checkCount-1). However, target 0 is never hit, while target 1 is > + always outside of the outermost try block of the tests, which therefore > + prints unexpected output and results in false failures when fired at. > + Additionally, target $checkCount is never generated. This looks right to me, but I am not sufficiently familiar with the exception system to check if this paragraph is correct or not. The code does correctly implement what this paragraph describes. 1047401 4 241256 akiss 2014-11-09 11:01:49 -0800 Created attachment 241256 Updated patch Fixed the ChangeLog. My bad. Sorry. 1047488 5 241256 commit-queue 2014-11-09 23:59:30 -0800 Comment on attachment 241256 Updated patch Clearing flags on attachment: 241256 Committed r175801: <http://trac.webkit.org/changeset/175801> 1047489 6 commit-queue 2014-11-09 23:59:33 -0800 All reviewed patches have been landed. Closing bug. 241254 2014-11-09 09:33:58 -0800 2014-11-09 11:01:49 -0800 Proposed patch. exfuzz-helper-range-fix-v1.patch text/plain 1604 akiss ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNzk0 MjJhLi5jZTBlMTA5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTQtMTEtMDkgIEFrb3MgS2lzcyAgPGFraXNzQGlu Zi51LXN6ZWdlZC5odT4KKworICAgICAgICBGaXggdGhlIGV4Y2VwdGlvbiBmdXp6IGhlbHBlciB0 byBnZW5lcmF0ZSB0YXJnZXRzIGluIHRoZSBjb3JyZWN0IHJhbmdlCisgICAgICAgIE5lZWQgdGhl IGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDdXJyZW50bHksIHRoZSBzY3JpcHQgZ2VuZXJhdGVzIGV4Y2VwdGlvbiBmdXp6 IHRhcmdldHMgaW4gdGhlIHJhbmdlIG9mCisgICAgICAgIDAuLigkY2hlY2tDb3VudC0xKS4gSG93 ZXZlciwgdGFyZ2V0IDAgaXMgbmV2ZXIgaGl0LCB3aGlsZSB0YXJnZXQgMSBpcworICAgICAgICBh bHdheXMgb3V0c2lkZSBvZiB0aGUgb3V0ZXJtb3N0IHRyeSBibG9jayBvZiB0aGUgdGVzdHMsIHdo aWNoIHRoZXJlZm9yZQorICAgICAgICBwcmludHMgdW5leHBlY3RlZCBvdXRwdXQgYW5kIHJlc3Vs dHMgaW4gZmFsc2UgZmFpbHVyZXMgd2hlbiBmaXJlZCBhdC4KKyAgICAgICAgQWRkaXRpb25hbGx5 LCB0YXJnZXQgJGNoZWNrQ291bnQgaXMgbmV2ZXIgZ2VuZXJhdGVkLgorCisgICAgICAgIFRoaXMg cGF0Y2ggZml4ZXMgdGhlIHNjcmlwdCB0byBnZW5lcmF0ZSB0YXJnZXRzIGluIHRoZSByYW5nZSBv ZgorICAgICAgICAyLi4kY2hlY2tDb3VudC4KKworICAgICAgICAqIFNjcmlwdHMvanNjLXN0cmVz cy10ZXN0LWhlbHBlcnMvanMtZXhjZXB0aW9uLWZ1eno6CisKIDIwMTQtMTEtMDggIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFJ1biBs YXlvdXQgdGVzdHMgdXNpbmcgdGhlIG5ldHdvcmsgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9qcy1leGNlcHRpb24tZnV6eiBiL1Rvb2xz L1NjcmlwdHMvanNjLXN0cmVzcy10ZXN0LWhlbHBlcnMvanMtZXhjZXB0aW9uLWZ1enoKaW5kZXgg NjNkMGE3My4uNmIxZjAyZiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRl c3QtaGVscGVycy9qcy1leGNlcHRpb24tZnV6egorKysgYi9Ub29scy9TY3JpcHRzL2pzYy1zdHJl c3MtdGVzdC1oZWxwZXJzL2pzLWV4Y2VwdGlvbi1mdXp6CkBAIC0xMDAsNyArMTAwLDcgQEAgaWYg KCEkY2hlY2tDb3VudCkgewogc3JhbmQoJHNlZWQpOwogCiBmb3IgKG15ICRpdGVyYXRpb24gPSAw OyAkaXRlcmF0aW9uIDwgJHJlcGVhdDsgKyskaXRlcmF0aW9uKSB7Ci0gICAgbXkgJHRhcmdldCA9 IGludChyYW5kKCkgKiAkY2hlY2tDb3VudCk7CisgICAgbXkgJHRhcmdldCA9IGludChyYW5kKCkg KiAoJGNoZWNrQ291bnQgLSAxKSkgKyAyOwogICAgIGlmICgkdmVyYm9zZSkgewogICAgICAgICBw cmludCAiaXRlcmF0aW9uKCRpdGVyYXRpb24pIHRhcmdldCgkdGFyZ2V0KTogUnVubmluZy5cbiI7 CiAgICAgfQo= 241256 2014-11-09 11:01:49 -0800 2014-11-09 23:59:30 -0800 Updated patch exfuzz-helper-range-fix-v2.patch text/plain 1625 akiss ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNzk0 MjJhLi4zN2RkNzI5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTQtMTEtMDkgIEFrb3MgS2lzcyAgPGFraXNzQGlu Zi51LXN6ZWdlZC5odT4KKworICAgICAgICBGaXggdGhlIGV4Y2VwdGlvbiBmdXp6IGhlbHBlciB0 byBnZW5lcmF0ZSB0YXJnZXRzIGluIHRoZSBjb3JyZWN0IHJhbmdlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg1NDQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHksIHRoZSBzY3JpcHQgZ2Vu ZXJhdGVzIGV4Y2VwdGlvbiBmdXp6IHRhcmdldHMgaW4gdGhlIHJhbmdlIG9mCisgICAgICAgIDAu LigkY2hlY2tDb3VudC0xKS4gSG93ZXZlciwgdGFyZ2V0IDAgaXMgbmV2ZXIgaGl0LCB3aGlsZSB0 YXJnZXQgMSBpcworICAgICAgICBhbHdheXMgb3V0c2lkZSBvZiB0aGUgb3V0ZXJtb3N0IHRyeSBi bG9jayBvZiB0aGUgdGVzdHMsIHdoaWNoIHRoZXJlZm9yZQorICAgICAgICBwcmludHMgdW5leHBl Y3RlZCBvdXRwdXQgYW5kIHJlc3VsdHMgaW4gZmFsc2UgZmFpbHVyZXMgd2hlbiBmaXJlZCBhdC4K KyAgICAgICAgQWRkaXRpb25hbGx5LCB0YXJnZXQgJGNoZWNrQ291bnQgaXMgbmV2ZXIgZ2VuZXJh dGVkLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIHNjcmlwdCB0byBnZW5lcmF0ZSB0 YXJnZXRzIGluIHRoZSByYW5nZSBvZgorICAgICAgICAyLi4kY2hlY2tDb3VudC4KKworICAgICAg ICAqIFNjcmlwdHMvanNjLXN0cmVzcy10ZXN0LWhlbHBlcnMvanMtZXhjZXB0aW9uLWZ1eno6CisK IDIwMTQtMTEtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdIFJ1biBsYXlvdXQgdGVzdHMgdXNpbmcgdGhlIG5ldHdvcmsgcHJvY2Vz cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9qcy1l eGNlcHRpb24tZnV6eiBiL1Rvb2xzL1NjcmlwdHMvanNjLXN0cmVzcy10ZXN0LWhlbHBlcnMvanMt ZXhjZXB0aW9uLWZ1enoKaW5kZXggNjNkMGE3My4uNmIxZjAyZiAxMDA3NTUKLS0tIGEvVG9vbHMv U2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy9qcy1leGNlcHRpb24tZnV6egorKysgYi9U b29scy9TY3JpcHRzL2pzYy1zdHJlc3MtdGVzdC1oZWxwZXJzL2pzLWV4Y2VwdGlvbi1mdXp6CkBA IC0xMDAsNyArMTAwLDcgQEAgaWYgKCEkY2hlY2tDb3VudCkgewogc3JhbmQoJHNlZWQpOwogCiBm b3IgKG15ICRpdGVyYXRpb24gPSAwOyAkaXRlcmF0aW9uIDwgJHJlcGVhdDsgKyskaXRlcmF0aW9u KSB7Ci0gICAgbXkgJHRhcmdldCA9IGludChyYW5kKCkgKiAkY2hlY2tDb3VudCk7CisgICAgbXkg JHRhcmdldCA9IGludChyYW5kKCkgKiAoJGNoZWNrQ291bnQgLSAxKSkgKyAyOwogICAgIGlmICgk dmVyYm9zZSkgewogICAgICAgICBwcmludCAiaXRlcmF0aW9uKCRpdGVyYXRpb24pIHRhcmdldCgk dGFyZ2V0KTogUnVubmluZy5cbiI7CiAgICAgfQo=