138538 2014-11-08 17:09:55 -0800 Move isEmptyValue() logic from HTMLInputElement to TextFieldInputType 2014-11-08 21:47:08 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 138515 1 cdumez cdumez commit-queue darin oldest_to_newest 1047337 0 cdumez 2014-11-08 17:09:55 -0800 Move isEmptyValue() logic from HTMLInputElement to TextFieldInputType as this only makes sense for text field input types. 1047358 1 241245 cdumez 2014-11-08 20:48:21 -0800 Created attachment 241245 Patch 1047368 2 241245 commit-queue 2014-11-08 21:47:04 -0800 Comment on attachment 241245 Patch Clearing flags on attachment: 241245 Committed r175787: <http://trac.webkit.org/changeset/175787> 1047369 3 commit-queue 2014-11-08 21:47:08 -0800 All reviewed patches have been landed. Closing bug. 241245 2014-11-08 20:48:21 -0800 2014-11-08 21:47:04 -0800 Patch bug-138538-20141108204821.patch text/plain 5264 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWNiNWJhMWQ1YmYyN2Q3 ZjIyNGU1ZTFiNjRkODNlZWM2NWY2MzBlYy4uZTQyZGM4NzFkMDFkNjUyZGZmNTY0YTcyZjc1MzY4 MDM4M2IyMWU2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE0LTExLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgTW92ZSBpc0VtcHR5VmFsdWUo KSBsb2dpYyBmcm9tIEhUTUxJbnB1dEVsZW1lbnQgdG8gVGV4dEZpZWxkSW5wdXRUeXBlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg1MzgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIGlzRW1wdHlW YWx1ZSgpIGxvZ2ljIGZyb20gSFRNTElucHV0RWxlbWVudCB0byBUZXh0RmllbGRJbnB1dFR5cGUK KyAgICAgICAgYXMgdGhpcyBvbmx5IG1ha2VzIHNlbnNlIGZvciB0ZXh0IGZpZWxkIGlucHV0IHR5 cGVzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAg ICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJ bnB1dEVsZW1lbnQ6OmlzRW1wdHlWYWx1ZSk6CisgICAgICAgICogaHRtbC9JbnB1dFR5cGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SW5wdXRUeXBlOjppc0VtcHR5VmFsdWUpOgorICAgICAgICAq IGh0bWwvSW5wdXRUeXBlLmg6CisgICAgICAgICogaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VGV4dEZpZWxkSW5wdXRUeXBlOjppc0VtcHR5VmFsdWUpOgor ICAgICAgICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmg6CisKKzIwMTQtMTEtMDggIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBTcGVlZCB1cCBIVE1MSW5wdXRF bGVtZW50Ojppc0VtcHR5VmFsdWUoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM4NTE1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1l bnQuY3BwCmluZGV4IDU0OWY0MWQ4NjhjYWFlZDdjZmQ2M2FhMzg1NTQ4OWQxZTZiNjcwMzUuLjE2 MTc3YmFmN2I0ZWVhMDg5MzFiOWVhMTAxYTg3ZjFkYzk2YTU5YjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtNjIsOCArNjIsNiBAQAogI2luY2x1ZGUgIlNl YXJjaElucHV0VHlwZS5oIgogI2luY2x1ZGUgIlN0eWxlUmVzb2x2ZXIuaCIKICNpbmNsdWRlICJU ZXh0QnJlYWtJdGVyYXRvci5oIgotI2luY2x1ZGUgIlRleHRDb250cm9sSW5uZXJFbGVtZW50cy5o IgotI2luY2x1ZGUgIlRleHROb2RlVHJhdmVyc2FsLmgiCiAjaW5jbHVkZSA8d3RmL01hdGhFeHRy YXMuaD4KICNpbmNsdWRlIDx3dGYvUmVmLmg+CiAKQEAgLTE2ODAsMTcgKzE2NzgsNyBAQCB2b2lk IEhUTUxJbnB1dEVsZW1lbnQ6OnVwZGF0ZVBsYWNlaG9sZGVyVGV4dCgpCiAKIGJvb2wgSFRNTElu cHV0RWxlbWVudDo6aXNFbXB0eVZhbHVlKCkgY29uc3QKIHsKLSAgICBpZiAoIWlzVGV4dEZpZWxk KCkpCi0gICAgICAgIHJldHVybiB0cnVlOwotCi0gICAgVGV4dENvbnRyb2xJbm5lclRleHRFbGVt ZW50KiBpbm5lclRleHQgPSBpbm5lclRleHRFbGVtZW50KCk7Ci0gICAgQVNTRVJUKGlubmVyVGV4 dCk7Ci0KLSAgICBmb3IgKFRleHQqIHRleHQgPSBUZXh0Tm9kZVRyYXZlcnNhbDo6Zmlyc3RXaXRo aW4oaW5uZXJUZXh0KTsgdGV4dDsgdGV4dCA9IFRleHROb2RlVHJhdmVyc2FsOjpuZXh0KHRleHQs IGlubmVyVGV4dCkpIHsKLSAgICAgICAgaWYgKHRleHQtPmxlbmd0aCgpKQotICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwotICAgIH0KLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gbV9pbnB1 dFR5cGUtPmlzRW1wdHlWYWx1ZSgpOwogfQogCiB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNl TWF4TGVuZ3RoQXR0cmlidXRlKGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWUpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0lucHV0VHlwZS5jcHAKaW5kZXggYWNhZWM3NWZiMmE4MWUzNGFmMGZlZGI2OGY2MjVlNmUxZjRk ZDRkYy4uODBiNDlmZWFlNjNlMWNhNzhkYmYzNzliMjI0ZmZiZDg4NjIyZjJjMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSW5wdXRUeXBlLmNwcApAQCAtNzE3LDYgKzcxNywxMSBAQCBTdHJpbmcgSW5wdXRUeXBl Ojp2aXNpYmxlVmFsdWUoKSBjb25zdAogICAgIHJldHVybiBlbGVtZW50KCkudmFsdWUoKTsKIH0K IAorYm9vbCBJbnB1dFR5cGU6OmlzRW1wdHlWYWx1ZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIHRy dWU7Cit9CisKIFN0cmluZyBJbnB1dFR5cGU6OnNhbml0aXplVmFsdWUoY29uc3QgU3RyaW5nJiBw cm9wb3NlZFZhbHVlKSBjb25zdAogewogICAgIHJldHVybiBwcm9wb3NlZFZhbHVlOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSW5wdXRUeXBlLmgKaW5kZXggMTdkMTI1Mzc5NWFlM2VkZjU5ODgyNzY3MmZiMDcyOGM3ZGVi MWNjNS4uNzMyZWRlY2JlYzBkZjcyMjg3MTIwNzM4MDFlMjA5YjgxOTg5ODFhYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0lucHV0VHlwZS5oCkBAIC0xNzQsNiArMTc0LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwg Ym9vbCBjYW5TZXRTdHJpbmdWYWx1ZSgpIGNvbnN0OwogICAgIHZpcnR1YWwgU3RyaW5nIGxvY2Fs aXplVmFsdWUoY29uc3QgU3RyaW5nJikgY29uc3Q7CiAgICAgdmlydHVhbCBTdHJpbmcgdmlzaWJs ZVZhbHVlKCkgY29uc3Q7CisgICAgdmlydHVhbCBib29sIGlzRW1wdHlWYWx1ZSgpIGNvbnN0Owog ICAgIC8vIFJldHVyaW5nIHRoZSBudWxsIHN0cmluZyBtZWFucyAidXNlIHRoZSBkZWZhdWx0IHZh bHVlLiIKICAgICAvLyBUaGlzIGZ1bmN0aW9uIG11c3QgYmUgY2FsbGVkIG9ubHkgYnkgSFRNTElu cHV0RWxlbWVudDo6c2FuaXRpemVWYWx1ZSgpLgogICAgIHZpcnR1YWwgU3RyaW5nIHNhbml0aXpl VmFsdWUoY29uc3QgU3RyaW5nJikgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVs ZElucHV0VHlwZS5jcHAKaW5kZXggOGE5MjU4ZThhOWY5MDNjODkyMDIwMjEwOWRhNTZmZDEyYjUy ZWNiYi4uOGIyZWU1YTRjYjJmZDMyMjk0NWU3MWMwMjNjNWE3NmExZDMyYjQ5NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcApAQCAtNTEsNiArNTEsNyBAQAog I2luY2x1ZGUgIlRleHRDb250cm9sSW5uZXJFbGVtZW50cy5oIgogI2luY2x1ZGUgIlRleHRFdmVu dC5oIgogI2luY2x1ZGUgIlRleHRJdGVyYXRvci5oIgorI2luY2x1ZGUgIlRleHROb2RlVHJhdmVy c2FsLmgiCiAjaW5jbHVkZSAiV2hlZWxFdmVudC5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBA IC04Nyw2ICs4OCwxOCBAQCBib29sIFRleHRGaWVsZElucHV0VHlwZTo6aXNUZXh0RmllbGQoKSBj b25zdAogICAgIHJldHVybiB0cnVlOwogfQogCitib29sIFRleHRGaWVsZElucHV0VHlwZTo6aXNF bXB0eVZhbHVlKCkgY29uc3QKK3sKKyAgICBUZXh0Q29udHJvbElubmVyVGV4dEVsZW1lbnQqIGlu bmVyVGV4dCA9IGlubmVyVGV4dEVsZW1lbnQoKTsKKyAgICBBU1NFUlQoaW5uZXJUZXh0KTsKKwor ICAgIGZvciAoVGV4dCogdGV4dCA9IFRleHROb2RlVHJhdmVyc2FsOjpmaXJzdFdpdGhpbihpbm5l clRleHQpOyB0ZXh0OyB0ZXh0ID0gVGV4dE5vZGVUcmF2ZXJzYWw6Om5leHQodGV4dCwgaW5uZXJU ZXh0KSkgeworICAgICAgICBpZiAodGV4dC0+bGVuZ3RoKCkpCisgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQorICAgIHJldHVybiB0cnVlOworfQorCiBib29sIFRleHRGaWVsZElucHV0 VHlwZTo6dmFsdWVNaXNzaW5nKGNvbnN0IFN0cmluZyYgdmFsdWUpIGNvbnN0CiB7CiAgICAgcmV0 dXJuIGVsZW1lbnQoKS5pc1JlcXVpcmVkKCkgJiYgdmFsdWUuaXNFbXB0eSgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuaCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmgKaW5kZXggYzJhODI2MTJlMWFiZmIyZjE3Mzg0 YzhkYjE2YjMyZGZkZTI1NjMyNy4uNGYwZTZmNmViNzUwZTNhMmFiMTFiNGJhNmMzMDQxNGIxNjEw YjE1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5oCkBAIC04MCw2 ICs4MCw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIGlzS2V5Ym9hcmRGb2N1c2FibGUo S2V5Ym9hcmRFdmVudCopIGNvbnN0IG92ZXJyaWRlIGZpbmFsOwogICAgIHZpcnR1YWwgYm9vbCBp c01vdXNlRm9jdXNhYmxlKCkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CiAgICAgdmlydHVhbCBib29s IGlzVGV4dEZpZWxkKCkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CisgICAgdmlydHVhbCBib29sIGlz RW1wdHlWYWx1ZSgpIGNvbnN0IG92ZXJyaWRlIGZpbmFsOwogICAgIHZpcnR1YWwgYm9vbCB2YWx1 ZU1pc3NpbmcoY29uc3QgU3RyaW5nJikgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CiAgICAgdmlydHVh bCB2b2lkIGhhbmRsZUJlZm9yZVRleHRJbnNlcnRlZEV2ZW50KEJlZm9yZVRleHRJbnNlcnRlZEV2 ZW50Kikgb3ZlcnJpZGUgZmluYWw7CiAgICAgdmlydHVhbCB2b2lkIGZvcndhcmRFdmVudChFdmVu dCopIG92ZXJyaWRlIGZpbmFsOwo=