138531 2014-11-07 18:12:24 -0800 Fix Ember.js warnings in the new perf dashboard UI 2016-02-16 13:53:19 -0800 1 1 1 Unclassified WebKit Perf Dashboard 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 138516 1 rniwa rniwa benjamin cdumez commit-queue kling rniwa oldest_to_newest 1047261 0 rniwa 2014-11-07 18:12:24 -0800 There are a few warnings in the current UI code. Fix that. 1047262 1 241222 rniwa 2014-11-07 18:22:18 -0800 Created attachment 241222 Patch 1047354 2 241222 commit-queue 2014-11-08 19:21:18 -0800 Comment on attachment 241222 Patch Clearing flags on attachment: 241222 Committed r175786: <http://trac.webkit.org/changeset/175786> 1047355 3 commit-queue 2014-11-08 19:21:22 -0800 All reviewed patches have been landed. Closing bug. 241222 2014-11-07 18:22:18 -0800 2014-11-08 19:21:18 -0800 Patch bug-138531-20141107182725.patch text/plain 5065 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTc1NzcyKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE0LTExLTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEZpeCBFbWJlci5qcyB3YXJuaW5ncyB0aGUgbmV3IHBlcmYgZGFzaGJvYXJkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg1MzEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB2YXJp b3VzIHdhcm5pbmdzLgorCisgICAgICAgICogcHVibGljL3YyL2FwcC5qczoKKyAgICAgICAgKEFw cC5JbnRlcmFjdGl2ZUNoYXJ0Q29tcG9uZW50Ll9yZWxheW91dERhdGFBbmRBeGVzKTogV2UgY2Fu J3QgdXNlICJyZW0iLiBVc2UgdGhpcy5fcmVtIGFzIGRvbmUgZm9yIHguCisgICAgICAgICogcHVi bGljL3YyL2RhdGEuanM6CisgICAgICAgIChQcml2aWxlZ2VkQVBJLl9wb3N0KTogUmVtb3ZlZCB0 aGUgc3VwZXJmbHVvdXMgY29uc29sZS5sb2cuCisgICAgICAgIChDb21taXRMb2dzLmZldGNoRm9y VGltZVJhbmdlKTogRGl0dG8uCisgICAgICAgICogcHVibGljL3YyL2luZGV4Lmh0bWw6IEFkZGVk IHRib2R5IGFzIHJlcXVpcmVkIGJ5IHRoZSBIVE1MIHNwZWNpZmljYXRpb24uCisKIDIwMTQtMTEt MDcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHR5cG9z IGluIHIxNzU3NjguCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2Fw cC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2Fw cC5qcwkocmV2aXNpb24gMTc1NzY5KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92Mi9hcHAuanMJKHdvcmtpbmcgY29weSkKQEAgLTExNTgsNyArMTE1OCw3IEBAIEFwcC5JbnRl cmFjdGl2ZUNoYXJ0Q29tcG9uZW50ID0gRW1iZXIuQ28KICAgICAgICAgdGhpcy5feUF4aXNVbml0 Q29udGFpbmVyID0gdGhpcy5feUF4aXNMYWJlbHMuYXBwZW5kKCJ0ZXh0IikKICAgICAgICAgICAg IC5hdHRyKCJ4IiwgMC41ICogdGhpcy5fcmVtKQogICAgICAgICAgICAgLmF0dHIoInkiLCB0aGlz Ll9yZW0pCi0gICAgICAgICAgICAuYXR0cigiZHkiLCAnMC44cmVtJykKKyAgICAgICAgICAgIC5h dHRyKCJkeSIsIDAuOCAqIHRoaXMuX3JlbSkKICAgICAgICAgICAgIC5zdHlsZSgidGV4dC1hbmNo b3IiLCAic3RhcnQiKQogICAgICAgICAgICAgLnN0eWxlKCJ6LWluZGV4IiwgIjEwMCIpCiAgICAg ICAgICAgICAudGV4dCh0aGlzLl95QXhpc1VuaXQpOwpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJr aXQub3JnL3B1YmxpYy92Mi9kYXRhLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3BlcmYud2Vi a2l0Lm9yZy9wdWJsaWMvdjIvZGF0YS5qcwkocmV2aXNpb24gMTc1NzY4KQorKysgV2Vic2l0ZXMv cGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9kYXRhLmpzCSh3b3JraW5nIGNvcHkpCkBAIC00NCw4 ICs0NCw3IEBAIFByaXZpbGVnZWRBUEkuX3Bvc3QgPSBmdW5jdGlvbiAodXJsLCBwYXIKICAgICAg ICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICByZXNvbHZlKGRhdGEpOwogICAgICAgICB9KS5m YWlsKGZ1bmN0aW9uICh4aHIsIHN0YXR1cywgZXJyb3IpIHsKLSAgICAgICAgICAgIGNvbnNvbGUu bG9nKHhocik7Ci0gICAgICAgICAgICByZWplY3QoeGhyLnN0YXR1cyArIChlcnJvciA/ICcsICcg KyBlcnJvciA6ICcnKSk7CisgICAgICAgICAgICByZWplY3QoeGhyLnN0YXR1cyArIChlcnJvciA/ ICcsICcgKyBlcnJvciA6ICcnKSArICdcblxuV2l0aCByZXNwb25zZTpcbicgKyB4aHIucmVzcG9u c2VUZXh0KTsKICAgICAgICAgfSk7CiAgICAgfSk7CiB9CkBAIC03Nyw4ICs3Niw2IEBAIENvbW1p dExvZ3MuZmV0Y2hGb3JUaW1lUmFuZ2UgPSBmdW5jdGlvbiAKICAgICAgICAgICAgIHJldHVybiBu ZXcgRW1iZXIuUlNWUC5Qcm9taXNlKGZ1bmN0aW9uIChyZXNvbHZlKSB7IHJlc29sdmUoY2FjaGVk Q29tbWl0c0ZvclJhbmdlKTsgfSk7CiAgICAgfQogCi0gICAgY29uc29sZS5sb2coJ0ZlY3RoaW5n ICcgKyB1cmwpOwotCiAgICAgcmV0dXJuIG5ldyBFbWJlci5SU1ZQLlByb21pc2UoZnVuY3Rpb24g KHJlc29sdmUsIHJlamVjdCkgewogICAgICAgICAkLmdldEpTT04odXJsLCBmdW5jdGlvbiAoZGF0 YSkgewogICAgICAgICAgICAgaWYgKGRhdGEuc3RhdHVzICE9ICdPSycpIHsKSW5kZXg6IFdlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvaW5kZXguaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2luZGV4Lmh0bWwJKHJldmlzaW9uIDE3 NTc2OCkKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvaW5kZXguaHRtbAko d29ya2luZyBjb3B5KQpAQCAtMTk2LDI0ICsxOTYsMjYgQEAKIAogICAgICAgICAgICAgICAgIDxk aXYge3tiaW5kLWF0dHIgY2xhc3M9IjpidWdzLXBhbmUgc2hvd2luZ0J1Z3NQYW5lOjpoaWRkZW4i fX0+CiAgICAgICAgICAgICAgICAgICAgIDx0YWJsZT4KLSAgICAgICAgICAgICAgICAgICAgICAg IHt7I2lmIHNlbGVjdGVkU2luZ2xlUG9pbnR9fQotICAgICAgICAgICAgICAgICAgICAgICAgICAg IHt7I2VhY2ggZGV0YWlscy5idWdUcmFja2Vyc319Ci0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDx0cj4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDx0aD57e2xh YmVsfX08L3RoPgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPHRkPgotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDxmb3JtIHt7YWN0aW9uICJhc3Nv Y2lhdGVCdWciIHRoaXMgZWRpdGVkQnVnTnVtYmVyIG9uPSJzdWJtaXQifX0+Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHt7aW5wdXQgdHlwZT10ZXh0IHZhbHVl PWVkaXRlZEJ1Z051bWJlcn19Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgPC9mb3JtPgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPC90ZD4KLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPC90cj4KLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICB7ey9lYWNofX0KLSAgICAgICAgICAgICAgICAgICAgICAgIHt7L2lmfX0KLSAgICAg ICAgICAgICAgICAgICAgICAgIDx0cj4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICA8dGg+ Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDxsYWJlbD5OYW1lOiB7e2lucHV0IHR5 cGU9dGV4dCB2YWx1ZT1uZXdBbmFseXNpc1Rhc2tOYW1lfX08L2xhYmVsPgotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICA8YnV0dG9uIHt7YWN0aW9uICJjcmVhdGVBbmFseXNpc1Rhc2si fX0+QW5hbHl6ZTwvYnV0dG9uPgotICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwvdGg+Ci0g ICAgICAgICAgICAgICAgICAgICAgICA8L3RyPgorICAgICAgICAgICAgICAgICAgICAgICAgPHRi b2R5PgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIHt7I2lmIHNlbGVjdGVkU2luZ2xlUG9p bnR9fQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB7eyNlYWNoIGRldGFpbHMuYnVn VHJhY2tlcnN9fQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPHRyPgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDx0aD57e2xhYmVsfX08L3RoPgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDx0ZD4KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPGZvcm0ge3thY3Rpb24gImFzc29jaWF0 ZUJ1ZyIgdGhpcyBlZGl0ZWRCdWdOdW1iZXIgb249InN1Ym1pdCJ9fT4KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHt7aW5wdXQgdHlwZT10ZXh0IHZhbHVl PWVkaXRlZEJ1Z051bWJlcn19CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDwvZm9ybT4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8 L3RkPgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPC90cj4KKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAge3svZWFjaH19CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAge3svaWZ9fQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIDx0cj4KKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgPHRoPgorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgPGxhYmVsPk5hbWU6IHt7aW5wdXQgdHlwZT10ZXh0IHZhbHVlPW5ld0FuYWx5c2lz VGFza05hbWV9fTwvbGFiZWw+CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8 YnV0dG9uIHt7YWN0aW9uICJjcmVhdGVBbmFseXNpc1Rhc2sifX0+QW5hbHl6ZTwvYnV0dG9uPgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8L3RoPgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIDwvdHI+CisgICAgICAgICAgICAgICAgICAgICAgICA8L3Rib2R5PgogICAgICAg ICAgICAgICAgICAgICA8L3RhYmxlPgogICAgICAgICAgICAgICAgIDwvZGl2PgogCg==