138528 2014-11-07 17:15:37 -0800 Delete cookies between tests 2014-11-08 19:17:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap cdumez commit-queue psolanki oldest_to_newest 1047253 0 ap 2014-11-07 17:15:37 -0800 We should start each test from a clean state, so that there is never a dependency on test order. Most of the time, tests clean up after themselves, and they should continue doing this so that they could be run from a browser. But it's been too often that leaking cookies caused test flakiness, it's time to stop that for good. 1047254 1 241221 ap 2014-11-07 17:19:43 -0800 Created attachment 241221 proposed fix 1047348 2 241221 commit-queue 2014-11-08 19:17:07 -0800 Comment on attachment 241221 proposed fix Clearing flags on attachment: 241221 Committed r175783: <http://trac.webkit.org/changeset/175783> 1047349 3 commit-queue 2014-11-08 19:17:18 -0800 All reviewed patches have been landed. Closing bug. 241221 2014-11-07 17:19:43 -0800 2014-11-08 19:17:07 -0800 proposed fix DeleteAllCookies.txt text/plain 5431 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTc3MSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTExLTA3 ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIERlbGV0ZSBj b29raWVzIGJldHdlZW4gdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzODUyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbTogKCtbV2ViUHJlZmVyZW5j ZXMgX2NsZWFyTmV0d29ya0xvYWRlclNlc3Npb25dKToKKyAgICAgICAgKiBXZWJWaWV3L1dlYlBy ZWZlcmVuY2VzUHJpdmF0ZS5oOgorICAgICAgICBBZGRlZCBhbiBTUEkgZm9yIER1bXBSZW5kZXJU cmVlLgorCiAyMDE0LTExLTA3ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29t PgogCiAgICAgICAgIFtpT1NdIFVwZGF0ZSBvcHRpbWl6ZWQgZnVsbHNjcmVlbiBtZWRpYSBjb250 cm9scwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1t CShyZXZpc2lvbiAxNzU0NzcpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZl cmVuY2VzLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00Myw2ICs0Myw3IEBACiAjaW1wb3J0IDxXZWJD b3JlL0FwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0F1ZGlvU2Vz c2lvbi5oPgogI2ltcG9ydCA8V2ViQ29yZS9OZXR3b3JrU3RvcmFnZVNlc3Npb24uaD4KKyNpbXBv cnQgPFdlYkNvcmUvUGxhdGZvcm1Db29raWVKYXIuaD4KICNpbXBvcnQgPFdlYkNvcmUvUmVzb3Vy Y2VIYW5kbGUuaD4KICNpbXBvcnQgPFdlYkNvcmUvVGV4dEVuY29kaW5nUmVnaXN0cnkuaD4KICNp bXBvcnQgPHJ1bnRpbWUvSW5pdGlhbGl6ZVRocmVhZGluZy5oPgpAQCAtMTczMiw2ICsxNzMzLDEx IEBAICsgKHZvaWQpX3N3aXRjaE5ldHdvcmtMb2FkZXJUb05ld1Rlc3RpbmcKICAgICBOZXR3b3Jr U3RvcmFnZVNlc3Npb246OnN3aXRjaFRvTmV3VGVzdGluZ1Nlc3Npb24oKTsKIH0KIAorKyAodm9p ZClfY2xlYXJOZXR3b3JrTG9hZGVyU2Vzc2lvbgoreworICAgIFdlYkNvcmU6OmRlbGV0ZUFsbENv b2tpZXMoTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpkZWZhdWx0U3RvcmFnZVNlc3Npb24oKSk7Cit9 CisKICsgKHZvaWQpX3NldEN1cnJlbnROZXR3b3JrTG9hZGVyU2Vzc2lvbkNvb2tpZUFjY2VwdFBv bGljeTooTlNIVFRQQ29va2llQWNjZXB0UG9saWN5KXBvbGljeQogewogICAgIFdLU2V0SFRUUENv b2tpZUFjY2VwdFBvbGljeShOZXR3b3JrU3RvcmFnZVNlc3Npb246OmRlZmF1bHRTdG9yYWdlU2Vz c2lvbigpLmNvb2tpZVN0b3JhZ2UoKS5nZXQoKSwgcG9saWN5KTsKSW5kZXg6IFNvdXJjZS9XZWJL aXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlc1ByaXZhdGUuaAkocmV2aXNpb24g MTc1NDc3KQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlc1ByaXZh dGUuaAkod29ya2luZyBjb3B5KQpAQCAtMzE0LDYgKzMxNCw3IEBAIEBpbnRlcmZhY2UgV2ViUHJl ZmVyZW5jZXMgKFdlYlByaXZhdGUpCiAvLyBGb3IgRHVtcFJlbmRlclRyZWUgdXNlIG9ubHkuCiAr ICh2b2lkKV9zd2l0Y2hOZXR3b3JrTG9hZGVyVG9OZXdUZXN0aW5nU2Vzc2lvbjsKICsgKHZvaWQp X3NldEN1cnJlbnROZXR3b3JrTG9hZGVyU2Vzc2lvbkNvb2tpZUFjY2VwdFBvbGljeTooTlNIVFRQ Q29va2llQWNjZXB0UG9saWN5KWNvb2tpZUFjY2VwdFBvbGljeTsKKysgKHZvaWQpX2NsZWFyTmV0 d29ya0xvYWRlclNlc3Npb247CiAKICsgKHZvaWQpc2V0V2ViS2l0TGlua1RpbWVWZXJzaW9uOihp bnQpdmVyc2lvbjsKIApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0NoYW5nZUxvZwkocmV2aXNpb24gMTc1NzcxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTQtMTEtMDcgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgRGVsZXRlIGNvb2tpZXMgYmV0d2VlbiB0ZXN0cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NTI4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAgICAgIChyZXNldFdlYlByZWZlcmVu Y2VzVG9Db25zaXN0ZW50VmFsdWVzKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RD b250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OnJlc2V0UHJlZmVy ZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMpOgorICAgICAgICBEbyBpdC4KKworICAgICAgICAqIFdl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgorICAgICAg ICAoV1RSOjpJbmplY3RlZEJ1bmRsZTo6YmVnaW5UZXN0aW5nKToKKyAgICAgICAgQWRkZWQgYSBG SVhNRS4KKwogMjAxNC0xMS0wNiAgSmFrZSBOaWVsc2VuICA8amFjb2JfbmllbHNlbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIGR1cGxpY2F0ZSBjb2RlIGZyb20gUGF0Y2hBbmFseXNpc1Rh c2suX3Rlc3RfcGF0Y2ggYW5kIGZpeCBidWcKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL21h Yy9EdW1wUmVuZGVyVHJlZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9t YWMvRHVtcFJlbmRlclRyZWUubW0JKHJldmlzaW9uIDE3NTQ3NykKKysrIFRvb2xzL0R1bXBSZW5k ZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQkod29ya2luZyBjb3B5KQpAQCAtODk5LDYgKzg5 OSw3IEBAIHN0YXRpYyB2b2lkIHJlc2V0V2ViUHJlZmVyZW5jZXNUb0NvbnNpc3QKICAgICBbcHJl ZmVyZW5jZXMgc2V0TWVkaWFTb3VyY2VFbmFibGVkOllFU107CiAjZW5kaWYKIAorICAgIFtXZWJQ cmVmZXJlbmNlcyBfY2xlYXJOZXR3b3JrTG9hZGVyU2Vzc2lvbl07CiAgICAgW1dlYlByZWZlcmVu Y2VzIF9zZXRDdXJyZW50TmV0d29ya0xvYWRlclNlc3Npb25Db29raWVBY2NlcHRQb2xpY3k6TlNI VFRQQ29va2llQWNjZXB0UG9saWN5T25seUZyb21NYWluRG9jdW1lbnREb21haW5dOwogfQogCklu ZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAkocmV2aXNpb24g MTc1NDc3KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKICNpbmNsdWRlIDxXZWJLaXQvV0tBdXRoZW50 aWNhdGlvbkRlY2lzaW9uTGlzdGVuZXIuaD4KICNpbmNsdWRlIDxXZWJLaXQvV0tDb250ZXh0Q29u ZmlndXJhdGlvblJlZi5oPgogI2luY2x1ZGUgPFdlYktpdC9XS0NvbnRleHRQcml2YXRlLmg+Cisj aW5jbHVkZSA8V2ViS2l0L1dLQ29va2llTWFuYWdlci5oPgogI2luY2x1ZGUgPFdlYktpdC9XS0Ny ZWRlbnRpYWwuaD4KICNpbmNsdWRlIDxXZWJLaXQvV0tJY29uRGF0YWJhc2UuaD4KICNpbmNsdWRl IDxXZWJLaXQvV0tOb3RpZmljYXRpb24uaD4KQEAgLTU4OCw3ICs1ODksOSBAQCB2b2lkIFRlc3RD b250cm9sbGVyOjpyZXNldFByZWZlcmVuY2VzVG9DCiAjZW5kaWYKIAogICAgIFdLUHJlZmVyZW5j ZXNTZXRBY2NlbGVyYXRlZERyYXdpbmdFbmFibGVkKHByZWZlcmVuY2VzLCBtX3Nob3VsZFVzZUFj Y2VsZXJhdGVkRHJhd2luZyk7Ci0gICAgCisKKyAgICBXS0Nvb2tpZU1hbmFnZXJEZWxldGVBbGxD b29raWVzKFdLQ29udGV4dEdldENvb2tpZU1hbmFnZXIobV9jb250ZXh0LmdldCgpKSk7CisKICAg ICBwbGF0Zm9ybVJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMoKTsKIH0KIApJbmRl eDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9J bmplY3RlZEJ1bmRsZS5jcHAJKHJldmlzaW9uIDE3NTQ3NykKKysrIFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNTQsNyArMjU0LDcgQEAgdm9pZCBJbmplY3RlZEJ1bmRsZTo6YmVnaW5UZXN0aW5nKFdLRGlj dAogICAgIFdLQnVuZGxlU2V0QWxsb3dGaWxlQWNjZXNzRnJvbUZpbGVVUkxzKG1fYnVuZGxlLCBt X3BhZ2VHcm91cCwgdHJ1ZSk7CiAgICAgV0tCdW5kbGVTZXRQbHVnaW5zRW5hYmxlZChtX2J1bmRs ZSwgbV9wYWdlR3JvdXAsIHRydWUpOwogICAgIFdLQnVuZGxlU2V0UG9wdXBCbG9ja2luZ0VuYWJs ZWQobV9idW5kbGUsIG1fcGFnZUdyb3VwLCBmYWxzZSk7Ci0gICAgV0tCdW5kbGVTZXRBbHdheXNB Y2NlcHRDb29raWVzKG1fYnVuZGxlLCBmYWxzZSk7CisgICAgV0tCdW5kbGVTZXRBbHdheXNBY2Nl cHRDb29raWVzKG1fYnVuZGxlLCBmYWxzZSk7IC8vIEZJWE1FOiBEbyB0aGlzIGZyb20gVUkgcHJv Y2Vzcywgc28gdGhhdCBOZXR3b3JraW5nIHByb2Nlc3MgZ2V0cyB0aGUgcHJlZmVyZW5jZSwgdG9v LgogICAgIFdLQnVuZGxlU2V0U2VyaWFsTG9hZGluZ0VuYWJsZWQobV9idW5kbGUsIGZhbHNlKTsK ICAgICBXS0J1bmRsZVNldENhY2hlTW9kZWwobV9idW5kbGUsIDEgLypDYWNoZU1vZGVsRG9jdW1l bnRCcm93c2VyKi8pOwogCg==