138526 2014-11-07 16:09:39 -0800 Directional single quotation marks are not rotated in vertical text 2014-12-05 21:13:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield buildbot commit-queue dino enrica jonlee rniwa simon.fraser thorton webkit-bug-importer oldest_to_newest 1047239 0 mmaxfield 2014-11-07 16:09:39 -0800 Directional single quotation marks are not rotated in vertical text 1047240 1 241217 mmaxfield 2014-11-07 16:10:56 -0800 Created attachment 241217 Patch 1047241 2 mmaxfield 2014-11-07 16:11:50 -0800 <rdar://problem/14393598> 1047308 3 241217 darin 2014-11-08 13:39:31 -0800 Comment on attachment 241217 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241217&action=review > Source/WebCore/platform/graphics/FontGlyphs.cpp:149 > + if (character == 0x02016 || character == 0x02020 || character == 0x02021 || character == 0x2030 || character == 0x02031) > return true; Strange that we write 0x2030 and not 0x02030 here given the rest of the surrounding code. This entire function has a coding style that is not great. A whole long data table written out as separate function calls, with no rationale given for the choices of the values or even a summary at the top. Did this come from some table in some specification? Does ICU have a function for this, and if so, why aren’t we using that? 1047389 4 241217 mmaxfield 2014-11-09 08:05:44 -0800 Comment on attachment 241217 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241217&action=review >> Source/WebCore/platform/graphics/FontGlyphs.cpp:149 >> return true; > > Strange that we write 0x2030 and not 0x02030 here given the rest of the surrounding code. > > This entire function has a coding style that is not great. A whole long data table written out as separate function calls, with no rationale given for the choices of the values or even a summary at the top. Did this come from some table in some specification? Does ICU have a function for this, and if so, why aren’t we using that? Yes: http://www.unicode.org/reports/tr50/tr50-6.Orientation.txt The numbers in this function originally came from a giant switch statement; I'm guessing the leading 0s existed to make the case statements right-aligned. I looked for an ICU function, but couldn't find one. I emailed Kida-san last week to ask if he knows of one. 1052974 5 241217 commit-queue 2014-12-05 21:13:41 -0800 Comment on attachment 241217 Patch Clearing flags on attachment: 241217 Committed r176903: <http://trac.webkit.org/changeset/176903> 1052975 6 commit-queue 2014-12-05 21:13:47 -0800 All reviewed patches have been landed. Closing bug. 241217 2014-11-07 16:10:56 -0800 2014-12-05 21:13:41 -0800 Patch bug-138526-20141107161107.patch text/plain 3794 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2VlZTAxNDI5MzRiYWI0 ZDk4YzhkM2QyODk3NTkwY2IxYjEzYmU4Yi4uYTBjNjBkODA2MmYzODk5M2NiZGQ2NmViN2FkNjEy MjZlMWRjMWU0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTExLTA3ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgRGlyZWN0aW9u YWwgc2luZ2xlIHF1b3RhdGlvbiBtYXJrcyBhcmUgbm90IHJvdGF0ZWQgaW4gdmVydGljYWwgdGV4 dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NTI2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdmVy dGljYWwgdGV4dCwgZGlyZWN0aW9uYWwgc2luZ2xlIHF1b3RhdGlvbiBtYXJrcyBhcmUgbm90IHJv dGF0ZWQgYWxvbmcgd2l0aAorICAgICAgICB0aGUgcmVzdCBvZiB0aGUgbGV0dGVycy4KKworICAg ICAgICBUZXN0OiBmYXN0L3RleHQvdmVydGljYWwtcXVvdGF0aW9uLW1hcmtzLmh0bWwKKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRHbHlwaHMuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6c2hvdWxkSWdub3JlUm90YXRpb24pOgorCiAyMDE0LTExLTA3ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUHNldWRvIGVs ZW1lbnQgbWF0Y2hlZENTU1J1bGVzIGRvIG5vdCBpbmNsdWRlIG1hdGNoaW5nIHNlbGVjdG9yIGlu Zm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRHbHlw aHMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEdseXBocy5jcHAK aW5kZXggMzMzMGIyM2UwNmZmZTU2ZDQ1NTg4ZmE2YzlhZmQ5MjYxZjFlNDgyOC4uOTMyMTYzNWZj ZGFmZjBlNjZjZjRiMTQyMmM1OGQ4ZTdkN2RiYzM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEdseXBocy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvRm9udEdseXBocy5jcHAKQEAgLTE0NSw4ICsxNDUsNyBAQCBzdGF0 aWMgYm9vbCBzaG91bGRJZ25vcmVSb3RhdGlvbihVQ2hhcjMyIGNoYXJhY3RlcikKICAgICBpZiAo aXNJblJhbmdlKGNoYXJhY3RlciwgMHgwMTEwMCwgMHgwMTFGRikgfHwgaXNJblJhbmdlKGNoYXJh Y3RlciwgMHgwMTQwMSwgMHgwMTY3RikgfHwgaXNJblJhbmdlKGNoYXJhY3RlciwgMHgwMTgwMCwg MHgwMThGRikpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAgaWYgKGNoYXJhY3RlciA9PSAw eDAyMDE2IHx8IGNoYXJhY3RlciA9PSAweDAyMDE4IHx8IGNoYXJhY3RlciA9PSAweDAyMDE5IHx8 IGNoYXJhY3RlciA9PSAweDAyMDIwIHx8IGNoYXJhY3RlciA9PSAweDAyMDIxCi0gICAgICAgIHx8 IGNoYXJhY3RlciA9PSAweDIwMzAgfHwgY2hhcmFjdGVyID09IDB4MDIwMzEpCisgICAgaWYgKGNo YXJhY3RlciA9PSAweDAyMDE2IHx8IGNoYXJhY3RlciA9PSAweDAyMDIwIHx8IGNoYXJhY3RlciA9 PSAweDAyMDIxIHx8IGNoYXJhY3RlciA9PSAweDIwMzAgfHwgY2hhcmFjdGVyID09IDB4MDIwMzEp CiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgaWYgKGlzSW5SYW5nZShjaGFyYWN0ZXIsIDB4 MDIwM0IsIDB4MDIwM0QpIHx8IGNoYXJhY3RlciA9PSAweDAyMDQyIHx8IGNoYXJhY3RlciA9PSAw eDAyMDQ0IHx8IGNoYXJhY3RlciA9PSAweDAyMDQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTQwYmVkYTcxYzYxMDkyZDg0 OGQ3ZDczYzQ4NjQzYjQzMDk5YTE1ZC4uZDg2NjhiMDUwNjA3MjJjNDQ5MjdjZWYwNzE0MWYyYTdm NGFkMmZmYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTA3ICBNeWxlcyBDLiBNYXhm aWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgRGlyZWN0aW9uYWwgc2luZ2xl IHF1b3RhdGlvbiBtYXJrcyBhcmUgbm90IHJvdGF0ZWQgaW4gdmVydGljYWwgdGV4dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NTI2CisKKyAgICAg ICAgQ29tcGFyZSB2ZXJ0aWNhbCBhbmQgaG9yaXpvbnRhbCByZW5kZXJpbmdzLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC90ZXh0L3ZlcnRp Y2FsLXF1b3RhdGlvbi1tYXJrcy1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L3RleHQvdmVydGljYWwtcXVvdGF0aW9uLW1hcmtzLmh0bWw6IEFkZGVkLgorCiAyMDE0LTExLTA3 ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogUHNldWRvIGVsZW1lbnQgbWF0Y2hlZENTU1J1bGVzIGRvIG5vdCBpbmNsdWRlIG1h dGNoaW5nIHNlbGVjdG9yIGluZm8KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC92 ZXJ0aWNhbC1xdW90YXRpb24tbWFya3MtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv dGV4dC92ZXJ0aWNhbC1xdW90YXRpb24tbWFya3MtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44 NGJlNTVkZTEzZTg3OTBkYTgxMjFlOWM2MjEyNGQyMTA2ZTY1OGVjCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3ZlcnRpY2FsLXF1b3RhdGlvbi1tYXJrcy1leHBlY3Rl ZC5odG1sCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KzwvaGVhZD4KKzxib2R5PgorPGRpdiBzdHlsZT0ibGluZS1oZWlnaHQ6IDUwcHg7IC13ZWJraXQt dHJhbnNmb3JtLW9yaWdpbjogbGVmdCBib3R0b207IC13ZWJraXQtdHJhbnNmb3JtOiByb3RhdGUo OTBkZWcpIHRyYW5zbGF0ZVgoLTUwcHgpOyBkaXNwbGF5OiBpbmxpbmUtYmxvY2siPgorV2hhdCYj eDIwMTk7cyBnb2luZyYjeDIwMTg7IG9uPworPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWwKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC92ZXJ0aWNhbC1xdW90YXRpb24tbWFya3MuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC92ZXJ0aWNhbC1xdW90YXRpb24tbWFya3MuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4wMzY2MzUwMTFiODMxMjhjYWUzZDUzNzYyYzk4NjI2YmQyMjUzNDY2Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3ZlcnRpY2FsLXF1b3RhdGlvbi1t YXJrcy5odG1sCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVh ZD4KKzwvaGVhZD4KKzxib2R5PgorPGRpdiBzdHlsZT0ibGluZS1oZWlnaHQ6IDUwcHg7IC13ZWJr aXQtd3JpdGluZy1tb2RlOnZlcnRpY2FsLXJsOyI+CitXaGF0JiN4MjAxOTtzIGdvaW5nJiN4MjAx ODsgb24/Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbAo=