138510 2014-11-07 11:42:57 -0800 Fix an alignment issue with operationPushCatchScope on ARMv7 2014-11-08 03:03:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 138254 108645 0 dbatyai.u-szeged webkit-unassigned commit-queue msaboff ossy oldest_to_newest 1047133 0 dbatyai.u-szeged 2014-11-07 11:42:57 -0800 A previous patch caused a regression on some ARMv7 platforms. Call arguments were set up differently than how the callee expected them. 1047134 1 241196 dbatyai.u-szeged 2014-11-07 11:47:10 -0800 Created attachment 241196 Patch 1047142 2 241196 ossy 2014-11-07 12:18:02 -0800 Comment on attachment 241196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241196&action=review r=me , but CQ-, because it depends on bug138254 > Source/JavaScriptCore/jit/JITInlines.h:586 > - setupArgumentsWithExecState(TrustedImm32(op1), TrustedImmPtr(identOp2), regOp3Payload, regOp3Tag, TrustedImm32(op4)); > + setupArgumentsWithExecState(TrustedImm32(op1), TrustedImmPtr(identOp2), EABI_32BIT_DUMMY_ARG regOp3Payload, regOp3Tag, TrustedImm32(op4)); Good catch, ARM EABI doesn't like splitting the 64 bit sized JSValue to r3 and stack. 1047220 3 241196 commit-queue 2014-11-07 15:36:20 -0800 Comment on attachment 241196 Patch Clearing flags on attachment: 241196 Committed r175766: <http://trac.webkit.org/changeset/175766> 1047221 4 commit-queue 2014-11-07 15:36:23 -0800 All reviewed patches have been landed. Closing bug. 241196 2014-11-07 11:47:10 -0800 2014-11-07 15:36:20 -0800 Patch patch.patch text/plain 3020 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJlNjc1MzMuLjRiOWMyNDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTA3ICBEw6FuaWVsIELDoXR5 YWkgIDxkYmF0eWFpLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4 IGFuIGFsaWdubWVudCBpc3N1ZSB3aXRoIG9wZXJhdGlvblB1c2hDYXRjaFNjb3BlIG9uIEFSTXY3 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg1MTAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9D Q2FsbEhlbHBlcnMuaDoKKyAgICAgICAgKEpTQzo6Q0NhbGxIZWxwZXJzOjpzZXR1cEFyZ3VtZW50 c1dpdGhFeGVjU3RhdGUpOgorICAgICAgICAqIGppdC9KSVRJbmxpbmVzLmg6CisgICAgICAgIChK U0M6OkpJVDo6Y2FsbE9wZXJhdGlvbik6CisKIDIwMTQtMTEtMDEgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04oQ01ha2UpOiBN YWtlIGl0IHBvc3NpYmxlIHRvIGJ1aWxkIHdpdGhvdXQgaW50cm9zcGVjdGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9DQ2FsbEhlbHBlcnMuaCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgKaW5kZXggZGRhNmViYS4uMGVkZTdmNCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9DQ2FsbEhlbHBlcnMuaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxsSGVscGVycy5oCkBAIC0xMjk0LDYgKzEyOTQs MTQgQEAgcHVibGljOgogICAgICAgICBtb3ZlKEdQUkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyLCBH UFJJbmZvOjphcmd1bWVudEdQUjApOwogICAgIH0KIAorICAgIEFMV0FZU19JTkxJTkUgdm9pZCBz ZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoVHJ1c3RlZEltbTMyIGFyZzEsIFRydXN0ZWRJbW1Q dHIgYXJnMiwgVHJ1c3RlZEltbTMyIGFyZzMpCisgICAgeworICAgICAgICBtb3ZlKGFyZzMsIEdQ UkluZm86OmFyZ3VtZW50R1BSMyk7CisgICAgICAgIG1vdmUoYXJnMSwgR1BSSW5mbzo6YXJndW1l bnRHUFIxKTsKKyAgICAgICAgbW92ZShhcmcyLCBHUFJJbmZvOjphcmd1bWVudEdQUjIpOworICAg ICAgICBtb3ZlKEdQUkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyLCBHUFJJbmZvOjphcmd1bWVudEdQ UjApOworICAgIH0KKwogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3VtZW50c1dpdGhF eGVjU3RhdGUoVHJ1c3RlZEltbTMyIGFyZzEsIEdQUlJlZyBhcmcyLCBUcnVzdGVkSW1tMzIgYXJn MykKICAgICB7CiAgICAgICAgIG1vdmUoYXJnMiwgR1BSSW5mbzo6YXJndW1lbnRHUFIyKTsKQEAg LTE0MTYsNiArMTQyNCwxNCBAQCBwdWJsaWM6CiAgICAgICAgIHNldHVwQXJndW1lbnRzV2l0aEV4 ZWNTdGF0ZShhcmcxLCBhcmcyLCBhcmczKTsKICAgICB9CiAKKyAgICBBTFdBWVNfSU5MSU5FIHZv aWQgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW0zMiBhcmcxLCBUcnVzdGVk SW1tUHRyIGFyZzIsIFRydXN0ZWRJbW0zMiBhcmczLCBHUFJSZWcgYXJnNCwgR1BSUmVnIGFyZzUs IFRydXN0ZWRJbW0zMiBhcmc2KQorICAgIHsKKyAgICAgICAgcG9rZShhcmc2LCBQT0tFX0FSR1VN RU5UX09GRlNFVCArIDIpOworICAgICAgICBwb2tlKGFyZzUsIFBPS0VfQVJHVU1FTlRfT0ZGU0VU ICsgMSk7CisgICAgICAgIHBva2UoYXJnNCwgUE9LRV9BUkdVTUVOVF9PRkZTRVQpOworICAgICAg ICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJnMyk7CisgICAgfQor CiAgICAgQUxXQVlTX0lOTElORSB2b2lkIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShUcnVz dGVkSW1tUHRyIGFyZzEsIEdQUlJlZyBhcmcyLCBHUFJSZWcgYXJnMywgVHJ1c3RlZEltbTMyIGFy ZzQsIFRydXN0ZWRJbW0zMiBhcmc1KQogICAgIHsKICAgICAgICAgcG9rZShhcmc1LCBQT0tFX0FS R1VNRU5UX09GRlNFVCArIDEpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaApp bmRleCBlOTVkOGI3Li5iNTRhZDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L0pJVElubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGlu ZXMuaApAQCAtNTgzLDcgKzU4Myw3IEBAIEFMV0FZU19JTkxJTkUgTWFjcm9Bc3NlbWJsZXI6OkNh bGwgSklUOjpjYWxsT3BlcmF0aW9uKFZfSklUT3BlcmF0aW9uX0VKIG9wZXJhdGlvCiAKIEFMV0FZ U19JTkxJTkUgTWFjcm9Bc3NlbWJsZXI6OkNhbGwgSklUOjpjYWxsT3BlcmF0aW9uKFZfSklUT3Bl cmF0aW9uX0VaSWRKWiBvcGVyYXRpb24sIGludDMyX3Qgb3AxLCBjb25zdCBJZGVudGlmaWVyKiBp ZGVudE9wMiwgUmVnaXN0ZXJJRCByZWdPcDNUYWcsIFJlZ2lzdGVySUQgcmVnT3AzUGF5bG9hZCwg aW50MzJfdCBvcDQpCiB7Ci0gICAgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJ bW0zMihvcDEpLCBUcnVzdGVkSW1tUHRyKGlkZW50T3AyKSwgcmVnT3AzUGF5bG9hZCwgcmVnT3Az VGFnLCBUcnVzdGVkSW1tMzIob3A0KSk7CisgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRl KFRydXN0ZWRJbW0zMihvcDEpLCBUcnVzdGVkSW1tUHRyKGlkZW50T3AyKSwgRUFCSV8zMkJJVF9E VU1NWV9BUkcgcmVnT3AzUGF5bG9hZCwgcmVnT3AzVGFnLCBUcnVzdGVkSW1tMzIob3A0KSk7CiAg ICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2sob3BlcmF0aW9uKTsKIH0KIAo=