138499 2014-11-07 01:51:50 -0800 Enable Cortex-A53-specific code paths by default if core is detected 2014-11-10 02:38:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned buildbot commit-queue loki ossy rakuco rniwa ryuan.choi oldest_to_newest 1047045 0 akiss 2014-11-07 01:51:50 -0800 This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=138315 . It would be good if the build system would detect that we are on a Cortex-A53 and enable specific code paths by default, with no need for --cmakeargs="-DWTF_CPU_ARM64_CORTEXA53=ON" command line arguments (which are easy to forget or misspell). 1047047 1 241168 akiss 2014-11-07 01:54:15 -0800 Created attachment 241168 Proposed patch. 1047052 2 241168 ossy 2014-11-07 02:28:56 -0800 Comment on attachment 241168 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=241168&action=review > Source/cmake/OptionsCommon.cmake:36 > + if (CPUINFO MATCHES "0xd03") I would restrict matching "0xd03" only in "CPU part" line to avoid accidental matches. And could you possibly add a comment to the ARM reference? http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0500f/BABFEABI.html > Source/cmake/OptionsCommon.cmake:37 > + set(WTF_CPU_ARM64_CORTEXA53_INITIALVALUE ON) Why not set(WTF_CPU_ARM64_CORTEXA53 1) and add_definitions(-DWTF_CPU_ARM64_CORTEXA53=1) ? In this case we wouldn't need WTF_CPU_ARM64_CORTEXA53_INITIALVALUE and the option. 1047067 3 241176 akiss 2014-11-07 06:36:51 -0800 Created attachment 241176 Proposed patch, v2 The updated patch now checks for 0xd03 only in the CPU part line, as requested. Also, comments are added. Moreover, the patch executes the check multiple times, once for each available core, because the /proc/cpuinfo API is somewhat strange on ARM64 and the result depends on the core the query is executed on. This might conceal the presence of an A53 core in a heterogeneous setup. Option and _INITIALVALUE are used to allow explicit setting of WTF_CPU_ARM64_CORTEXA53 from command line, independently from the result of the detection. 1047068 4 commit-queue 2014-11-07 06:39:47 -0800 Attachment 241176 did not pass style-queue: ERROR: Source/cmake/OptionsCommon.cmake:46: No space after "(" [whitespace/parentheses] [5] ERROR: Source/cmake/OptionsCommon.cmake:46: No space before ")" [whitespace/parentheses] [5] ERROR: Source/cmake/OptionsCommon.cmake:46: One space between command "endforeach" and its parentheses, should be "endforeach (" [whitespace/parentheses] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1047070 5 241178 akiss 2014-11-07 06:42:53 -0800 Created attachment 241178 Proposed patch, v3 One misplaced space. My bad. Sorry for the noise. 1047506 6 241178 ossy 2014-11-10 02:01:37 -0800 Comment on attachment 241178 Proposed patch, v3 r=me 1047508 7 241178 commit-queue 2014-11-10 02:38:12 -0800 Comment on attachment 241178 Proposed patch, v3 Clearing flags on attachment: 241178 Committed r175804: <http://trac.webkit.org/changeset/175804> 1047509 8 commit-queue 2014-11-10 02:38:18 -0800 All reviewed patches have been landed. Closing bug. 241168 2014-11-07 01:54:15 -0800 2014-11-07 06:36:51 -0800 Proposed patch. detect-cortexa53-v2.patch text/plain 1535 akiss ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZWRkOGJiLi4yMmU4NWMw IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTQtMTEtMDcgIEFrb3MgS2lzcyAgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAg ICBFbmFibGUgQ29ydGV4LUE1My1zcGVjaWZpYyBjb2RlIHBhdGhzIGJ5IGRlZmF1bHQgaWYgY29y ZSBpcyBkZXRlY3RlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzODQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE9uIEFSTTY0L0xpbnV4LCBjaGVjayAvcHJvYy9jcHVpbmZvIGZvciBDUFUgcGFydCAw eGQwMyAoc2lnbmFsaW5nCisgICAgICAgIENvcnRleC1BNTMpIGFuZCBzZXQgdGhlIGluaXRpYWwg dmFsdWUgb2YgV1RGX0NQVV9BUk02NF9DT1JURVhBNTMgdG8gdHJ1ZQorICAgICAgICBpZiBmb3Vu ZC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDE0 LTExLTAzICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgRU5B QkxFX0ZJTFRFUlNfTEVWRUxfMiBmZWF0dXJlIGd1YXJkLgpkaWZmIC0tZ2l0IGEvU291cmNlL2Nt YWtlL09wdGlvbnNDb21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFr ZQppbmRleCBhYjIzMDliLi5jNWJmNmI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9u c0NvbW1vbi5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAt MzAsNiArMzAsMTUgQEAgaWYgKENNQUtFX0NPTVBJTEVSX0lTX0dOVUNYWCBPUiAiJHtDTUFLRV9D WFhfQ09NUElMRVJfSUR9IiBTVFJFUVVBTCAiQ2xhbmciKQogICAgIHNldChDTUFLRV9DWFhfRkxB R1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtc3RkPWMrKzExIikKIGVuZGlmICgpCiAKK3NldChXVEZf Q1BVX0FSTTY0X0NPUlRFWEE1M19JTklUSUFMVkFMVUUgT0ZGKQoraWYgKFdURl9DUFVfQVJNNjQg QU5EICgke0NNQUtFX1NZU1RFTV9OQU1FfSBTVFJFUVVBTCAiTGludXgiKSkKKyAgICBmaWxlKFJF QUQgIi9wcm9jL2NwdWluZm8iIENQVUlORk8pCisgICAgaWYgKENQVUlORk8gTUFUQ0hFUyAiMHhk MDMiKQorICAgICAgICBzZXQoV1RGX0NQVV9BUk02NF9DT1JURVhBNTNfSU5JVElBTFZBTFVFIE9O KQorICAgIGVuZGlmICgpCitlbmRpZiAoKQorb3B0aW9uKFdURl9DUFVfQVJNNjRfQ09SVEVYQTUz ICJFbmFibGUgQ29ydGV4LUE1My1zcGVjaWZpYyBjb2RlIHBhdGhzIiAke1dURl9DUFVfQVJNNjRf Q09SVEVYQTUzX0lOSVRJQUxWQUxVRX0pCisKIGlmIChXVEZfQ1BVX0FSTTY0X0NPUlRFWEE1MykK ICAgICBpZiAoTk9UIFdURl9DUFVfQVJNNjQpCiAgICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1Ig IldURl9DUFVfQVJNNjRfQ09SVEVYQTUzIHNldCB3aXRob3V0IFdURl9DUFVfQVJNNjQiKQo= 241176 2014-11-07 06:36:51 -0800 2014-11-07 06:42:53 -0800 Proposed patch, v2 detect-cortexa53-v4.patch text/plain 2262 akiss ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZWRkOGJiLi5lY2E0ZGY5 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTQtMTEtMDcgIEFrb3MgS2lzcyAgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAg ICBFbmFibGUgQ29ydGV4LUE1My1zcGVjaWZpYyBjb2RlIHBhdGhzIGJ5IGRlZmF1bHQgaWYgY29y ZSBpcyBkZXRlY3RlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzODQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE9uIEFSTTY0L0xpbnV4LCBjaGVjayAvcHJvYy9jcHVpbmZvIGZvciBDUFUgcGFydCAw eGQwMyAoc2lnbmFsaW5nCisgICAgICAgIENvcnRleC1BNTMpIGFuZCBzZXQgdGhlIGluaXRpYWwg dmFsdWUgb2YgV1RGX0NQVV9BUk02NF9DT1JURVhBNTMgdG8gdHJ1ZQorICAgICAgICBpZiBmb3Vu ZC4KKworICAgICAgICBTaW5jZSBvbiBBUk02NC9MaW51eCB0aGUgcGFydCBudW1iZXIgdGhhdCBj cHVpbmZvIHJlcG9ydHMgZGVwZW5kcyBvbgorICAgICAgICB0aGUgY29yZSB0aGUgcXVlcnkgaXMg cnVuIG9uLCB0aGUgY2hlY2sgaXMgYm91bmQgdG8gYW5kIGV4ZWN1dGVkIG9uIHRoZQorICAgICAg ICBhdmFpbGFibGUgY29yZXMgb25lIGJ5IG9uZS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9P cHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDE0LTExLTAzICBEZWFuIEphY2tzb24gIDxkaW5vQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgRU5BQkxFX0ZJTFRFUlNfTEVWRUxfMiBmZWF0dXJlIGd1 YXJkLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UgYi9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQppbmRleCBhYjIzMDliLi5lOTk2MThjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQorKysgYi9Tb3VyY2UvY21h a2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtMzAsNiArMzAsMjMgQEAgaWYgKENNQUtFX0NPTVBJ TEVSX0lTX0dOVUNYWCBPUiAiJHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IiBTVFJFUVVBTCAiQ2xh bmciKQogICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtc3RkPWMr KzExIikKIGVuZGlmICgpCiAKKyMgRGV0ZWN0IENvcnRleC1BNTMgY29yZSBpZiBDUFUgaXMgQVJN NjQgYW5kIE9TIGlzIExpbnV4LgorIyBRdWVyeSAvcHJvYy9jcHVpbmZvIGZvciBlYWNoIGF2YWls YWJsZSBjb3JlIGFuZCBjaGVjayByZXBvcnRlZCBDUFUgcGFydCBudW1iZXI6IDB4ZDAzIHNpZ25h bHMgQ29ydGV4LUE1My4KKyMgKHNlZSBNYWluIElEIFJlZ2lzdGVyIGluIEFSTSBDb3J0ZXgtQTUz IE1QQ29yZSBQcm9jZXNzb3IgVGVjaG5pY2FsIFJlZmVyZW5jZSBNYW51YWwpCitzZXQoV1RGX0NQ VV9BUk02NF9DT1JURVhBNTNfSU5JVElBTFZBTFVFIE9GRikKK2lmIChXVEZfQ1BVX0FSTTY0IEFO RCAoJHtDTUFLRV9TWVNURU1fTkFNRX0gU1RSRVFVQUwgIkxpbnV4IikpCisgICAgZXhlY3V0ZV9w cm9jZXNzKENPTU1BTkQgbnByb2MgT1VUUFVUX1ZBUklBQkxFIFBST0NfQ09VTlQpCisgICAgbWF0 aChFWFBSIFBST0NfTUFYICR7UFJPQ19DT1VOVH0tMSkKKyAgICBmb3JlYWNoIChQUk9DX0lEIFJB TkdFICR7UFJPQ19NQVh9KQorICAgICAgICBleGVjdXRlX3Byb2Nlc3MoQ09NTUFORCB0YXNrc2V0 IC1jICR7UFJPQ19JRH0gZ3JlcCAiXkNQVSBwYXJ0IiAvcHJvYy9jcHVpbmZvIE9VVFBVVF9WQVJJ QUJMRSBQUk9DX1BBUlQpCisgICAgICAgIGlmIChQUk9DX1BBUlQgTUFUQ0hFUyAiMHhkMDMiKQor ICAgICAgICAgICAgc2V0KFdURl9DUFVfQVJNNjRfQ09SVEVYQTUzX0lOSVRJQUxWQUxVRSBPTikK KyAgICAgICAgICAgIGJyZWFrICgpCisgICAgICAgIGVuZGlmICgpCisgICAgZW5kZm9yZWFjaCgg KQorZW5kaWYgKCkKK29wdGlvbihXVEZfQ1BVX0FSTTY0X0NPUlRFWEE1MyAiRW5hYmxlIENvcnRl eC1BNTMtc3BlY2lmaWMgY29kZSBwYXRocyIgJHtXVEZfQ1BVX0FSTTY0X0NPUlRFWEE1M19JTklU SUFMVkFMVUV9KQorCiBpZiAoV1RGX0NQVV9BUk02NF9DT1JURVhBNTMpCiAgICAgaWYgKE5PVCBX VEZfQ1BVX0FSTTY0KQogICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJXVEZfQ1BVX0FSTTY0 X0NPUlRFWEE1MyBzZXQgd2l0aG91dCBXVEZfQ1BVX0FSTTY0IikK 241178 2014-11-07 06:42:53 -0800 2014-11-10 02:38:12 -0800 Proposed patch, v3 detect-cortexa53-v5.patch text/plain 2262 akiss ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZWRkOGJiLi5lY2E0ZGY5 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTQtMTEtMDcgIEFrb3MgS2lzcyAgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAg ICBFbmFibGUgQ29ydGV4LUE1My1zcGVjaWZpYyBjb2RlIHBhdGhzIGJ5IGRlZmF1bHQgaWYgY29y ZSBpcyBkZXRlY3RlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzODQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE9uIEFSTTY0L0xpbnV4LCBjaGVjayAvcHJvYy9jcHVpbmZvIGZvciBDUFUgcGFydCAw eGQwMyAoc2lnbmFsaW5nCisgICAgICAgIENvcnRleC1BNTMpIGFuZCBzZXQgdGhlIGluaXRpYWwg dmFsdWUgb2YgV1RGX0NQVV9BUk02NF9DT1JURVhBNTMgdG8gdHJ1ZQorICAgICAgICBpZiBmb3Vu ZC4KKworICAgICAgICBTaW5jZSBvbiBBUk02NC9MaW51eCB0aGUgcGFydCBudW1iZXIgdGhhdCBj cHVpbmZvIHJlcG9ydHMgZGVwZW5kcyBvbgorICAgICAgICB0aGUgY29yZSB0aGUgcXVlcnkgaXMg cnVuIG9uLCB0aGUgY2hlY2sgaXMgYm91bmQgdG8gYW5kIGV4ZWN1dGVkIG9uIHRoZQorICAgICAg ICBhdmFpbGFibGUgY29yZXMgb25lIGJ5IG9uZS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9P cHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDE0LTExLTAzICBEZWFuIEphY2tzb24gIDxkaW5vQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgRU5BQkxFX0ZJTFRFUlNfTEVWRUxfMiBmZWF0dXJlIGd1 YXJkLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UgYi9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQppbmRleCBhYjIzMDliLi4wNDVmZGNmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQorKysgYi9Tb3VyY2UvY21h a2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtMzAsNiArMzAsMjMgQEAgaWYgKENNQUtFX0NPTVBJ TEVSX0lTX0dOVUNYWCBPUiAiJHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IiBTVFJFUVVBTCAiQ2xh bmciKQogICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtc3RkPWMr KzExIikKIGVuZGlmICgpCiAKKyMgRGV0ZWN0IENvcnRleC1BNTMgY29yZSBpZiBDUFUgaXMgQVJN NjQgYW5kIE9TIGlzIExpbnV4LgorIyBRdWVyeSAvcHJvYy9jcHVpbmZvIGZvciBlYWNoIGF2YWls YWJsZSBjb3JlIGFuZCBjaGVjayByZXBvcnRlZCBDUFUgcGFydCBudW1iZXI6IDB4ZDAzIHNpZ25h bHMgQ29ydGV4LUE1My4KKyMgKHNlZSBNYWluIElEIFJlZ2lzdGVyIGluIEFSTSBDb3J0ZXgtQTUz IE1QQ29yZSBQcm9jZXNzb3IgVGVjaG5pY2FsIFJlZmVyZW5jZSBNYW51YWwpCitzZXQoV1RGX0NQ VV9BUk02NF9DT1JURVhBNTNfSU5JVElBTFZBTFVFIE9GRikKK2lmIChXVEZfQ1BVX0FSTTY0IEFO RCAoJHtDTUFLRV9TWVNURU1fTkFNRX0gU1RSRVFVQUwgIkxpbnV4IikpCisgICAgZXhlY3V0ZV9w cm9jZXNzKENPTU1BTkQgbnByb2MgT1VUUFVUX1ZBUklBQkxFIFBST0NfQ09VTlQpCisgICAgbWF0 aChFWFBSIFBST0NfTUFYICR7UFJPQ19DT1VOVH0tMSkKKyAgICBmb3JlYWNoIChQUk9DX0lEIFJB TkdFICR7UFJPQ19NQVh9KQorICAgICAgICBleGVjdXRlX3Byb2Nlc3MoQ09NTUFORCB0YXNrc2V0 IC1jICR7UFJPQ19JRH0gZ3JlcCAiXkNQVSBwYXJ0IiAvcHJvYy9jcHVpbmZvIE9VVFBVVF9WQVJJ QUJMRSBQUk9DX1BBUlQpCisgICAgICAgIGlmIChQUk9DX1BBUlQgTUFUQ0hFUyAiMHhkMDMiKQor ICAgICAgICAgICAgc2V0KFdURl9DUFVfQVJNNjRfQ09SVEVYQTUzX0lOSVRJQUxWQUxVRSBPTikK KyAgICAgICAgICAgIGJyZWFrICgpCisgICAgICAgIGVuZGlmICgpCisgICAgZW5kZm9yZWFjaCAo KQorZW5kaWYgKCkKK29wdGlvbihXVEZfQ1BVX0FSTTY0X0NPUlRFWEE1MyAiRW5hYmxlIENvcnRl eC1BNTMtc3BlY2lmaWMgY29kZSBwYXRocyIgJHtXVEZfQ1BVX0FSTTY0X0NPUlRFWEE1M19JTklU SUFMVkFMVUV9KQorCiBpZiAoV1RGX0NQVV9BUk02NF9DT1JURVhBNTMpCiAgICAgaWYgKE5PVCBX VEZfQ1BVX0FSTTY0KQogICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJXVEZfQ1BVX0FSTTY0 X0NPUlRFWEE1MyBzZXQgd2l0aG91dCBXVEZfQ1BVX0FSTTY0IikK