138496 2014-11-06 22:59:48 -0800 Invoking an action menu should dismiss existing selection 2014-11-07 10:55:02 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1047031 0 bdakin 2014-11-06 22:59:48 -0800 Invoking an action menu should dismiss existing selection, unless the action menu is being invoked on a selection or text. 1047032 1 241164 bdakin 2014-11-06 23:03:55 -0800 Created attachment 241164 Patch 1047115 2 bdakin 2014-11-07 10:55:02 -0800 Thanks! http://trac.webkit.org/changeset/175753 241164 2014-11-06 23:03:55 -0800 2014-11-07 06:50:24 -0800 Patch for-review.txt text/plain 1747 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTc0MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTExLTA2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBJbnZva2luZyBhbiBhY3Rpb24gbWVu dSBzaG91bGQgZGlzbWlzcyBleGlzdGluZyBzZWxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODQ5NgorICAgICAgICAtYW5kIGNvcnJlc3Bv bmRpbmctCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE4ODkyNzg3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLQWN0aW9u TWVudUNvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgd2ls bE9wZW5NZW51OndpdGhFdmVudDpdKToKKwogMjAxNC0xMS0wNiAgQ29ucmFkIFNodWx0eiAgPGNv bnJhZF9zaHVsdHpAYXBwbGUuY29tPgogCiAgICAgICAgIENsaWVudHMgc2hvdWxkIGJlIGFibGUg dG8gY3VzdG9taXplIHRoZSB2aWV3IHVzZWQgZm9yIHBhZ2UgcHJldmlld3MKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xs ZXIubW0JKHJldmlzaW9uIDE3NTc0MCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMv V0tBY3Rpb25NZW51Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMTk1LDE1ICsxOTUs MTggQEAgLSAodm9pZCl3aWxsT3Blbk1lbnU6KE5TTWVudSAqKW1lbnUgd2l0aAogICAgICAgICBy ZXR1cm47CiAKICAgICBpZiAoX3R5cGUgPT0ga1dLQWN0aW9uTWVudURhdGFEZXRlY3RlZEl0ZW0p IHsKLSAgICAgICAgaWYgKG1lbnUubnVtYmVyT2ZJdGVtcyA9PSAxKQorICAgICAgICBpZiAobWVu dS5udW1iZXJPZkl0ZW1zID09IDEpIHsKKyAgICAgICAgICAgIF9wYWdlLT5jbGVhclNlbGVjdGlv bigpOwogICAgICAgICAgICAgW3NlbGYgX3Nob3dUZXh0SW5kaWNhdG9yXTsKLSAgICAgICAgZWxz ZQorICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIF9wYWdlLT5zZWxlY3RMYXN0QWN0aW9uTWVu dVJhbmdlKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBpZiAoIVtzZWxmIGlzTWVu dUZvclRleHRDb250ZW50XSkKKyAgICBpZiAoIVtzZWxmIGlzTWVudUZvclRleHRDb250ZW50XSkg eworICAgICAgICBfcGFnZS0+Y2xlYXJTZWxlY3Rpb24oKTsKICAgICAgICAgcmV0dXJuOworICAg IH0KIAogICAgIC8vIEFjdGlvbiBtZW51cyBmb3IgdGV4dCBzaG91bGQgaGlnaGxpZ2h0IHRoZSB0 ZXh0IHNvIHRoYXQgaXQgaXMgY2xlYXIgd2hhdCB0aGUgYWN0aW9uIG1lbnUgYWN0aW9ucwogICAg IC8vIHdpbGwgYXBwbHkgdG8uIElmIHRoZSB0ZXh0IGlzIGFscmVhZHkgc2VsZWN0ZWQsIHRoZSBt ZW51IHdpbGwgdXNlIHRoZSBleGlzdGluZyBzZWxlY3Rpb24uCg==