138485 2014-11-06 16:31:19 -0800 Remove useless if check in HTMLInputElement::setValue() 2014-11-06 21:53:45 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin buildbot commit-queue kling rniwa oldest_to_newest 1046957 0 cdumez 2014-11-06 16:31:19 -0800 Remove useless if check in HTMLInputElement::setValue(). 1046961 1 241144 cdumez 2014-11-06 16:32:58 -0800 Created attachment 241144 Patch 1046987 2 241144 dbates 2014-11-06 18:11:25 -0800 Comment on attachment 241144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241144&action=review > Source/WebCore/html/HTMLInputElement.cpp:-963 > - > - if (!valueChanged) > - return; It looks like this code was inadvertently left in the patch for bug #67742 (http://trac.webkit.org/b/94836), which moved the logic for dispatching change events among other changes from class HTMLInputElement to class InputType or classes that extend InputType. For completeness, this code was originally added in the patch for bug #63092 (http://trac.webkit.org/changeset/89624). 1046991 3 241144 dbates 2014-11-06 18:13:35 -0800 Comment on attachment 241144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241144&action=review > Source/WebCore/ChangeLog:9 > + Remove useless if check in HTMLInputElement::setValue(), probably left > + out after earlier refactoring. For your consideration, I suggest adding a remark that this code was inadvertently left in as part of the patch for bug #67742 (http://trac.webkit.org/changeset/94836). If you feel this is unnecessary then feel free to cq+ this patch. 1047004 4 241155 cdumez 2014-11-06 19:13:44 -0800 Created attachment 241155 Patch 1047024 5 241155 commit-queue 2014-11-06 21:53:42 -0800 Comment on attachment 241155 Patch Clearing flags on attachment: 241155 Committed r175742: <http://trac.webkit.org/changeset/175742> 1047025 6 commit-queue 2014-11-06 21:53:45 -0800 All reviewed patches have been landed. Closing bug. 241144 2014-11-06 16:32:58 -0800 2014-11-06 19:13:41 -0800 Patch bug-138485-20141106163307.patch text/plain 1492 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBiZjlhMjIzOTUxYmU3 OTRiNjcyNDEzZGEyZmJiNjI3ODI2NjI0MS4uNTYyZGMxMDAwZDFlOTcwMWQwNTVhMzAxNWQ5NjM0 NGFhYmEyYWIzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTExLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVzZWxlc3MgaWYg Y2hlY2sgaW4gSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWUoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDg1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHVzZWxlc3MgaWYgY2hlY2sgaW4g SFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWUoKSwgcHJvYmFibHkgbGVmdAorICAgICAgICBvdXQg YWZ0ZXIgZWFybGllciByZWZhY3RvcmluZy4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpzZXRWYWx1ZSk6 CisKIDIwMTQtMTEtMDYgIEplcmVteSBKb25lcyAgPGplcmVteWpAYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCB0eXBvIGluIG9wdGltaXplZCBmdWxsc2NyZWVuIGFjdGl2YXRpb24uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCBhMjgzMTYwNzMzZTNlNGViNWZl MGE3M2QzYTVlYWM3ZTE0NzVlNmNlLi42M2ZhMjdhMTBmYjhhZTRhMmVkYWZjYTg3MThmM2E5MDNj MjUyODE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTk1 OCw5ICs5NTgsNiBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlKGNvbnN0IFN0cmlu ZyYgdmFsdWUsIFRleHRGaWVsZEV2ZW50QmVoYXZpb3IgZXZlbgogICAgIHNldExhc3RDaGFuZ2VX YXNOb3RVc2VyRWRpdCgpOwogICAgIHNldEZvcm1Db250cm9sVmFsdWVNYXRjaGVzUmVuZGVyZXIo ZmFsc2UpOwogICAgIG1faW5wdXRUeXBlLT5zZXRWYWx1ZShzYW5pdGl6ZWRWYWx1ZSwgdmFsdWVD aGFuZ2VkLCBldmVudEJlaGF2aW9yKTsKLQotICAgIGlmICghdmFsdWVDaGFuZ2VkKQotICAgICAg ICByZXR1cm47CiB9CiAKIHZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWVJbnRlcm5hbChj b25zdCBTdHJpbmcmIHNhbml0aXplZFZhbHVlLCBUZXh0RmllbGRFdmVudEJlaGF2aW9yIGV2ZW50 QmVoYXZpb3IpCg== 241155 2014-11-06 19:13:44 -0800 2014-11-06 21:53:42 -0800 Patch bug-138485-20141106191355.patch text/plain 1493 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBiZjlhMjIzOTUxYmU3 OTRiNjcyNDEzZGEyZmJiNjI3ODI2NjI0MS4uN2ZhNDUyZmJkNGM2NDY5N2JhZGE0N2EyNzNiZjUy OTY4NTk1ODZmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTExLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVzZWxlc3MgaWYg Y2hlY2sgaW4gSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWUoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDg1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgRGFuaWVsIEJhdGVzLgorCisgICAgICAgIFJlbW92ZSB1c2VsZXNzIGlmIGNoZWNrIGluIEhU TUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlKCkuIEl0IHdhcworICAgICAgICBpbmFkdmVydGVudGx5 IGxlZnQgaW4gYXMgcGFydCBvZiByOTQ4MzYuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWUp OgorCiAyMDE0LTExLTA2ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggdHlwbyBpbiBvcHRpbWl6ZWQgZnVsbHNjcmVlbiBhY3RpdmF0aW9uLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKaW5kZXggYTI4MzE2MDczM2UzZTRlYjVm ZTBhNzNkM2E1ZWFjN2UxNDc1ZTZjZS4uNjNmYTI3YTEwZmI4YWU0YTJlZGFmY2E4NzE4ZjNhOTAz YzI1MjgxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC05 NTgsOSArOTU4LDYgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50OjpzZXRWYWx1ZShjb25zdCBTdHJp bmcmIHZhbHVlLCBUZXh0RmllbGRFdmVudEJlaGF2aW9yIGV2ZW4KICAgICBzZXRMYXN0Q2hhbmdl V2FzTm90VXNlckVkaXQoKTsKICAgICBzZXRGb3JtQ29udHJvbFZhbHVlTWF0Y2hlc1JlbmRlcmVy KGZhbHNlKTsKICAgICBtX2lucHV0VHlwZS0+c2V0VmFsdWUoc2FuaXRpemVkVmFsdWUsIHZhbHVl Q2hhbmdlZCwgZXZlbnRCZWhhdmlvcik7Ci0KLSAgICBpZiAoIXZhbHVlQ2hhbmdlZCkKLSAgICAg ICAgcmV0dXJuOwogfQogCiB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlSW50ZXJuYWwo Y29uc3QgU3RyaW5nJiBzYW5pdGl6ZWRWYWx1ZSwgVGV4dEZpZWxkRXZlbnRCZWhhdmlvciBldmVu dEJlaGF2aW9yKQo=