138479 2014-11-06 15:17:21 -0800 Drop useless HTMLElement::isURLAttribute() override 2014-11-07 10:28:42 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin commit-queue esprehn+autocc gyuyoung.kim kling rniwa oldest_to_newest 1046926 0 cdumez 2014-11-06 15:17:21 -0800 Drop useless HTMLElement::isURLAttribute() override as it is doing nothing but call the parent class' isURLAttribute(). 1046929 1 241134 cdumez 2014-11-06 15:19:24 -0800 Created attachment 241134 Patch 1047043 2 241134 mark.lam 2014-11-07 01:37:24 -0800 Comment on attachment 241134 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241134&action=review r=me with comment fix. > Source/WebCore/ChangeLog:9 > + nothing but call the parent class' isURLAttribute(). typo: /call/calling/ 1047097 3 241188 cdumez 2014-11-07 09:42:13 -0800 Created attachment 241188 Patch 1047106 4 241188 commit-queue 2014-11-07 10:28:37 -0800 Comment on attachment 241188 Patch Clearing flags on attachment: 241188 Committed r175752: <http://trac.webkit.org/changeset/175752> 1047107 5 commit-queue 2014-11-07 10:28:42 -0800 All reviewed patches have been landed. Closing bug. 241134 2014-11-06 15:19:24 -0800 2014-11-07 09:42:10 -0800 Patch bug-138479-20141106151933.patch text/plain 2163 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzM4YzRmZTEyZDczYjE1 ZGI5Y2UyNGNhZWQ3MTA2ODgxOTJlODlmYi4uYTA1OGJjNzcyNmM5NjA0N2ZmNWM2M2ZlMzk4Njhl NDY0ZmU2YTRmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTExLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCB1c2VsZXNzIEhUTUxF bGVtZW50Ojppc1VSTEF0dHJpYnV0ZSgpIG92ZXJyaWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIHVzZWxlc3MgSFRNTEVsZW1lbnQ6OmlzVVJM QXR0cmlidXRlKCkgb3ZlcnJpZGUgYXMgaXQgaXMgZG9pbmcKKyAgICAgICAgbm90aGluZyBidXQg Y2FsbCB0aGUgcGFyZW50IGNsYXNzJyBpc1VSTEF0dHJpYnV0ZSgpLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogaHRtbC9IVE1MRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRWxlbWVudDo6aXNVUkxBdHRyaWJ1dGUpOiBE ZWxldGVkLgorICAgICAgICAqIGh0bWwvSFRNTEVsZW1lbnQuaDoKKwogMjAxNC0xMS0wNiAgQmV0 aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUHJldmlldyB2aWV3cyBvZnRl biBtaXNwbGFjZWQgaW5zaWRlIHBvcG92ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAK aW5kZXggYzc5MzFhZTU3ZjIzNWJhZjk5YWRmYWZjYzI4MTIyOGI2ZTBkNzQwMy4uMzdhNzMyMDdk NGM0ZThlYWM3MTlhZDNjMGJmNGJhZDcxY2IyYjQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxl bWVudC5jcHAKQEAgLTEwMzMsMTEgKzEwMzMsNiBAQCB2b2lkIEhUTUxFbGVtZW50OjphZGp1c3RE aXJlY3Rpb25hbGl0eUlmTmVlZGVkQWZ0ZXJDaGlsZHJlbkNoYW5nZWQoRWxlbWVudCogYmVmbwog ICAgIH0KIH0KIAotYm9vbCBIVE1MRWxlbWVudDo6aXNVUkxBdHRyaWJ1dGUoY29uc3QgQXR0cmli dXRlJiBhdHRyaWJ1dGUpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIFN0eWxlZEVsZW1lbnQ6OmlzVVJM QXR0cmlidXRlKGF0dHJpYnV0ZSk7Ci19Ci0KIHZvaWQgSFRNTEVsZW1lbnQ6OmFkZEhUTUxMZW5n dGhUb1N0eWxlKE11dGFibGVTdHlsZVByb3BlcnRpZXMmIHN0eWxlLCBDU1NQcm9wZXJ0eUlEIHBy b3BlcnR5SUQsIGNvbnN0IFN0cmluZyYgdmFsdWUpCiB7CiAgICAgLy8gRklYTUU6IFRoaXMgZnVu Y3Rpb24gc2hvdWxkIG5vdCBzcGluIHVwIHRoZSBDU1MgcGFyc2VyLCBidXQgc2hvdWxkIGluc3Rl YWQganVzdCBmaWd1cmUgb3V0IHRoZSBjb3JyZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmgK aW5kZXggODEyMzQ3OGRkOWUwYWVhNDM5NzU2NzM5ZWFkMDU2NWE1YjFiOWRiOC4uNzkzNzdkNmI5 OWI0MTZjMzExZjg2ZGJmYTM2MmFiM2ZjZjQ2NjVhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1l bnQuaApAQCAtMTIwLDggKzEyMCw2IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgY2hp bGRyZW5DaGFuZ2VkKGNvbnN0IENoaWxkQ2hhbmdlJikgb3ZlcnJpZGU7CiAgICAgdm9pZCBjYWxj dWxhdGVBbmRBZGp1c3REaXJlY3Rpb25hbGl0eSgpOwogCi0gICAgdmlydHVhbCBib29sIGlzVVJM QXR0cmlidXRlKGNvbnN0IEF0dHJpYnV0ZSYpIGNvbnN0IG92ZXJyaWRlOwotCiBwcml2YXRlOgog ICAgIHZpcnR1YWwgU3RyaW5nIG5vZGVOYW1lKCkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CiAK 241188 2014-11-07 09:42:13 -0800 2014-11-07 10:28:37 -0800 Patch bug-138479-20141107094224.patch text/plain 2163 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBiZjlhMjIzOTUxYmU3 OTRiNjcyNDEzZGEyZmJiNjI3ODI2NjI0MS4uMDkzZjk4NTNhZTI5NzZhODViNjZjZjViNDBhZGY4 NGY0ZDk4MTI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTExLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCB1c2VsZXNzIEhUTUxF bGVtZW50Ojppc1VSTEF0dHJpYnV0ZSgpIG92ZXJyaWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBN YXJrIExhbS4KKworICAgICAgICBEcm9wIHVzZWxlc3MgSFRNTEVsZW1lbnQ6OmlzVVJMQXR0cmli dXRlKCkgb3ZlcnJpZGUgYXMgaXQgaXMgZG9pbmcKKyAgICAgICAgbm90aGluZyBidXQgY2FsbGlu ZyB0aGUgcGFyZW50IGNsYXNzJyBpc1VSTEF0dHJpYnV0ZSgpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRWxlbWVudDo6aXNVUkxBdHRyaWJ1dGUpOiBEZWxl dGVkLgorICAgICAgICAqIGh0bWwvSFRNTEVsZW1lbnQuaDoKKwogMjAxNC0xMS0wNiAgSmVyZW15 IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHR5cG8gaW4gb3B0aW1p emVkIGZ1bGxzY3JlZW4gYWN0aXZhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAK aW5kZXggNjQ3MDQzMDVkNWNjYmE1NWFkNTkzNzkzNzA4YmI2YWVjMGEwYzA2NC4uMDNjZjk0ZWNj ODcxNmIzMGU2M2ZhNzEzOWM3N2RhMzFkMzRjYjFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxl bWVudC5jcHAKQEAgLTEwMzEsMTEgKzEwMzEsNiBAQCB2b2lkIEhUTUxFbGVtZW50OjphZGp1c3RE aXJlY3Rpb25hbGl0eUlmTmVlZGVkQWZ0ZXJDaGlsZHJlbkNoYW5nZWQoRWxlbWVudCogYmVmbwog ICAgIH0KIH0KIAotYm9vbCBIVE1MRWxlbWVudDo6aXNVUkxBdHRyaWJ1dGUoY29uc3QgQXR0cmli dXRlJiBhdHRyaWJ1dGUpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIFN0eWxlZEVsZW1lbnQ6OmlzVVJM QXR0cmlidXRlKGF0dHJpYnV0ZSk7Ci19Ci0KIHZvaWQgSFRNTEVsZW1lbnQ6OmFkZEhUTUxMZW5n dGhUb1N0eWxlKE11dGFibGVTdHlsZVByb3BlcnRpZXMmIHN0eWxlLCBDU1NQcm9wZXJ0eUlEIHBy b3BlcnR5SUQsIGNvbnN0IFN0cmluZyYgdmFsdWUpCiB7CiAgICAgLy8gRklYTUU6IFRoaXMgZnVu Y3Rpb24gc2hvdWxkIG5vdCBzcGluIHVwIHRoZSBDU1MgcGFyc2VyLCBidXQgc2hvdWxkIGluc3Rl YWQganVzdCBmaWd1cmUgb3V0IHRoZSBjb3JyZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmgK aW5kZXggODEyMzQ3OGRkOWUwYWVhNDM5NzU2NzM5ZWFkMDU2NWE1YjFiOWRiOC4uNzkzNzdkNmI5 OWI0MTZjMzExZjg2ZGJmYTM2MmFiM2ZjZjQ2NjVhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1l bnQuaApAQCAtMTIwLDggKzEyMCw2IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgY2hp bGRyZW5DaGFuZ2VkKGNvbnN0IENoaWxkQ2hhbmdlJikgb3ZlcnJpZGU7CiAgICAgdm9pZCBjYWxj dWxhdGVBbmRBZGp1c3REaXJlY3Rpb25hbGl0eSgpOwogCi0gICAgdmlydHVhbCBib29sIGlzVVJM QXR0cmlidXRlKGNvbnN0IEF0dHJpYnV0ZSYpIGNvbnN0IG92ZXJyaWRlOwotCiBwcml2YXRlOgog ICAgIHZpcnR1YWwgU3RyaW5nIG5vZGVOYW1lKCkgY29uc3Qgb3ZlcnJpZGUgZmluYWw7CiAK