138475 2014-11-06 14:04:46 -0800 Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev in git.py 2014-11-06 14:41:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 matthew_hanson webkit-unassigned commit-queue dbates glenn mrowe rniwa oldest_to_newest 1046903 0 matthew_hanson 2014-11-06 14:04:46 -0800 This code breaks compatibility with the svn_revision_from_git_commit method. Once it is removed, it is up to the caller of _run_git_svn_find_rev to ensure that its revision is prepended with an 'r', when calling _run_git_svn_find_rev with an SVN revision. 1046906 1 241132 matthew_hanson 2014-11-06 14:07:16 -0800 Created attachment 241132 Patch 1046914 2 matthew_hanson 2014-11-06 14:41:26 -0800 Committed r175717: <http://trac.webkit.org/changeset/175717> 241132 2014-11-06 14:07:16 -0800 2014-11-06 14:35:56 -0800 Patch bug-138475-20141106140726.patch text/plain 2893 matthew_hanson U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTYyZWJmMDY4OGVhZGU3OTdlMzNhMTRkMzU1MzQ4NDky NTU5OGYyNS4uNTFmODZlZjQ3MjkyMmJkNWFjYjZlZDFhM2EzNGM4Nzk3ZDdkZTBkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE0LTExLTA2ICBNYXR0aGV3IEhhbnNvbiAgPG1hdHRoZXdfaGFuc29uQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgY29kZSB0aGF0IHByZXBlbmRzIGEgbGVhZGluZyAncicgdG8g dGhlIGZpcnN0IGFyZ3VtZW50IG9mIF9ydW5fZ2l0X3N2bl9maW5kX3JldgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDc1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5nZSBpbiBodHRwczov L3RyYWMud2Via2l0Lm9yZy8xNzU2MDMgaW50cm9kdWNlZCBicm9rZSBjb21wYXRpYmlsaXR5IHdp dGggc3ZuX3JldmlzaW9uX2Zyb21fZ2l0X2NvbW1pdC4KKyAgICAgICAgVGhpcyBwYXRjaCByZXZl cnRzIHRoZSBwYXJ0IG9mIHRoYXQgY2hhbmdlIHRoYXQgYnJva2UgY29tcGF0aWJpbGl0eS4gSW4g YWRkaXRpb24sIHRoaXMgcGF0Y2ggYWRkcyBhIGNvbW1lbnQgdG8KKyAgICAgICAgZXhwbGFpbiB0 aGF0IFNWTiByZXZpc2lvbnMgcmVxdWlyZSBhIGxlYWRpbmcgJ3InLCBtb3ZlcyBhbiBleGlzdGlu ZyBjb21tZW50IHRvIGEgbW9yZSBhcHByb3ByaWF0ZSBsb2NhdGlvbiBhbmQKKyAgICAgICAgcmVu YW1lcyB0aGUgcG9zaXRpb25hbCBhcmd1bWVudCB0byBiZXR0ZXIgcmVmbGVjdCB0aGF0IGl0IGNh biByZXByZXNlbnQgZWl0aGVyIGFuIFNWTiByZXZpc2lvbiBvciBhIEdpdCB0cmVlLWlzaC4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9naXQucHk6Cisg ICAgICAgIChHaXQuX3J1bl9naXRfc3ZuX2ZpbmRfcmV2KToKKyAgICAgICAgQWRkIGNvbW1lbnQg bWVudGlvbmluZyB0aGF0IHN2bl9yZXZpc2lvbnMgbmVlZCB0byBiZWdpbiB3aXRoICdyJy4KKyAg ICAgICAgTW92ZSBjb21tZW50IChleHBsYWluaW5nIHRoYXQgZ2l0IHN2biBmaW5kLXJldiBleGl0 cyB3aXRoIGNvZGUgMCB3aGVuIG5vIG1hdGNoIGlzIGZvdW5kKSB0byBhIG1vcmUgYXBwcm9wcmlh dGUgbG9jYXRpb24uCisgICAgICAgIFJlbmFtZSB0aGUgYXJndW1lbnQgJ3JldmlzaW9uJyB0byAn cmV2aXNpb25fb3JfdHJlZWlzaCcgdG8gcmVmbGVjdCB0aGUgZHVhbCBmb3JtIHRoYXQgYXJndW1l bnQgY2FuIHRha2UuCisgICAgICAgIFJlbW92ZSBjb2RlIHRoYXQgY29lcmNlZCB0aGUgcmV2aXNp b24vdHJlZWlzaCBpbnRvIGEgc3RyaW5nIGFuZCBwcmVwZW5kZWQgYW4gJ3InLgorCiAyMDE0LTEx LTA0ICBNYXR0aGV3IEhhbnNvbiAgPG1hdHRoZXdfaGFuc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgYSBtZXRob2QgZm9yIHBlcmZvcm1pbmcgY2hlcnJ5cGljay1tZXJnZXMuCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vZ2l0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL2dpdC5weQppbmRleCA3 NmY3ZTJmOTlmNjc0OTgxM2Q3N2JjOWMxOGM4OTgzZDMxYTIwOGM3Li5kZWQxNmY5MzIyZDgwYWIz MTE2YTZkYjlmYjQ1MTNlZmI3NTVlZjM1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9zY20vZ2l0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9naXQucHkKQEAgLTMyMywxNiArMzIzLDEzIEBAIGNsYXNz IEdpdChTQ00sIFNWTlJlcG9zaXRvcnkpOgogICAgICAgICAgICAgY29tbWFuZCArPSBjaGFuZ2Vk X2ZpbGVzCiAgICAgICAgIHJldHVybiBzZWxmLnByZXBlbmRfc3ZuX3JldmlzaW9uKHNlbGYucnVu KGNvbW1hbmQsIGRlY29kZV9vdXRwdXQ9RmFsc2UsIGN3ZD1zZWxmLmNoZWNrb3V0X3Jvb3QpKQog Ci0gICAgZGVmIF9ydW5fZ2l0X3N2bl9maW5kX3JldihzZWxmLCByZXZpc2lvbiwgYnJhbmNoPU5v bmUpOgotICAgICAgICByZXZpc2lvbiA9IHN0cihyZXZpc2lvbikKLSAgICAgICAgaWYgcmV2aXNp b24gYW5kIHJldmlzaW9uWzBdICE9ICdyJzoKLSAgICAgICAgICAgIHJldmlzaW9uID0gJ3InICsg cmV2aXNpb24KLQotICAgICAgICAjIGdpdCBzdm4gZmluZC1yZXYgYWx3YXlzIGV4aXRzIDAsIGV2 ZW4gd2hlbiB0aGUgcmV2aXNpb24gb3IgY29tbWl0IGlzIG5vdCBmb3VuZC4KLSAgICAgICAgY29t bWFuZCA9IFsnc3ZuJywgJ2ZpbmQtcmV2JywgcmV2aXNpb25dCisgICAgZGVmIF9ydW5fZ2l0X3N2 bl9maW5kX3JldihzZWxmLCByZXZpc2lvbl9vcl90cmVlaXNoLCBicmFuY2g9Tm9uZSk6CisgICAg ICAgICMgZ2l0IHN2biBmaW5kLXJldiByZXF1aXJlcyBTVk4gcmV2aXNpb25zIHRvIGJlZ2luIHdp dGggdGhlIGNoYXJhY3RlciAncicuCisgICAgICAgIGNvbW1hbmQgPSBbJ3N2bicsICdmaW5kLXJl dicsIHJldmlzaW9uX29yX3RyZWVpc2hdCiAgICAgICAgIGlmIGJyYW5jaDoKICAgICAgICAgICAg IGNvbW1hbmQuYXBwZW5kKGJyYW5jaCkKIAorICAgICAgICAjIGdpdCBzdm4gZmluZC1yZXYgYWx3 YXlzIGV4aXRzIDAsIGV2ZW4gd2hlbiB0aGUgcmV2aXNpb24gb3IgY29tbWl0IGlzIG5vdCBmb3Vu ZC4KICAgICAgICAgcmV0dXJuIHNlbGYuX3J1bl9naXQoY29tbWFuZCkucnN0cmlwKCkKIAogICAg IGRlZiBfc3RyaW5nX3RvX2ludF9vcl9ub25lKHNlbGYsIHN0cmluZyk6Cg==