138471 2014-11-06 11:52:01 -0800 Data detectors popover points at the first line of the detected item 2014-11-06 13:35:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca bdakin buildbot rniwa oldest_to_newest 1046864 0 thorton 2014-11-06 11:52:01 -0800 Data detectors popover points at the first line of the detected item 1046865 1 241121 thorton 2014-11-06 11:52:14 -0800 Created attachment 241121 Patch 1046866 2 thorton 2014-11-06 11:53:12 -0800 <rdar://problem/18893079> 1046867 3 241121 thorton 2014-11-06 11:53:38 -0800 Comment on attachment 241121 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241121&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1137 > + detectedDataBoundingBox.unite(mainResultRange->ownerDocument().view()->contentsToWindow(quad.enclosingBoundingBox())); Probably should keep the view around on the side... 1046888 4 241121 sam 2014-11-06 13:08:10 -0800 Comment on attachment 241121 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241121&action=review >> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1137 >> + detectedDataBoundingBox.unite(mainResultRange->ownerDocument().view()->contentsToWindow(quad.enclosingBoundingBox())); > > Probably should keep the view around on the side... Agreed. 1046894 5 thorton 2014-11-06 13:35:33 -0800 http://trac.webkit.org/changeset/175711 241121 2014-11-06 11:52:14 -0800 2014-11-06 13:08:10 -0800 Patch bug-138471-20141106115224.patch text/plain 1950 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjlmOTI2NmJmM2JhZDc4 ZmVjNmM0MDRmNjllYThmYTRjMmQ4ZTRiMC4uNWNjM2YyOTUzZWE4YzQ0MGM2OWVlZjViY2VkNTI1 MjRiNTNjMjZmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTExLTA2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCisgICAgICAgIERhdGEgZGV0ZWN0 b3JzIHBvcG92ZXIgcG9pbnRzIGF0IHRoZSBmaXJzdCBsaW5lIG9mIHRoZSBkZXRlY3RlZCBpdGVt CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg0NzEK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4ODkzMDc5PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQ YWdlTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpzY2FuRm9yRGF0YURldGVjdGVkSXRlbXMpOgor ICAgICAgICBEZXRlcm1pbmUgdGhlIGJvdW5kaW5nIGJveCBvZiBhbGwgcXVhZHMgb2YgdGhlIGRl dGVjdGVkIGl0ZW0ncyB0ZXh0LgorICAgICAgICBUaGlzIHdheSwgdGhlIHBvcG92ZXIgd2lsbCBw b2ludCBhdCB0aGUgYm9yZGVyIG9mIHRoZSBpdGVtLCBpbnN0ZWFkIG9mCisgICAgICAgIHJpZ2h0 IGF0IHRoZSB2ZXJ5IGZpcnN0IGxpbmUuCisKKzIwMTQtMTEtMDYgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgVGV4dEluZGljYXRvcldpbmRvdydzIGJv dW5jZSBhbmltYXRpb24gaXMgbG9wc2lkZWQgd2hlbiBpbmRpY2F0aW5nIHR3byBzaG9ydCBsaW5l cyBvZiB0ZXh0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzg0NTgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9XZWJQYWdlTWFjLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9XZWJQYWdlTWFjLm1tCmluZGV4IGQ4OWNmYmIwODhjOWVhOTNiNDUzYmQwMWE0ZDhmZmNiOGQy MTk3ZDguLjVhODY4YzUwZWUwMzkwNTQ0YTNkNjhhZjdhN2UzM2QxNzFiOWQ1OGQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0K QEAgLTExMzIsOCArMTEzMiw5IEBAIHN0YXRpYyBSZXRhaW5QdHI8RERBY3Rpb25Db250ZXh0PiBz Y2FuRm9yRGF0YURldGVjdGVkSXRlbXMoY29uc3QgSGl0VGVzdFJlc3VsdCYKIAogICAgIFZlY3Rv cjxGbG9hdFF1YWQ+IHF1YWRzOwogICAgIG1haW5SZXN1bHRSYW5nZS0+dGV4dFF1YWRzKHF1YWRz KTsKLSAgICBpZiAoIXF1YWRzLmlzRW1wdHkoKSkKLSAgICAgICAgZGV0ZWN0ZWREYXRhQm91bmRp bmdCb3ggPSBtYWluUmVzdWx0UmFuZ2UtPm93bmVyRG9jdW1lbnQoKS52aWV3KCktPmNvbnRlbnRz VG9XaW5kb3cocXVhZHNbMF0uZW5jbG9zaW5nQm91bmRpbmdCb3goKSk7CisgICAgZGV0ZWN0ZWRE YXRhQm91bmRpbmdCb3ggPSBGbG9hdFJlY3QoKTsKKyAgICBmb3IgKGNvbnN0IGF1dG8mIHF1YWQg OiBxdWFkcykKKyAgICAgICAgZGV0ZWN0ZWREYXRhQm91bmRpbmdCb3gudW5pdGUobWFpblJlc3Vs dFJhbmdlLT5vd25lckRvY3VtZW50KCkudmlldygpLT5jb250ZW50c1RvV2luZG93KHF1YWQuZW5j bG9zaW5nQm91bmRpbmdCb3goKSkpOwogCiAgICAgZGV0ZWN0ZWREYXRhUmFuZ2UgPSBtYWluUmVz dWx0UmFuZ2U7CiAK