138470 2014-11-06 11:48:59 -0800 Add test for fix of REGRESSION (r174985-174986): Site display disappears 2014-11-10 15:23:50 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 1046862 0 msaboff 2014-11-06 11:48:59 -0800 The patch was landed before a test was created. 1047658 1 241312 msaboff 2014-11-10 15:15:46 -0800 Created attachment 241312 Patch 1047660 2 241312 ggaren 2014-11-10 15:17:28 -0800 Comment on attachment 241312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241312&action=review r=me > LayoutTests/js/dom/document-write-functions-cached.html:18 > +if (document.writeln === document.writeln) > + debug("PASS: document.write is cached."); > +else > + debug("FAIL: document.write is not cached, but should be."); Message should be writeln, not write. 1047662 3 msaboff 2014-11-10 15:23:17 -0800 (In reply to comment #2) > Comment on attachment 241312 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241312&action=review > > r=me > > > LayoutTests/js/dom/document-write-functions-cached.html:18 > > +if (document.writeln === document.writeln) > > + debug("PASS: document.write is cached."); > > +else > > + debug("FAIL: document.write is not cached, but should be."); > > Message should be writeln, not write. Fixed. 1047663 4 msaboff 2014-11-10 15:23:50 -0800 Committed r175834: <http://trac.webkit.org/changeset/175834> 241312 2014-11-10 15:15:46 -0800 2014-11-10 15:17:28 -0800 Patch 138470.patch text/plain 2463 msaboff SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3NTgzMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTExLTEwICBNaWNoYWVsIFNhYm9mZiAg PG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCB0ZXN0IGZvciBmaXggb2YgUkVHUkVT U0lPTiAocjE3NDk4NS0xNzQ5ODYpOiBTaXRlIGRpc3BsYXkgZGlzYXBwZWFycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDcwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGVja3MgdGhhdCBk b2N1bWVudC53cml0ZSgpIGFuZCBkb2N1bWVudC53cml0ZWxuKCkgYXJlIGNhY2hlZCBhbmQgdGhl IHNhbWUgaW5zdGFuY2UKKyAgICAgICAgaXMgYWx3YXlzIHJldHVybmVkLgorCisgICAgICAgICog anMvZG9tL2RvY3VtZW50LXdyaXRlLWZ1bmN0aW9ucy1jYWNoZWQtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBqcy9kb20vZG9jdW1lbnQtd3JpdGUtZnVuY3Rpb25zLWNhY2hlZC5odG1s OiBBZGRlZC4KKwogMjAxNC0xMS0wNCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OKHIxNzQ4MjMpOiBTZXZlcmFsIHRlc3RzIGZhaWwgZHVlIHRv IGNhbnBsYXl0aHJvdWdoIGZpcmluZyBiZWZvcmUgdHJhY2tzIGFyZSBhdmFpbGFibGUKSW5kZXg6 IExheW91dFRlc3RzL2pzL2RvbS9kb2N1bWVudC13cml0ZS1mdW5jdGlvbnMtY2FjaGVkLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9kb20vZG9jdW1lbnQtd3JpdGUt ZnVuY3Rpb25zLWNhY2hlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9qcy9kb20vZG9jdW1lbnQtd3JpdGUtZnVuY3Rpb25zLWNhY2hlZC1leHBlY3RlZC50eHQJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSw4IEBACitUaGlzIHBhZ2UgdGVzdHMgdGhhdCB0aGUgZG9j dW1lbnQgZnVuY3Rpb25zIHdyaXRlKCkgYW5kIHdyaXRlbG4oKSBhcmUgY2FjaGVkLiBJZiB0aGUg dGVzdCBwYXNzZXMsIHlvdSdsbCBzZWUgYSBQQVNTIG1lc3NhZ2VzIGJlbG93LgorCitQQVNTOiBk b2N1bWVudC53cml0ZSBpcyBjYWNoZWQuCitQQVNTOiBkb2N1bWVudC53cml0ZSBpcyBjYWNoZWQu CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRl eDogTGF5b3V0VGVzdHMvanMvZG9tL2RvY3VtZW50LXdyaXRlLWZ1bmN0aW9ucy1jYWNoZWQuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9kb20vZG9jdW1lbnQtd3JpdGUtZnVuY3Rp b25zLWNhY2hlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvZG9tL2RvY3Vt ZW50LXdyaXRlLWZ1bmN0aW9ucy1jYWNoZWQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsx LDI1IEBACis8IURPQ1RZUEUgSFRNTD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4v Li4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5Pgor PHA+VGhpcyBwYWdlIHRlc3RzIHRoYXQgdGhlIGRvY3VtZW50IGZ1bmN0aW9ucyB3cml0ZSgpIGFu ZCB3cml0ZWxuKCkgYXJlIGNhY2hlZC4gSWYgdGhlIHRlc3QgcGFzc2VzLCB5b3UnbGwgc2VlIGEg UEFTUyBtZXNzYWdlcyBiZWxvdy48L3A+Cis8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KKzxzY3Jp cHQ+CitpZiAoZG9jdW1lbnQud3JpdGUgPT09IGRvY3VtZW50LndyaXRlKQorICAgIGRlYnVnKCJQ QVNTOiBkb2N1bWVudC53cml0ZSBpcyBjYWNoZWQuIik7CitlbHNlCisgICAgZGVidWcoIkZBSUw6 IGRvY3VtZW50LndyaXRlIGlzIG5vdCBjYWNoZWQsIGJ1dCBzaG91bGQgYmUuIik7CisKK2lmIChk b2N1bWVudC53cml0ZWxuID09PSBkb2N1bWVudC53cml0ZWxuKQorICAgIGRlYnVnKCJQQVNTOiBk b2N1bWVudC53cml0ZSBpcyBjYWNoZWQuIik7CitlbHNlCisgICAgZGVidWcoIkZBSUw6IGRvY3Vt ZW50LndyaXRlIGlzIG5vdCBjYWNoZWQsIGJ1dCBzaG91bGQgYmUuIik7CisKK2lmICh0aGlzLnRl c3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzxzY3Jp cHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4K