138465 2014-11-06 07:24:45 -0800 [EFL] Require at least EFL 1.9 if ENABLE(ACCESSIBILITY) after r175098 2014-11-07 02:07:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evab.u-szeged evab.u-szeged commit-queue gyuyoung.kim k.czech rakuco ryuan.choi sergio oldest_to_newest 1046801 0 evab.u-szeged 2014-11-06 07:24:45 -0800 After https://trac.webkit.org/changeset/175098 build-webkit fails with EFL 1.7 with the following error: ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp: In member function 'Eina_Bool WebKit::WebAccessibility::action(Ecore_X_Event_Client_Message*)': ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:77:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_OVER' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:86:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_UP' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:89:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_DOWN' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:92:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_SCROLL' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:95:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_MOUSE' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:98:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_ENABLE' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:101:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_DISABLE' was not declared in this scope These defines introduced in EFL 1.9, so we should require at least EFL 1.9 if ENABLE(ACCESSIBILITY). 1046802 1 241105 evab.u-szeged 2014-11-06 07:29:33 -0800 Created attachment 241105 Patch 1046996 2 241105 gyuyoung.kim 2014-11-06 18:22:34 -0800 Comment on attachment 241105 Patch LGTM 1047049 3 241105 commit-queue 2014-11-07 02:07:13 -0800 Comment on attachment 241105 Patch Clearing flags on attachment: 241105 Committed r175746: <http://trac.webkit.org/changeset/175746> 1047050 4 commit-queue 2014-11-07 02:07:18 -0800 All reviewed patches have been landed. Closing bug. 241105 2014-11-06 07:29:33 -0800 2014-11-07 02:07:13 -0800 Patch bug-138465-20141106162943.patch text/plain 1647 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDJmNTg3 ZThmMjFkZGE5NWMxNDdjNTQxMjU1NWZhYjIyNzg5NzIwY2QuLmI4N2EwMTIzY2VkZTgzZDExZDlh ZDNhMDU5ZmI1YjY4OWRhZTg5ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xNTgsNiArMTU4 LDEzIEBAIGVsc2UgKCkKICAgICBzZXQoRUZMX1JFUVVJUkVEX1ZFUlNJT04gMS43KQogZW5kaWYg KCkKIAoraWYgKEVOQUJMRV9BQ0NFU1NJQklMSVRZKQorICAgIGZpbmRfcGFja2FnZShBVEsgMi4x MC4wIFJFUVVJUkVEKQorICAgIHNldChFRkxfUkVRVUlSRURfVkVSU0lPTiAxLjkpCitlbHNlICgp CisgICAgYWRkX2RlZmluaXRpb25zKC1ESEFWRV9BQ0NFU1NJQklMSVRZPTApCitlbmRpZiAoKQor CiBmaW5kX3BhY2thZ2UoRWluYSAke0VGTF9SRVFVSVJFRF9WRVJTSU9OfSBSRVFVSVJFRCAke0VG TF9DT05GSUdfTU9ERX0pCiBmaW5kX3BhY2thZ2UoRXZhcyAke0VGTF9SRVFVSVJFRF9WRVJTSU9O fSBSRVFVSVJFRCAke0VGTF9DT05GSUdfTU9ERX0pCiBmaW5kX3BhY2thZ2UoRWNvcmUgJHtFRkxf UkVRVUlSRURfVkVSU0lPTn0gQ09NUE9ORU5UUyBFdmFzIEZpbGUgSW5wdXQgSW1mIEltZl9FdmFz ICR7RUNPUkVfQURESVRJT05BTF9DT01QT05FTlRTfSAke0VGTF9DT05GSUdfTU9ERX0pCkBAIC0y ODUsMTEgKzI5Miw2IEBAIGlmIChFTkFCTEVfU1BFTExDSEVDSykKICAgICBmaW5kX3BhY2thZ2Uo RW5jaGFudCBSRVFVSVJFRCkKIGVuZGlmICgpCiAKLWlmIChFTkFCTEVfQUNDRVNTSUJJTElUWSkK LSAgICBmaW5kX3BhY2thZ2UoQVRLIDIuMTAuMCBSRVFVSVJFRCkKLWVsc2UgKCkKLSAgICBhZGRf ZGVmaW5pdGlvbnMoLURIQVZFX0FDQ0VTU0lCSUxJVFk9MCkKLWVuZGlmICgpCiAKIGlmIChFTkFC TEVfU1BFRUNIX1NZTlRIRVNJUykKICAgICBmaW5kX3BhY2thZ2UoRXNwZWFrIFJFUVVJUkVEKQpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDllZGQ4YmIwOTIyNzBjNjA4 Mzg4ODUwMzFlMTQxY2RiZGM2NjI4MGMuLmIyZDI2ZDhmZmI5ZWQ2YmM5ZWE5MTgwMDNjYmU5MDg3 N2Y3ZTA0MGQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNC0xMS0wNiAgRXZhIEJhbGF6c2ZhbHZpICA8ZXZhYi51LXN6ZWdlZEBwYXJ0 bmVyLnNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIFJlcXVpcmUgYXQgbGVhc3QgRUZMIDEu OSBpZiBFTkFCTEUoQUNDRVNTSUJJTElUWSkgYWZ0ZXIgcjE3NTA5OAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDY1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0Vm bC5jbWFrZToKKwogMjAxNC0xMS0wMyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIEVOQUJMRV9GSUxURVJTX0xFVkVMXzIgZmVhdHVyZSBndWFyZC4K