138457 2014-11-06 00:17:53 -0800 Canvas with focusable fallback content does not scroll into view when focus is moved to fallback 2016-01-03 07:24:38 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 jdiggs jdiggs cmarcelo commit-queue eric.carlson esprehn+autocc gyuyoung.kim kangil.han oldest_to_newest 1046748 0 241091 jdiggs 2014-11-06 00:17:53 -0800 Created attachment 241091 test case Steps to reproduce: 1. Load the attached test case in Safari or Epiphany 2. Press Tab to move focus to Link 1 3. Press Tab again to move focus to Link 2 (which is fallback content and not rendered) Expected results: The parent canvas element would be scrolled into view. Actual results: Link 1 loses the focus ring, but the canvas element is not scrolled into view making it difficult to identify what has focus. 1046751 1 241092 jdiggs 2014-11-06 00:24:28 -0800 Created attachment 241092 Patch 1070089 2 246810 jdiggs 2015-02-18 02:21:21 -0800 Created attachment 246810 Patch 1151993 3 246810 mcatanzaro 2016-01-02 10:36:15 -0800 Comment on attachment 246810 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246810&action=review > Source/WebCore/dom/Element.cpp:2053 > + else if (auto* canvas = ancestorsOfType<HTMLCanvasElement>(*this).first()) { Make sure canvas is guaranteed to be non-null. 1152100 4 jdiggs 2016-01-03 07:24:38 -0800 Thanks for the review. I had forgotten about this patch. That said, the previous/obsoleted patch (or some revised version thereof) may need to be the approach taken. The spec changed and scrolling to the top is no longer a requirement. (This is a good thing because scrolling to the top is inconsistent with what some user agents do when other focusable elements need to be scrolled on screen.) See http://www.w3.org/TR/2dcontext/#drawing-paths-to-the-canvas. 241091 2014-11-06 00:17:53 -0800 2014-11-06 00:17:53 -0800 test case focused-link-in-canvas.html text/html 403 jdiggs PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiBydW5UZXN0KCkgewogICAgdmFyIGNhbnZh cyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjYW52YXMiKTsKICAgIGNhbnZhcy5zdHlsZS50 b3AgPSB3aW5kb3cuaW5uZXJIZWlnaHQ7Cn0KPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHkgb25sb2Fk PSJydW5UZXN0KCk7Ij4KPHA+PGEgaHJlZj0ibGluazEiPkxpbmsgMTwvYT48L3A+CjxkaXY+CiAg PGNhbnZhcyBpZD0iY2FudmFzIiBoZWlnaHQ9IjIwMCIgd2lkdGg9IjIwMCIgc3R5bGU9InBvc2l0 aW9uOiBhYnNvbHV0ZTsgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7Ij4KICAgIDxhIGlkPSJsaW5r IiBocmVmPSJsaW5rMiI+TGluayAyPC9hPgogIDwvY2FudmFzPgo8L2Rpdj4KPC9ib2R5Pgo8L2h0 bWw+Cg== 241092 2014-11-06 00:24:28 -0800 2015-02-18 02:21:14 -0800 Patch bug-138457-20141106032438.patch text/plain 4294 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFkNWYwNDQ0ZTAzMmFm ZDk5ZDljOThkYjFlMzM3MDIyY2U0OWJjMi4uMGUwOTlkNzE0NGMzZTMxOTA0OGZiOGVhMTUyNGM2 ZDAyOTFhNmM5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTExLTA2ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBDYW52YXMgd2l0aCBm b2N1c2FibGUgZmFsbGJhY2sgY29udGVudCBkb2VzIG5vdCBzY3JvbGwgaW50byB2aWV3IHdoZW4g Zm9jdXMgaXMgbW92ZWQgdG8gZmFsbGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzODQ1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNjcm9sbCB0aGUgY2FudmFzIGludG8gdmlldyB3aGVuIGFuIHVu cmVuZGVyZWQvZmFsbGJhY2sgZGVzY2VuZGFudCBnYWlucyBmb2N1cy4KKworICAgICAgICBUZXN0 OiBmYXN0L2NhbnZhcy9mb2N1c2VkLWxpbmstaW4tY2FudmFzLmh0bWwKKworICAgICAgICAqIGRv bS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnVwZGF0ZUZvY3VzQXBw ZWFyYW5jZSk6CisKIDIwMTQtMTEtMDUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBTdG9wIHNwZWNpYWwtY2FzaW5nIHRoZSBlbXB0eSBzdHJpbmcgaW4gSFRNTElu cHV0RWxlbWVudC50eXBlIHNldHRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IDUzODFiYzgx MmM2ZmVlNjk5MmNjNTNhYmIxZmE0YzAwYzE2YmRjNTguLjVkNjNmMDYzNTQ5MmIxMjVhODdhNzU5 OTRlNzExZDg2ZTUwODA5ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTE5NjYsNiArMTk2 NiwxMyBAQCB2b2lkIEVsZW1lbnQ6OnVwZGF0ZUZvY3VzQXBwZWFyYW5jZShib29sIC8qcmVzdG9y ZVByZXZpb3VzU2VsZWN0aW9uKi8pCiAgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKHJlbmRlcmVy KCkgJiYgIXJlbmRlcmVyKCktPmlzV2lkZ2V0KCkpCiAgICAgICAgIHJlbmRlcmVyKCktPnNjcm9s bFJlY3RUb1Zpc2libGUoYm91bmRpbmdCb3goKSk7CisgICAgZWxzZSBpZiAoYXV0byogY2FudmFz ID0gYW5jZXN0b3JzT2ZUeXBlPEhUTUxDYW52YXNFbGVtZW50PigqdGhpcykuZmlyc3QoKSkgewor ICAgICAgICAvLyBFbGVtZW50cyBpbiBjYW52YXMgZmFsbGJhY2sgY29udGVudCBhcmUgbm90IHJl bmRlcmVkLCBidXQgdGhleSBhcmUgYWxsb3dlZCB0byBiZQorICAgICAgICAvLyBmb2N1c2FibGUg YXMgbG9uZyBhcyB0aGVpciBjYW52YXMgaXMgZGlzcGxheWVkIGFuZCB2aXNpYmxlLiBBbmQgaW4g dGhhdCBjYXNlIHdlCisgICAgICAgIC8vIHNob3VsZCBzY3JvbGwgdG8gYnJpbmcgdGhlIGNhbnZh cyBpbnRvIHZpZXcuCisgICAgICAgIGlmIChjYW52YXMtPnJlbmRlcmVyKCkgJiYgY2FudmFzLT5y ZW5kZXJlcigpLT5zdHlsZSgpLnZpc2liaWxpdHkoKSA9PSBWSVNJQkxFKQorICAgICAgICAgICAg Y2FudmFzLT5yZW5kZXJlcigpLT5zY3JvbGxSZWN0VG9WaXNpYmxlKGNhbnZhcy0+Ym91bmRpbmdC b3goKSk7CisgICAgfQogfQogCiB2b2lkIEVsZW1lbnQ6OmJsdXIoKQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGNjYjA5YjQ0 ZTMxNmJjMTdhNjBhMzBkYWJkZWNmZjYwMmQwODM5YTUuLmUyMTk2NDUxNGJkZjI3MWRiN2M0YzMz NjE3NGY3N2M4YzNkYWU0OTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0xMS0wNiAgSm9h bm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CisKKyAgICAgICAgQ2FudmFzIHdpdGgg Zm9jdXNhYmxlIGZhbGxiYWNrIGNvbnRlbnQgZG9lcyBub3Qgc2Nyb2xsIGludG8gdmlldyB3aGVu IGZvY3VzIGlzIG1vdmVkIHRvIGZhbGxiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg0NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy9mb2N1c2VkLWxpbmst aW4tY2FudmFzLmh0bWw6IEFkZGVkLgorCiAyMDE0LTExLTA1ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcCBzcGVjaWFsLWNhc2luZyB0aGUgZW1wdHkgc3Ry aW5nIGluIEhUTUxJbnB1dEVsZW1lbnQudHlwZSBzZXR0ZXIKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC9jYW52YXMvZm9jdXNlZC1saW5rLWluLWNhbnZhcy1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uNGVmZGMwZTk1MGQ3ZmFlY2ZjYzc1N2NkNzY4ZDYyYzM4NGM5ZjY0YwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1j YW52YXMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKK1RoaXMgdGVzdHMgdGhhdCBnaXZp bmcgZm9jdXMgdG8gYW4gZWxlbWVudCBpbiBjYW52YXMgZmFsbGJhY2sgY29udGVudCBzY3JvbGxz IHRoZSBjYW52YXMgaW50byB2aWV3LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor UEFTUyBhZnRlclNjcm9sbFkgPiBiZWZvcmVTY3JvbGxZIGlzIHRydWUKK1BBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorTGluayAxCisKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvZm9jdXNlZC1saW5rLWluLWNhbnZhcy5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvZm9jdXNlZC1saW5rLWluLWNhbnZhcy5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjgzOTI4ZTdlMWFmYTFkYjAwNWE1ZmVmYWVjNjNkYjY0MGZjZjcwNDAKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9mb2N1c2VkLWxpbmstaW4tY2FudmFz Lmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi8u Li9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+Cis8cD48YSBocmVmPSIjIj5MaW5rIDE8L2E+PC9wPgorPGRpdj4KKyAgPGNhbnZhcyBp ZD0iY2FudmFzIiBoZWlnaHQ9IjIwMCIgd2lkdGg9IjIwMCIgc3R5bGU9InBvc2l0aW9uOiBhYnNv bHV0ZTsgdG9wOiAxMDAwcHg7IGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOyI+CisgICAgPGEgaWQ9 ImxpbmtJbkNhbnZhcyIgaHJlZj0iIyI+TGluayAyPC9hPgorICA8L2NhbnZhcz4KKzwvZGl2Pgor PHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgZ2l2aW5nIGZvY3VzIHRvIGFu IGVsZW1lbnQgaW4gY2FudmFzIGZhbGxiYWNrIGNvbnRlbnQgc2Nyb2xscyB0aGUgY2FudmFzIGlu dG8gdmlldy4iKTsKK3ZhciBiZWZvcmVTY3JvbGxZID0gd2luZG93LnNjcm9sbFk7Cit2YXIgbGlu a0luQ2FudmFzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxpbmtJbkNhbnZhcyIpOworbGlu a0luQ2FudmFzLmZvY3VzKCk7CisKK3ZhciBhZnRlclNjcm9sbFkgPSB3aW5kb3cuc2Nyb2xsWTsK K3Nob3VsZEJlVHJ1ZSgiYWZ0ZXJTY3JvbGxZID4gYmVmb3JlU2Nyb2xsWSIpOworPC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+ Cis8L2JvZHk+Cis8L2h0bWw+Cg== 246810 2015-02-18 02:21:21 -0800 2016-01-02 10:36:15 -0800 Patch bug-138457-20150218052115.patch text/plain 9405 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGMyYzAxODE1MWQ1YmU2 NmRlOTcxYmZiODFkZjA1YWYyNzM5YmY0MC4uZDAxMGNiNzNiNWZmYzU5ZGUxMzRlMzdmMGIxNDNm MmY4NDE1YTA2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE1LTAyLTE4ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBDYW52YXMgd2l0aCBm b2N1c2FibGUgZmFsbGJhY2sgY29udGVudCBkb2VzIG5vdCBzY3JvbGwgaW50byB2aWV3IHdoZW4g Zm9jdXMgaXMgbW92ZWQgdG8gZmFsbGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzODQ1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEVsZW1lbnRzIGluIGNhbnZhcyBmYWxsYmFjayBjb250ZW50IGFy ZSBub3QgcmVuZGVyZWQsIGJ1dCB0aGV5IGFyZQorICAgICAgICBhbGxvd2VkIHRvIGJlIGZvY3Vz YWJsZSBhcyBsb25nIGFzIHRoZWlyIGNhbnZhcyBpcyBkaXNwbGF5ZWQgYW5kCisgICAgICAgIHZp c2libGUuIEFjY29yZGluZyB0byB0aGUgY3VycmVudCBzcGVjaWZpY2F0aW9uLCAiSWYgdGhlIGZv Y3VzIGFyZWEKKyAgICAgICAgaXMgbm90IG9uIHRoZSBzY3JlZW4sIHRoZW4gc2Nyb2xsIHRoZSBm b2N1cyBvdXRsaW5lIGludG8gdmlldyBieQorICAgICAgICBhbGlnbmluZyBpdCB0byB0aGUgdG9w IHdoZW4gaXQgcmVjZWl2ZXMgZm9jdXMuIiBXZSBub3cgc2Nyb2xsIHRoZQorICAgICAgICBjYW52 YXMgdG8gdGhlIHRvcCBvZiB0aGUgc2NyZWVuLCBhbmQgYWxzbyBkcmF3IHRoZSBmb2N1cyBvdXRs aW5lCisgICAgICAgIHdoaWNoIHdlIHdlcmUgYWxzbyBmYWlsaW5nIHRvIGRvLgorCisgICAgICAg IFRlc3RzOiBmYXN0L2NhbnZhcy9mb2N1c2VkLWxpbmstaW4tY2FudmFzLWZvY3VzLXJpbmcuaHRt bAorICAgICAgICAgICAgICAgZmFzdC9jYW52YXMvZm9jdXNlZC1saW5rLWluLWNhbnZhcy1zY3Jv bGxpbmcuaHRtbAorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6dXBkYXRlRm9jdXNBcHBlYXJhbmNlKToKKyAgICAgICAgU2Nyb2xsIGNhbnZh cyBpbnRvIHZpZXcgd2hlbiBhIGZhbGxiYWNrIGVsZW1lbnQgcmVjZWl2ZXMgZm9jdXMKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpkcmF3Rm9jdXNJZk5lZWRlZEludGVy bmFsKToKKyAgICAgICAgQWxzbyBjb25zaWRlciBpZiB0aGUgZWxlbWVudCBpcyB0aGUgRG9jdW1l bnQncyBmb2N1c2VkIGVsZW1lbnQ7CisgICAgICAgIG5vdCBqdXN0IGlmIHRoZSBlbGVtZW50IGNs YWltcyB0byBiZSBmb2N1c2VkLgorCiAyMDE1LTAyLTE2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFw cGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OOiBWaWRlbyBjb250cm9sIGZhaWxzIHRvIGhp ZGUgYWZ0ZXIgcGxheWJhY2sgYmVnaW5zIGluIHJlZmxvd2FibGUgRVBVQiBmaWxlcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9t L0VsZW1lbnQuY3BwCmluZGV4IDNiNGRiNTRhNzQ5N2I3OTIxOGQyMTc0NDY0MTNhZWJkY2FiMDI3 OWMuLmNlZDRhOTRiMzI4Mzg4OGNiYTJkODRhMDYzZDQyN2UwZjVmMzU2YjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5jcHAKQEAgLTIwNTAsNiArMjA1MCwxNSBAQCB2b2lkIEVsZW1lbnQ6OnVwZGF0ZUZv Y3VzQXBwZWFyYW5jZShib29sIC8qcmVzdG9yZVByZXZpb3VzU2VsZWN0aW9uKi8pCiAgICAgICAg IH0KICAgICB9IGVsc2UgaWYgKHJlbmRlcmVyKCkgJiYgIXJlbmRlcmVyKCktPmlzV2lkZ2V0KCkp CiAgICAgICAgIHJlbmRlcmVyKCktPnNjcm9sbFJlY3RUb1Zpc2libGUocmVuZGVyZXIoKS0+YW5j aG9yUmVjdCgpKTsKKyAgICBlbHNlIGlmIChhdXRvKiBjYW52YXMgPSBhbmNlc3RvcnNPZlR5cGU8 SFRNTENhbnZhc0VsZW1lbnQ+KCp0aGlzKS5maXJzdCgpKSB7CisgICAgICAgIC8vIEVsZW1lbnRz IGluIGNhbnZhcyBmYWxsYmFjayBjb250ZW50IGFyZSBub3QgcmVuZGVyZWQsIGJ1dCB0aGV5IGFy ZSBhbGxvd2VkIHRvIGJlIGZvY3VzYWJsZQorICAgICAgICAvLyBhcyBsb25nIGFzIHRoZWlyIGNh bnZhcyBpcyBkaXNwbGF5ZWQgYW5kIHZpc2libGUuIEFjY29yZGluZyB0byB0aGUgY3VycmVudCBz cGVjaWZpY2F0aW9uLAorICAgICAgICAvLyAiSWYgdGhlIGZvY3VzIGFyZWEgaXMgbm90IG9uIHRo ZSBzY3JlZW4sIHRoZW4gc2Nyb2xsIHRoZSBmb2N1cyBvdXRsaW5lIGludG8gdmlldyBieSBhbGln bmluZworICAgICAgICAvLyBpdCB0byB0aGUgdG9wIHdoZW4gaXQgcmVjZWl2ZXMgZm9jdXMuIiBT ZWUgU3RlcCAzIG9mOgorICAgICAgICAvLyBodHRwOi8vd3d3LnczLm9yZy9odG1sL3dnL2RyYWZ0 cy8yZGNvbnRleHQvaHRtbDVfY2FudmFzX0NSLyNkcmF3aW5nLXBhdGhzLXRvLXRoZS1jYW52YXMK KyAgICAgICAgaWYgKGNhbnZhcy0+cmVuZGVyZXIoKSAmJiBjYW52YXMtPnJlbmRlcmVyKCktPnN0 eWxlKCkudmlzaWJpbGl0eSgpID09IFZJU0lCTEUpCisgICAgICAgICAgICBjYW52YXMtPnNjcm9s bEludG9WaWV3KHRydWUpOworICAgIH0KIH0KIAogdm9pZCBFbGVtZW50OjpibHVyKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQy RC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0 MkQuY3BwCmluZGV4IDA5ZGIzMTZiNWM2OGM5NWNjNDNkZGJmNGFkN2RmMDE4MmUxZDJmOWUuLmVi YjgzODViNTU0YmZmNTY0MzY1NGZmMzY3MGFiNjExMjczNTFkZDAgMTAwNzU1Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApA QCAtMTk4Niw4ICsxOTg2LDkgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmRyYXdG b2N1c0lmTmVlZGVkSW50ZXJuYWwoY29uc3QgUGF0aCYgcGF0aCwgRWxlbWUKIHsKICAgICBHcmFw aGljc0NvbnRleHQqIGNvbnRleHQgPSBkcmF3aW5nQ29udGV4dCgpOwogCi0gICAgaWYgKCFlbGVt ZW50IHx8ICFlbGVtZW50LT5mb2N1c2VkKCkgfHwgIXN0YXRlKCkubV9oYXNJbnZlcnRpYmxlVHJh bnNmb3JtIHx8IHBhdGguaXNFbXB0eSgpCi0gICAgICAgIHx8ICFlbGVtZW50LT5pc0Rlc2NlbmRh bnRPZihjYW52YXMoKSkgfHwgIWNvbnRleHQpCisgICAgLy8gZHJhd0ZvY3VzSWZOZWVkZWQgY2Fu IGJlIGNhbGxlZCBiZWZvcmUgRG9jdW1lbnQ6OnNldEZvY3VzZWRFbGVtZW50IGhhcyBjYWxsZWQg RWxlbWVudDo6c2V0Rm9jdXMuCisgICAgaWYgKCFlbGVtZW50IHx8ICghZWxlbWVudC0+Zm9jdXNl ZCgpICYmIGVsZW1lbnQgIT0gY2FudmFzKCktPmRvY3VtZW50KCkuZm9jdXNlZEVsZW1lbnQoKSkK KyAgICAgICAgfHwgIXN0YXRlKCkubV9oYXNJbnZlcnRpYmxlVHJhbnNmb3JtIHx8IHBhdGguaXNF bXB0eSgpIHx8ICFlbGVtZW50LT5pc0Rlc2NlbmRhbnRPZihjYW52YXMoKSkgfHwgIWNvbnRleHQp CiAgICAgICAgIHJldHVybjsKIAogICAgIGNvbnRleHQtPmRyYXdGb2N1c1JpbmcocGF0aCwgMSwg MSwgUmVuZGVyVGhlbWU6OmZvY3VzUmluZ0NvbG9yKCkpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVjZTU1Yjk2OGUxMGIw YTFjZjYzOWIxZDQ3MzdjM2Y5NWMyZTgyNWMuLjI2NzA3NmJmYzgxNzUyZDllMjFmZDAyYzMxYTIz YjI3ODJhNzI3YmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wMi0xOCAgSm9hbm1hcmll IERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+CisKKyAgICAgICAgQ2FudmFzIHdpdGggZm9jdXNh YmxlIGZhbGxiYWNrIGNvbnRlbnQgZG9lcyBub3Qgc2Nyb2xsIGludG8gdmlldyB3aGVuIGZvY3Vz IGlzIG1vdmVkIHRvIGZhbGxiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzg0NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMtZm9jdXMt cmluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL2ZvY3VzZWQt bGluay1pbi1jYW52YXMtZm9jdXMtcmluZy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nh bnZhcy9mb2N1c2VkLWxpbmstaW4tY2FudmFzLXNjcm9sbGluZy1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMtc2Nyb2xsaW5n Lmh0bWw6IEFkZGVkLgorCiAyMDE1LTAyLTE2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wcm92ZWQgQ29uc29sZSBTdXBw b3J0IGZvciBCb3VuZCBGdW5jdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2Fu dmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMtZm9jdXMtcmluZy1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy9mb2N1c2VkLWxpbmstaW4tY2FudmFzLWZvY3VzLXJpbmctZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ4NjU4MWFmMmMzNjRmNDA2YWU4NTU1YWFjZWUxNGYwMDRj YjhjZTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9mb2N1c2Vk LWxpbmstaW4tY2FudmFzLWZvY3VzLXJpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTUgQEAK K1RoaXMgdGVzdHMgdGhhdCBnaXZpbmcgZm9jdXMgdG8gYW4gZWxlbWVudCBpbiBjYW52YXMgZmFs bGJhY2sgY29udGVudCBkcmF3cyBhIGZvY3VzIHJpbmcuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KKworCitQQVNTIGZvY3VzUmluZ1dhc0RyYXduT25DYW52YXMoY2FudmFzLCBsaW5rSW5Q YXJhZ3JhcGgpIGlzIGZhbHNlCitQQVNTIGZvY3VzUmluZ1dhc0RyYXduT25DYW52YXMoY2FudmFz LCBsaW5rSW5DYW52YXMpIGlzIHRydWUKK1BBU1MgZm9jdXNSaW5nV2FzRHJhd25PbkNhbnZhcyhj YW52YXMsIGxpbmtJblBhcmFncmFwaCkgaXMgZmFsc2UKK1BBU1MgZm9jdXNSaW5nV2FzRHJhd25P bkNhbnZhcyhjYW52YXMsIGxpbmtJbkNhbnZhcykgaXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitMaW5rIDEKKworCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9mb2N1c2VkLWxpbmstaW4tY2FudmFzLWZvY3VzLXJpbmcu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMtZm9j dXMtcmluZy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE2M2JiODRkMzI0MDgxYjc0OGVkNTZjYWVkNDhkN2Yy YjAwNjEwNWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9mb2N1 c2VkLWxpbmstaW4tY2FudmFzLWZvY3VzLXJpbmcuaHRtbApAQCAtMCwwICsxLDUwIEBACis8aHRt bD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+ PC9zY3JpcHQ+Cis8c2NyaXB0PgorICAgIGZ1bmN0aW9uIGZvY3VzUmluZ1dhc0RyYXduT25DYW52 YXMoY2FudmFzLCBmb2N1c2VkRWxlbWVudCkgeworICAgICAgICB2YXIgY29udGV4dCA9IGNhbnZh cy5nZXRDb250ZXh0KCIyZCIpOworICAgICAgICB2YXIgcGF0aCA9IG5ldyBQYXRoMkQoKTsKKyAg ICAgICAgcGF0aC5yZWN0KDEwLCAxMCwgMTAsIDEwKTsKKyAgICAgICAgY29udGV4dC5kcmF3Rm9j dXNJZk5lZWRlZChwYXRoLCBmb2N1c2VkRWxlbWVudCk7CisKKyAgICAgICAgdmFyIGltYWdlZGF0 YSA9IGNvbnRleHQuZ2V0SW1hZ2VEYXRhKDAsIDAsIDMwLCAzMCk7CisgICAgICAgIHZhciB0b3Rh bCA9IDA7CisgICAgICAgIGZvcih2YXIgeCA9IDA7IHggPCAzMCAqIDMwICogNDsgeCsrKQorICAg ICAgICAgICAgdG90YWwgKz0gaW1hZ2VkYXRhLmRhdGFbeF07CisKKyAgICAgICAgY29udGV4dC5j bGVhclJlY3QoMCwgMCwgY2FudmFzLndpZHRoLCBjYW52YXMuaGVpZ2h0KTsKKyAgICAgICAgcmV0 dXJuIHRvdGFsICE9IDA7CisgICAgfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYg aWQ9ImNvbnNvbGUiPjwvZGl2PgorPGRpdj4KKzxwPjxhIGlkPSJsaW5rSW5QYXJhZ3JhcGgiIGhy ZWY9IiMiPkxpbmsgMTwvYT48L3A+Cis8Y2FudmFzIGlkPSJjYW52YXMiIGhlaWdodD0iMzAiIHdp ZHRoPSIzMCI+Cis8YSBpZD0ibGlua0luQ2FudmFzIiBocmVmPSIjIj5MaW5rIDI8L2E+Cis8L2Nh bnZhcz4KKzwvZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgZ2l2 aW5nIGZvY3VzIHRvIGFuIGVsZW1lbnQgaW4gY2FudmFzIGZhbGxiYWNrIGNvbnRlbnQgZHJhd3Mg YSBmb2N1cyByaW5nLiIpOworCit2YXIgY2FudmFzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImNhbnZhcyIpOwordmFyIGxpbmtJblBhcmFncmFwaCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJsaW5rSW5QYXJhZ3JhcGgiKTsKK3ZhciBsaW5rSW5DYW52YXMgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgibGlua0luQ2FudmFzIik7CisKK2xpbmtJblBhcmFncmFwaC5mb2N1cygpOworc2hv dWxkQmVGYWxzZSgiZm9jdXNSaW5nV2FzRHJhd25PbkNhbnZhcyhjYW52YXMsIGxpbmtJblBhcmFn cmFwaCkiKTsKKworbGlua0luQ2FudmFzLmZvY3VzKCk7CitzaG91bGRCZVRydWUoImZvY3VzUmlu Z1dhc0RyYXduT25DYW52YXMoY2FudmFzLCBsaW5rSW5DYW52YXMpIik7CisKK2xpbmtJblBhcmFn cmFwaC5mb2N1cygpOworc2hvdWxkQmVGYWxzZSgiZm9jdXNSaW5nV2FzRHJhd25PbkNhbnZhcyhj YW52YXMsIGxpbmtJblBhcmFncmFwaCkiKTsKKworbGlua0luQ2FudmFzLmZvY3VzKCk7CitzaG91 bGRCZVRydWUoImZvY3VzUmluZ1dhc0RyYXduT25DYW52YXMoY2FudmFzLCBsaW5rSW5DYW52YXMp Iik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0 LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMtc2Nyb2xsaW5nLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMtc2Nyb2xs aW5nLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNTc0NmEyZmRlZGRjMDc4MGU4MDUzODQxMWQ5 OWFiYmM1NmYxMjI0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMv Zm9jdXNlZC1saW5rLWluLWNhbnZhcy1zY3JvbGxpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs MTMgQEAKK1RoaXMgdGVzdHMgdGhhdCBnaXZpbmcgZm9jdXMgdG8gYW4gZWxlbWVudCBpbiBjYW52 YXMgZmFsbGJhY2sgY29udGVudCBzY3JvbGxzIHRoZSBjYW52YXMgaW50byB2aWV3LgorCitPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB3aW5kb3cuc2Nyb2xsWSAhPSAxMDAwIGlz IHRydWUKK1BBU1Mgd2luZG93LnNjcm9sbFkgPT0gMTAwMCBpcyB0cnVlCitQQVNTIHN1Y2Nlc3Nm dWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK0xpbmsgMQorCisKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2ZvY3VzZWQtbGluay1pbi1jYW52YXMtc2Nyb2xs aW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9mb2N1c2VkLWxpbmstaW4tY2FudmFz LXNjcm9sbGluZy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjUxN2MwODgzNWRiMDMxNjY2ZDQxNzE2MmM4MGI4 ZGFiNGI2YTU4MjUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9m b2N1c2VkLWxpbmstaW4tY2FudmFzLXNjcm9sbGluZy5odG1sCkBAIC0wLDAgKzEsMTkgQEAKKzxo dG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz Ij48L3NjcmlwdD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHA+PGEgaHJlZj0iIyI+TGlu ayAxPC9hPjwvcD4KKzxkaXYgc3R5bGU9ImhlaWdodDogMjAwMHB4OyI+CisgIDxjYW52YXMgaWQ9 ImNhbnZhcyIgaGVpZ2h0PSIyMDAiIHdpZHRoPSIyMDAiIHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1 dGU7IHRvcDogMTAwMHB4OyBib3JkZXI6IDFweCBzb2xpZCBibGFjazsiPgorICAgIDxhIGlkPSJs aW5rSW5DYW52YXMiIGhyZWY9IiMiPkxpbmsgMjwvYT4KKyAgPC9jYW52YXM+Cis8L2Rpdj4KKzxz Y3JpcHQ+CitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IGdpdmluZyBmb2N1cyB0byBhbiBl bGVtZW50IGluIGNhbnZhcyBmYWxsYmFjayBjb250ZW50IHNjcm9sbHMgdGhlIGNhbnZhcyBpbnRv IHZpZXcuIik7CitzaG91bGRCZVRydWUoIndpbmRvdy5zY3JvbGxZICE9IDEwMDAiKTsKK2RvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJsaW5rSW5DYW52YXMiKS5mb2N1cygpOworc2hvdWxkQmVUcnVl KCJ3aW5kb3cuc2Nyb2xsWSA9PSAxMDAwIik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8u Li9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K