138445 2014-11-05 15:19:27 -0800 It should be possible to open a page preview by clicking on it 2014-11-05 15:54:23 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz bdakin commit-queue conrad_shultz thorton webkit-bug-importer oldest_to_newest 1046624 0 conrad_shultz 2014-11-05 15:19:27 -0800 It should be possible to open a page preview by clicking on it. 1046627 1 webkit-bug-importer 2014-11-05 15:20:25 -0800 <rdar://problem/18887218> 1046634 2 241065 conrad_shultz 2014-11-05 15:33:42 -0800 Created attachment 241065 Patch 1046635 3 241065 conrad_shultz 2014-11-05 15:36:18 -0800 Comment on attachment 241065 Patch Will rebase and post a new patch. 1046639 4 241067 conrad_shultz 2014-11-05 15:43:21 -0800 Created attachment 241067 Patch 1046640 5 commit-queue 2014-11-05 15:44:32 -0800 Attachment 241067 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:351: The parameter name "pagePreviewViewController" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:815: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1046643 6 thorton 2014-11-05 15:54:23 -0800 http://trac.webkit.org/changeset/175646 241065 2014-11-05 15:33:42 -0800 2014-11-05 15:36:18 -0800 Patch bug-138445-20141105153352.patch text/plain 5979 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTFiNzYzMTY3MzlkNDI0 ZWM4YTVlM2I5NzFmMmE4NDI5Y2MxMjE1Yy4uYTgyNmViMGU3M2M5OTJhYTdhZDgwMGRiODg1ZWZj YmNjZjUzZmI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE0LTExLTA1ICBDb25y YWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CisKKyAgICAgICAgSXQgc2hvdWxk IGJlIHBvc3NpYmxlIHRvIG9wZW4gYSBwYWdlIHByZXZpZXcgYnkgY2xpY2tpbmcgb24gaXQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODQ0NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNsaWNr IHJlY29nbml6ZXIgdG8gV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyIGFuZCBwbHVtYiBpdCB0 aHJvdWdoIHRvIFdLQWN0aW9uTWVudUNvbnRyb2xsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv bWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW06CisgICAgICAgIERlY2xhcmUgPFdLUGFnZVBy ZXZpZXdWaWV3Q29udHJvbGxlckRlbGVnYXRlPiwgY3VycmVudGx5IGhvbWUgdG8ganVzdCBhIHNp bmdsZSBtZXRob2QuCisgICAgICAgICgtW1dLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciBsb2Fk Vmlld10pOgorICAgICAgICBDb25maWd1cmUgYW5kIGFkZCBhIGNsaWNrIGdlc3R1cmUgcmVjb2du aXplciB0byB0aGUgV0tXZWJWaWV3LgorICAgICAgICAoLVtXS1BhZ2VQcmV2aWV3Vmlld0NvbnRy b2xsZXIgX2NsaWNrUmVjb2duaXplZDpdKToKKyAgICAgICAgR2VzdHVyZSByZWNvZ25pemVyIGFj dGlvbjsgc2VuZCAtcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcldhc0NsaWNrZWQ6IHRvIHRoZSBk ZWxlZ2F0ZS4KKyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29udHJvbGxlciB3aWxsRGVzdHJveVZp ZXc6XSk6CisgICAgICAgIEV4dHJhY3QgY29kZSB0byAtX2NsZWFyUHJldmlld1BvcG92ZXIuCisg ICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgZGlkQ2xvc2VNZW51OndpdGhFdmVudDpd KToKKyAgICAgICAgRGl0dG8uCisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgX2Ny ZWF0ZVByZXZpZXdQb3BvdmVyRm9yVVJMOl0pOgorICAgICAgICBTZXQgb3Vyc2VsZiBhcyB0aGUg ZGVsZWdhdGUgb2YgdGhlIHBhZ2UgcHJldmlldyBjb250cm9sbGVyLgorICAgICAgICAoLVtXS0Fj dGlvbk1lbnVDb250cm9sbGVyIF9jbGVhclByZXZpZXdQb3BvdmVyXSk6CisgICAgICAgIEV4dHJh Y3RlZCBmcm9tIHZhcmlvdXMgb3RoZXIgbWV0aG9kczsgaWYgYXBwcm9wcmlhdGUsIG5pbCBvdXQg dGhlIHByZXZpZXcgdmlldyBjb250cm9sbGVyJ3MgZGVsZWdhdGUuCisgICAgICAgICgtW1dLQWN0 aW9uTWVudUNvbnRyb2xsZXIgcG9wb3ZlcldpbGxDbG9zZTpdKToKKyAgICAgICAgRXh0cmFjdCBj b2RlIHRvIC1fY2xlYXJQcmV2aWV3UG9wb3Zlci4KKyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29u dHJvbGxlciBwYWdlUHJldmlld1ZpZXdDb250cm9sbGVyV2FzQ2xpY2tlZDpdKToKKyAgICAgICAg V0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyRGVsZWdhdGUgbWV0aG9kOyBvcGVuIHRoZSBVUkwg b2YgdGhlIGNsaWNrZWQgcGFnZS4KKwogMjAxNC0xMS0wNCAgSm9uIEhvbmV5Y3V0dCAgPGpob25l eWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkNvbnRlbnQgY3Jhc2ggaW4gV2ViUGFnZTo6 c2VsZWN0V2l0aEdlc3R1cmUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCmluZGV4IDRlODQwYmUyZjgzYTQwYWVkZGNj MmUyNmNjNzgwZjZjOGZmYWE0NTkuLjg0MmZhODk0OTY5ZGY2NDA0NGU3ZDcwOWU3MmNhYWY0NTFh MGY4MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25N ZW51Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0 aW9uTWVudUNvbnRyb2xsZXIubW0KQEAgLTcyLDEyICs3MiwxOCBAQCB1c2luZyBuYW1lc3BhY2Ug V2ViS2l0OwogQGVuZAogCiAjaWYgV0tfQVBJX0VOQUJMRUQKKworQGNsYXNzIFdLUGFnZVByZXZp ZXdWaWV3Q29udHJvbGxlcjsKKworQHByb3RvY29sIFdLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxl ckRlbGVnYXRlIDxOU09iamVjdD4KKy0gKHZvaWQpcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcldh c0NsaWNrZWQ6KFdLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciAqKXBhZ2VQcmV2aWV3Vmlld0Nv bnRyb2xsZXI7CitAZW5kCisKIEBpbnRlcmZhY2UgV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVy IDogTlNWaWV3Q29udHJvbGxlciB7CiBAcHVibGljCiAgICAgTlNTaXplIF9wcmVmZXJyZWRTaXpl OwotCi1AcHJpdmF0ZQogICAgIFJldGFpblB0cjxOU1VSTD4gX3VybDsKKyAgICBpZCA8V0tQYWdl UHJldmlld1ZpZXdDb250cm9sbGVyRGVsZWdhdGU+IF9kZWxlZ2F0ZTsKIH0KIAogLSAoaW5zdGFu Y2V0eXBlKWluaXRXaXRoUGFnZVVSTDooTlNVUkwgKilVUkw7CkBAIC0xMDUsMTAgKzExMSwyMSBA QCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogICAgICAgICBOU1VSTFJlcXVlc3QgKnJlcXVlc3Qg PSBbTlNVUkxSZXF1ZXN0IHJlcXVlc3RXaXRoVVJMOl91cmwuZ2V0KCldOwogICAgICAgICBbd2Vi VmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKICAgICB9CisgICAgUmV0YWluUHRyPE5TQ2xpY2tH ZXN0dXJlUmVjb2duaXplcj4gY2xpY2tSZWNvZ25pemVyID0gYWRvcHROUyhbW05TQ2xpY2tHZXN0 dXJlUmVjb2duaXplciBhbGxvY10gaW5pdFdpdGhUYXJnZXQ6c2VsZiBhY3Rpb246QHNlbGVjdG9y KF9jbGlja1JlY29nbml6ZWQ6KV0pOworICAgIFt3ZWJWaWV3IGFkZEdlc3R1cmVSZWNvZ25pemVy OmNsaWNrUmVjb2duaXplci5nZXQoKV07CiAgICAgc2VsZi52aWV3ID0gd2ViVmlldy5nZXQoKTsK IH0KIAorLSAodm9pZClfY2xpY2tSZWNvZ25pemVkOihOU0dlc3R1cmVSZWNvZ25pemVyICopZ2Vz dHVyZVJlY29nbml6ZXIKK3sKKyAgICBbX2RlbGVnYXRlIHBhZ2VQcmV2aWV3Vmlld0NvbnRyb2xs ZXJXYXNDbGlja2VkOnNlbGZdOworfQorCiBAZW5kCisKK0BpbnRlcmZhY2UgV0tBY3Rpb25NZW51 Q29udHJvbGxlciAoKSA8V0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyRGVsZWdhdGU+CitAZW5k CisKICNlbmRpZgogCiBAaW1wbGVtZW50YXRpb24gV0tBY3Rpb25NZW51Q29udHJvbGxlcgpAQCAt MTMyLDggKzE0OSw3IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAgICAgX3BhZ2UgPSBudWxs cHRyOwogICAgIF93a1ZpZXcgPSBudWxscHRyOwogICAgIF9oaXRUZXN0UmVzdWx0ID0gQWN0aW9u TWVudUhpdFRlc3RSZXN1bHQoKTsKLSAgICBbX3ByZXZpZXdQb3BvdmVyIHNldERlbGVnYXRlOm5p bF07Ci0gICAgX3ByZXZpZXdQb3BvdmVyID0gbmlsOworCiB9CiAKIC0gKHZvaWQpcHJlcGFyZUZv ck1lbnU6KE5TTWVudSAqKW1lbnUgd2l0aEV2ZW50OihOU0V2ZW50ICopZXZlbnQKQEAgLTE4Niwx MSArMjAyLDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICBpZiAoX3R5cGUgPT0ga1dL QWN0aW9uTWVudURhdGFEZXRlY3RlZEl0ZW0gJiYgbWVudS5udW1iZXJPZkl0ZW1zID4gMSkKICAg ICAgICAgW3NlbGYgX2hpZGVUZXh0SW5kaWNhdG9yXTsKIAotICAgIGlmICghX3Nob3VsZEtlZXBQ cmV2aWV3UG9wb3Zlck9wZW4pIHsKLSAgICAgICAgW19wcmV2aWV3UG9wb3ZlciBjbG9zZV07Ci0g ICAgICAgIFtfcHJldmlld1BvcG92ZXIgc2V0RGVsZWdhdGU6bmlsXTsKLSAgICAgICAgX3ByZXZp ZXdQb3BvdmVyID0gbmlsOwotICAgIH0KKyAgICBpZiAoIV9zaG91bGRLZWVwUHJldmlld1BvcG92 ZXJPcGVuKQorICAgICAgICBbc2VsZiBfY2xlYXJQcmV2aWV3UG9wb3Zlcl07CiAKICAgICBfc3Rh dGUgPSBBY3Rpb25NZW51U3RhdGU6Ok5vbmU7CiAgICAgX2hpdFRlc3RSZXN1bHQgPSBBY3Rpb25N ZW51SGl0VGVzdFJlc3VsdCgpOwpAQCAtMjg3LDYgKzMwMCw3IEBAIHVzaW5nIG5hbWVzcGFjZSBX ZWJLaXQ7CiAgICAgUmV0YWluUHRyPFdLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcj4gcHJldmll d1ZpZXdDb250cm9sbGVyID0gYWRvcHROUyhbW1dLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciBh bGxvY10gaW5pdFdpdGhQYWdlVVJMOnVybF0pOwogICAgIE5TUmVjdCB3a1ZpZXdCb3VuZHMgPSBb X3drVmlldyBib3VuZHNdOwogICAgIHByZXZpZXdWaWV3Q29udHJvbGxlci0+X3ByZWZlcnJlZFNp emUgPSBOU01ha2VTaXplKE5TV2lkdGgod2tWaWV3Qm91bmRzKSAqIDAuNzUsIE5TSGVpZ2h0KHdr Vmlld0JvdW5kcykgKiAwLjc1KTsKKyAgICBwcmV2aWV3Vmlld0NvbnRyb2xsZXItPl9kZWxlZ2F0 ZSA9IHNlbGY7CiAKICAgICBfcHJldmlld1BvcG92ZXIgPSBhZG9wdE5TKFtbTlNQb3BvdmVyIGFs bG9jXSBpbml0XSk7CiAgICAgW19wcmV2aWV3UG9wb3ZlciBzZXRCZWhhdmlvcjpOU1BvcG92ZXJC ZWhhdmlvclRyYW5zaWVudF07CkBAIC0yOTUsNiArMzA5LDE4IEBAIHVzaW5nIG5hbWVzcGFjZSBX ZWJLaXQ7CiB9CiAjZW5kaWYKIAorLSAodm9pZClfY2xlYXJQcmV2aWV3UG9wb3ZlcgoreworI2lm IFdLX0FQSV9FTkFCTEVECisgICAgaWYgKFdLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciAqcGFn ZVByZXZpZXdWaWV3Q29udHJvbGxlciA9IChXS1BhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIgKilb X3ByZXZpZXdQb3BvdmVyIGNvbnRlbnRWaWV3Q29udHJvbGxlcl0pCisgICAgICAgIHBhZ2VQcmV2 aWV3Vmlld0NvbnRyb2xsZXItPl9kZWxlZ2F0ZSA9IG5pbDsKKyNlbmRpZgorCisgICAgW19wcmV2 aWV3UG9wb3ZlciBjbG9zZV07CisgICAgW19wcmV2aWV3UG9wb3ZlciBzZXREZWxlZ2F0ZTpuaWxd OworICAgIF9wcmV2aWV3UG9wb3ZlciA9IG5pbDsKK30KKwogI3ByYWdtYSBtYXJrIEltYWdlIGFj dGlvbnMKIAogLSAoTlNBcnJheSAqKV9kZWZhdWx0TWVudUl0ZW1zRm9ySW1hZ2UKQEAgLTU2OSw3 ICs1OTUsNyBAQCBzdGF0aWMgTlNTdHJpbmcgKnBhdGhUb1Bob3RvT25EaXNrKE5TU3RyaW5nICpz dWdnZXN0ZWRGaWxlbmFtZSkKIC0gKHZvaWQpcG9wb3ZlcldpbGxDbG9zZTooTlNOb3RpZmljYXRp b24gKilub3RpZmljYXRpb24KIHsKICAgICBfc2hvdWxkS2VlcFByZXZpZXdQb3BvdmVyT3BlbiA9 IE5POwotICAgIF9wcmV2aWV3UG9wb3ZlciA9IG5pbDsKKyAgICBbc2VsZiBfY2xlYXJQcmV2aWV3 UG9wb3Zlcl07CiB9CiAKICNwcmFnbWEgbWFyayBNZW51IEl0ZW1zCkBAIC03NDQsNiArNzcwLDE4 IEBAIHN0YXRpYyBOU0ltYWdlICp3ZWJLaXRCdW5kbGVJbWFnZU5hbWVkKE5TU3RyaW5nICpuYW1l KQogICAgICAgICBbX3drVmlldy5hY3Rpb25NZW51IGFkZEl0ZW06aXRlbV07CiB9CiAKKyNpZiBX S19BUElfRU5BQkxFRAorCisjcHJhZ21hIG1hcmsgV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVy RGVsZWdhdGUKKworLSAodm9pZClwYWdlUHJldmlld1ZpZXdDb250cm9sbGVyV2FzQ2xpY2tlZDoo V0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyICopcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcgor eworICAgIGlmIChOU1VSTCAqdXJsID0gcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlci0+X3VybC5n ZXQoKSkKKyAgICAgICAgW1tOU1dvcmtzcGFjZSBzaGFyZWRXb3Jrc3BhY2VdIG9wZW5VUkw6dXJs XTsKK30KKworI2VuZGlmCisKIEBlbmQKIAogI2VuZGlmIC8vIFBMQVRGT1JNKE1BQykK 241067 2014-11-05 15:43:21 -0800 2014-11-05 15:50:33 -0800 Patch bug-138445-20141105154332.patch text/plain 6134 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2VmN2VkYmNmMjNhMmI0 ODQ0ZTY5ZTk3ZTY3YWI5MTY0OThiMDgzNy4uZmE3NTVkOTBkMWQzYjdkMGJlZjY0YmE4YzA4MTNk MzgzNWU0MzFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE0LTExLTA1ICBDb25y YWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CisKKyAgICAgICAgSXQgc2hvdWxk IGJlIHBvc3NpYmxlIHRvIG9wZW4gYSBwYWdlIHByZXZpZXcgYnkgY2xpY2tpbmcgb24gaXQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODQ0NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNsaWNr IHJlY29nbml6ZXIgdG8gV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyIGFuZCBwbHVtYiBpdCB0 aHJvdWdoIHRvIFdLQWN0aW9uTWVudUNvbnRyb2xsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv bWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW06CisgICAgICAgIERlY2xhcmUgPFdLUGFnZVBy ZXZpZXdWaWV3Q29udHJvbGxlckRlbGVnYXRlPiwgY3VycmVudGx5IGhvbWUgdG8ganVzdCBhIHNp bmdsZSBtZXRob2QuCisgICAgICAgICgtW1dLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciBsb2Fk Vmlld10pOgorICAgICAgICBDb25maWd1cmUgYW5kIGFkZCBhIGNsaWNrIGdlc3R1cmUgcmVjb2du aXplciB0byB0aGUgV0tXZWJWaWV3LgorICAgICAgICAoLVtXS1BhZ2VQcmV2aWV3Vmlld0NvbnRy b2xsZXIgX2NsaWNrUmVjb2duaXplZDpdKToKKyAgICAgICAgR2VzdHVyZSByZWNvZ25pemVyIGFj dGlvbjsgc2VuZCAtcGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcldhc0NsaWNrZWQ6IHRvIHRoZSBk ZWxlZ2F0ZS4KKyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29udHJvbGxlciB3aWxsRGVzdHJveVZp ZXc6XSk6CisgICAgICAgIEV4dHJhY3QgY29kZSB0byAtX2NsZWFyUHJldmlld1BvcG92ZXIuCisg ICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgZGlkQ2xvc2VNZW51OndpdGhFdmVudDpd KToKKyAgICAgICAgRGl0dG8uCisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgX2Ny ZWF0ZVByZXZpZXdQb3BvdmVyRm9yVVJMOl0pOgorICAgICAgICBTZXQgb3Vyc2VsZiBhcyB0aGUg ZGVsZWdhdGUgb2YgdGhlIHBhZ2UgcHJldmlldyBjb250cm9sbGVyLgorICAgICAgICAoLVtXS0Fj dGlvbk1lbnVDb250cm9sbGVyIF9jbGVhclByZXZpZXdQb3BvdmVyXSk6CisgICAgICAgIEV4dHJh Y3RlZCBmcm9tIHZhcmlvdXMgb3RoZXIgbWV0aG9kczsgaWYgYXBwcm9wcmlhdGUsIG5pbCBvdXQg dGhlIHByZXZpZXcgdmlldyBjb250cm9sbGVyJ3MgZGVsZWdhdGUuCisgICAgICAgICgtW1dLQWN0 aW9uTWVudUNvbnRyb2xsZXIgcG9wb3ZlcldpbGxDbG9zZTpdKToKKyAgICAgICAgRXh0cmFjdCBj b2RlIHRvIC1fY2xlYXJQcmV2aWV3UG9wb3Zlci4KKyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29u dHJvbGxlciBwYWdlUHJldmlld1ZpZXdDb250cm9sbGVyV2FzQ2xpY2tlZDpdKToKKyAgICAgICAg V0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyRGVsZWdhdGUgbWV0aG9kOyBvcGVuIHRoZSBVUkwg b2YgdGhlIGNsaWNrZWQgcGFnZS4KKwogMjAxNC0xMS0wNSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBh cHBsZS5jb20+CiAKICAgICAgICAgUGFnZSBwcmV2aWV3IHBvcG92ZXIgc2hvdWxkIHNob3cgc2Nh bGVkLWRvd24gd2ViIGNvbnRlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9tYWMvV0tBY3Rpb25NZW51Q29udHJvbGxlci5tbQppbmRleCBmYTQ1MzMxNDRiNTYwYzE3ZTll YmE5MmFlMWU0OGZkNjE0YjdhMDRkLi5hYTAxMTQ4ZWEwNjIzMWE1YjIzZGZkYjIxNzA1YjRmZGQ5 MjQwNzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9u TWVudUNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Fj dGlvbk1lbnVDb250cm9sbGVyLm1tCkBAIC03NCwxMiArNzQsMTggQEAgc3RhdGljIGNvbnN0IENH RmxvYXQgcG9wb3ZlclRvVmlld1NjYWxlID0gMC43NTsKIEBlbmQKIAogI2lmIFdLX0FQSV9FTkFC TEVECisKK0BjbGFzcyBXS1BhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXI7CisKK0Bwcm90b2NvbCBX S1BhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXJEZWxlZ2F0ZSA8TlNPYmplY3Q+CistICh2b2lkKXBh Z2VQcmV2aWV3Vmlld0NvbnRyb2xsZXJXYXNDbGlja2VkOihXS1BhZ2VQcmV2aWV3Vmlld0NvbnRy b2xsZXIgKilwYWdlUHJldmlld1ZpZXdDb250cm9sbGVyOworQGVuZAorCiBAaW50ZXJmYWNlIFdL UGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciA6IE5TVmlld0NvbnRyb2xsZXIgewogQHB1YmxpYwog ICAgIE5TU2l6ZSBfbWFpblZpZXdTaXplOwotCi1AcHJpdmF0ZQogICAgIFJldGFpblB0cjxOU1VS TD4gX3VybDsKKyAgICBpZCA8V0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyRGVsZWdhdGU+IF9k ZWxlZ2F0ZTsKIH0KIAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoUGFnZVVSTDooTlNVUkwgKilV Ukw7CkBAIC0xMTAsMTAgKzExNiwyMiBAQCBzdGF0aWMgY29uc3QgQ0dGbG9hdCBwb3BvdmVyVG9W aWV3U2NhbGUgPSAwLjc1OwogCiAgICAgLy8gU2V0dGluZyB0aGUgd2ViVmlldyBib3VuZHMgd2ls bCBzY2FsZSBpdCB0byA3NSUgb2YgdGhlIF9tYWluVmlld1NpemUuIAogICAgIFt3ZWJWaWV3IHNl dEJvdW5kczpOU01ha2VSZWN0KDAsIDAsIF9tYWluVmlld1NpemUud2lkdGggLyBwb3BvdmVyVG9W aWV3U2NhbGUsIF9tYWluVmlld1NpemUuaGVpZ2h0IC8gcG9wb3ZlclRvVmlld1NjYWxlKV07CisK KyAgICBSZXRhaW5QdHI8TlNDbGlja0dlc3R1cmVSZWNvZ25pemVyPiBjbGlja1JlY29nbml6ZXIg PSBhZG9wdE5TKFtbTlNDbGlja0dlc3R1cmVSZWNvZ25pemVyIGFsbG9jXSBpbml0V2l0aFRhcmdl dDpzZWxmIGFjdGlvbjpAc2VsZWN0b3IoX2NsaWNrUmVjb2duaXplZDopXSk7CisgICAgW3dlYlZp ZXcgYWRkR2VzdHVyZVJlY29nbml6ZXI6Y2xpY2tSZWNvZ25pemVyLmdldCgpXTsKICAgICBzZWxm LnZpZXcgPSB3ZWJWaWV3LmdldCgpOwogfQogCistICh2b2lkKV9jbGlja1JlY29nbml6ZWQ6KE5T R2VzdHVyZVJlY29nbml6ZXIgKilnZXN0dXJlUmVjb2duaXplcgoreworICAgIFtfZGVsZWdhdGUg cGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcldhc0NsaWNrZWQ6c2VsZl07Cit9CisKIEBlbmQKKwor QGludGVyZmFjZSBXS0FjdGlvbk1lbnVDb250cm9sbGVyICgpIDxXS1BhZ2VQcmV2aWV3Vmlld0Nv bnRyb2xsZXJEZWxlZ2F0ZT4KK0BlbmQKKwogI2VuZGlmCiAKIEBpbXBsZW1lbnRhdGlvbiBXS0Fj dGlvbk1lbnVDb250cm9sbGVyCkBAIC0xMzcsOCArMTU1LDcgQEAgc3RhdGljIGNvbnN0IENHRmxv YXQgcG9wb3ZlclRvVmlld1NjYWxlID0gMC43NTsKICAgICBfcGFnZSA9IG51bGxwdHI7CiAgICAg X3drVmlldyA9IG51bGxwdHI7CiAgICAgX2hpdFRlc3RSZXN1bHQgPSBBY3Rpb25NZW51SGl0VGVz dFJlc3VsdCgpOwotICAgIFtfcHJldmlld1BvcG92ZXIgc2V0RGVsZWdhdGU6bmlsXTsKLSAgICBf cHJldmlld1BvcG92ZXIgPSBuaWw7CisKIH0KIAogLSAodm9pZClwcmVwYXJlRm9yTWVudTooTlNN ZW51ICopbWVudSB3aXRoRXZlbnQ6KE5TRXZlbnQgKilldmVudApAQCAtMTk2LDExICsyMTMsOCBA QCBzdGF0aWMgY29uc3QgQ0dGbG9hdCBwb3BvdmVyVG9WaWV3U2NhbGUgPSAwLjc1OwogICAgIGlm IChfdHlwZSA9PSBrV0tBY3Rpb25NZW51RGF0YURldGVjdGVkSXRlbSAmJiBtZW51Lm51bWJlck9m SXRlbXMgPiAxKQogICAgICAgICBbc2VsZiBfaGlkZVRleHRJbmRpY2F0b3JdOwogCi0gICAgaWYg KCFfc2hvdWxkS2VlcFByZXZpZXdQb3BvdmVyT3BlbikgewotICAgICAgICBbX3ByZXZpZXdQb3Bv dmVyIGNsb3NlXTsKLSAgICAgICAgW19wcmV2aWV3UG9wb3ZlciBzZXREZWxlZ2F0ZTpuaWxdOwot ICAgICAgICBfcHJldmlld1BvcG92ZXIgPSBuaWw7Ci0gICAgfQorICAgIGlmICghX3Nob3VsZEtl ZXBQcmV2aWV3UG9wb3Zlck9wZW4pCisgICAgICAgIFtzZWxmIF9jbGVhclByZXZpZXdQb3BvdmVy XTsKIAogICAgIF9zdGF0ZSA9IEFjdGlvbk1lbnVTdGF0ZTo6Tm9uZTsKICAgICBfaGl0VGVzdFJl c3VsdCA9IEFjdGlvbk1lbnVIaXRUZXN0UmVzdWx0KCk7CkBAIC0yOTcsNiArMzExLDcgQEAgc3Rh dGljIGNvbnN0IENHRmxvYXQgcG9wb3ZlclRvVmlld1NjYWxlID0gMC43NTsKIHsKICAgICBSZXRh aW5QdHI8V0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyPiBwcmV2aWV3Vmlld0NvbnRyb2xsZXIg PSBhZG9wdE5TKFtbV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyIGFsbG9jXSBpbml0V2l0aFBh Z2VVUkw6dXJsXSk7CiAgICAgcHJldmlld1ZpZXdDb250cm9sbGVyLT5fbWFpblZpZXdTaXplID0g X3drVmlldy5ib3VuZHMuc2l6ZTsKKyAgICBwcmV2aWV3Vmlld0NvbnRyb2xsZXItPl9kZWxlZ2F0 ZSA9IHNlbGY7CiAKICAgICBfcHJldmlld1BvcG92ZXIgPSBhZG9wdE5TKFtbTlNQb3BvdmVyIGFs bG9jXSBpbml0XSk7CiAgICAgW19wcmV2aWV3UG9wb3ZlciBzZXRCZWhhdmlvcjpOU1BvcG92ZXJC ZWhhdmlvclRyYW5zaWVudF07CkBAIC0zMzAsNiArMzQ1LDE4IEBAIHN0YXRpYyBjb25zdCBDR0Zs b2F0IHBvcG92ZXJUb1ZpZXdTY2FsZSA9IDAuNzU7CiAKICNlbmRpZiAvLyBXS19BUElfRU5BQkxF RAogCistICh2b2lkKV9jbGVhclByZXZpZXdQb3BvdmVyCit7CisjaWYgV0tfQVBJX0VOQUJMRUQK KyAgICBpZiAoV0tQYWdlUHJldmlld1ZpZXdDb250cm9sbGVyICpwYWdlUHJldmlld1ZpZXdDb250 cm9sbGVyID0gKFdLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciAqKVtfcHJldmlld1BvcG92ZXIg Y29udGVudFZpZXdDb250cm9sbGVyXSkKKyAgICAgICAgcGFnZVByZXZpZXdWaWV3Q29udHJvbGxl ci0+X2RlbGVnYXRlID0gbmlsOworI2VuZGlmCisKKyAgICBbX3ByZXZpZXdQb3BvdmVyIGNsb3Nl XTsKKyAgICBbX3ByZXZpZXdQb3BvdmVyIHNldERlbGVnYXRlOm5pbF07CisgICAgX3ByZXZpZXdQ b3BvdmVyID0gbmlsOworfQorCiAjcHJhZ21hIG1hcmsgSW1hZ2UgYWN0aW9ucwogCiAtIChOU0Fy cmF5ICopX2RlZmF1bHRNZW51SXRlbXNGb3JJbWFnZQpAQCAtNjA0LDcgKzYzMSw3IEBAIHN0YXRp YyBOU1N0cmluZyAqcGF0aFRvUGhvdG9PbkRpc2soTlNTdHJpbmcgKnN1Z2dlc3RlZEZpbGVuYW1l KQogLSAodm9pZClwb3BvdmVyV2lsbENsb3NlOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlv bgogewogICAgIF9zaG91bGRLZWVwUHJldmlld1BvcG92ZXJPcGVuID0gTk87Ci0gICAgX3ByZXZp ZXdQb3BvdmVyID0gbmlsOworICAgIFtzZWxmIF9jbGVhclByZXZpZXdQb3BvdmVyXTsKIH0KIAog I3ByYWdtYSBtYXJrIE1lbnUgSXRlbXMKQEAgLTc3OSw2ICs4MDYsMTggQEAgc3RhdGljIE5TSW1h Z2UgKndlYktpdEJ1bmRsZUltYWdlTmFtZWQoTlNTdHJpbmcgKm5hbWUpCiAgICAgICAgIFtfd2tW aWV3LmFjdGlvbk1lbnUgYWRkSXRlbTppdGVtXTsKIH0KIAorI2lmIFdLX0FQSV9FTkFCTEVECisK KyNwcmFnbWEgbWFyayBXS1BhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXJEZWxlZ2F0ZQorCistICh2 b2lkKXBhZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXJXYXNDbGlja2VkOihXS1BhZ2VQcmV2aWV3Vmll d0NvbnRyb2xsZXIgKilwYWdlUHJldmlld1ZpZXdDb250cm9sbGVyCit7CisgICAgaWYgKE5TVVJM ICp1cmwgPSBwYWdlUHJldmlld1ZpZXdDb250cm9sbGVyLT5fdXJsLmdldCgpKQorICAgICAgICBb W05TV29ya3NwYWNlIHNoYXJlZFdvcmtzcGFjZV0gb3BlblVSTDp1cmxdOworfQorCisjZW5kaWYK KwogQGVuZAogCiAjZW5kaWYgLy8gUExBVEZPUk0oTUFDKQo=