138444 2014-11-05 15:16:25 -0800 Page preview popover should show scaled-down web content 2014-11-05 16:19:46 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin conrad_shultz thorton oldest_to_newest 1046620 0 bdakin 2014-11-05 15:16:25 -0800 Page preview popover should show scaled-down web content rdar://problem/18887140 1046628 1 241062 bdakin 2014-11-05 15:20:48 -0800 Created attachment 241062 Patch 1046629 2 241062 thorton 2014-11-05 15:22:24 -0800 Comment on attachment 241062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241062&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:63 > +static const CGFloat preferredPopoverToWKViewScale = 0.75; It's not a WKView :) 1046631 3 241062 andersca 2014-11-05 15:27:23 -0800 Comment on attachment 241062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241062&action=review >> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:63 >> +static const CGFloat preferredPopoverToWKViewScale = 0.75; > > It's not a WKView :) Nor preferred :) > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:110 > + [webView setBounds:NSMakeRect(0, 0, _mainViewSize.width / preferredPopoverToWKViewScale, _mainViewSize.height / preferredPopoverToWKViewScale)]; This could probably use a comment. 1046632 4 bdakin 2014-11-05 15:32:06 -0800 Thanks! http://trac.webkit.org/changeset/175645 1046652 5 thorton 2014-11-05 16:19:46 -0800 Build fix in http://trac.webkit.org/changeset/175649 241062 2014-11-05 15:20:48 -0800 2014-11-05 15:27:23 -0800 Patch for-review.txt text/plain 4069 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTY0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTExLTA1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBQYWdlIHByZXZpZXcgcG9wb3ZlciBz aG91bGQgc2hvdyBzY2FsZWQtZG93biB3ZWIgY29udGVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiBrZWVwaW5nIHRoZSBwcmVmZXJy ZWQgc2l6ZSBpbiB0aGUgY29udHJvbGxlciwga2VlcCB0aGUgbWFpbiB2aWV34oCZcyAKKyAgICAg ICAgc2l6ZSwgYW5kIHRoZW4gc2NhbGUgdGhlIGJvdW5kcyBvZiB0aGUgcG9wb3ZlcuKAmXMgdmll dyB1c2luZyB0aGF0IGFuZCB0aGUgc2NhbGUgCisgICAgICAgIGZhY3RvciBhcyBhIGNvbnN0YW50 LiBTZXQgdGhlIHNpemUgb2YgdGhlIHBvcG92ZXIgZXhwbGljaXRseSBzbyB0aGF0IGl0IGRvZXNu 4oCZdCAKKyAgICAgICAgZ2V0IHRoZSB2aWV34oCZcyBzaXplLiBUaGlzIHdpbGwgY2F1c2UgaXQg dG8gc2NhbGUgdGhlIFdLV2ViVmlldy4KKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLQWN0aW9u TWVudUNvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxl ciBpbml0V2l0aFBhZ2VVUkw6XSk6CisgICAgICAgICgtW1dLUGFnZVByZXZpZXdWaWV3Q29udHJv bGxlciBsb2FkVmlld10pOgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIF9jcmVh dGVQcmV2aWV3UG9wb3ZlckZvclVSTDpvcmlnaW5SZWN0Ol0pOgorICAgICAgICAoLVtXS0FjdGlv bk1lbnVDb250cm9sbGVyIF9wcmVmZXJyZWRTaXplRm9yUG9wb3ZlclByZXNlbnRlZEZyb21Pcmln aW5SZWN0Ol0pOgorCiAyMDE0LTExLTA1ICBDb25yYWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBh cHBsZS5jb20+CiAKICAgICAgICAgUGFnZSBwcmV2aWV3IHBvcG92ZXJzIHNvbWV0aW1lcyBjb3Zl ciB0aGVpciBvcmlnaW5hdGluZyBlbGVtZW50CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCShyZXZpc2lvbiAx NzU2NDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRy b2xsZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTYwLDYgKzYwLDggQEAgU09GVF9MSU5LX0NMQVNT KEltYWdlS2l0LCBJS1NsaWRlc2hvdykKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogdXNpbmcg bmFtZXNwYWNlIFdlYktpdDsKIAorc3RhdGljIGNvbnN0IENHRmxvYXQgcHJlZmVycmVkUG9wb3Zl clRvV0tWaWV3U2NhbGUgPSAwLjc1OworCiBAaW50ZXJmYWNlIFdLQWN0aW9uTWVudUNvbnRyb2xs ZXIgKCkgPE5TU2hhcmluZ1NlcnZpY2VEZWxlZ2F0ZSwgTlNTaGFyaW5nU2VydmljZVBpY2tlckRl bGVnYXRlLCBOU1BvcG92ZXJEZWxlZ2F0ZT4KIC0gKHZvaWQpX3VwZGF0ZUFjdGlvbk1lbnVJdGVt c0ZvclN0YWdlOihNZW51VXBkYXRlU3RhZ2Upc3RhZ2U7CiAtIChCT09MKV9jYW5BZGRJbWFnZVRv UGhvdG9zOwpAQCAtNzQsNyArNzYsNyBAQCAtIChOU0FycmF5ICopX2FjdGlvbk1lbnVJdGVtc0Zv ckhpdFRlc3RSCiAjaWYgV0tfQVBJX0VOQUJMRUQKIEBpbnRlcmZhY2UgV0tQYWdlUHJldmlld1Zp ZXdDb250cm9sbGVyIDogTlNWaWV3Q29udHJvbGxlciB7CiBAcHVibGljCi0gICAgTlNTaXplIF9w cmVmZXJyZWRTaXplOworICAgIE5TU2l6ZSBfbWFpblZpZXdTaXplOwogCiBAcHJpdmF0ZQogICAg IFJldGFpblB0cjxOU1VSTD4gX3VybDsKQEAgLTkyLDE5ICs5NCwyMCBAQCAtIChpbnN0YW5jZXR5 cGUpaW5pdFdpdGhQYWdlVVJMOihOU1VSTCAqCiAgICAgICAgIHJldHVybiBuaWw7CiAKICAgICBf dXJsID0gVVJMOwotICAgIF9wcmVmZXJyZWRTaXplID0gTlNNYWtlU2l6ZSgzMjAsIDU2OCk7Cisg ICAgX21haW5WaWV3U2l6ZSA9IE5TTWFrZVNpemUoMzIwLCA1NjgpOwogCiAgICAgcmV0dXJuIHNl bGY7CiB9CiAKIC0gKHZvaWQpbG9hZFZpZXcKIHsKLSAgICBSZXRhaW5QdHI8V0tXZWJWaWV3PiB3 ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VS ZWN0KDAsIDAsIF9wcmVmZXJyZWRTaXplLndpZHRoLCBfcHJlZmVycmVkU2l6ZS5oZWlnaHQpXSk7 CisgICAgUmV0YWluUHRyPFdLV2ViVmlldz4gd2ViVmlldyA9IGFkb3B0TlMoW1tXS1dlYlZpZXcg YWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCBfbWFpblZpZXdTaXplLndpZHRo LCBfbWFpblZpZXdTaXplLmhlaWdodCldKTsKICAgICBbd2ViVmlldyBfc2V0SWdub3Jlc05vbldo ZWVsTW91c2VFdmVudHM6WUVTXTsKICAgICBpZiAoX3VybCkgewogICAgICAgICBOU1VSTFJlcXVl c3QgKnJlcXVlc3QgPSBbTlNVUkxSZXF1ZXN0IHJlcXVlc3RXaXRoVVJMOl91cmwuZ2V0KCldOwog ICAgICAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKICAgICB9CisgICAgW3dlYlZp ZXcgc2V0Qm91bmRzOk5TTWFrZVJlY3QoMCwgMCwgX21haW5WaWV3U2l6ZS53aWR0aCAvIHByZWZl cnJlZFBvcG92ZXJUb1dLVmlld1NjYWxlLCBfbWFpblZpZXdTaXplLmhlaWdodCAvIHByZWZlcnJl ZFBvcG92ZXJUb1dLVmlld1NjYWxlKV07CiAgICAgc2VsZi52aWV3ID0gd2ViVmlldy5nZXQoKTsK IH0KIApAQCAtMjkxLDE3ICsyOTQsMTcgQEAgLSAodm9pZClfcHJldmlld1VSTEZyb21BY3Rpb25N ZW51OihpZClzZQogLSAodm9pZClfY3JlYXRlUHJldmlld1BvcG92ZXJGb3JVUkw6KE5TVVJMICop dXJsIG9yaWdpblJlY3Q6KE5TUmVjdClvcmlnaW5SZWN0CiB7CiAgICAgUmV0YWluUHRyPFdLUGFn ZVByZXZpZXdWaWV3Q29udHJvbGxlcj4gcHJldmlld1ZpZXdDb250cm9sbGVyID0gYWRvcHROUyhb W1dLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlciBhbGxvY10gaW5pdFdpdGhQYWdlVVJMOnVybF0p OwotICAgIHByZXZpZXdWaWV3Q29udHJvbGxlci0+X3ByZWZlcnJlZFNpemUgPSBbc2VsZiBfcHJl ZmVycmVkU2l6ZUZvclBvcG92ZXJQcmVzZW50ZWRGcm9tT3JpZ2luUmVjdDpvcmlnaW5SZWN0XTsK KyAgICBwcmV2aWV3Vmlld0NvbnRyb2xsZXItPl9tYWluVmlld1NpemUgPSBfd2tWaWV3LmJvdW5k cy5zaXplOwogCiAgICAgX3ByZXZpZXdQb3BvdmVyID0gYWRvcHROUyhbW05TUG9wb3ZlciBhbGxv Y10gaW5pdF0pOwogICAgIFtfcHJldmlld1BvcG92ZXIgc2V0QmVoYXZpb3I6TlNQb3BvdmVyQmVo YXZpb3JUcmFuc2llbnRdOworICAgIFtfcHJldmlld1BvcG92ZXIgc2V0Q29udGVudFNpemU6W3Nl bGYgX3ByZWZlcnJlZFNpemVGb3JQb3BvdmVyUHJlc2VudGVkRnJvbU9yaWdpblJlY3Q6b3JpZ2lu UmVjdF1dOwogICAgIFtfcHJldmlld1BvcG92ZXIgc2V0Q29udGVudFZpZXdDb250cm9sbGVyOnBy ZXZpZXdWaWV3Q29udHJvbGxlci5nZXQoKV07CiAgICAgW19wcmV2aWV3UG9wb3ZlciBzZXREZWxl Z2F0ZTpzZWxmXTsKIH0KIAogLSAoTlNTaXplKV9wcmVmZXJyZWRTaXplRm9yUG9wb3ZlclByZXNl bnRlZEZyb21PcmlnaW5SZWN0OihOU1JlY3Qpb3JpZ2luUmVjdAogewotICAgIHN0YXRpYyBjb25z dCBDR0Zsb2F0IHByZWZlcnJlZFBvcG92ZXJUb1dLVmlld1NjYWxlID0gMC43NTsKICAgICBzdGF0 aWMgY29uc3QgQ0dGbG9hdCBzY3JlZW5QYWRkaW5nID0gNDA7CiAKICAgICBOU1dpbmRvdyAqd2lu ZG93ID0gX3drVmlldy53aW5kb3c7Cg==