138437 2014-11-05 14:04:49 -0800 Page preview popovers sometimes cover their originating element 2014-11-05 14:53:17 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz andersca bdakin commit-queue conrad_shultz thorton webkit-bug-importer oldest_to_newest 1046600 0 conrad_shultz 2014-11-05 14:04:49 -0800 Page preview popovers sometimes cover their originating element. 1046601 1 webkit-bug-importer 2014-11-05 14:05:36 -0800 <rdar://problem/18885782> 1046604 2 241057 conrad_shultz 2014-11-05 14:14:27 -0800 Created attachment 241057 Patch 1046610 3 241057 bdakin 2014-11-05 14:51:36 -0800 Comment on attachment 241057 Patch Taking too long! I will commit 1046611 4 bdakin 2014-11-05 14:53:17 -0800 http://trac.webkit.org/changeset/175643 241057 2014-11-05 14:14:27 -0800 2014-11-05 14:51:36 -0800 Patch bug-138437-20141105141438.patch text/plain 4866 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTFiNzYzMTY3MzlkNDI0 ZWM4YTVlM2I5NzFmMmE4NDI5Y2MxMjE1Yy4uY2U3MGE4MzM4ODlmMjFmMGNmNWVhYWE2NmVlNDQ1 YWE4NWUwMmUwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTExLTA1ICBDb25y YWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUGFnZSBwcmV2 aWV3IHBvcG92ZXJzIHNvbWV0aW1lcyBjb3ZlciB0aGVpciBvcmlnaW5hdGluZyBlbGVtZW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg0MzcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBhIHBvcG92 ZXIgaXMgc3VmZmljaWVudGx5IGxhcmdlLCBhbmQgdGhlIG9yaWdpbmF0aW5nIGVsZW1lbnQgaXMg aW4gYSBwYXJ0aWN1bGFyIGxvY2F0aW9uLCBpdCdzCisgICAgICAgIHBvc3NpYmxlIHRoYXQgdGhl IHBvcG92ZXIgY2FuJ3QgYmUgcG9zaXRpb25lZCBpbiBhIG1hbm5lciB0aGF0IGRvZXNuJ3Qgb2Nj bHVkZSB0aGUgb3JpZ2luYXRpbmcgZWxlbWVudC4KKyAgICAgICAgQWRkcmVzcyB0aGlzIGJ5IHNj YWxpbmcgZG93biB0aGUgcG9wb3ZlciBjb250ZW50IGlmIGl0IGNhbid0IGZpdCBlbnRpcmVseSBi ZXR3ZWVuIHRoZSBvcmlnaW5hdGluZworICAgICAgICBlbGVtZW50IGFuZCB0aGUgc2NyZWVuIGVk Z2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW06 CisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgX3ByZXZpZXdVUkxGcm9tQWN0aW9u TWVudTpdKToKKyAgICAgICAgVXBkYXRlIHRvIHVzZSAtX2NyZWF0ZVByZXZpZXdQb3BvdmVyRm9y VVJMOm9yaWdpblJlY3Q6LgorICAgICAgICAoLVtXS0FjdGlvbk1lbnVDb250cm9sbGVyIF9jcmVh dGVQcmV2aWV3UG9wb3ZlckZvclVSTDpvcmlnaW5SZWN0Ol0pOgorICAgICAgICBSZW5hbWVkIGZy b20gLV9jcmVhdGVQcmV2aWV3UG9wb3ZlckZvclVSTDo7IGV4dHJhY3QgY29kZSB0byAtX3ByZWZl cnJlZFNpemVGb3JQb3BvdmVyUHJlc2VudGVkRnJvbU9yaWdpblJlY3Q6LgorICAgICAgICAoLVtX S0FjdGlvbk1lbnVDb250cm9sbGVyIF9wcmVmZXJyZWRTaXplRm9yUG9wb3ZlclByZXNlbnRlZEZy b21PcmlnaW5SZWN0Ol0pOgorICAgICAgICBDb21wdXRlIGEgc2l6ZSB0aGF0IGlzIGFzIGxhcmdl IGFzIHBvc3NpYmxlIHdoaWxlIGtlZXBpbmcgdGhlIHBvcG92ZXIgYmV0d2VlbiB0aGUgb3JpZ2lu IHJlY3QgYW5kIHNjcmVlbiBlZGdlCisgICAgICAgICh3aXRoIGFuIGFyYml0cmFyeSBwYWRkaW5n IGFwcGxpZWQgdG8ga2VlcCBmcm9tIGRpcmVjdGx5IGFidXR0aW5nIHRoZSBzY3JlZW4gZWRnZSku CisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgX2NyZWF0ZVByZXZpZXdQb3BvdmVy Rm9yVVJMOl0pOiBEZWxldGVkLgorCiAyMDE0LTExLTA0ICBKb24gSG9uZXljdXR0ICA8amhvbmV5 Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQ29udGVudCBjcmFzaCBpbiBXZWJQYWdlOjpz ZWxlY3RXaXRoR2VzdHVyZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dLQWN0aW9uTWVudUNvbnRyb2xsZXIubW0KaW5kZXggNGU4NDBiZTJmODNhNDBhZWRkY2My ZTI2Y2M3ODBmNmM4ZmZhYTQ1OS4uMGU3YzJkNGExYWNmZTc1MTk5ZWEyZmY5NjFkZGQ5MzQzMjM0 OTUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1l bnVDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rp b25NZW51Q29udHJvbGxlci5tbQpAQCAtMjc4LDIyICsyNzgsNDcgQEAgdXNpbmcgbmFtZXNwYWNl IFdlYktpdDsKIAogICAgIFdlYkhpdFRlc3RSZXN1bHQqIGhpdFRlc3RSZXN1bHQgPSBfcGFnZS0+ bGFzdE1vdXNlTW92ZUhpdFRlc3RSZXN1bHQoKTsKICAgICBOU1VSTCAqdXJsID0gW05TVVJMIF93 ZWJfVVJMV2l0aFdURlN0cmluZzpoaXRUZXN0UmVzdWx0LT5hYnNvbHV0ZUxpbmtVUkwoKV07Ci0g ICAgW3NlbGYgX2NyZWF0ZVByZXZpZXdQb3BvdmVyRm9yVVJMOnVybF07Ci0gICAgW19wcmV2aWV3 UG9wb3ZlciBzaG93UmVsYXRpdmVUb1JlY3Q6aGl0VGVzdFJlc3VsdC0+ZWxlbWVudEJvdW5kaW5n Qm94KCkgb2ZWaWV3Ol93a1ZpZXcgcHJlZmVycmVkRWRnZTpOU01heFlFZGdlXTsKKyAgICBOU1Jl Y3Qgb3JpZ2luUmVjdCA9IGhpdFRlc3RSZXN1bHQtPmVsZW1lbnRCb3VuZGluZ0JveCgpOworICAg IFtzZWxmIF9jcmVhdGVQcmV2aWV3UG9wb3ZlckZvclVSTDp1cmwgb3JpZ2luUmVjdDpvcmlnaW5S ZWN0XTsKKyAgICBbX3ByZXZpZXdQb3BvdmVyIHNob3dSZWxhdGl2ZVRvUmVjdDpvcmlnaW5SZWN0 IG9mVmlldzpfd2tWaWV3IHByZWZlcnJlZEVkZ2U6TlNNYXhZRWRnZV07CiB9CiAKLS0gKHZvaWQp X2NyZWF0ZVByZXZpZXdQb3BvdmVyRm9yVVJMOihOU1VSTCAqKXVybAorLSAodm9pZClfY3JlYXRl UHJldmlld1BvcG92ZXJGb3JVUkw6KE5TVVJMICopdXJsIG9yaWdpblJlY3Q6KE5TUmVjdClvcmln aW5SZWN0CiB7CiAgICAgUmV0YWluUHRyPFdLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcj4gcHJl dmlld1ZpZXdDb250cm9sbGVyID0gYWRvcHROUyhbW1dLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxl ciBhbGxvY10gaW5pdFdpdGhQYWdlVVJMOnVybF0pOwotICAgIE5TUmVjdCB3a1ZpZXdCb3VuZHMg PSBbX3drVmlldyBib3VuZHNdOwotICAgIHByZXZpZXdWaWV3Q29udHJvbGxlci0+X3ByZWZlcnJl ZFNpemUgPSBOU01ha2VTaXplKE5TV2lkdGgod2tWaWV3Qm91bmRzKSAqIDAuNzUsIE5TSGVpZ2h0 KHdrVmlld0JvdW5kcykgKiAwLjc1KTsKKyAgICBwcmV2aWV3Vmlld0NvbnRyb2xsZXItPl9wcmVm ZXJyZWRTaXplID0gW3NlbGYgX3ByZWZlcnJlZFNpemVGb3JQb3BvdmVyUHJlc2VudGVkRnJvbU9y aWdpblJlY3Q6b3JpZ2luUmVjdF07CiAKICAgICBfcHJldmlld1BvcG92ZXIgPSBhZG9wdE5TKFtb TlNQb3BvdmVyIGFsbG9jXSBpbml0XSk7CiAgICAgW19wcmV2aWV3UG9wb3ZlciBzZXRCZWhhdmlv cjpOU1BvcG92ZXJCZWhhdmlvclRyYW5zaWVudF07CiAgICAgW19wcmV2aWV3UG9wb3ZlciBzZXRD b250ZW50Vmlld0NvbnRyb2xsZXI6cHJldmlld1ZpZXdDb250cm9sbGVyLmdldCgpXTsKICAgICBb X3ByZXZpZXdQb3BvdmVyIHNldERlbGVnYXRlOnNlbGZdOwogfQotI2VuZGlmCisKKy0gKE5TU2l6 ZSlfcHJlZmVycmVkU2l6ZUZvclBvcG92ZXJQcmVzZW50ZWRGcm9tT3JpZ2luUmVjdDooTlNSZWN0 KW9yaWdpblJlY3QKK3sKKyAgICBzdGF0aWMgY29uc3QgQ0dGbG9hdCBwcmVmZXJyZWRQb3BvdmVy VG9XS1ZpZXdTY2FsZSA9IDAuNzU7CisgICAgc3RhdGljIGNvbnN0IENHRmxvYXQgc2NyZWVuUGFk ZGluZyA9IDQwOworCisgICAgTlNXaW5kb3cgKndpbmRvdyA9IF93a1ZpZXcud2luZG93OworICAg IE5TUmVjdCBvcmlnaW5TY3JlZW5SZWN0ID0gW3dpbmRvdyBjb252ZXJ0UmVjdFRvU2NyZWVuOltf d2tWaWV3IGNvbnZlcnRSZWN0Om9yaWdpblJlY3QgdG9WaWV3Om5pbF1dOworICAgIE5TUmVjdCBz Y3JlZW5GcmFtZSA9IHdpbmRvdy5zY3JlZW4udmlzaWJsZUZyYW1lOworCisgICAgQ0dGbG9hdCBh dmFpbGFibGVTcGFjZUFib3ZlID0gTlNNYXhZKHNjcmVlbkZyYW1lKSAtIE5TTWF4WShvcmlnaW5T Y3JlZW5SZWN0KTsKKyAgICBDR0Zsb2F0IGF2YWlsYWJsZVNwYWNlQmVsb3cgPSBOU01pblkob3Jp Z2luU2NyZWVuUmVjdCkgLSBOU01pblkoc2NyZWVuRnJhbWUpOworICAgIENHRmxvYXQgbWF4QXZh aWxhYmxlVmVydGljYWxTcGFjZSA9IGZtYXgoYXZhaWxhYmxlU3BhY2VBYm92ZSwgYXZhaWxhYmxl U3BhY2VCZWxvdykgLSBzY3JlZW5QYWRkaW5nOworCisgICAgQ0dGbG9hdCBhdmFpbGFibGVTcGFj ZUF0TGVmdCA9IE5TTWluWChvcmlnaW5TY3JlZW5SZWN0KSAtIE5TTWluWChzY3JlZW5GcmFtZSk7 CisgICAgQ0dGbG9hdCBhdmFpbGFibGVTcGFjZUF0UmlnaHQgPSBOU01heFgoc2NyZWVuRnJhbWUp IC0gTlNNYXhYKG9yaWdpblNjcmVlblJlY3QpOworICAgIENHRmxvYXQgbWF4QXZhaWxhYmxlSG9y aXpvbnRhbFNwYWNlID0gZm1heChhdmFpbGFibGVTcGFjZUF0TGVmdCwgYXZhaWxhYmxlU3BhY2VB dFJpZ2h0KSAtIHNjcmVlblBhZGRpbmc7CisKKyAgICBOU1JlY3Qgd2tWaWV3Qm91bmRzID0gX3dr Vmlldy5ib3VuZHM7CisgICAgTlNTaXplIHByZWZlcnJlZFNpemUgPSBOU01ha2VTaXplKE5TV2lk dGgod2tWaWV3Qm91bmRzKSAqIHByZWZlcnJlZFBvcG92ZXJUb1dLVmlld1NjYWxlLCBOU0hlaWdo dCh3a1ZpZXdCb3VuZHMpICogcHJlZmVycmVkUG9wb3ZlclRvV0tWaWV3U2NhbGUpOworICAgIHBy ZWZlcnJlZFNpemUud2lkdGggPSBmbWluKHByZWZlcnJlZFNpemUud2lkdGgsIG1heEF2YWlsYWJs ZUhvcml6b250YWxTcGFjZSk7CisgICAgcHJlZmVycmVkU2l6ZS5oZWlnaHQgPSBmbWluKHByZWZl cnJlZFNpemUuaGVpZ2h0LCBtYXhBdmFpbGFibGVWZXJ0aWNhbFNwYWNlKTsKKyAgICByZXR1cm4g cHJlZmVycmVkU2l6ZTsKK30KKworI2VuZGlmIC8vIFdLX0FQSV9FTkFCTEVECiAKICNwcmFnbWEg bWFyayBJbWFnZSBhY3Rpb25zCiAK