138433 2014-11-05 12:04:53 -0800 Remove 2 unnecessary virtual functions on InputType 2014-11-05 13:22:09 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue kling rniwa oldest_to_newest 1046554 0 cdumez 2014-11-05 12:04:53 -0800 Remove 2 unnecessary virtual functions on InputType: - valueAttributeChanged() - updateClearButtonVisibility() 1046556 1 241047 cdumez 2014-11-05 12:07:10 -0800 Created attachment 241047 Patch 1046584 2 241047 commit-queue 2014-11-05 13:22:06 -0800 Comment on attachment 241047 Patch Clearing flags on attachment: 241047 Committed r175639: <http://trac.webkit.org/changeset/175639> 1046585 3 commit-queue 2014-11-05 13:22:09 -0800 All reviewed patches have been landed. Closing bug. 241047 2014-11-05 12:07:10 -0800 2014-11-05 13:22:06 -0800 Patch bug-138433-20141105120720.patch text/plain 4171 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFlZDFlY2I0OTg0NDY1 MjA4ZGIzMzM2NGM1OTdjNDhlNjU0M2I0Mi4uMTYyYTdlNTNmYjhjNDZjYWU2NDkyMmMyNGY2N2Nh ZGFlNjJjYzEwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE0LTExLTA1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVtb3ZlIDIgdW5uZWNlc3Nh cnkgdmlydHVhbCBmdW5jdGlvbnMgb24gSW5wdXRUeXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg0MzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgMiB1bnVzZWQgdmlydHVhbCBmdW5jdGlv bnMgb24gSW5wdXRUeXBlOgorICAgICAgICAtIHZhbHVlQXR0cmlidXRlQ2hhbmdlZCgpCisgICAg ICAgIC0gdXBkYXRlQ2xlYXJCdXR0b25WaXNpYmlsaXR5KCkKKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpwYXJzZUF0dHJpYnV0 ZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Ojp1cGRhdGVDbGVhckJ1dHRv blZpc2liaWxpdHkpOiBEZWxldGVkLgorICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5o OgorICAgICAgICAqIGh0bWwvSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklucHV0 VHlwZTo6dmFsdWVBdHRyaWJ1dGVDaGFuZ2VkKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6 OklucHV0VHlwZTo6dXBkYXRlQ2xlYXJCdXR0b25WaXNpYmlsaXR5KTogRGVsZXRlZC4KKyAgICAg ICAgKiBodG1sL0lucHV0VHlwZS5oOgorCisyMDE0LTExLTA1ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CisKICAgICAgICAgUmUtZXZhbHVhdGUgaWYgYSByZXBldGl0aXZlIHRpbWVy IHNob3VsZCBiZSB0aHJvdHRsZWQgdXBvbiBmaXJpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODMzOQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M SW5wdXRFbGVtZW50LmNwcAppbmRleCA4NzU5ZjQ3ZDJjYjc3NGZjYmQ3NjRlMDk4NGM2YWFjZTg5 ZjI3ODEyLi5hMjgzMTYwNzMzZTNlNGViNWZlMGE3M2QzYTVlYWM3ZTE0NzVlNmNlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTYzNSw3ICs2MzUsNiBAQCB2 b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUm IG5hbWUsIGNvbnN0IEF0b21pY1N0cgogICAgICAgICBzZXRGb3JtQ29udHJvbFZhbHVlTWF0Y2hl c1JlbmRlcmVyKGZhbHNlKTsKICAgICAgICAgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCk7CiAgICAg ICAgIG1fdmFsdWVBdHRyaWJ1dGVXYXNVcGRhdGVkQWZ0ZXJQYXJzaW5nID0gIW1fcGFyc2luZ0lu UHJvZ3Jlc3M7Ci0gICAgICAgIG1faW5wdXRUeXBlLT52YWx1ZUF0dHJpYnV0ZUNoYW5nZWQoKTsK ICAgICB9IGVsc2UgaWYgKG5hbWUgPT0gY2hlY2tlZEF0dHIpIHsKICAgICAgICAgLy8gQW5vdGhl ciByYWRpbyBidXR0b24gaW4gdGhlIHNhbWUgZ3JvdXAgbWlnaHQgYmUgY2hlY2tlZCBieSBzdGF0 ZQogICAgICAgICAvLyByZXN0b3JlLiBXZSBzaG91bGRuJ3QgY2FsbCBzZXRDaGVja2VkKCkgZXZl biBpZiB0aGlzIGhhcyB0aGUgY2hlY2tlZApAQCAtMTM4MSwxMSArMTM4MCw2IEBAIHZvaWQgSFRN TElucHV0RWxlbWVudDo6b25TZWFyY2goKQogICAgIGRpc3BhdGNoRXZlbnQoRXZlbnQ6OmNyZWF0 ZShldmVudE5hbWVzKCkuc2VhcmNoRXZlbnQsIHRydWUsIGZhbHNlKSk7CiB9CiAKLXZvaWQgSFRN TElucHV0RWxlbWVudDo6dXBkYXRlQ2xlYXJCdXR0b25WaXNpYmlsaXR5KCkKLXsKLSAgICBtX2lu cHV0VHlwZS0+dXBkYXRlQ2xlYXJCdXR0b25WaXNpYmlsaXR5KCk7Ci19Ci0KIHZvaWQgSFRNTElu cHV0RWxlbWVudDo6ZG9jdW1lbnREaWRSZXN1bWVGcm9tUGFnZUNhY2hlKCkKIHsKICAgICBBU1NF UlQobmVlZHNTdXNwZW5zaW9uQ2FsbGJhY2soKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5oCmluZGV4IGE0NjZmNzk4MjY1MGZmNjg4YTczNzU0Mzg1YzM3ZWZlNTlhMjA5NTYu LjdiNGZhYWJlNTIxN2FiZDUyMzBjOTlhNzA2MDU1OTYzMzcxYWI0YzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBAIC0yNTksOCArMjU5LDYgQEAgcHVibGljOgogICAg IHZvaWQgYWRkU2VhcmNoUmVzdWx0KCk7CiAgICAgdm9pZCBvblNlYXJjaCgpOwogCi0gICAgdm9p ZCB1cGRhdGVDbGVhckJ1dHRvblZpc2liaWxpdHkoKTsKLQogICAgIHZpcnR1YWwgYm9vbCB3aWxs UmVzcG9uZFRvTW91c2VDbGlja0V2ZW50cygpIG92ZXJyaWRlOwogCiAjaWYgRU5BQkxFKERBVEFM SVNUX0VMRU1FTlQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAKaW5kZXggYzRiMzRiMmY5YWZm MGFlYzM4YmY3ZDJkZmMzYWI1ZGNjOTA0NGVmMS4uYWNhZWM3NWZiMmE4MWUzNGFmMGZlZGI2OGY2 MjVlNmUxZjRkZDRkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmNwcApAQCAtOTE5LDEwICs5 MTksNiBAQCB2b2lkIElucHV0VHlwZTo6cmVxdWlyZWRBdHRyaWJ1dGVDaGFuZ2VkKCkKIHsKIH0K IAotdm9pZCBJbnB1dFR5cGU6OnZhbHVlQXR0cmlidXRlQ2hhbmdlZCgpCi17Ci19Ci0KIHZvaWQg SW5wdXRUeXBlOjpzdWJ0cmVlSGFzQ2hhbmdlZCgpCiB7CiAgICAgQVNTRVJUX05PVF9SRUFDSEVE KCk7CkBAIC05NTIsMTAgKzk0OCw2IEBAIERlY2ltYWwgSW5wdXRUeXBlOjpmaW5kQ2xvc2VzdFRp Y2tNYXJrVmFsdWUoY29uc3QgRGVjaW1hbCYpCiB9CiAjZW5kaWYKIAotdm9pZCBJbnB1dFR5cGU6 OnVwZGF0ZUNsZWFyQnV0dG9uVmlzaWJpbGl0eSgpCi17Ci19Ci0KIGJvb2wgSW5wdXRUeXBlOjpz dXBwb3J0c0luZGV0ZXJtaW5hdGVBcHBlYXJhbmNlKCkgY29uc3QKIHsKICAgICByZXR1cm4gZmFs c2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oIGIvU291cmNl L1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaAppbmRleCBiYTAwM2VhZmQ1ZDRlNDYxZTllMjE4MjU3 YWE1Y2ZkYTQxM2NhYTNjLi4xN2QxMjUzNzk1YWUzZWRmNTk4ODI3NjcyZmIwNzI4YzdkZWIxY2M1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKQEAgLTI3MSw5ICsyNzEsNyBAQCBwdWJsaWM6CiAg ICAgdmlydHVhbCB2b2lkIGRpc2FibGVkQXR0cmlidXRlQ2hhbmdlZCgpOwogICAgIHZpcnR1YWwg dm9pZCByZWFkb25seUF0dHJpYnV0ZUNoYW5nZWQoKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVxdWly ZWRBdHRyaWJ1dGVDaGFuZ2VkKCk7Ci0gICAgdmlydHVhbCB2b2lkIHZhbHVlQXR0cmlidXRlQ2hh bmdlZCgpOwogICAgIHZpcnR1YWwgU3RyaW5nIGRlZmF1bHRUb29sVGlwKCkgY29uc3Q7Ci0gICAg dmlydHVhbCB2b2lkIHVwZGF0ZUNsZWFyQnV0dG9uVmlzaWJpbGl0eSgpOwogCiAjaWYgRU5BQkxF KERBVEFMSVNUX0VMRU1FTlQpCiAgICAgdmlydHVhbCB2b2lkIGxpc3RBdHRyaWJ1dGVUYXJnZXRD aGFuZ2VkKCk7Cg==