138432 2014-11-05 11:48:07 -0800 Action menu URL preview should "peek," i.e. appear when the menu item is highlighted 2014-11-05 12:17:24 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin conrad_shultz thorton oldest_to_newest 1046550 0 bdakin 2014-11-05 11:48:07 -0800 Action menu URL preview should "peek," i.e. appear when the menu item is highlighted rdar://problem/18774264 1046551 1 241046 bdakin 2014-11-05 11:53:50 -0800 Created attachment 241046 Patch 1046555 2 241046 conrad_shultz 2014-11-05 12:05:05 -0800 Comment on attachment 241046 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241046&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.h:59 > + RetainPtr<NSPopover> _previewPopover; I wonder if we should close the popover and nil out its delegate when the action menu controller is deallocated just to be on the safe side. > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:180 > + if (_previewPopover && !_shouldKeepPreviewPopoverOpen) { The _previewPopover check is unnecessary. > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:182 > + _previewPopover = nil; It would probably be a good idea to nil out the popover's delegate as part of tear-down. > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:258 > +- (void)_keepPreviewOpen:(id)sender Should this be -_keepPreviewOpenFromActionMenu: for consistency? > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:267 > + return; Is there any way for this to be received with a different URL from the one being shown? If there is, I'm not sure this will do the right thing. 1046561 3 bdakin 2014-11-05 12:11:59 -0800 (In reply to comment #2) > Comment on attachment 241046 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241046&action=review > > > Source/WebKit2/UIProcess/mac/WKActionMenuController.h:59 > > + RetainPtr<NSPopover> _previewPopover; > > I wonder if we should close the popover and nil out its delegate when the > action menu controller is deallocated just to be on the safe side. > Sounds like a good idea. I'll put it in willDestroyView for now, but maybe we should have a dealloc too? > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:180 > > + if (_previewPopover && !_shouldKeepPreviewPopoverOpen) { > > The _previewPopover check is unnecessary. > Removed. > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:182 > > + _previewPopover = nil; > > It would probably be a good idea to nil out the popover's delegate as part > of tear-down. > Will do. > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:258 > > +- (void)_keepPreviewOpen:(id)sender > > Should this be -_keepPreviewOpenFromActionMenu: for consistency? > It should. Fixed. > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:267 > > + return; > > Is there any way for this to be received with a different URL from the one > being shown? If there is, I'm not sure this will do the right thing. Good point. This should not be possible… I'll give some thought to whether it deserves some sort of belt-and-suspenders. 1046565 4 bdakin 2014-11-05 12:17:24 -0800 http://trac.webkit.org/changeset/175632 Thanks! 241046 2014-11-05 11:53:50 -0800 2014-11-05 12:05:17 -0800 Patch for-review.txt text/plain 7317 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTYyOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ1IEBACisyMDE0LTExLTA1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBBY3Rpb24gbWVudSBVUkwgcHJldmll dyBzaG91bGQgInBlZWssIiBpLmUuIGFwcGVhciB3aGVuIHRoZSBtZW51IGl0ZW0gaXMgCisgICAg ICAgIGhpZ2hsaWdodGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzg0MzIKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFy Oi8vcHJvYmxlbS8xODc3NDI2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5ldyBpdmFycy4gS2VlcCBhIHJlZmVyZW5jZSB0byB0aGUgcG9wb3Zlciwg YW5kIGEgQk9PTCB0aGF0IGluZGljYXRlcyB3aGV0aGVyIHdlIAorICAgICAgICBzaG91bGQgY2xv c2UgdGhlIHBvcG92ZXIgd2hlbiB0aGUgbWVudSBnb2VzIGF3YXkuCisgICAgICAgICogVUlQcm9j ZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLmg6CisgICAgICAgICogVUlQcm9jZXNzL21h Yy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tOgorCisgICAgICAgIFJlLXNldCB0aGUgcHJldmll dyBib29sIHRvIE5PIHdoZW5ldmVyIHdlIGFyZSBhYm91dCB0byBwb3AgdXAgYSBuZXcgbWVudS4K KyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29udHJvbGxlciBwcmVwYXJlRm9yTWVudTp3aXRoRXZl bnQ6XSk6CisKKyAgICAgICAgQ2xvc2UgdGhlIHBvcG92ZXIgd2hlbiB0aGUgbWVudSBjbG9zZXMg dW5sZXNzIF9zaG91bGRLZWVwUHJldmlld1BvcG92ZXJPcGVuIGhhcyAKKyAgICAgICAgYmVlbiBz ZXQuCisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgZGlkQ2xvc2VNZW51OndpdGhF dmVudDpdKToKKworICAgICAgICBTZXQgX3Nob3VsZEtlZXBQcmV2aWV3UG9wb3Zlck9wZW4uCisg ICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgX2tlZXBQcmV2aWV3T3BlbjpdKToKKwor ICAgICAgICBSZS1mYWN0b3JlZCB0byB1c2UgaXZhci4KKyAgICAgICAgKC1bV0tBY3Rpb25NZW51 Q29udHJvbGxlciBfcHJldmlld1VSTEZyb21BY3Rpb25NZW51Ol0pOgorICAgICAgICAoLVtXS0Fj dGlvbk1lbnVDb250cm9sbGVyIF9jcmVhdGVQcmV2aWV3UG9wb3ZlckZvclVSTDpdKToKKworICAg ICAgICBOb3cgY2FsbCBfcHJldmlld1VSTEZyb21BY3Rpb25NZW51IG9uIG1lbnUgaXRlbSBoaWdo bGlnaHQuCisgICAgICAgICgtW1dLQWN0aW9uTWVudUNvbnRyb2xsZXIgbWVudTp3aWxsSGlnaGxp Z2h0SXRlbTpdKToKKworICAgICAgICBOU1BvcG92ZXIgZGVsZWdhdGUgbWV0aG9kIHNvIHRoYXQg d2UgY2FuIGtlZXAgb3VyIEJPT0wgYW5kIGl2YXIgYWNjdXJhdGUgaW4gdGhlIAorICAgICAgICBj YXNlIHdoZXJlIHRoZSBwb3BvdmVyIGlzIGNsb3NlZCBieSBzb21lIG90aGVyIG1lY2hhbmlzbSB0 aGFuIHRoZSBhY3Rpb24gbWVudSAKKyAgICAgICAgZ29pbmcgYXdheS4KKyAgICAgICAgKC1bV0tB Y3Rpb25NZW51Q29udHJvbGxlciBwb3BvdmVyV2lsbENsb3NlOl0pOgorCisgICAgICAgIE5ldyBz ZWxlY3RvciBmb3IgdGhlIHByZXZpZXcuIE5vdyB3aGVuIHRoaXMgaXRlbSBpcyBhY3R1YWxseSBz ZWxlY3RlZCwgd2UganVzdCAKKyAgICAgICAgd2FudCB0byBzZXQgdGhlIEJPT0wgX3Nob3VsZEtl ZXBQcmV2aWV3UG9wb3Zlck9wZW4gdG8gWUVTIHNvIHRoYXQgd2Uga2VlcCB0aGUgCisgICAgICAg IHByZXZpZXcgb3Blbi4KKyAgICAgICAgKC1bV0tBY3Rpb25NZW51Q29udHJvbGxlciBfY3JlYXRl QWN0aW9uTWVudUl0ZW1Gb3JUYWc6XSk6CisKIDIwMTQtMTEtMDMgIERlYW4gSmFja3NvbiAgPGRp bm9AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBFTkFCTEVfRklMVEVSU19MRVZFTF8yIGZlYXR1 cmUgZ3VhcmQuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLQWN0aW9uTWVu dUNvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFj L1dLQWN0aW9uTWVudUNvbnRyb2xsZXIuaAkocmV2aXNpb24gMTc1NjExKQorKysgU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTU2LDggKzU2LDEwIEBAIEBpbnRlcmZhY2UgV0tBY3Rpb25NZW51Q29udHJvbGxlciA6 IE5TT2IKICAgICBSZWZQdHI8QVBJOjpPYmplY3Q+IF91c2VyRGF0YTsKICAgICBfV0tBY3Rpb25N ZW51VHlwZSBfdHlwZTsKICAgICBSZXRhaW5QdHI8TlNTaGFyaW5nU2VydmljZVBpY2tlcj4gX3No YXJpbmdTZXJ2aWNlUGlja2VyOworICAgIFJldGFpblB0cjxOU1BvcG92ZXI+IF9wcmV2aWV3UG9w b3ZlcjsKIAogICAgIEJPT0wgX2lzU2hvd2luZ1RleHRJbmRpY2F0b3I7CisgICAgQk9PTCBfc2hv dWxkS2VlcFByZXZpZXdQb3BvdmVyT3BlbjsKIH0KIAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRo UGFnZTooV2ViS2l0OjpXZWJQYWdlUHJveHkmKXBhZ2UgdmlldzooV0tWaWV3ICopd2tWaWV3OwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVy Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tBY3Rpb25N ZW51Q29udHJvbGxlci5tbQkocmV2aXNpb24gMTc1NjExKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XS0FjdGlvbk1lbnVDb250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01 OSw3ICs1OSw3IEBAIFNPRlRfTElOS19DTEFTUyhJbWFnZUtpdCwgSUtTbGlkZXNob3cpCiB1c2lu ZyBuYW1lc3BhY2UgV2ViQ29yZTsKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKLUBpbnRlcmZh Y2UgV0tBY3Rpb25NZW51Q29udHJvbGxlciAoKSA8TlNTaGFyaW5nU2VydmljZURlbGVnYXRlLCBO U1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGU+CitAaW50ZXJmYWNlIFdLQWN0aW9uTWVudUNv bnRyb2xsZXIgKCkgPE5TU2hhcmluZ1NlcnZpY2VEZWxlZ2F0ZSwgTlNTaGFyaW5nU2VydmljZVBp Y2tlckRlbGVnYXRlLCBOU1BvcG92ZXJEZWxlZ2F0ZT4KIC0gKHZvaWQpX3VwZGF0ZUFjdGlvbk1l bnVJdGVtc0ZvclN0YWdlOihNZW51VXBkYXRlU3RhZ2Upc3RhZ2U7CiAtIChCT09MKV9jYW5BZGRJ bWFnZVRvUGhvdG9zOwogLSAodm9pZClfc2hvd1RleHRJbmRpY2F0b3I7CkBAIC0xNDMsNiArMTQz LDcgQEAgLSAodm9pZClwcmVwYXJlRm9yTWVudTooTlNNZW51ICopbWVudSB3aQogICAgIFtzZWxm IF91cGRhdGVBY3Rpb25NZW51SXRlbXNGb3JTdGFnZTpNZW51VXBkYXRlU3RhZ2U6OlByZXBhcmVG b3JNZW51XTsKIAogICAgIFtzZWxmIF9oaWRlVGV4dEluZGljYXRvcl07CisgICAgX3Nob3VsZEtl ZXBQcmV2aWV3UG9wb3Zlck9wZW4gPSBOTzsKIH0KIAogLSAoQk9PTClpc01lbnVGb3JUZXh0Q29u dGVudApAQCAtMTc1LDcgKzE3NiwxMiBAQCAtICh2b2lkKWRpZENsb3NlTWVudTooTlNNZW51ICop bWVudSB3aXRoCiAKICAgICBpZiAoX3R5cGUgPT0ga1dLQWN0aW9uTWVudURhdGFEZXRlY3RlZEl0 ZW0gJiYgbWVudS5udW1iZXJPZkl0ZW1zID4gMSkKICAgICAgICAgW3NlbGYgX2hpZGVUZXh0SW5k aWNhdG9yXTsKLSAgICAKKworICAgIGlmIChfcHJldmlld1BvcG92ZXIgJiYgIV9zaG91bGRLZWVw UHJldmlld1BvcG92ZXJPcGVuKSB7CisgICAgICAgIFtfcHJldmlld1BvcG92ZXIgY2xvc2VdOwor ICAgICAgICBfcHJldmlld1BvcG92ZXIgPSBuaWw7CisgICAgfQorCiAgICAgX3N0YXRlID0gQWN0 aW9uTWVudVN0YXRlOjpOb25lOwogICAgIF9oaXRUZXN0UmVzdWx0ID0gQWN0aW9uTWVudUhpdFRl c3RSZXN1bHQoKTsKICAgICBfdHlwZSA9IGtXS0FjdGlvbk1lbnVOb25lOwpAQCAtMjQ5LDI0ICsy NTUsMzMgQEAgLSAodm9pZClfYWRkVG9SZWFkaW5nTGlzdEZyb21BY3Rpb25NZW51OgogfQogCiAj aWYgV0tfQVBJX0VOQUJMRUQKKy0gKHZvaWQpX2tlZXBQcmV2aWV3T3BlbjooaWQpc2VuZGVyCit7 CisgICAgX3Nob3VsZEtlZXBQcmV2aWV3UG9wb3Zlck9wZW4gPSBZRVM7Cit9CisKIC0gKHZvaWQp X3ByZXZpZXdVUkxGcm9tQWN0aW9uTWVudTooaWQpc2VuZGVyCiB7CisgICAgLy8gV2UgbWlnaHQg YWxyZWFkeSBoYXZlIGEgcHJldmlldyBzaG93aW5nIGlmIHRoZSBtZW51IGl0ZW0gd2FzIGhpZ2hs aWdodGVkIGVhcmxpZXIuCisgICAgaWYgKF9wcmV2aWV3UG9wb3ZlcikKKyAgICAgICAgcmV0dXJu OworCiAgICAgV2ViSGl0VGVzdFJlc3VsdCogaGl0VGVzdFJlc3VsdCA9IF9wYWdlLT5sYXN0TW91 c2VNb3ZlSGl0VGVzdFJlc3VsdCgpOwogICAgIE5TVVJMICp1cmwgPSBbTlNVUkwgX3dlYl9VUkxX aXRoV1RGU3RyaW5nOmhpdFRlc3RSZXN1bHQtPmFic29sdXRlTGlua1VSTCgpXTsKLSAgICBSZXRh aW5QdHI8TlNQb3BvdmVyPiBwb3BvdmVyID0gW3NlbGYgX2NyZWF0ZVByZXZpZXdQb3BvdmVyRm9y VVJMOnVybF07Ci0gICAgW3BvcG92ZXIgc2hvd1JlbGF0aXZlVG9SZWN0OmhpdFRlc3RSZXN1bHQt PmVsZW1lbnRCb3VuZGluZ0JveCgpIG9mVmlldzpfd2tWaWV3IHByZWZlcnJlZEVkZ2U6TlNNYXhZ RWRnZV07CisgICAgW3NlbGYgX2NyZWF0ZVByZXZpZXdQb3BvdmVyRm9yVVJMOnVybF07CisgICAg W19wcmV2aWV3UG9wb3ZlciBzaG93UmVsYXRpdmVUb1JlY3Q6aGl0VGVzdFJlc3VsdC0+ZWxlbWVu dEJvdW5kaW5nQm94KCkgb2ZWaWV3Ol93a1ZpZXcgcHJlZmVycmVkRWRnZTpOU01heFlFZGdlXTsK IH0KIAotLSAoUmV0YWluUHRyPE5TUG9wb3Zlcj4pX2NyZWF0ZVByZXZpZXdQb3BvdmVyRm9yVVJM OihOU1VSTCAqKXVybAorLSAodm9pZClfY3JlYXRlUHJldmlld1BvcG92ZXJGb3JVUkw6KE5TVVJM ICopdXJsCiB7CiAgICAgUmV0YWluUHRyPFdLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxlcj4gcHJl dmlld1ZpZXdDb250cm9sbGVyID0gYWRvcHROUyhbW1dLUGFnZVByZXZpZXdWaWV3Q29udHJvbGxl ciBhbGxvY10gaW5pdFdpdGhQYWdlVVJMOnVybF0pOwogICAgIE5TUmVjdCB3a1ZpZXdCb3VuZHMg PSBbX3drVmlldyBib3VuZHNdOwogICAgIHByZXZpZXdWaWV3Q29udHJvbGxlci0+X3ByZWZlcnJl ZFNpemUgPSBOU01ha2VTaXplKE5TV2lkdGgod2tWaWV3Qm91bmRzKSAqIDAuNzUsIE5TSGVpZ2h0 KHdrVmlld0JvdW5kcykgKiAwLjc1KTsKIAotICAgIFJldGFpblB0cjxOU1BvcG92ZXI+IHBvcG92 ZXIgPSBhZG9wdE5TKFtbTlNQb3BvdmVyIGFsbG9jXSBpbml0XSk7Ci0gICAgW3BvcG92ZXIgc2V0 QmVoYXZpb3I6TlNQb3BvdmVyQmVoYXZpb3JUcmFuc2llbnRdOwotICAgIFtwb3BvdmVyIHNldENv bnRlbnRWaWV3Q29udHJvbGxlcjpwcmV2aWV3Vmlld0NvbnRyb2xsZXIuZ2V0KCldOwotICAgIHJl dHVybiBwb3BvdmVyOworICAgIF9wcmV2aWV3UG9wb3ZlciA9IGFkb3B0TlMoW1tOU1BvcG92ZXIg YWxsb2NdIGluaXRdKTsKKyAgICBbX3ByZXZpZXdQb3BvdmVyIHNldEJlaGF2aW9yOk5TUG9wb3Zl ckJlaGF2aW9yVHJhbnNpZW50XTsKKyAgICBbX3ByZXZpZXdQb3BvdmVyIHNldENvbnRlbnRWaWV3 Q29udHJvbGxlcjpwcmV2aWV3Vmlld0NvbnRyb2xsZXIuZ2V0KCldOworICAgIFtfcHJldmlld1Bv cG92ZXIgc2V0RGVsZWdhdGU6c2VsZl07CiB9CiAjZW5kaWYKIApAQCAtNTAzLDYgKzUxOCwxNSBA QCAtICh2b2lkKW1lbnVOZWVkc1VwZGF0ZTooTlNNZW51ICopbWVudQogICAgIFtzZWxmIF91cGRh dGVBY3Rpb25NZW51SXRlbXNGb3JTdGFnZTpNZW51VXBkYXRlU3RhZ2U6Ok1lbnVOZWVkc1VwZGF0 ZV07CiB9CiAKKy0gKHZvaWQpbWVudTooTlNNZW51ICopbWVudSB3aWxsSGlnaGxpZ2h0SXRlbToo TlNNZW51SXRlbSAqKWl0ZW0KK3sKKyNpZiBXS19BUElfRU5BQkxFRAorICAgIGlmIChpdGVtLnRh ZyAhPSBrV0tDb250ZXh0QWN0aW9uSXRlbVRhZ1ByZXZpZXdMaW5rKQorICAgICAgICByZXR1cm47 CisgICAgW3NlbGYgX3ByZXZpZXdVUkxGcm9tQWN0aW9uTWVudTppdGVtXTsKKyNlbmRpZgorfQor CiAjcHJhZ21hIG1hcmsgTlNTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlIGltcGxlbWVudGF0 aW9uCiAKIC0gKE5TQXJyYXkgKilzaGFyaW5nU2VydmljZVBpY2tlcjooTlNTaGFyaW5nU2Vydmlj ZVBpY2tlciAqKXNoYXJpbmdTZXJ2aWNlUGlja2VyIHNoYXJpbmdTZXJ2aWNlc0Zvckl0ZW1zOihO U0FycmF5ICopaXRlbXMgbWFzazooTlNTaGFyaW5nU2VydmljZU1hc2spbWFzayBwcm9wb3NlZFNo YXJpbmdTZXJ2aWNlczooTlNBcnJheSAqKXByb3Bvc2VkU2VydmljZXMKQEAgLTUzMCw2ICs1NTQs MTQgQEAgLSAoTlNXaW5kb3cgKilzaGFyaW5nU2VydmljZTooTlNTaGFyaW5nUwogICAgIHJldHVy biBfd2tWaWV3LndpbmRvdzsKIH0KIAorI3ByYWdtYSBtYXJrIE5TUG9wb3ZlckRlbGVnYXRlIGlt cGxlbWVudGF0aW9uCisKKy0gKHZvaWQpcG9wb3ZlcldpbGxDbG9zZTooTlNOb3RpZmljYXRpb24g Kilub3RpZmljYXRpb24KK3sKKyAgICBfc2hvdWxkS2VlcFByZXZpZXdQb3BvdmVyT3BlbiA9IE5P OworICAgIF9wcmV2aWV3UG9wb3ZlciA9IG5pbDsKK30KKwogI3ByYWdtYSBtYXJrIE1lbnUgSXRl bXMKIAogLSAoUmV0YWluUHRyPE5TTWVudUl0ZW0+KV9jcmVhdGVBY3Rpb25NZW51SXRlbUZvclRh ZzoodWludDMyX3QpdGFnCkBAIC01NDgsNyArNTgwLDcgQEAgLSAoUmV0YWluUHRyPE5TTWVudUl0 ZW0+KV9jcmVhdGVBY3Rpb25NZQogCiAjaWYgV0tfQVBJX0VOQUJMRUQKICAgICBjYXNlIGtXS0Nv bnRleHRBY3Rpb25JdGVtVGFnUHJldmlld0xpbms6Ci0gICAgICAgIHNlbGVjdG9yID0gQHNlbGVj dG9yKF9wcmV2aWV3VVJMRnJvbUFjdGlvbk1lbnU6KTsKKyAgICAgICAgc2VsZWN0b3IgPSBAc2Vs ZWN0b3IoX2tlZXBQcmV2aWV3T3BlbjopOwogICAgICAgICB0aXRsZSA9IEAiUHJldmlldyI7CiAg ICAgICAgIGltYWdlID0gW05TSW1hZ2UgaW1hZ2VOYW1lZDpAIk5TQWN0aW9uTWVudVF1aWNrTG9v ayJdOwogICAgICAgICBicmVhazsK