138430 2014-11-05 10:19:33 -0800 RenderBlock shouldn't need a pre-destructor hook. 2014-11-05 13:22:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1046517 0 kling 2014-11-05 10:19:33 -0800 RenderBlock does nothing interesting in willBeDestroyed() and can make do with a plain destructor. 1046518 1 241038 kling 2014-11-05 10:21:15 -0800 Created attachment 241038 Patch 1046586 2 241038 commit-queue 2014-11-05 13:22:47 -0800 Comment on attachment 241038 Patch Clearing flags on attachment: 241038 Committed r175640: <http://trac.webkit.org/changeset/175640> 1046587 3 commit-queue 2014-11-05 13:22:51 -0800 All reviewed patches have been landed. Closing bug. 241038 2014-11-05 10:21:15 -0800 2014-11-05 13:22:47 -0800 Patch bug-138430.diff text/plain 2690 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNGUwNGEzLi5kM2FmNzk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTQtMTEtMDUgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbmRlckJsb2NrIHNob3VsZG4ndCBuZWVkIGEgcHJlLWRlc3RydWN0b3IgaG9vay4KKyAg ICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzODQzMD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwgdGhhdCB3YXMgaW50ZXJlc3RpbmcgaW4g UmVuZGVyQmxvY2s6OndpbGxCZURlc3Ryb3llZCgpIGhhcyBtaWdyYXRlZAorICAgICAgICB0byBS ZW5kZXJCbG9ja0Zsb3cuIHJlbW92ZUZyb21VcGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXRUcmFu c2FjdGlvbigpCisgICAgICAgIGNhbiBiZSBjYWxsZWQgZnJvbSB0aGUgcGxhaW4gZGVzdHJ1Y3Rv ciwgc28ganVzdCBtb3ZlIGl0IHRoZXJlLgorCisgICAgICAgIFdlIGRvbid0IGhhdmUgdG8gd29y cnkgYWJvdXQgZGVzdHJveUxlZnRvdmVyQ2hpbGRyZW4oKSwgc2luY2UgUmVuZGVyRWxlbWVudAor ICAgICAgICB3aWxsIHRha2UgY2FyZSBvZiB0aGF0IGZvciB1cy4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6flJl bmRlckJsb2NrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjp3aWxsQmVEZXN0cm95 ZWQpOiBEZWxldGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgorCiAyMDE0 LTExLTA1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OKHIxNzU2MDEpOiBBc3NlcnRpb24gZmFpbHVyZXMgaW4gU2ltcGxlTGluZUxheW91dApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggY2FkMDdjMS4uMzUw MjIwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC0yMjMs NiArMjIzLDggQEAgc3RhdGljIHZvaWQgcmVtb3ZlQmxvY2tGcm9tRGVzY2VuZGFudEFuZENvbnRh aW5lck1hcHMoUmVuZGVyQmxvY2sqIGJsb2NrLCBUcmFja2UKIAogUmVuZGVyQmxvY2s6On5SZW5k ZXJCbG9jaygpCiB7CisgICAgcmVtb3ZlRnJvbVVwZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dFRy YW5zYWN0aW9uKCk7CisKICAgICBpZiAoZ1JhcmVEYXRhTWFwKQogICAgICAgICBnUmFyZURhdGFN YXAtPnJlbW92ZSh0aGlzKTsKICAgICBpZiAoZ1BlcmNlbnRIZWlnaHREZXNjZW5kYW50c01hcCkK QEAgLTIzNiwxNyArMjM4LDYgQEAgYm9vbCBSZW5kZXJCbG9jazo6aGFzUmFyZURhdGEoKSBjb25z dAogICAgIHJldHVybiBnUmFyZURhdGFNYXAgPyBnUmFyZURhdGFNYXAtPmNvbnRhaW5zKHRoaXMp IDogZmFsc2U7CiB9CiAKLXZvaWQgUmVuZGVyQmxvY2s6OndpbGxCZURlc3Ryb3llZCgpCi17Ci0g ICAgLy8gTWFrZSBzdXJlIHRvIGRlc3Ryb3kgYW5vbnltb3VzIGNoaWxkcmVuIGZpcnN0IHdoaWxl IHRoZXkgYXJlIHN0aWxsIGNvbm5lY3RlZCB0byB0aGUgcmVzdCBvZiB0aGUgdHJlZSwgc28gdGhh dCB0aGV5IHdpbGwKLSAgICAvLyBwcm9wZXJseSBkaXJ0eSBsaW5lIGJveGVzIHRoYXQgdGhleSBh cmUgcmVtb3ZlZCBmcm9tLiBFZmZlY3RzIHRoYXQgZG8gOmJlZm9yZS86YWZ0ZXIgb25seSBvbiBo b3ZlciBjb3VsZCBjcmFzaCBvdGhlcndpc2UuCi0gICAgZGVzdHJveUxlZnRvdmVyQ2hpbGRyZW4o KTsKLQotICAgIHJlbW92ZUZyb21VcGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXRUcmFuc2FjdGlv bigpOwotCi0gICAgUmVuZGVyQm94Ojp3aWxsQmVEZXN0cm95ZWQoKTsKLX0KLQogdm9pZCBSZW5k ZXJCbG9jazo6c3R5bGVXaWxsQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5k ZXJTdHlsZSYgbmV3U3R5bGUpCiB7CiAgICAgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlID0g aGFzSW5pdGlhbGl6ZWRTdHlsZSgpID8gJnN0eWxlKCkgOiBudWxscHRyOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmggYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2suaAppbmRleCA1MTkyMjUzLi4zNGJjZWNlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaApAQCAtMzE2LDcgKzMxNiw2IEBAIHB1YmxpYzoK IAogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgUmVuZGVyRmxvd1RocmVhZCogbG9jYXRlRmxvd1Ro cmVhZENvbnRhaW5pbmdCbG9jaygpIGNvbnN0IG92ZXJyaWRlOwotICAgIHZpcnR1YWwgdm9pZCB3 aWxsQmVEZXN0cm95ZWQoKSBvdmVycmlkZTsKIAogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKSBv dmVycmlkZTsKIAo=