138421 2014-11-05 06:46:10 -0800 [WinCairo] Compile error, missing guard. 2014-11-05 15:04:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 138170 1 peavo webkit-unassigned alex.christensen benjamin bfulgham commit-queue diorahman oldest_to_newest 1046460 0 peavo 2014-11-05 06:46:10 -0800 There is missing a guard for CSS_SELECTORS_LEVEL4 in CSSParserValues.cpp. 1046461 1 241026 peavo 2014-11-05 06:50:02 -0800 Created attachment 241026 Patch 1046475 2 241026 bfulgham 2014-11-05 08:52:55 -0800 Comment on attachment 241026 Patch r=me. Thank you for fixing this! 1046477 3 bfulgham 2014-11-05 08:54:28 -0800 This bug was introduced in <http://trac.webkit.org/changeset/175446>. 1046501 4 241026 commit-queue 2014-11-05 09:35:12 -0800 Comment on attachment 241026 Patch Clearing flags on attachment: 241026 Committed r175621: <http://trac.webkit.org/changeset/175621> 1046502 5 commit-queue 2014-11-05 09:35:15 -0800 All reviewed patches have been landed. Closing bug. 1046539 6 peavo 2014-11-05 11:00:24 -0800 (In reply to comment #2) > Comment on attachment 241026 [details] > Patch > > r=me. Thank you for fixing this! Thanks for reviewing :) 1046613 7 diorahman 2014-11-05 15:04:37 -0800 Thank you for fixing this. My bad. 241026 2014-11-05 06:50:02 -0800 2014-11-05 09:35:12 -0800 Patch bug-138421-20141105155000.patch text/plain 1504 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NTYxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTExLTA1ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvciwgbWlzc2luZyBndWFyZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzODQyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIG1pc3NpbmcgYSBndWFyZCBmb3IgQ1NTX1NFTEVD VE9SU19MRVZFTDQgaW4gQ1NTUGFyc2VyVmFsdWVzLmNwcC4KKworICAgICAgICAqIGNzcy9DU1NQ YXJzZXJWYWx1ZXMuY3BwOgorCiAyMDE0LTExLTA1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFw cGxlLmNvbT4KIAogICAgICAgICBTaW1wbGUgbGluZSBsYXlvdXQ6IHN1cHBvcnQgdGV4dC10cmFu c2Zvcm06IGxvd2VyY2FzZXx1cHBlcmNhc2V8Y2FwaXRhbGl6ZQpJbmRleDogU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlclZhbHVlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv Y3NzL0NTU1BhcnNlclZhbHVlcy5jcHAJKHJldmlzaW9uIDE3NTYxOSkKKysrIFNvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjEsNiArMjYx LDcgQEAgdm9pZCBDU1NQYXJzZXJTZWxlY3Rvcjo6YWRvcHRTZWxlY3RvclZlYwogICAgIG1fc2Vs ZWN0b3ItPnNldFNlbGVjdG9yTGlzdChXVEY6Om1vdmUoc2VsZWN0b3JMaXN0KSk7CiB9CiAKKyNp ZiBFTkFCTEUoQ1NTX1NFTEVDVE9SU19MRVZFTDQpCiB2b2lkIENTU1BhcnNlclNlbGVjdG9yOjpz ZXRBcmd1bWVudExpc3QoVmVjdG9yPENTU1BhcnNlclN0cmluZz4mIHN0cmluZ1ZlY3RvcikKIHsK ICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKCFzdHJpbmdWZWN0b3IuaXNFbXB0eSgpLCAiTm8gQ1NT IFNlbGVjdG9yIHRha2VzIGFuIGVtcHR5IGFyZ3VtZW50IGxpc3QuIik7CkBAIC0yNzAsNiArMjcx LDcgQEAgdm9pZCBDU1NQYXJzZXJTZWxlY3Rvcjo6c2V0QXJndW1lbnRMaXN0KAogICAgICAgICBh cmd1bWVudExpc3QtPmFwcGVuZChhcmd1bWVudCk7CiAgICAgbV9zZWxlY3Rvci0+c2V0QXJndW1l bnRMaXN0KFdURjo6bW92ZShhcmd1bWVudExpc3QpKTsKIH0KKyNlbmRpZgogCiB2b2lkIENTU1Bh cnNlclNlbGVjdG9yOjpzZXRQc2V1ZG9DbGFzc1ZhbHVlKGNvbnN0IENTU1BhcnNlclN0cmluZyYg cHNldWRvQ2xhc3NTdHJpbmcpCiB7Cg==