<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>13842</bug_id>
          
          <creation_ts>2007-05-23 07:10:16 -0700</creation_ts>
          <short_desc>Simplify Color::light() and Color::dark()</short_desc>
          <delta_ts>2007-05-26 07:00:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Trivial</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>9301</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2007-05-23 07:10:16 -0700</bug_when>
    <thetext>The RGB-&gt;HSV-&gt;RGB conversion Color::light() and Color::dark() do is an overkill. I don&apos;t think those functions are hot but what they do can be described and implemented in simpler terms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9302</commentid>
    <comment_count>1</comment_count>
      <attachid>14683</attachid>
    <who name="">mitz</who>
    <bug_when>2007-05-23 07:11:25 -0700</bug_when>
    <thetext>Created attachment 14683
Simpler implementation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9305</commentid>
    <comment_count>2</comment_count>
      <attachid>14684</attachid>
    <who name="">mitz</who>
    <bug_when>2007-05-23 07:40:01 -0700</bug_when>
    <thetext>Created attachment 14684
Simpler implementation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9306</commentid>
    <comment_count>3</comment_count>
      <attachid>14684</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2007-05-23 07:57:12 -0700</bug_when>
    <thetext>Comment on attachment 14684
Simpler implementation

Does this really give the same values as before? If so, seems fine. But I was under the impression that scaling value didn&apos;t affect the 3 channels equally.

I don&apos;t think dark() properly handles the case where all three of r, g, and b are zero. So review- because of that. Otherwise, would be r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9313</commentid>
    <comment_count>4</comment_count>
      <attachid>14684</attachid>
    <who name="">mitz</who>
    <bug_when>2007-05-23 09:09:22 -0700</bug_when>
    <thetext>Comment on attachment 14684
Simpler implementation

(In reply to comment #3)
&gt; (From update of attachment 14684 [edit])
&gt; Does this really give the same values as before? If so, seems fine. But I was
&gt; under the impression that scaling value didn&apos;t affect the 3 channels equally.

If you look at convertHSVToRGB() you&apos;ll see that its result can be expressed as &quot;v times some vector x whose components do not depend on v&quot;, so indeed for given h and s components, scaling v affects the 3 channels equally. (IIRC in the HSL space, L doesn&apos;t affect all channels equally, since L=1.0 maps to white).

&gt; I don&apos;t think dark() properly handles the case where all three of r, g, and b
&gt; are zero.

I verified that in that case (v - 0.33f) / v is -inf and therefore the multiplier is 0, so the result is &lt;0,0,0,alpha&gt;, which is what I would expect.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9300</commentid>
    <comment_count>5</comment_count>
      <attachid>14684</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2007-05-23 09:12:22 -0700</bug_when>
    <thetext>Comment on attachment 14684
Simpler implementation

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9074</commentid>
    <comment_count>6</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-05-26 07:00:59 -0700</bug_when>
    <thetext>Landed in r21798.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>14683</attachid>
            <date>2007-05-23 07:11:25 -0700</date>
            <delta_ts>2007-05-23 07:13:10 -0700</delta_ts>
            <desc>Simpler implementation</desc>
            <filename>13842_r1.patch</filename>
            <type>text/plain</type>
            <size>4387</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyMTY2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMDctMDUtMjMgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gaHR0
cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDIKKyAgICAgICAgICBTaW1w
bGlmeSBDb2xvcjo6bGlnaHQoKSBhbmQgQ29sb3I6OmRhcmsoKQorCisgICAgICAgIE5vdCB0ZXN0
YWJsZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OkNvbG9yOjpsaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpDb2xvcjo6ZGFyayk6
CisKIDIwMDctMDUtMjMgIExhcnMgS25vbGwgPGxhcnNAdHJvbGx0ZWNoLmNvbT4KIAogICAgICAg
ICBSZXZpZXdlZCBieSBaYWNrIGFuZCBWYWxncmluZApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9n
cmFwaGljcy9Db2xvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9Db2xvci5jcHAJKHJldmlzaW9uIDIxNjYwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9Db2xvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Niw3OCArMTU2LDYgQEAgdm9pZCBDb2xv
cjo6c2V0TmFtZWRDb2xvcihjb25zdCBTdHJpbmcmIAogICAgIG1fdmFsaWQgPSBmb3VuZENvbG9y
OwogfQogCi1jb25zdCBmbG9hdCB1bmRlZmluZWRIdWUgPSAtMTsKLQotLy8gRXhwbGFuYXRpb25z
IG9mIHRoZXNlIGFsZ29yaXRobXMgY2FuIGJlIGZvdW5kIGF0IGh0dHA6Ly93d3cuYWNtLm9yZy9q
Z3QvcGFwZXJzL1NtaXRoTHlvbnM5Ni9oc3ZfcmdiLmh0bWwKLXN0YXRpYyB2b2lkIGNvbnZlcnRS
R0JUb0hTVihmbG9hdCByLCBmbG9hdCBnLCBmbG9hdCBiLCBmbG9hdCYgaCwgZmxvYXQmIHMsIGZs
b2F0JiB2KQotewotICAgIGZsb2F0IHggPSBtaW4ociwgbWluKGcsIGIpKTsKLSAgICB2ID0gbWF4
KHIsIG1heChnLCBiKSk7Ci0KLSAgICBpZiAodiA9PSB4KSB7Ci0gICAgICAgIGggPSB1bmRlZmlu
ZWRIdWU7Ci0gICAgICAgIHMgPSAwOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIGZsb2F0IGYgPSAo
ciA9PSB4KSA/IGcgLSBiIDogKChnID09IHgpID8gYiAtIHIgOiByIC0gZyk7IAotICAgICAgICBp
bnQgaSA9IChyID09IHgpID8gMyA6ICgoZyA9PSB4KSA/IDUgOiAxKTsgCi0gICAgICAgIGggPSBp
IC0gZiAvICh2IC0geCk7Ci0gICAgICAgIGlmICh2ICE9IDApCi0gICAgICAgICAgICBzID0gKHYg
LSB4KSAvIHY7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHMgPSAwOwotICAgIH0KLX0KLQot
c3RhdGljIHZvaWQgY29udmVydEhTVlRvUkdCKGZsb2F0IGgsIGZsb2F0IHMsIGZsb2F0IHYsIGZs
b2F0JiByLCBmbG9hdCYgZywgZmxvYXQmIGIpCi17Ci0gICAgaWYgKGggPT0gdW5kZWZpbmVkSHVl
KSB7Ci0gICAgICAgIHIgPSB2OwotICAgICAgICBnID0gdjsKLSAgICAgICAgYiA9IHY7Ci0gICAg
ICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBpbnQgaSA9IHN0YXRpY19jYXN0PGludD4oaCk7IC8v
IHNlY3RvciAwIHRvIDUKLSAgICBmbG9hdCBmID0gaCAtIGk7IC8vIGZyYWN0aW9uYWwgcGFydCBv
ZiBoCi0gICAgaWYgKCEoaSAmIDEpKQotICAgICAgICBmID0gMSAtIGY7Ci0gICAgZmxvYXQgbSA9
IHYgKiAoMSAtIHMpOwotICAgIGZsb2F0IG4gPSB2ICogKDEgLSBzICogZik7Ci0KLSAgICBzd2l0
Y2ggKGkpIHsKLSAgICAgICAgZGVmYXVsdDogLy8gMCBhbmQgNgotICAgICAgICAgICAgciA9IHY7
Ci0gICAgICAgICAgICBnID0gbjsKLSAgICAgICAgICAgIGIgPSBtOwotICAgICAgICAgICAgYnJl
YWs7Ci0gICAgICAgIGNhc2UgMToKLSAgICAgICAgICAgIHIgPSBuOwotICAgICAgICAgICAgZyA9
IHY7Ci0gICAgICAgICAgICBiID0gbTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNl
IDI6Ci0gICAgICAgICAgICByID0gbTsKLSAgICAgICAgICAgIGcgPSB2OwotICAgICAgICAgICAg
YiA9IG47Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSAzOgotICAgICAgICAgICAg
ciA9IG07Ci0gICAgICAgICAgICBnID0gbjsKLSAgICAgICAgICAgIGIgPSB2OwotICAgICAgICAg
ICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgNDoKLSAgICAgICAgICAgIHIgPSBuOwotICAgICAgICAg
ICAgZyA9IG07Ci0gICAgICAgICAgICBiID0gdjsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAg
ICBjYXNlIDU6Ci0gICAgICAgICAgICByID0gdjsKLSAgICAgICAgICAgIGcgPSBtOwotICAgICAg
ICAgICAgYiA9IG47Ci0gICAgICAgICAgICBicmVhazsKLSAgICB9Ci19Ci0KIENvbG9yIENvbG9y
OjpsaWdodCgpIGNvbnN0CiB7CiAgICAgLy8gSGFyZGNvZGUgdGhpcyBjb21tb24gY2FzZSBmb3Ig
c3BlZWQuCkBAIC0yMzYsMTUgKzE2NCwxNiBAQCBDb2xvciBDb2xvcjo6bGlnaHQoKSBjb25zdAog
ICAgIAogICAgIGNvbnN0IGZsb2F0IHNjYWxlRmFjdG9yID0gbmV4dGFmdGVyZigyNTYuMGYsIDAu
MGYpOwogCi0gICAgZmxvYXQgciwgZywgYiwgYSwgaCwgcywgdjsKKyAgICBmbG9hdCByLCBnLCBi
LCBhOwogICAgIGdldFJHQkEociwgZywgYiwgYSk7Ci0gICAgY29udmVydFJHQlRvSFNWKHIsIGcs
IGIsIGgsIHMsIHYpOwotICAgIHYgPSBtYXgoMC4wZiwgbWluKHYgKyAwLjMzZiwgMS4wZikpOwot
ICAgIGNvbnZlcnRIU1ZUb1JHQihoLCBzLCB2LCByLCBnLCBiKTsKLSAgICByZXR1cm4gQ29sb3Io
c3RhdGljX2Nhc3Q8aW50PihyICogc2NhbGVGYWN0b3IpLAotICAgICAgICAgICAgICAgICBzdGF0
aWNfY2FzdDxpbnQ+KGcgKiBzY2FsZUZhY3RvciksCi0gICAgICAgICAgICAgICAgIHN0YXRpY19j
YXN0PGludD4oYiAqIHNjYWxlRmFjdG9yKSwKLSAgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8
aW50PihhICogc2NhbGVGYWN0b3IpKTsKKworICAgIGZsb2F0IHYgPSBtYXgociwgbWF4KGcsIGIp
KTsKKyAgICBmbG9hdCBtdWx0aXBsaWVyID0gbWF4KDEuMGYsIHYgKyAwLjMzZikgLyB2OworCisg
ICAgcmV0dXJuIENvbG9yKHN0YXRpY19jYXN0PGludD4obXVsdGlwbGllciAqIHIgKiBzY2FsZUZh
Y3RvciksCisgICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4obXVsdGlwbGllciAqIGcg
KiBzY2FsZUZhY3RvciksCisgICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4obXVsdGlw
bGllciAqIGIgKiBzY2FsZUZhY3RvciksCisgICAgICAgICAgICAgICAgIGFscGhhKCkpOwogfQog
CiBDb2xvciBDb2xvcjo6ZGFyaygpIGNvbnN0CkBAIC0yNTUsMTUgKzE4NCwxNiBAQCBDb2xvciBD
b2xvcjo6ZGFyaygpIGNvbnN0CiAgICAgCiAgICAgY29uc3QgZmxvYXQgc2NhbGVGYWN0b3IgPSBu
ZXh0YWZ0ZXJmKDI1Ni4wZiwgMC4wZik7CiAKLSAgICBmbG9hdCByLCBnLCBiLCBhLCBoLCBzLCB2
OworICAgIGZsb2F0IHIsIGcsIGIsIGE7CiAgICAgZ2V0UkdCQShyLCBnLCBiLCBhKTsKLSAgICBj
b252ZXJ0UkdCVG9IU1YociwgZywgYiwgaCwgcywgdik7Ci0gICAgdiA9IG1heCgwLjBmLCBtaW4o
diAtIDAuMzNmLCAxLjBmKSk7Ci0gICAgY29udmVydEhTVlRvUkdCKGgsIHMsIHYsIHIsIGcsIGIp
OwotICAgIHJldHVybiBDb2xvcihzdGF0aWNfY2FzdDxpbnQ+KHIgKiBzY2FsZUZhY3RvciksCi0g
ICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZyAqIHNjYWxlRmFjdG9yKSwKLSAgICAg
ICAgICAgICAgICAgc3RhdGljX2Nhc3Q8aW50PihiICogc2NhbGVGYWN0b3IpLAotICAgICAgICAg
ICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGEgKiBzY2FsZUZhY3RvcikpOworCisgICAgZmxvYXQg
diA9IG1heChyLCBtYXgoZywgYikpOworICAgIGZsb2F0IG11bHRpcGxpZXIgPSBtYXgoMC4wZiwg
KHYgLSAwLjMzZikgLyB2KTsKKworICAgIHJldHVybiBDb2xvcihzdGF0aWNfY2FzdDxpbnQ+KG11
bHRpcGxpZXIgKiByICogc2NhbGVGYWN0b3IpLAorICAgICAgICAgICAgICAgICBzdGF0aWNfY2Fz
dDxpbnQ+KG11bHRpcGxpZXIgKiBnICogc2NhbGVGYWN0b3IpLAorICAgICAgICAgICAgICAgICBz
dGF0aWNfY2FzdDxpbnQ+KG11bHRpcGxpZXIgKiBiICogc2NhbGVGYWN0b3IpLAorICAgICAgICAg
ICAgICAgICBhbHBoYSgpKTsKIH0KIAogc3RhdGljIGludCBibGVuZChpbnQgYywgaW50IGEpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>14684</attachid>
            <date>2007-05-23 07:40:01 -0700</date>
            <delta_ts>2007-05-23 09:12:22 -0700</delta_ts>
            <desc>Simpler implementation</desc>
            <filename>13842_r1.patch</filename>
            <type>text/plain</type>
            <size>4501</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyMTY2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMDctMDUtMjMgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gaHR0
cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDIKKyAgICAgICAgICBTaW1w
bGlmeSBDb2xvcjo6bGlnaHQoKSBhbmQgQ29sb3I6OmRhcmsoKQorCisgICAgICAgIE5vdCB0ZXN0
YWJsZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OkNvbG9yOjpsaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpDb2xvcjo6ZGFyayk6
CisKIDIwMDctMDUtMjMgIExhcnMgS25vbGwgPGxhcnNAdHJvbGx0ZWNoLmNvbT4KIAogICAgICAg
ICBSZXZpZXdlZCBieSBaYWNrIGFuZCBWYWxncmluZApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9n
cmFwaGljcy9Db2xvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9Db2xvci5jcHAJKHJldmlzaW9uIDIxNjYwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9Db2xvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Niw3OCArMTU2LDYgQEAgdm9pZCBDb2xv
cjo6c2V0TmFtZWRDb2xvcihjb25zdCBTdHJpbmcmIAogICAgIG1fdmFsaWQgPSBmb3VuZENvbG9y
OwogfQogCi1jb25zdCBmbG9hdCB1bmRlZmluZWRIdWUgPSAtMTsKLQotLy8gRXhwbGFuYXRpb25z
IG9mIHRoZXNlIGFsZ29yaXRobXMgY2FuIGJlIGZvdW5kIGF0IGh0dHA6Ly93d3cuYWNtLm9yZy9q
Z3QvcGFwZXJzL1NtaXRoTHlvbnM5Ni9oc3ZfcmdiLmh0bWwKLXN0YXRpYyB2b2lkIGNvbnZlcnRS
R0JUb0hTVihmbG9hdCByLCBmbG9hdCBnLCBmbG9hdCBiLCBmbG9hdCYgaCwgZmxvYXQmIHMsIGZs
b2F0JiB2KQotewotICAgIGZsb2F0IHggPSBtaW4ociwgbWluKGcsIGIpKTsKLSAgICB2ID0gbWF4
KHIsIG1heChnLCBiKSk7Ci0KLSAgICBpZiAodiA9PSB4KSB7Ci0gICAgICAgIGggPSB1bmRlZmlu
ZWRIdWU7Ci0gICAgICAgIHMgPSAwOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIGZsb2F0IGYgPSAo
ciA9PSB4KSA/IGcgLSBiIDogKChnID09IHgpID8gYiAtIHIgOiByIC0gZyk7IAotICAgICAgICBp
bnQgaSA9IChyID09IHgpID8gMyA6ICgoZyA9PSB4KSA/IDUgOiAxKTsgCi0gICAgICAgIGggPSBp
IC0gZiAvICh2IC0geCk7Ci0gICAgICAgIGlmICh2ICE9IDApCi0gICAgICAgICAgICBzID0gKHYg
LSB4KSAvIHY7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHMgPSAwOwotICAgIH0KLX0KLQot
c3RhdGljIHZvaWQgY29udmVydEhTVlRvUkdCKGZsb2F0IGgsIGZsb2F0IHMsIGZsb2F0IHYsIGZs
b2F0JiByLCBmbG9hdCYgZywgZmxvYXQmIGIpCi17Ci0gICAgaWYgKGggPT0gdW5kZWZpbmVkSHVl
KSB7Ci0gICAgICAgIHIgPSB2OwotICAgICAgICBnID0gdjsKLSAgICAgICAgYiA9IHY7Ci0gICAg
ICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBpbnQgaSA9IHN0YXRpY19jYXN0PGludD4oaCk7IC8v
IHNlY3RvciAwIHRvIDUKLSAgICBmbG9hdCBmID0gaCAtIGk7IC8vIGZyYWN0aW9uYWwgcGFydCBv
ZiBoCi0gICAgaWYgKCEoaSAmIDEpKQotICAgICAgICBmID0gMSAtIGY7Ci0gICAgZmxvYXQgbSA9
IHYgKiAoMSAtIHMpOwotICAgIGZsb2F0IG4gPSB2ICogKDEgLSBzICogZik7Ci0KLSAgICBzd2l0
Y2ggKGkpIHsKLSAgICAgICAgZGVmYXVsdDogLy8gMCBhbmQgNgotICAgICAgICAgICAgciA9IHY7
Ci0gICAgICAgICAgICBnID0gbjsKLSAgICAgICAgICAgIGIgPSBtOwotICAgICAgICAgICAgYnJl
YWs7Ci0gICAgICAgIGNhc2UgMToKLSAgICAgICAgICAgIHIgPSBuOwotICAgICAgICAgICAgZyA9
IHY7Ci0gICAgICAgICAgICBiID0gbTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNl
IDI6Ci0gICAgICAgICAgICByID0gbTsKLSAgICAgICAgICAgIGcgPSB2OwotICAgICAgICAgICAg
YiA9IG47Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSAzOgotICAgICAgICAgICAg
ciA9IG07Ci0gICAgICAgICAgICBnID0gbjsKLSAgICAgICAgICAgIGIgPSB2OwotICAgICAgICAg
ICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgNDoKLSAgICAgICAgICAgIHIgPSBuOwotICAgICAgICAg
ICAgZyA9IG07Ci0gICAgICAgICAgICBiID0gdjsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAg
ICBjYXNlIDU6Ci0gICAgICAgICAgICByID0gdjsKLSAgICAgICAgICAgIGcgPSBtOwotICAgICAg
ICAgICAgYiA9IG47Ci0gICAgICAgICAgICBicmVhazsKLSAgICB9Ci19Ci0KIENvbG9yIENvbG9y
OjpsaWdodCgpIGNvbnN0CiB7CiAgICAgLy8gSGFyZGNvZGUgdGhpcyBjb21tb24gY2FzZSBmb3Ig
c3BlZWQuCkBAIC0yMzYsMTUgKzE2NCwyMSBAQCBDb2xvciBDb2xvcjo6bGlnaHQoKSBjb25zdAog
ICAgIAogICAgIGNvbnN0IGZsb2F0IHNjYWxlRmFjdG9yID0gbmV4dGFmdGVyZigyNTYuMGYsIDAu
MGYpOwogCi0gICAgZmxvYXQgciwgZywgYiwgYSwgaCwgcywgdjsKKyAgICBmbG9hdCByLCBnLCBi
LCBhOwogICAgIGdldFJHQkEociwgZywgYiwgYSk7Ci0gICAgY29udmVydFJHQlRvSFNWKHIsIGcs
IGIsIGgsIHMsIHYpOwotICAgIHYgPSBtYXgoMC4wZiwgbWluKHYgKyAwLjMzZiwgMS4wZikpOwot
ICAgIGNvbnZlcnRIU1ZUb1JHQihoLCBzLCB2LCByLCBnLCBiKTsKLSAgICByZXR1cm4gQ29sb3Io
c3RhdGljX2Nhc3Q8aW50PihyICogc2NhbGVGYWN0b3IpLAotICAgICAgICAgICAgICAgICBzdGF0
aWNfY2FzdDxpbnQ+KGcgKiBzY2FsZUZhY3RvciksCi0gICAgICAgICAgICAgICAgIHN0YXRpY19j
YXN0PGludD4oYiAqIHNjYWxlRmFjdG9yKSwKLSAgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8
aW50PihhICogc2NhbGVGYWN0b3IpKTsKKworICAgIGZsb2F0IHYgPSBtYXgociwgbWF4KGcsIGIp
KTsKKworICAgIGlmICh2ID09IDAuMGYpCisgICAgICAgIC8vIExpZ2h0ZW5lZCBibGFjayB3aXRo
IGFscGhhLgorICAgICAgICByZXR1cm4gQ29sb3IoMHg1NCwgMHg1NCwgMHg1NCwgYWxwaGEoKSk7
CisKKyAgICBmbG9hdCBtdWx0aXBsaWVyID0gbWluKDEuMGYsIHYgKyAwLjMzZikgLyB2OworCisg
ICAgcmV0dXJuIENvbG9yKHN0YXRpY19jYXN0PGludD4obXVsdGlwbGllciAqIHIgKiBzY2FsZUZh
Y3RvciksCisgICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4obXVsdGlwbGllciAqIGcg
KiBzY2FsZUZhY3RvciksCisgICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4obXVsdGlw
bGllciAqIGIgKiBzY2FsZUZhY3RvciksCisgICAgICAgICAgICAgICAgIGFscGhhKCkpOwogfQog
CiBDb2xvciBDb2xvcjo6ZGFyaygpIGNvbnN0CkBAIC0yNTUsMTUgKzE4OSwxNiBAQCBDb2xvciBD
b2xvcjo6ZGFyaygpIGNvbnN0CiAgICAgCiAgICAgY29uc3QgZmxvYXQgc2NhbGVGYWN0b3IgPSBu
ZXh0YWZ0ZXJmKDI1Ni4wZiwgMC4wZik7CiAKLSAgICBmbG9hdCByLCBnLCBiLCBhLCBoLCBzLCB2
OworICAgIGZsb2F0IHIsIGcsIGIsIGE7CiAgICAgZ2V0UkdCQShyLCBnLCBiLCBhKTsKLSAgICBj
b252ZXJ0UkdCVG9IU1YociwgZywgYiwgaCwgcywgdik7Ci0gICAgdiA9IG1heCgwLjBmLCBtaW4o
diAtIDAuMzNmLCAxLjBmKSk7Ci0gICAgY29udmVydEhTVlRvUkdCKGgsIHMsIHYsIHIsIGcsIGIp
OwotICAgIHJldHVybiBDb2xvcihzdGF0aWNfY2FzdDxpbnQ+KHIgKiBzY2FsZUZhY3RvciksCi0g
ICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZyAqIHNjYWxlRmFjdG9yKSwKLSAgICAg
ICAgICAgICAgICAgc3RhdGljX2Nhc3Q8aW50PihiICogc2NhbGVGYWN0b3IpLAotICAgICAgICAg
ICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGEgKiBzY2FsZUZhY3RvcikpOworCisgICAgZmxvYXQg
diA9IG1heChyLCBtYXgoZywgYikpOworICAgIGZsb2F0IG11bHRpcGxpZXIgPSBtYXgoMC4wZiwg
KHYgLSAwLjMzZikgLyB2KTsKKworICAgIHJldHVybiBDb2xvcihzdGF0aWNfY2FzdDxpbnQ+KG11
bHRpcGxpZXIgKiByICogc2NhbGVGYWN0b3IpLAorICAgICAgICAgICAgICAgICBzdGF0aWNfY2Fz
dDxpbnQ+KG11bHRpcGxpZXIgKiBnICogc2NhbGVGYWN0b3IpLAorICAgICAgICAgICAgICAgICBz
dGF0aWNfY2FzdDxpbnQ+KG11bHRpcGxpZXIgKiBiICogc2NhbGVGYWN0b3IpLAorICAgICAgICAg
ICAgICAgICBhbHBoYSgpKTsKIH0KIAogc3RhdGljIGludCBibGVuZChpbnQgYywgaW50IGEpCg==
</data>
<flag name="review"
          id="6034"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>