138419 2014-11-05 06:14:05 -0800 [EFL] Remove m_scrollPosition from CoordinatedGraphicsScene 2014-11-06 02:09:00 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi buildbot cmarcelo commit-queue gyuyoung.kim lucas.de.marchi luiz noam rniwa sergio zeno oldest_to_newest 1046455 0 ryuan.choi 2014-11-05 06:14:05 -0800 m_scrollPosition of CoordinatedGraphicsScene is only to adjust fixed element in paintToCurrentGLContext. But, WebView already know it so we can pass it to paintToCurrentGLContext. 1046457 1 241025 ryuan.choi 2014-11-05 06:20:12 -0800 Created attachment 241025 Patch 1046746 2 241025 gyuyoung.kim 2014-11-06 00:16:25 -0800 Comment on attachment 241025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241025&action=review > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:-77 > - const FloatPoint& scrollPosition = rect.location(); Is this scrollPosition same with contentPosition which is used by this patch ? I think this patch should pass WKViewRestoreZoomAndScrollBackForward unit test at least. 1046752 3 241025 ryuan.choi 2014-11-06 00:26:34 -0800 Comment on attachment 241025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241025&action=review >> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:-77 >> - const FloatPoint& scrollPosition = rect.location(); > > Is this scrollPosition same with contentPosition which is used by this patch ? I think this patch should pass WKViewRestoreZoomAndScrollBackForward unit test at least. Sure, scroll API such as EwkView::scrollBy update m_contentPosition via WKViewSetContentPosition and calls setVisibleContentRect via didChangeContentsVisibility. If these are different, fixed elements will be drawn at wrong coordination. And I tested WKViewRestoreZoomAndScrollBackForward and WKViewScrollTo and both tests are fine. 1046770 4 241025 commit-queue 2014-11-06 02:08:53 -0800 Comment on attachment 241025 Patch Clearing flags on attachment: 241025 Committed r175692: <http://trac.webkit.org/changeset/175692> 1046771 5 commit-queue 2014-11-06 02:09:00 -0800 All reviewed patches have been landed. Closing bug. 241025 2014-11-05 06:20:12 -0800 2014-11-06 02:08:53 -0800 Patch bug-138419-20141105232019.patch text/plain 7914 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzQ3ODM0MzgxYzFjZTgx ODVjNmFhYmNhNDg1ZjQ0NDVhNTViNzAzYi4uZGY3ZjAyOTkzNjUzMGM4MWYyNzJmYjBkOTZkMzQ5 ZWQ3NzkyOGFiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTExLTA1ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIG1f c2Nyb2xsUG9zaXRpb24gZnJvbSBDb29yZGluYXRlZEdyYXBoaWNzU2NlbmUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzODQxOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1fc2Nyb2xsUG9zaXRpb24gb2Yg Q29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lIGlzIG9ubHkgdG8gYWRqdXN0IHRoZSBwb3NpdGlvbgor ICAgICAgICBvZiBmaXhlZCBlbGVtZW50LiBCdXQgdGhpcyBhZGp1c3RtZW50IGlzIG9ubHkgY2Fs bGVkIGJ5IHBhaW50VG9DdXJyZW50R0xDb250ZXh0KCkKKyAgICAgICAgYW5kIFdlYlZpZXcgY2Fu IHBhc3Mgc2FtZSBpbmZvcm1hdGlvbiB0byB0aGUgcGFyYW1ldGVyIG9mIHRoYXQgbWV0aG9kLgor CisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFw aGljc1NjZW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVkR3JhcGhpY3NTY2Vu ZTo6cGFpbnRUb0N1cnJlbnRHTENvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0 ZWRHcmFwaGljc1NjZW5lOjphZGp1c3RQb3NpdGlvbkZvckZpeGVkTGF5ZXJzKToKKyAgICAgICAg KFdlYkNvcmU6OkNvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZTo6c2V0U2Nyb2xsUG9zaXRpb24pOiBE ZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5h dGVkR3JhcGhpY3NTY2VuZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBo aWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHk6OnNldFZpc2libGVDb250ZW50c1JlY3QpOgor ICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL1dlYlZpZXcuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3OjpwYWludFRvQ3VycmVudEdMQ29udGV4dCk6CisKIDIwMTQt MTEtMDQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAg QWRkIGJ1bmRsZSBTUEkgYWxsb3dpbmcgUGFnZU92ZXJsYXkgdG8gY3VzdG9taXplIHRoZSBhY3Rp b24gbWVudQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVk R3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHAK aW5kZXggYTU4MmQ4MzNiMjliMTZkNzJhYTFkMmI3MTRhNjYwYWNhNmJhYjNkYy4uZmRhZTNiNGIz NDNmMzc0OTk3ZmViYTM3YmRmNmQ0YzU5YjRlNzNhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5l LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZEdyYXBoaWNzU2NlbmUuY3BwCkBAIC01OSw3ICs1OSw3IEBAIENvb3JkaW5hdGVk R3JhcGhpY3NTY2VuZTo6fkNvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZSgpCiB7CiB9CiAKLXZvaWQg Q29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lOjpwYWludFRvQ3VycmVudEdMQ29udGV4dChjb25zdCBU cmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0cml4LCBmbG9hdCBvcGFjaXR5LCBjb25zdCBGbG9hdFJl Y3QmIGNsaXBSZWN0LCBjb25zdCBDb2xvciYgYmFja2dyb3VuZENvbG9yLCBib29sIGRyYXdzQmFj a2dyb3VuZCwgVGV4dHVyZU1hcHBlcjo6UGFpbnRGbGFncyBQYWludEZsYWdzKQordm9pZCBDb29y ZGluYXRlZEdyYXBoaWNzU2NlbmU6OnBhaW50VG9DdXJyZW50R0xDb250ZXh0KGNvbnN0IFRyYW5z Zm9ybWF0aW9uTWF0cml4JiBtYXRyaXgsIGZsb2F0IG9wYWNpdHksIGNvbnN0IEZsb2F0UmVjdCYg Y2xpcFJlY3QsIGNvbnN0IENvbG9yJiBiYWNrZ3JvdW5kQ29sb3IsIGJvb2wgZHJhd3NCYWNrZ3Jv dW5kLCBjb25zdCBGbG9hdFBvaW50JiBjb250ZW50UG9zaXRpb24sIFRleHR1cmVNYXBwZXI6OlBh aW50RmxhZ3MgUGFpbnRGbGFncykKIHsKICAgICBpZiAoIW1fdGV4dHVyZU1hcHBlcikgewogICAg ICAgICBtX3RleHR1cmVNYXBwZXIgPSBUZXh0dXJlTWFwcGVyOjpjcmVhdGUoVGV4dHVyZU1hcHBl cjo6T3BlbkdMTW9kZSk7CkBAIC02OSw3ICs2OSw3IEBAIHZvaWQgQ29vcmRpbmF0ZWRHcmFwaGlj c1NjZW5lOjpwYWludFRvQ3VycmVudEdMQ29udGV4dChjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJp CiAgICAgQVNTRVJUKG1fdGV4dHVyZU1hcHBlci0+YWNjZWxlcmF0aW9uTW9kZSgpID09IFRleHR1 cmVNYXBwZXI6Ok9wZW5HTE1vZGUpOwogICAgIHN5bmNSZW1vdGVDb250ZW50KCk7CiAKLSAgICBh ZGp1c3RQb3NpdGlvbkZvckZpeGVkTGF5ZXJzKCk7CisgICAgYWRqdXN0UG9zaXRpb25Gb3JGaXhl ZExheWVycyhjb250ZW50UG9zaXRpb24pOwogICAgIFRleHR1cmVNYXBwZXJMYXllciogY3VycmVu dFJvb3RMYXllciA9IHJvb3RMYXllcigpOwogICAgIGlmICghY3VycmVudFJvb3RMYXllcikKICAg ICAgICAgcmV0dXJuOwpAQCAtMTM1LDExICsxMzUsNiBAQCB2b2lkIENvb3JkaW5hdGVkR3JhcGhp Y3NTY2VuZTo6cGFpbnRUb0dyYXBoaWNzQ29udGV4dChQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dCog cAogICAgIG1fdGV4dHVyZU1hcHBlci0+c2V0R3JhcGhpY3NDb250ZXh0KDApOwogfQogCi12b2lk IENvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZTo6c2V0U2Nyb2xsUG9zaXRpb24oY29uc3QgRmxvYXRQ b2ludCYgc2Nyb2xsUG9zaXRpb24pCi17Ci0gICAgbV9zY3JvbGxQb3NpdGlvbiA9IHNjcm9sbFBv c2l0aW9uOwotfQotCiB2b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZTo6dXBkYXRlVmlld3Bv cnQoKQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CkBAIC0xNDcsNyArMTQyLDcgQEAg dm9pZCBDb29yZGluYXRlZEdyYXBoaWNzU2NlbmU6OnVwZGF0ZVZpZXdwb3J0KCkKICAgICAgICAg bV9jbGllbnQtPnVwZGF0ZVZpZXdwb3J0KCk7CiB9CiAKLXZvaWQgQ29vcmRpbmF0ZWRHcmFwaGlj c1NjZW5lOjphZGp1c3RQb3NpdGlvbkZvckZpeGVkTGF5ZXJzKCkKK3ZvaWQgQ29vcmRpbmF0ZWRH cmFwaGljc1NjZW5lOjphZGp1c3RQb3NpdGlvbkZvckZpeGVkTGF5ZXJzKGNvbnN0IEZsb2F0UG9p bnQmIGNvbnRlbnRQb3NpdGlvbikKIHsKICAgICBpZiAobV9maXhlZExheWVycy5pc0VtcHR5KCkp CiAgICAgICAgIHJldHVybjsKQEAgLTE1NSw3ICsxNTAsNyBAQCB2b2lkIENvb3JkaW5hdGVkR3Jh cGhpY3NTY2VuZTo6YWRqdXN0UG9zaXRpb25Gb3JGaXhlZExheWVycygpCiAgICAgLy8gRml4ZWQg bGF5ZXIgcG9zaXRpb25zIGFyZSB1cGRhdGVkIGJ5IHRoZSB3ZWIgcHJvY2VzcyB3aGVuIHdlIHVw ZGF0ZSB0aGUgdmlzaWJsZSBjb250ZW50cyByZWN0IC8gc2Nyb2xsIHBvc2l0aW9uLgogICAgIC8v IElmIHdlIHdhbnQgdGhvc2UgbGF5ZXJzIHRvIGZvbGxvdyBhY2N1cmF0ZWx5IHRoZSB2aWV3cG9y dCB3aGVuIHdlIG1vdmUgYmV0d2VlbiB0aGUgd2ViIHByb2Nlc3MgdXBkYXRlcywgd2UgaGF2ZSB0 byBvZmZzZXQKICAgICAvLyB0aGVtIGJ5IHRoZSBkZWx0YSBiZXR3ZWVuIHRoZSBjdXJyZW50IHBv c2l0aW9uIGFuZCB0aGUgcG9zaXRpb24gb2YgdGhlIHZpZXdwb3J0IHVzZWQgZm9yIHRoZSBsYXN0 IGxheW91dC4KLSAgICBGbG9hdFNpemUgZGVsdGEgPSBtX3Njcm9sbFBvc2l0aW9uIC0gbV9yZW5k ZXJlZENvbnRlbnRzU2Nyb2xsUG9zaXRpb247CisgICAgRmxvYXRTaXplIGRlbHRhID0gY29udGVu dFBvc2l0aW9uIC0gbV9yZW5kZXJlZENvbnRlbnRzU2Nyb2xsUG9zaXRpb247CiAKICAgICBmb3Ig KGF1dG8mIGZpeGVkTGF5ZXIgOiBtX2ZpeGVkTGF5ZXJzLnZhbHVlcygpKQogICAgICAgICBmaXhl ZExheWVyLT5zZXRTY3JvbGxQb3NpdGlvbkRlbHRhSWZOZWVkZWQoZGVsdGEpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0 ZWRHcmFwaGljc1NjZW5lLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRH cmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUuaAppbmRleCBkYTA3MGIxOGIwNWYyNzY3 N2RiNGU0MjJhM2E0ZGNhYWM5NmE4OWQxLi4yYzcyMGMyYWE3MzZmOGI5NzZlMmEzYWY2YTkyYmM2 ZWIxN2YzZDRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUu aApAQCAtNjEsOSArNjEsOCBAQCBjbGFzcyBDb29yZGluYXRlZEdyYXBoaWNzU2NlbmUgOiBwdWJs aWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8Q29vcmRpbmF0ZWRHcmFwaGljcwogcHVibGljOgogICAg IGV4cGxpY2l0IENvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZShDb29yZGluYXRlZEdyYXBoaWNzU2Nl bmVDbGllbnQqKTsKICAgICB2aXJ0dWFsIH5Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUoKTsKLSAg ICB2b2lkIHBhaW50VG9DdXJyZW50R0xDb250ZXh0KGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4 JiwgZmxvYXQsIGNvbnN0IEZsb2F0UmVjdCYsIGNvbnN0IENvbG9yJiBiYWNrZ3JvdW5kQ29sb3Is IGJvb2wgZHJhd3NCYWNrZ3JvdW5kLCBUZXh0dXJlTWFwcGVyOjpQYWludEZsYWdzID0gMCk7Cisg ICAgdm9pZCBwYWludFRvQ3VycmVudEdMQ29udGV4dChjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJp eCYsIGZsb2F0LCBjb25zdCBGbG9hdFJlY3QmLCBjb25zdCBDb2xvciYgYmFja2dyb3VuZENvbG9y LCBib29sIGRyYXdzQmFja2dyb3VuZCwgY29uc3QgRmxvYXRQb2ludCYsIFRleHR1cmVNYXBwZXI6 OlBhaW50RmxhZ3MgPSAwKTsKICAgICB2b2lkIHBhaW50VG9HcmFwaGljc0NvbnRleHQoUGxhdGZv cm1HcmFwaGljc0NvbnRleHQqLCBjb25zdCBDb2xvciYgYmFja2dyb3VuZENvbG9yLCBib29sIGRy YXdzQmFja2dyb3VuZCk7Ci0gICAgdm9pZCBzZXRTY3JvbGxQb3NpdGlvbihjb25zdCBGbG9hdFBv aW50Jik7CiAgICAgdm9pZCBkZXRhY2goKTsKICAgICB2b2lkIGFwcGVuZFVwZGF0ZShzdGQ6OmZ1 bmN0aW9uPHZvaWQoKT4pOwogCkBAIC0xMjEsNyArMTIwLDcgQEAgcHJpdmF0ZToKICAgICBUZXh0 dXJlTWFwcGVyTGF5ZXIqIHJvb3RMYXllcigpIHsgcmV0dXJuIG1fcm9vdExheWVyLmdldCgpOyB9 CiAKICAgICB2b2lkIHN5bmNSZW1vdGVDb250ZW50KCk7Ci0gICAgdm9pZCBhZGp1c3RQb3NpdGlv bkZvckZpeGVkTGF5ZXJzKCk7CisgICAgdm9pZCBhZGp1c3RQb3NpdGlvbkZvckZpeGVkTGF5ZXJz KGNvbnN0IEZsb2F0UG9pbnQmIGNvbnRlbnRQb3NpdGlvbik7CiAKICAgICB2b2lkIGRpc3BhdGNo T25NYWluVGhyZWFkKHN0ZDo6ZnVuY3Rpb248dm9pZCgpPik7CiAgICAgdm9pZCB1cGRhdGVWaWV3 cG9ydCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVk R3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHkuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0 UHJveHkuY3BwCmluZGV4IDAwMGU3ZGQyZWM5YTNkZDViNzI5NTZmMjg5Y2MxOTk1NjhmMWJhMmIu LjljNzFmOTE4ZGU0ZjMxZWExZWZiOGRjNTc1YTM2OGRhMjRlOTAzMmYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5 ZXJUcmVlSG9zdFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRp bmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3RQcm94eS5jcHAKQEAgLTcyLDEz ICs3Miw2IEBAIHZvaWQgQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHk6OmNvbW1pdENvb3Jk aW5hdGVkR3JhcGhpY3NTdGF0ZShjb25zdCBDb29yZGluCiAKIHZvaWQgQ29vcmRpbmF0ZWRMYXll clRyZWVIb3N0UHJveHk6OnNldFZpc2libGVDb250ZW50c1JlY3QoY29uc3QgRmxvYXRSZWN0JiBy ZWN0LCBjb25zdCBGbG9hdFBvaW50JiB0cmFqZWN0b3J5VmVjdG9yKQogewotICAgIC8vIEluZm9y bSB0aGUgcmVuZGVyZXIgdG8gYWRqdXN0IHZpZXdwb3J0LWZpeGVkIGxheWVycy4KLSAgICBSZWZQ dHI8Q29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lPiBzY2VuZVByb3RlY3RvcihtX3NjZW5lKTsKLSAg ICBjb25zdCBGbG9hdFBvaW50JiBzY3JvbGxQb3NpdGlvbiA9IHJlY3QubG9jYXRpb24oKTsKLSAg ICBkaXNwYXRjaFVwZGF0ZShbPV0gewotICAgICAgICBzY2VuZVByb3RlY3Rvci0+c2V0U2Nyb2xs UG9zaXRpb24oc2Nyb2xsUG9zaXRpb24pOwotICAgIH0pOwotCiAgICAgaWYgKHJlY3QgPT0gbV9s YXN0U2VudFZpc2libGVSZWN0ICYmIHRyYWplY3RvcnlWZWN0b3IgPT0gbV9sYXN0U2VudFRyYWpl Y3RvcnlWZWN0b3IpCiAgICAgICAgIHJldHVybjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAppbmRleCA1OGEy NmYwZmNmZmQ4YmI3MTdlMDAxOGMyYmRjZjMwMTI2MjQwZDRkLi4xYTEyZDVlOWRlNGYyMDQyZGE1 MzZhNzBlYThmYWI2NjVkNWQyNGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcApAQCAtMTU0LDcgKzE1NCw3 IEBAIHZvaWQgV2ViVmlldzo6cGFpbnRUb0N1cnJlbnRHTENvbnRleHQoKQogCiAgICAgY29uc3Qg RmxvYXRSZWN0JiB2aWV3cG9ydCA9IG1fdXNlclZpZXdwb3J0VHJhbnNmb3JtLm1hcFJlY3QoSW50 UmVjdChJbnRQb2ludCgpLCBtX3NpemUpKTsKIAotICAgIHNjZW5lLT5wYWludFRvQ3VycmVudEdM Q29udGV4dCh0cmFuc2Zvcm1Ub1NjZW5lKCkudG9UcmFuc2Zvcm1hdGlvbk1hdHJpeCgpLCBtX29w YWNpdHksIHZpZXdwb3J0LCBtX3BhZ2UtPnBhZ2VFeHRlbmRlZEJhY2tncm91bmRDb2xvcigpLCBt X3BhZ2UtPmRyYXdzQmFja2dyb3VuZCgpKTsKKyAgICBzY2VuZS0+cGFpbnRUb0N1cnJlbnRHTENv bnRleHQodHJhbnNmb3JtVG9TY2VuZSgpLnRvVHJhbnNmb3JtYXRpb25NYXRyaXgoKSwgbV9vcGFj aXR5LCB2aWV3cG9ydCwgbV9wYWdlLT5wYWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3IoKSwgbV9w YWdlLT5kcmF3c0JhY2tncm91bmQoKSwgbV9jb250ZW50UG9zaXRpb24pOwogfQogCiB2b2lkIFdl YlZpZXc6OnNldERyYXdzQmFja2dyb3VuZChib29sIGRyYXdzQmFja2dyb3VuZCkK