138418 2014-11-05 05:20:51 -0800 NetscapePlugin: NPP_GetValue should receive a pointer to NPBool, not bool 2014-11-05 05:29:22 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned oldest_to_newest 1046449 0 berto 2014-11-05 05:20:51 -0800 In NetscapePlugin::platformPostInitialize() we're calling NPP_GetValue(NPPVpluginNeedsXEmbed, &needsXEmbed) but needsXEmbed has the wrong type. 1046450 1 241024 berto 2014-11-05 05:22:20 -0800 Created attachment 241024 Patch 1046451 2 berto 2014-11-05 05:29:22 -0800 Committed r175619: <http://trac.webkit.org/changeset/175619> 241024 2014-11-05 05:22:20 -0800 2014-11-05 05:23:33 -0800 Patch 138418.diff text/plain 1383 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhYmRkNTg3Li41MTJmZjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMTEtMDUgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBOZXRzY2FwZVBsdWdpbjogTlBQX0dldFZhbHVlIHNob3VsZCByZWNlaXZlIGEgcG9pbnRl ciB0byBOUEJvb2wsIG5vdCBib29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzg0MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZXBsYWNlIGJvb2wgd2l0aCBOUEJvb2wsIHdoaWNoIGlzIGFjdHVhbGx5 IGFuIHVuc2lnbmVkIGNoYXIuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2Nh cGUveDExL05ldHNjYXBlUGx1Z2luWDExLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQ bHVnaW46OnBsYXRmb3JtUG9zdEluaXRpYWxpemUpOgorCiAyMDE0LTExLTA1ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgV2Vi S2l0V2ViUmVzb3VyY2U6OmZhaWxlZC13aXRoLXRscy1lcnJvcnMgc2lnbmFsCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBl UGx1Z2luWDExLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEuY3BwCmluZGV4IDcwMTRkZmMuLjY2NGVkNzQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0 c2NhcGVQbHVnaW5YMTEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lu cy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEuY3BwCkBAIC0yMDIsNyArMjAyLDcgQEAg dm9pZCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1QcmVJbml0aWFsaXplKCkKIGJvb2wgTmV0c2Nh cGVQbHVnaW46OnBsYXRmb3JtUG9zdEluaXRpYWxpemUoKQogewogICAgIHVpbnQ2NF90IHdpbmRv d0lEID0gMDsKLSAgICBib29sIG5lZWRzWEVtYmVkID0gZmFsc2U7CisgICAgTlBCb29sIG5lZWRz WEVtYmVkID0gZmFsc2U7CiAgICAgaWYgKG1faXNXaW5kb3dlZCkgewogICAgICAgICBOUFBfR2V0 VmFsdWUoTlBQVnBsdWdpbk5lZWRzWEVtYmVkLCAmbmVlZHNYRW1iZWQpOwogICAgICAgICBpZiAo bmVlZHNYRW1iZWQpIHsK