138416 2014-11-05 03:43:53 -0800 Fix the debug build after r175525 2014-11-05 09:04:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 138407 P2 Normal --- 137942 1 ossy ossy commit-queue darin d-r fmalita gyuyoung.kim krit nikos.andronikos ossy pdr schenney sergio oldest_to_newest 1046441 0 ossy 2014-11-05 03:43:53 -0800 ../../Source/WebCore/svg/SVGMarkerElement.cpp: In member function 'WebCore::SVGMarkerOrientType& WebCore::SVGMarkerElement::orientType() const': ../../Source/WebCore/svg/SVGMarkerElement.cpp:256:51: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] cc1plus: all warnings being treated as errors line256: ASSERT(wrapper->currentAnimatedValue() >= 0 && wrapper->currentAnimatedValue() < SVGMarkerOrientMax); wrapper->currentAnimatedValue() is unsigned, so it is always true, I think we should simple remove it. 1046442 1 241023 ossy 2014-11-05 03:46:22 -0800 Created attachment 241023 Patch 1046445 2 ossy 2014-11-05 04:09:50 -0800 *** This bug has been marked as a duplicate of bug 138414 *** 1046483 3 darin 2014-11-05 09:04:26 -0800 *** This bug has been marked as a duplicate of bug 138407 *** 241023 2014-11-05 03:46:22 -0800 2014-11-05 04:10:33 -0800 Patch bug-138416-20141105124711.patch text/plain 1538 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUyZTgxZjUwN2JjZGZm NzJhNzllNmU2NWM3OTI0MmE1ZjA5MDNlOC4uZjllZDIwZjAxZTM5NDIwOTJlNzYwNmJkNzU3NTEx OGIzZGZkYmRhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTA1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBkZWJ1 ZyBidWlsZCBhZnRlciByMTc1NTI1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzg0MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHN2Zy9TVkdNYXJrZXJFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNWR01hcmtlckVsZW1lbnQ6Om9yaWVudFR5cGUpOgorCiAyMDE0LTExLTA1ICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGUgbGluZSBsYXlvdXQ6 IHN1cHBvcnQgdGV4dC10cmFuc2Zvcm06IGxvd2VyY2FzZXx1cHBlcmNhc2V8Y2FwaXRhbGl6ZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR01hcmtlckVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR01hcmtlckVsZW1lbnQuY3BwCmluZGV4IGQ5ZjE2MWQzN2YwZmY4 MmYzMjFjNWQyYmMxNDBlNWVmNTcxYTdiNTQuLjJkOWRkMzAwYjY0YzRhMTZlODZjNzUyZmRiODYy YTQ5YzU0MTUwMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdNYXJrZXJFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHTWFya2VyRWxlbWVudC5jcHAKQEAg LTI1Myw3ICsyNTMsNyBAQCBTVkdNYXJrZXJPcmllbnRUeXBlJiBTVkdNYXJrZXJFbGVtZW50Ojpv cmllbnRUeXBlKCkgY29uc3QKIHsKICAgICBpZiAoU1ZHQW5pbWF0ZWRFbnVtZXJhdGlvbiogd3Jh cHBlciA9IFNWR0FuaW1hdGVkUHJvcGVydHk6Omxvb2t1cFdyYXBwZXI8VXNlT3duZXJUeXBlLCBT VkdBbmltYXRlZEVudW1lcmF0aW9uPih0aGlzLCBvcmllbnRUeXBlUHJvcGVydHlJbmZvKCkpKSB7 CiAgICAgICAgIGlmICh3cmFwcGVyLT5pc0FuaW1hdGluZygpKSB7Ci0gICAgICAgICAgICBBU1NF UlQod3JhcHBlci0+Y3VycmVudEFuaW1hdGVkVmFsdWUoKSA+PSAwICYmIHdyYXBwZXItPmN1cnJl bnRBbmltYXRlZFZhbHVlKCkgPCBTVkdNYXJrZXJPcmllbnRNYXgpOworICAgICAgICAgICAgQVNT RVJUKHdyYXBwZXItPmN1cnJlbnRBbmltYXRlZFZhbHVlKCkgPCBTVkdNYXJrZXJPcmllbnRNYXgp OwogICAgICAgICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8U1ZHTWFya2VyT3JpZW50VHlw ZSY+KHdyYXBwZXItPmN1cnJlbnRBbmltYXRlZFZhbHVlKCkpOwogICAgICAgICB9CiAgICAgfQo=